From: Miguel F. <mi...@ce...> - 2002-05-28 18:37:39
|
On Tue, 2002-05-28 at 15:27, Mike Melanson wrote: > > Let's move this BITMAPINFOHEADER into some xine header file. Besides > > reducing code duplication we must convert the struct declaration to use > > intxx_t types instead of short/long/etc. This will fix some problems > > with 64-bit systems. I just don't know which header does it belong, any > > suggestion? > > If you are going to keep it around, the structure should probably > go into buffer.h since it pertains to buffers. But are you sure you want > to change the sizes of any of the members? I assumed that the whole > rationale for keeping it had to do with needing to send it to the Win32 > decoder DLLs. They are going to expect the data types to line up in a > certain way, right? Yeah, right. I don't want to change _any_ member size. Just use int32_t instead of long, int16_t instead of short and so on... There's a open bug in sf exactly about this problem (portability in 64bit machines). regards, Miguel |