Re: [xine-devel] xine-plugin,mms,asf patches

[Andrei L. <Um...@ed...>]

On Sun, 03 Feb 2002 22:52:55 -0200
Miguel Freitas <mi...@ce...> wrote:

> Hi Andrei,
> 
> (just a few comments, i haven't tested the patches)
> 
>  >Here a 3 patches which let using mozilla, and mms plugin to watch
>  >streaming asf
> 
> Good to know someone is working on xine-plugin! ;) I really think it's a 
> very interesting software (much better than any existing "plugger" over 
> there).
> 
>  >1.xine-plugin.patch (against CVS xine-plugin )Still have problems with
>  >not freed memory. After all the calls like
>  >xine_list_video_output_plugins and so on memory is not free(). Because
>  >some of the call return complex structures and i
>  >think may be it will be better to add to xine-lib functions
>  >like: xine_free_plugin_memory.
> 
> Yes, we need to implement some "free" functions on xine core to fix a 
> couple of (small) mem leaks. In this case i'm not sure about when should 
> the mime string be freed as it is passed down to netscape (and i don't 
> know nsapi). Anyway i think it would be better to fix the leak than 
> leaving an static string... (At least we could copy the returned string 
> to a static buffer or something)
> 
>  > 3. Small patch for asf demuxer. As was suggested in xine-devel it was
>  > a problems with multiply video streams . And i did not found
>  > place in code(Is this correct?) where we choose one stream from N to
>  > send to decode plugin. So i just choose  first stream.
> 
> Your patch should only protect initializing the same codec more than 
> once. The real choosing of one stream data to decode is currently inside 
> w32codec...
> 
> http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/xine/xine-lib/src/libw32dll/w32codec.c.diff?r1=1.55&r2=1.56
> 
> 
> regards,
> 
> Miguel
> 

Hello Miguel.
Concerning functions which will free memory i think i will write them today tomorrow.
About asf i have tested those "ugly" asf files from CNN and if i choose only one video -stream (first) everything is good if leave as before picture is broken.
By the way you mean that asf demuxer should pass streams to w32 decoder without choosing one ?  I have looked in mplayer demuxer they  choose
one stream from N in demuxer.  And how about ffmpeg plugin ? We also need to add code which will choose right stream.
At least with this patch all my .asf working nicely.

P.S. What is difference between those N video streams in .asf -size,quality ? Sorry i did not find any informations on this. 

Andrei.