Hi Kimmo,
Thanks for your comments. I'll install AStyle and use that for my
Winmerge repository instead of using the EolExtension. I've read what
I could in the wiki, and on the SF mailing-lists. What would be the
best medium for discussions? The forums? This mailing list?
I think it would be a good idea to have a discussion about how to
proceed with the huge task of moving WinMerge towards version 3.
Kind regards,
Philip
On 1 August 2011 20:05, Kimmo Varis <ki...@wi...> wrote:
> Hi, and welcome, nice to see some activity here! :)
>
> I've been on summer vacation so I only just read your tickets. I shortly
> commented there. But I think we need some serious discussion about the
> editor and its implementation before you run into implementing it. Have
> you read the wiki in bitbucket? Or discussions at sourceforge forum?
>
> About the commits in your repository:
> - f9a030a1e6b0 (EOL conversion file): I don't want to pull this. Latest
> versions of Astyle can enforce code file EOL style. Nothing prevents you
> from using it but I don't want to enforce everybody to use it.
>
> - 6fc42c709e2b (Removing unused variables to clean up build warnings.):
> Maybe. It changes the XDiff code which is external library... I'd rather
> not modify it, not for fixing minor warning. We need to update that
> library later on and edits mean we need to merge them. Might be trivial,
> might be headache. Not forgetting that perhaps we after all want to use
> something else than xdiff...
>
> Regards,
> Kimmo
>
>
>
> On 7/31/2011 11:12 PM, Philip Goh wrote:
>> Greetings List,
>>
>> I'm going to start participating in the development effort for
>> WinMerge 3. To that end, I've raised a couple of tickets in the
>> BitBucket issues page and I've begun implementing them.
>> In the interim, I have a 2 commits that I'd like added to the WinMerge
>> repository. Could someone pull them from my personal WinMerge
>> repository? I think the pull request will look something like:
>>
>> hg pull https://you...@bi.../philipgoh/WinMerge-PG
>>
>> I'm going to continue working on these tickets, and it would be nice
>> to know that my changes are going to get accepted. If the format is
>> not acceptable, any constructive comments would be welcome.
>>
>> Thanks,
>> Philip
>>
>> ------------------------------------------------------------------------------
>> Got Input? Slashdot Needs You.
>> Take our quick survey online. Come on, we don't ask for help often.
>> Plus, you'll get a chance to win $100 to spend on ThinkGeek.
>> http://p.sf.net/sfu/slashdot-survey
>> _______________________________________________
>> Winmerge-development mailing list
>> Win...@li...
>> https://lists.sourceforge.net/lists/listinfo/winmerge-development
>>
>
> ------------------------------------------------------------------------------
> BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
> The must-attend event for mobile developers. Connect with experts.
> Get tools for creating Super Apps. See the latest technologies.
> Sessions, hands-on labs, demos & much more. Register early & save!
> http://p.sf.net/sfu/rim-blackberry-1
> _______________________________________________
> Winmerge-development mailing list
> Win...@li...
> https://lists.sourceforge.net/lists/listinfo/winmerge-development
>
|