#1828 Unicode files are compared as binary files

[Martin Vanek]

When comparing two directories with *.cpp files, Unicode files are compared as binary files. They are missing in the list of compared files unless the option "Show binary files" is not selected.

Martin Vanek

[Kimmo Varis]

Hmm. By Unicode files you apparently mean UTF-16 or UTF-32 files which contain zeros.

Quick contents-compare method looks only bytes and hence don't know if the file is "binary" or UTF-16 or UTF-32. Full contents -compare should work better.

[Martin Vanek]

File Compare Method is "Full Contents". File is UTF-16, first two bytes are hex FFFE.
Older WinMerge version 2.8.6 is working properly.

[Kimmo Varis]

Oh, thanks for the info. I think I now have some clue what is going on...

Just for clarity, if you enable plugins from menu Plugins/List then UTF-16 files are handled correctly?

I think this is caused by the plugins disabling patches, some translation calls are inside plugins code.

[Martin Vanek]

Enable plugins or not, it has no effect.

[Matthias]

No that's a real bug.
Winmerge is checking with CheckForInvalidUtf8 for invalid values.
So if we have a unicodefile this prog fails.
Actually only Ascii and UTF8 are shown as text files.

[Matthias]

solution see patch 2477657

[Kimmo Varis]

This is fixed by Matthias' patch.