Menu

#1237 file filter bug in directory compare

Branch
closed-works-for-me
nobody
7
2006-06-19
2006-05-12
Anonymous
No

Hello,

I have been using the following file filter in WinMerge
2.4.4 to filter out the SVN sandboxes without problems.
After installing 2.4.6 this filter stopped working, i.
e. it doesn't filter out anything. I haven't found
anything on the mailing archives, so does anyone know
if the way filters work has changed, my filter is wrong
or WinMerge has changed somehow?
Thanks in advance!

The filter:

## This is a directory/file filter for WinMerge
## This filter suppresses various binaries found in
Visual C++ source
trees
name: NoSVN
desc: Suppresses the .svn folder
def: include
d: [._][Ss][Vv][Nn]$

Discussion

  • Kimmo Varis

    Kimmo Varis - 2006-05-15

    Logged In: YES
    user_id=631874

    Hmm. There is another report about filtering subdirs broken.
    Currently I've no idea about what change in sources could
    have caused that.

    One thing about your filter: WinMerge (like Windows) doesn't
    make difference between small letters and capital letters so
    you could simplify your filter to just:

    d: [._]svn$

    Our example filter "Merge_VC_loose.flt" uses this rule for
    cvs folders:

    d: \\cvs$ ## CVS control directory

    so it could be \\ is now required in begin of subdir
    filtering rule. Not sure about this since I don't remember
    details.

     
  • Nobody/Anonymous

    Logged In: NO

    Yes, the filter was [._]svn$ and it worked with 2.4.4. I was
    just adding the upper/lowercase because i was clueless. Will
    try your suggestion with \\. Thanks!

     
  • Kimmo Varis

    Kimmo Varis - 2006-05-24
    • milestone: --> Branch
    • priority: 5 --> 7
     
  • Kimmo Varis

    Kimmo Varis - 2006-05-24

    Logged In: YES
    user_id=631874

    I'd be interested to hear if that fixes your problem. If it
    does not fix the problem then I have to start going through
    CVS history finding changes that could even cause this...

    This kind of breakage is pretty bad in stable branch.

    So increasing the priority until I figure out what happened.

     
  • Nobody/Anonymous

    Logged In: NO

    I have tried using \\ but it doesn't work either. Moreover I
    can't seem to get any sort of filtering to work with 2.4.6.

    d: .*
    d: *
    f: .*
    f: *

    none of those work in 2.4.6?

     
  • Kimmo Varis

    Kimmo Varis - 2006-06-12

    Logged In: YES
    user_id=631874

    Filters work for me (and I expect for lots of people since
    there aren't other similar reports).

    Do filters coming with WinMerge (without any modifications
    done!) work? Could there be just some formatting issue or
    something like that.

     
  • Nobody/Anonymous

    Logged In: NO

    I think you can close this one. I have edited the filter
    numerous times and at one point in time the filter started
    working again. Semantically the filter looks exactly like
    the one posted in the initial bug-report. I think it started
    working after I added an empty newline after the d: - line.
    But even if I now remove this last empty newline the filter
    works. Weird.

     
  • Kimmo Varis

    Kimmo Varis - 2006-06-19

    Logged In: YES
    user_id=631874

    Thanks for the info.

    There is no requirement for last empty line. Maybe there
    were some control character accidentally added? Or previous
    line had different EOL type or something like that. Those
    are sometimes insanely hard to spot.

    Anyway, I'll submit a TODO-item for making file filter file
    reading code to better validate the file and either ignore
    additional chars or show an error.

    Ok, new item is:
    #1508772 File filter file reading should better handle
    format errors
    https://sourceforge.net/tracker/index.php?func=detail&aid=1508772&group_id=13216&atid=759426

    I'm closing this item now.

     
  • Kimmo Varis

    Kimmo Varis - 2006-06-19
    • status: open --> closed-works-for-me
     

Log in to post a comment.

MongoDB Logo MongoDB