webadmin-devel — The webmin development mailing list

Re: <hr>

[Joe C. <jo...@sw...>]

This should find it's way into a 'themeable' item, rather than a one 
time universal replacement.

Just a thought.

Adding the icon is too much.  Maybe it would be appropriate in some 
themes (and once the header is fully themeable then you'll be able to do 
anything you want with it, including sticking icons and whatever else in 
it).  So I'd consider this an argument for fully themeable header and 
footer (and probably a removal of the <hr> in every module), rather than 
an argument for significantly altering the default theme to include an 
icon in the header.

Benjamin Meyer wrote:

> ---
> oop only sent this too Jamie, re-sending it to the list.
> 
> -Ben
> ---
> 
> Please tell me this not true, but it looks like every single module has
> 
> &header(...)
> printf "<hr>\n";
> 
> ...
> ......
> ...
> 
> printf "<hr>\n";
> &footer(...)
> 
> If that is the case then I volenteer to go through and remove it from every 
> module and added it to the the header and footer functions (along with adding 
> the option to not show it)  I have an account on sourceforge (icefox2)
> 
> Also while I am at it what do you think of adding the modules icon to the 
> paramaters of the header so all the icons will show up in the modules index 
> page.
> 
> -Benjamin Meyer


                                   --
                      Joe Cooper <jo...@sw...>
                  Affordable Web Caching Proxy Appliances
                         http://www.swelltech.com

Re: webmin users

[Joe C. <jo...@sw...>]

Um...putting /everything/ into Webmin Configuration would also be a 
little thing, but wouldn't make Webmin better, it would just put 
everything on a lower page, and harder to reach...

I disagree with your assessment of where Webmin Users should be.  It's a 
frequently accessed item on many servers, and is quite well placed in 
the 'top' page.  The Webmin tab is not crowded enough to start trying to 
hide things to make it more accessible (in fact, one could easily argue 
that the Webmin Configuration page /is/ beginning to get crowded, so 
things might need to start moving out of the Configuration page and onto 
another).  I certainly see no reason to put /more/ onto the page.

Benjamin Meyer wrote:

> It may not gain much, but every little thing makes webmin better :)
> 
> -Ben
> 
> 
> On Monday 18 June 2001 07:52, you wrote:
> 
>>Benjamin Meyer wrote:
>>
>>>Why is webmin users in its own module and not in the webmin
>>>configuration? Would it make more sense to move it in there?
>>>
>>Not really .. the Webmin Configuration module deals with global options,
>>while the Webmin Users module controls who can login. I guess webmin users
>>could just be another icon under webmin configuration, but that wouldn't
>>really gain much ..
>>
>> - Jamie
>>
>>-
>>Forwarded by the Webmin development list at web...@we...
>>To remove yourself from this list, go to
>>http://lists.sourceforge.net/lists/listinfo/webadmin-devel
>>
> 
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel
> 
> 
> 



-- 

                                   --
                      Joe Cooper <jo...@sw...>
                  Affordable Web Caching Proxy Appliances
                         http://www.swelltech.com

Re: cvs repository

[Nick J. <ni...@na...>]

I was looking for that as well. From what i'm told all patches go through
jamie, just post them to the list.

On Tue, Jun 19, 2001 at 07:23:07AM -0400, Benjamin Meyer wrote:
> I noticed that we are not using sourceforge's cvs for the repository.  I 
> couldn't find a developers page in the webmin website.  Where does the 
> current cvs reside?  (Is there a cvs?)  Is there a reason for us not to use 
> the sourceforge cvs?
> 
> -Ben
> 
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel
> 

-- 
  Nick Jennings

Re: Groups issue

[Jamie C. <jca...@we...>]

Benjamin Meyer wrote:
> 
> > > 2) If you put in a wrong date it gives you the error "invalid expiry
> > > date" Shoudn't that read expiration :)
> > >
> > > 3) If you go past 2038 you start getting wacky errors
> >
> > Yeah, unix time can't handle that.
> 
> It would be nice to simply have a check for the year then.

Good point .. I'll put it in.
 
> > > 4) We allow for wrong dates such as Feb 31 so we should simply have drop
> > > down boxes for the Experation day and year.
> >
> > Personally I find it easier to type in a number rather than select it
> > from a long list..
> 
> Then we should remove the pull down menu for the months.  concistancy is the
> key.

No, I think ease of use is. A pull-down with 12 choices is usable, but one
with 31 is not (at least on Netscape on Linux).

 - Jamie

cvs repository

[Benjamin M. <be...@me...>]

I noticed that we are not using sourceforge's cvs for the repository.  I 
couldn't find a developers page in the webmin website.  Where does the 
current cvs reside?  (Is there a cvs?)  Is there a reason for us not to use 
the sourceforge cvs?

-Ben

Re: Groups issue

[Benjamin M. <be...@me...>]

> > 2) If you put in a wrong date it gives you the error "invalid expiry
> > date" Shoudn't that read expiration :)
> >
> > 3) If you go past 2038 you start getting wacky errors
>
> Yeah, unix time can't handle that.

It would be nice to simply have a check for the year then.

> > 4) We allow for wrong dates such as Feb 31 so we should simply have drop
> > down boxes for the Experation day and year.
>
> Personally I find it easier to type in a number rather than select it
> from a long list..

Then we should remove the pull down menu for the months.  concistancy is the 
key.

-Benjamin

Re: miniserv.pl hangs on module update

[Jamie C. <jca...@we...>]

Curtis Doty wrote:
> 
> I seem to have recently acquired a bug where I cannot do a remote url
> install of a module.
> 
> While attempting to figure it out, I uncovered another one. (!?@#!) It
> appears the module filename is not properly escaped. I tried to quote it in
> all places where it could be backquoted. Attached is the patch. I've not
> looked beyond one file, install_mod.cgi.

Yeah, someone else just reported that one :) It will be fixed in the next
release ..
 
> So anyway, miniserv.pl is still hanging. Endless hourglass when I attempt to
> install a module from local or remote source. It looks like miniserv.pl is
> spinning and enlessly spawning rm, over and over. Any ideas on how to debug?

Odd .. what module were you trying to remotely install?

 - Jamie

miniserv.pl hangs on module update

[Curtis D. <Cu...@Gr...>]

I seem to have recently acquired a bug where I cannot do a remote url
install of a module.

While attempting to figure it out, I uncovered another one. (!?@#!) It
appears the module filename is not properly escaped. I tried to quote it in
all places where it could be backquoted. Attached is the patch. I've not
looked beyond one file, install_mod.cgi.

So anyway, miniserv.pl is still hanging. Endless hourglass when I attempt to
install a module from local or remote source. It looks like miniserv.pl is
spinning and enlessly spawning rm, over and over. Any ideas on how to debug?

../C

Re: Groups issue

[Jamie C. <jca...@we...>]

Benjamin Meyer wrote:
> 
> 1) When I click on the primary group button I get this error:
> 
> Can't modify reference constructor in local at
> /usr/local/webmin-0.86/useradmin/my_group_chooser.cgi line 137, near ");"

This is a known problem which oddly occurs with only some versions of perl.
There is an update for it at http://www.webmin.com/webmin/updates.html
 
> 2) If you put in a wrong date it gives you the error "invalid expiry date"
> Shoudn't that read expiration :)
> 
> 3) If you go past 2038 you start getting wacky errors

Yeah, unix time can't handle that.

> 4) We allow for wrong dates such as Feb 31 so we should simply have drop down
> boxes for the Experation day and year.

Personally I find it easier to type in a number rather than select it
from a long list..

 - Jamie

Re: <hr>

[Jamie C. <jca...@we...>]

Benjamin Meyer wrote:
> Please tell me this not true, but it looks like every single module has
> 
> &header(...)
> printf "<hr>\n";
> 
> ...
> ......
> ...
> 
> printf "<hr>\n";
> &footer(...)
> 
> If that is the case then I volenteer to go through and remove it from every
> module and added it to the the header and footer functions (along with adding
> the option to not show it)  I have an account on sourceforge (icefox2)

Not every single module - some programs call header() with no parameters
and don't output an <hr>. You are right that the majority do though ..
 
> Also while I am at it what do you think of adding the modules icon to the
> paramaters of the header so all the icons will show up in the modules index
> page.

That could be done pretty easily.. though the header is getting pretty crowded
on most modules.

 - Jamie

Re: website licencing issue

[Jamie C. <jca...@we...>]

Benjamin Meyer wrote:
> 
> On the website it lists all of the included default modules as being gpl'd.
> Is this simply out of date information or correct?

The site is wrong - I have fixed it up now though.

 - Jamie

Re: module request

[<gsa...@pr...>]

Hi Benjamin,

I'm one of the developers of the TCP Wrappers module under Webmin and I want to tell you that the module is licensed GPL (check the third party modules page). I don't know what happens to my email address but we can communicate with this one...

Greetings
Gianfranco Samuele.


On Jun 18 13:53, Benjamin Meyer <be...@me...> wrote:
>
> Subject: Re: module request
>
> It looks like two caldera people are working on this and from what it looks
> like this is licensed under a bsd license. I wasn't able to send them e-mail
> to get an answer because the address doesn't work.
> (Please correct me if I am wrong about the licensing!) If the licensing is
> bsd then a few minor issues we should be able to incorperate it into the
> Network Configuration Modules.  Any reason we would not want to?
> 
> -Ben
> 
> On Monday 18 June 2001 13:15, Curtis Doty wrote:
> > >Can someone point me to the correct spot.  The ftp site doesn't
> > >have anything
> > >on it and I can't seem to find tcpwrapper webmin module via google.
> >
> > http://webmin.ven.org/tcpw/
> >
> > -
> > Forwarded by the Webmin development list at web...@we...
> > To remove yourself from this list, go to
> > http://lists.sourceforge.net/lists/listinfo/webadmin-devel
> 
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel
> 
> 

Re: module request

[Benjamin M. <be...@me...>]

It looks like two caldera people are working on this and from what it looks 
like this is licensed under a bsd license. I wasn't able to send them e-mail 
to get an answer because the address doesn't work.  
(Please correct me if I am wrong about the licensing!) If the licensing is 
bsd then a few minor issues we should be able to incorperate it into the 
Network Configuration Modules.  Any reason we would not want to?

-Ben

On Monday 18 June 2001 13:15, Curtis Doty wrote:
> >Can someone point me to the correct spot.  The ftp site doesn't
> >have anything
> >on it and I can't seem to find tcpwrapper webmin module via google.
>
> http://webmin.ven.org/tcpw/
>
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel

Re: icon art etc

[Benjamin M. <be...@me...>]

I would like that, yah my current theme has to use themes which I also hate.  
I look forward to seeing it.

-Benjamin Meyer

On Monday 18 June 2001 13:23, Nick Jennings wrote:
> On Mon, Jun 18, 2001 at 06:56:11AM -0400, Benjamin Meyer wrote:
> > > To do stuff like that, you need to override the index.cgi program in
> > > your theme. Have a look at the included caldera theme for an example..
> > > it has it's own index.cgi which outputs a top-bottom frameset.
> >
> > caldera uses frames.
>
>  I am currently working on a theme that does not use frames, uses a nice
>  tableset, even when modules are being used the table menus stay. I made
>  a simple patch to the web-lib.pl (to the header and footer subroutines).
>
>  I think it looks much better without frames, i hate frames. :)
>
>  Not sure whether I will be able to release my changes back, if anything
>  I might be able to release the web-lib.pl changes, if they are accepted.
>  basically it will introduce a theme config option like tables=1 and
>  web-lib-.pl will check that conf option whenever the header and footer
>  subroutine are called, if that option is true it will call a header.pl
>  script in the theme's directory and return the output to the module,
>  this can be an entire tableset so the module content is in it's own
>  table in this layout, and the footer.pl will close it all up. it works
>  very nicely.

Re: icon art etc

[Nick J. <ni...@na...>]

On Mon, Jun 18, 2001 at 06:56:11AM -0400, Benjamin Meyer wrote:
> > To do stuff like that, you need to override the index.cgi program in your
> > theme. Have a look at the included caldera theme for an example.. it has
> > it's own index.cgi which outputs a top-bottom frameset.
> 
> caldera uses frames.
> 

 I am currently working on a theme that does not use frames, uses a nice
 tableset, even when modules are being used the table menus stay. I made
 a simple patch to the web-lib.pl (to the header and footer subroutines).

 I think it looks much better without frames, i hate frames. :)

 Not sure whether I will be able to release my changes back, if anything
 I might be able to release the web-lib.pl changes, if they are accepted.
 basically it will introduce a theme config option like tables=1 and 
 web-lib-.pl will check that conf option whenever the header and footer
 subroutine are called, if that option is true it will call a header.pl
 script in the theme's directory and return the output to the module,
 this can be an entire tableset so the module content is in it's own
 table in this layout, and the footer.pl will close it all up. it works
 very nicely.

-- 
  Nick Jennings

RE: module request

[Curtis D. <Cu...@Gr...>]

>Can someone point me to the correct spot.  The ftp site doesn't 
>have anything 
>on it and I can't seem to find tcpwrapper webmin module via google.

http://webmin.ven.org/tcpw/

website licencing issue

[Benjamin M. <be...@me...>]

On the website it lists all of the included default modules as being gpl'd.  
Is this simply out of date information or correct?

-Benjamin

Re: webmin users

[Benjamin M. <be...@me...>]

It may not gain much, but every little thing makes webmin better :)

-Ben


On Monday 18 June 2001 07:52, you wrote:
> Benjamin Meyer wrote:
> > Why is webmin users in its own module and not in the webmin
> > configuration? Would it make more sense to move it in there?
>
> Not really .. the Webmin Configuration module deals with global options,
> while the Webmin Users module controls who can login. I guess webmin users
> could just be another icon under webmin configuration, but that wouldn't
> really gain much ..
>
>  - Jamie
>
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel

Re: module request

[Benjamin M. <be...@me...>]

Can someone point me to the correct spot.  The ftp site doesn't have anything 
on it and I can't seem to find tcpwrapper webmin module via google.

-Ben


On Monday 18 June 2001 10:52, you wrote:
> There is also a libwrap module for the Guardian Digital WebTool, which is
> based upon Webmin.  You can download the src.rpm and take a look
> (ftp.engardelinux.org) and, if you feel so inspired, hack it back into a
> module that will work with Webmin.
>
> That was my original intent, but I haven't had time to yet. :(
>
> -r
>
> > tcpwrappers has a third party module, which I think is maintained by a
> > couple of Mandrake folks.
> >
> > Benjamin Meyer wrote:
> > > I noticed that there wan't a hosts.allow or hosts.deny module.  If I
> > > missed this let me know and I will pick it up for my first modules.
> > >
> > > -Benjamin
> >
> >                                    --
> >                       Joe Cooper <jo...@sw...>
> >                   Affordable Web Caching Proxy Appliances
> >                          http://www.swelltech.com
> >
> >
> > -
> > Forwarded by the Webmin development list at web...@we...
> > To remove yourself from this list, go to
> > http://lists.sourceforge.net/lists/listinfo/webadmin-devel

<hr>

[Benjamin M. <be...@me...>]

---
oop only sent this too Jamie, re-sending it to the list.

-Ben
---

Please tell me this not true, but it looks like every single module has

&header(...)
printf "<hr>\n";

...
......
...

printf "<hr>\n";
&footer(...)

If that is the case then I volenteer to go through and remove it from every 
module and added it to the the header and footer functions (along with adding 
the option to not show it)  I have an account on sourceforge (icefox2)

Also while I am at it what do you think of adding the modules icon to the 
paramaters of the header so all the icons will show up in the modules index 
page.

-Benjamin Meyer

Re: module request

[Ryan W. M. <ry...@gu...>]

There is also a libwrap module for the Guardian Digital WebTool, which is
based upon Webmin.  You can download the src.rpm and take a look
(ftp.engardelinux.org) and, if you feel so inspired, hack it back into a
module that will work with Webmin.

That was my original intent, but I haven't had time to yet. :(

-r


> tcpwrappers has a third party module, which I think is maintained by a
> couple of Mandrake folks.
>
> Benjamin Meyer wrote:
>
> > I noticed that there wan't a hosts.allow or hosts.deny module.  If I missed
> > this let me know and I will pick it up for my first modules.
> >
> > -Benjamin
>
>                                    --
>                       Joe Cooper <jo...@sw...>
>                   Affordable Web Caching Proxy Appliances
>                          http://www.swelltech.com
>
>
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel
>

-- 
 +-- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --+
   Ryan W. Maple           "Finality is A Good Thing."  -- Dave Wreski
   Guardian Digital, Inc.                     ry...@gu...
 +-- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --+

Re: webmin users

[Jamie C. <jca...@we...>]

Benjamin Meyer wrote:
> 
> Why is webmin users in its own module and not in the webmin configuration?
> Would it make more sense to move it in there?

Not really .. the Webmin Configuration module deals with global options,
while the Webmin Users module controls who can login. I guess webmin users
could just be another icon under webmin configuration, but that wouldn't
really gain much ..

 - Jamie

Re: module request

[Joe C. <jo...@sw...>]

tcpwrappers has a third party module, which I think is maintained by a 
couple of Mandrake folks.

Benjamin Meyer wrote:

> I noticed that there wan't a hosts.allow or hosts.deny module.  If I missed 
> this let me know and I will pick it up for my first modules.
> 
> -Benjamin

                                   --
                      Joe Cooper <jo...@sw...>
                  Affordable Web Caching Proxy Appliances
                         http://www.swelltech.com

module request

[Benjamin M. <be...@me...>]

I noticed that there wan't a hosts.allow or hosts.deny module.  If I missed 
this let me know and I will pick it up for my first modules.

-Benjamin

Groups issue

[Benjamin M. <be...@me...>]

1) When I click on the primary group button I get this error:

Can't modify reference constructor in local at 
/usr/local/webmin-0.86/useradmin/my_group_chooser.cgi line 137, near ");"

2) If you put in a wrong date it gives you the error "invalid expiry date"  
Shoudn't that read expiration :)

3) If you go past 2038 you start getting wacky errors

4) We allow for wrong dates such as Feb 31 so we should simply have drop down 
boxes for the Experation day and year.

-Ben