Re: [Vym-devel] for CMake users
Brought to you by:
insilmaril
From: Uwe D. <vym@InSilmaril.de> - 2012-04-12 13:13:09
|
On Thu, Apr 12, Patrick Spendrin wrote: > Am 11.04.2012 21:50, schrieb Uwe Drechsel: > ... > >> Your patch is missing the installation commands, if Uwe is ok with that > >> (I assume since he committed your patch), I'll add the remaining parts > >> to get the cmake part on the same level as the qmake one. > > In the attached patch vym-cmakelists-install.diff I added most of the > install commands required. Since there is no pdf documentation in git, I > didn't make any attempt in generating/installing it (if wanted, I could > do that too). > > In the cmake file I fixed the installation of the translations, so that > the .qm files get installed rather than the .ts files (this makes the > german translation work for me). I don't know how that would work for > qmake, but since my first installer was based on qmake and still > installed the .ts files instead of the .qm files, this needs to be > changed there too (if you know how to do that in qmake please do so). > > I also had to patch parser.cpp since the Microsoft compiler doesn't > accept named boolean operators (not, or, and instead of !, ||, &&). > > > > > Of course no objections here. > > (Some maintainers are against having multiple buildsystems side by side, > because it either brings more work because of keeping them in sync, or > one being constantly outdated.) > Well, I maintain the builds in openSUSE. Becauce building the pdfs requires additional packages, I so far did this in a buildscript. (Recently added it: scripts: makedist-vym) Fow now I am going to stick with qmake, as this works well on Linux and also worked on Mac. Still I would like to make it easy for others to build on their favourite system, so I don't mind having CMake tracked in git, as long as I don't have to really maintain it ;-) Pushed to master now. Thanks Uwe |