#903 SDL cannot set selected ethernet interface properly

[Querino]

SDL version does not set the selected ethernet interface.

machine settings -> ethernet settings -> interface

first of all, the selected interface does not get marked using the usual 'star'.
now when i save settings, the .ini looks like this:

ETHERNET_INTERFACE="\Device\NPF_{BB993C70-7121-4EED-BF4D-6804CE90E1EE}"

and it does not work. if i change the .ini manually (i got that from winvice .ini) to

ETHERNET_INTERFACE="Qualcomm Atheros Ar81xx series PCI-E Ethernet Controller (\Device\NPF_{BB993C70-7121-4EED-BF4D-6804CE90E1EE})"

it does work. maybe related to https://sourceforge.net/p/vice-emu/bugs/861/ ?

tested with sdl2vice 3.1 (under windows)

[Greg King]

The menu tick-mark is shown; but, it is off the right side of the 40-column screen (it can be seen on x128's 80-column screen).

Maybe related to https://sourceforge.net/p/vice-emu/bugs/861/ ?

Yep, I forgot about the Windows SDL ports. This patch fixes it. The commit message is:

* Made SDL WinVICE Ethernet "Interface" menu create a proper resource setting.

* Made "Ethernet settings" menu show current interface.
* Fixed memory leaks (adapter names weren't being freed).

Companion of r33039. Fixes bug #903.

[Querino]

The menu tick-mark is shown; but, it is off the right side of the 40-column screen (it can be seen on x128's 80-column screen).

i mean the asterisk on the right side when something is selected. like at other places, example:

Ethernet Cart Emulation

and if selected:

Ethernet Cart Emulation *

but as you say, most adapters names are too long anywway to display the asterisk, and it's only a small cosmetical thing.

the patch iself does work well, good job. well, that part is fixed, but there's still this issue left: https://sourceforge.net/p/vice-emu/bugs/902/
unless we're doing something wrong.

thanks for the diffs!

[gpz]

fixed in trunk / 3.2