#2142 xplus4 broken samples

[Durandal]

TED samples are broken on xplus4, noticed on 45633 but probably started on 45283 according with the commit history.

Samples sound extremely low and distorted.
Setting the experimental SOUND_SYSTEM_FLOAT define fixes the distortion not the low volume, and normal TED sound is silent.
Attached a program with samples, press 1-8 for sample playback, program is compatible with PAL and NTSC

Video of the same program running on an NTSC Plus/4
https://youtube.com/shorts/eZLtTbUllUc

[Querino]

after some simple testing with older versions, i think the problem starts here:

https://sourceforge.net/p/vice-emu/code/45283/

[Durandal]

Tested with YapeSDL 0.80.1 (July 2024), and samples work fine there.

[Querino]

Well, the last one that sounded properly in my short test me was 3.8.45282, while 3.8.45298 sounds as it does up to today.

[gpz]

Really hard to tell what the problem could be.... the new sound logic is basically copied 1:1 from SDL-Yape for that matter (and it did fix some other problems too)

[gpz]

If someone wants to help, this is the code to stare at and find the difference to what VICE does:

https://github.com/calmopyrin/yapesdl/blob/master/tedsound.cpp

[gpz]

Looks like i was using an older version of that code as a reference.

Good news: that program uses "digital mode" so it should be rather easy to fix (no LFSR trickery or sth like that)

[gpz]

should be fixed in r45723 - please test

[Querino]

seems to be fine.

[Durandal]

Yes, confirmed fixed