Option Save Settings To NEW.INI saves settings only for the current computer
Versatile Commodore Emulator
Brought to you by:
blackystardust,
gpz
For example,
we have vice.ini with two configurations for[C64SC]
and [SCPU64]
.
After running x64sc.exe and executing Save-settings-to vice.ini,
or Save-settings-to any existing .ini (Replace),
the configurations for both machines are saved.
But if we do Save-settings-to new.ini (input new name)
only the[C64SC]
configuration is saved and the other one is not.
This also happens when vice.ini is loaded into xscpu.exe. Then we lose the configuration for x64sc.
Maybe this is intentional, then please close the ticket.
But it's a bit unexpected.
This is a tricky one... i agree it's unexpected. And i am sure this behaviour is not "intended" - its just how it works :) The problem is, that the current emulator does not "know" about the config of other emulators at all. When saving to an existing file, it will copy whatever is there for the other emus, and insert the config for the new emu. When creating a new file, there is nothing to copy, so it will only save the config of the current emu.
Maybe this can be changed so it uses the last filename of the config for copying the config, and the new filename for creating the new config. I'll have a look :)
Or maybe a message when saving to a new ini. will be enough:
This will save you searching :)
Saved new configuration for [C64SC] only!
etc.
That'd be the last resort.... i'd prefer to make it just work as expected :)
interesting, i always thought it makes sense the way it currently is. each emulator only writes its own settings, so if we start a new, empty config file, it will only contain the settings from the current emulator.
if we "save settings to" and point to an existing config file, only the current emulators settings are updated, leaving the other settings untouched. as expected.
Looking at it this way, it is actually practical. And it is worth leaving this "save" as it is. And optionally, insert the text in the GUI that this is only a record of the configuration of the current emulator. Just to be clear
This is a decision to consider.
The tricky part is.... after saving the config into a new file in the vice directory, also the other emulators will use that config file - and any previously stored settings for them are gone. As long as you don't do that, it behaves as expected, i agree
Another idea: splitting the config into separate files per emulator - that would remove all those problems AND reduce the amount of code.
Each emulator will have its own starting .ini?
Instead of one common vice.ini?