Re: [Tuxpaint-devel] Help needed: label tool

[Pere P. i C. <pe...@fo...>]

El dt 06 de 10 de 2009 a les 18:06 -0700, en/na Bill Kendrick va
escriure:
> On Wed, Oct 07, 2009 at 12:45:40AM +0200, Pere Pujal i Carabantes wrote:
> > So the editing is not commited and you click on save or type CTRL + S.
> > This has been there for a while in the text tool, I don't understand its
> > logic, but it is explicitely disabled to render the currently unfinished
> > edited text when saving.
> 
> Hrm that's a bug.  I think it's similar to one we fixed a while back
> regarding printing.  Kids would type some text, then hit [Print], but
> their text would not be on the printout.  Turns out it hadn't been
> applied to the drawing yet!  (That was fixed in 0.9.18; see CHANGES.txt)
> 
> And, obviously, I think Label should do the same.  If I add a label,
> but forget to hit [Enter] or [Tab], and then I hit "Save" or [Ctrl+S],
> the label should be saved.  And if I hit "Print" or [Ctrl+P], the label
> should appear on my printout. :)
> 
> Now, the hack I did for Printing causes the text entry to end.
> (And it appears that the insertion cursor ends up at the beginning of
> the text that had been entered.)  It's not ideal, but better than
> a bogus print, or losing data when you save and then quit.
> 
>   |            [type "hello"]
>    hello|      [press Ctrl+P]
>   |hello       [cursor in a weird place, and I cannot edit[*]]
> 
> where "|" is the blinking insertion pointer.
> 
> [*] I'm not SUPER worried about not being able to edit, esp. with the Text
> tool.  Once you change tools, text gets applied.  Should be the same with
> printing or saving.
> 
I will not have time to check carefully for side issues, but commenting
out the lines 2360 2361 seems to fix the blinking pointer for CTRL+P, of
course you have to find the corresponding lines for click on print. I
currently don't have the time.

Also copying/adapting the block of code where thoose lines leave to the
corresponding place at the saving code should fix the losing of data
when saving and quitting.


Going on hollidays NOW :)
See you at the end of next week.
Pere