tuxpaint-devel — General discussion list for Tux Paint developers

Re: [Tuxpaint-devel] Tux Paint 0.9.33-rc1 posted for beta builds

[Bill K. <nb...@so...>]

On Mon, Jul 08, 2024 at 10:50:12AM +0100, Will Thompson wrote:
> Hi,
> 
> I pushed <https://github.com/flathub/org.tuxpaint.Tuxpaint/tree/beta> this
> to the beta branch on the flathub repo; it should be live on flathub-beta
> <https://docs.flathub.org/docs/for-users/installation/#flathub-beta-repository>
> in
> 3–4 hours.

Cool!

 
> This reminded me that there is 1 buildsystem patch needed there, to find
> the include & link arguments for SDL2_gfx via pkg-config.
> https://github.com/flathub/org.tuxpaint.Tuxpaint/blob/beta/Makefile-sdl2_gfx-pkgconfig.patch
> should be applicable more broadly to fix the build when SDL2_gfx is not on
> the default include/link path.

I've applied it upstream.  HTH!  Thanks!

-bill!

Re: [Tuxpaint-devel] Tux Paint 0.9.33-rc1 posted for beta builds

[Will T. <wj...@en...>]

Hi,

I pushed <https://github.com/flathub/org.tuxpaint.Tuxpaint/tree/beta> this
to the beta branch on the flathub repo; it should be live on flathub-beta
<https://docs.flathub.org/docs/for-users/installation/#flathub-beta-repository>
in
3–4 hours.

This reminded me that there is 1 buildsystem patch needed there, to find
the include & link arguments for SDL2_gfx via pkg-config.
https://github.com/flathub/org.tuxpaint.Tuxpaint/blob/beta/Makefile-sdl2_gfx-pkgconfig.patch
should be applicable more broadly to fix the build when SDL2_gfx is not on
the default include/link path.

– Will

On Sat, 6 Jul 2024 at 20:40, Bill Kendrick <nb...@so...> wrote:

>
> Hi all!  Today I tagged and cut release candidates of Tux Paint 0.9.33
> and friends:
>
>  * Tux Paint 0.9.33-rc1
>
> https://sourceforge.net/projects/tuxpaint/files/tuxpaint/0.9.33-beta/tuxpaint-0.9.33-rc1.tar.gz/download
>
>  * Tux Paint Config 0.0.24-rc1
>
> https://sourceforge.net/projects/tuxpaint/files/tuxpaint-config/0.0.24-beta/tuxpaint-config-0.0.24-rc1.tar.gz/download
>
>  * Tux Paint Stamps 2024-07-XX-rc1
>
> https://sourceforge.net/projects/tuxpaint/files/tuxpaint-stamps/2024-07-XX-beta/tuxpaint-stamps-2024.07.06.tar.gz/download
>
> When you have time, please build versions based on these for your favorite
> platform, so we can have people beta test them.
>
> Tux Paint includes a number of changes and bugfixes since the last
> release, back in January:
>
>  * A pair of new "Dither" magic tools
>  * New "Filled Polygon" magic tool
>  * New magic tool API call to retract an undo snapshot
>    (utilized by "Filled Polygon")
>  * Update to "3D Glasses" magic tool
>  * Option to un-group (one big list, no pagination) Magic tools
>  * Some new, transparent, erasers
>  * A few new brushes (Paint & Line tools)
>  * Brushes can have descriptions
>  * Font face/size shown when choosing/changing a font (Text & Label tools)
>  * Click-and-release (no drag) with rotating brush would not draw anything;
>    now it draws as if you dragged "up"
>  * Labels on UI buttons will now also word-wrap on dashes ("-"),
>    and support Unicode soft hyphens to hint where words may be broken
>  * When exporting a drawing (via "Open" dialog), the name of the file
>    is shown, AND is placed in your Copy/Paste buffer
>  * OS Trashcan support ("Erase" in "Open" dialog) on Haiku now, too
>  * Snappier screen refresh on macOS
>  * Workaround for bash-completion (newer versions) bug in some locales
>    (was due to Tux Paint's file being read before bash-completion's own
>    "000_bash_completion_compat.bash")
>  * Some work towards supporting OS/2 builds
>  * Universal bundling simplification for macOS
>  * Appdate metadata updates for Appstream 1.0
>  * Remove final coupla of RSVG library warnings during compliation
>  * Removed some unused text rendering code
>  * Updated Troubleshooting Guide to cover macOS, Haiku, and Linux
>  * Docs made more consistent, re: where files go
>  * Added process to run `indent` on "tp_magic_example.c" regularly
>  * Doc styling modernization in FAQ, Env. Vars., & Advanced Stamp Howto.
>  * Doc corrections re: old usage of "--fullscreen" (with no parameter)
>  * Localization updates
>  * Bugfix: Avoid invalid memory access in Linear Gradient (Fill tool)
>
> WHEW!  It's a lot!  Despite feeling like I haven't done anything with
> Tux Paint for a few months, I guess the truth is we were REALLY busy
> in the beginning of the year. :-)
>
>
> Tux Paint Config. adds a new checkbox (in "Simplification") for the
> magic tool ungrouping feature.  Otherwise, both Config. Tux Paint Stamps
> only had some localization updates since their last releases
> (also back in January).
>
> Thanks in advance!  For others up here in the northern hemisphere,
> I hope you're staying safe & cool!
>
> -bill!
>
>
>
> _______________________________________________
> Tuxpaint-devel mailing list
> Tux...@li...
> https://lists.sourceforge.net/lists/listinfo/tuxpaint-devel
>

Re: [Tuxpaint-devel] [Tuxpaint-maintainers] Tux Paint 0.9.33-rc1 posted for beta builds

[Pere P. i C. <per...@gm...>]

Hi,

Android build at
https://provant.freeddns.org/pere/public_html/Tux%20Paint/0.9.33-RC1/

Best
Pere


El ds. 06 de 07 de 2024 a les 12:40 -0700, en/na Bill Kendrick va escriure:
> Hi all!  Today I tagged and cut release candidates of Tux Paint 0.9.33
> and friends:
> 
>  * Tux Paint 0.9.33-rc1
>    https://sourceforge.net/projects/tuxpaint/files/tuxpaint/0.9.33-beta/tuxpaint-0.9.33-rc1.tar.gz/download
> 
>  * Tux Paint Config 0.0.24-rc1
>    https://sourceforge.net/projects/tuxpaint/files/tuxpaint-config/0.0.24-beta/tuxpaint-config-0.0.24-rc1.tar.gz/download
> 
>  * Tux Paint Stamps 2024-07-XX-rc1
>    https://sourceforge.net/projects/tuxpaint/files/tuxpaint-stamps/2024-07-XX-beta/tuxpaint-stamps-2024.07.06.tar.gz/download
> 
> When you have time, please build versions based on these for your favorite
> platform, so we can have people beta test them.
> 
> Tux Paint includes a number of changes and bugfixes since the last
> release, back in January:
> 
>  * A pair of new "Dither" magic tools
>  * New "Filled Polygon" magic tool
>  * New magic tool API call to retract an undo snapshot
>    (utilized by "Filled Polygon")
>  * Update to "3D Glasses" magic tool
>  * Option to un-group (one big list, no pagination) Magic tools
>  * Some new, transparent, erasers
>  * A few new brushes (Paint & Line tools)
>  * Brushes can have descriptions
>  * Font face/size shown when choosing/changing a font (Text & Label tools)
>  * Click-and-release (no drag) with rotating brush would not draw anything;
>    now it draws as if you dragged "up"
>  * Labels on UI buttons will now also word-wrap on dashes ("-"),
>    and support Unicode soft hyphens to hint where words may be broken
>  * When exporting a drawing (via "Open" dialog), the name of the file
>    is shown, AND is placed in your Copy/Paste buffer
>  * OS Trashcan support ("Erase" in "Open" dialog) on Haiku now, too
>  * Snappier screen refresh on macOS
>  * Workaround for bash-completion (newer versions) bug in some locales
>    (was due to Tux Paint's file being read before bash-completion's own
>    "000_bash_completion_compat.bash")
>  * Some work towards supporting OS/2 builds
>  * Universal bundling simplification for macOS
>  * Appdate metadata updates for Appstream 1.0
>  * Remove final coupla of RSVG library warnings during compliation
>  * Removed some unused text rendering code
>  * Updated Troubleshooting Guide to cover macOS, Haiku, and Linux
>  * Docs made more consistent, re: where files go
>  * Added process to run `indent` on "tp_magic_example.c" regularly
>  * Doc styling modernization in FAQ, Env. Vars., & Advanced Stamp Howto.
>  * Doc corrections re: old usage of "--fullscreen" (with no parameter)
>  * Localization updates
>  * Bugfix: Avoid invalid memory access in Linear Gradient (Fill tool)
> 
> WHEW!  It's a lot!  Despite feeling like I haven't done anything with
> Tux Paint for a few months, I guess the truth is we were REALLY busy
> in the beginning of the year. :-)
> 
> 
> Tux Paint Config. adds a new checkbox (in "Simplification") for the
> magic tool ungrouping feature.  Otherwise, both Config. Tux Paint Stamps
> only had some localization updates since their last releases
> (also back in January).
> 
> Thanks in advance!  For others up here in the northern hemisphere,
> I hope you're staying safe & cool!
> 
> -bill!
> 
> 
> 
> _______________________________________________
> Tuxpaint-maintainers mailing list
> Tux...@li...
> https://lists.sourceforge.net/lists/listinfo/tuxpaint-maintainers

Re: [Tuxpaint-devel] Tux Paint 0.9.33-rc1 posted for beta builds

[Shin-ichi T. <dol...@wm...>]

Hi!

Build for Windows and RHELs are ready.

  https://z1.plala.jp/tuxpaint/testing/windows/0.9.33-rc1/
  https://z1.plala.jp/tuxpaint/testing/rpms/0.9.33-rc1/

Please take note that libunibreak also has been updated this time.


On Sat, 6 Jul 2024 12:40:00 -0700, Bill Kendrick wrote:
>
>Hi all!  Today I tagged and cut release candidates of Tux Paint 0.9.33
>and friends:
>
> * Tux Paint 0.9.33-rc1
>   https://sourceforge.net/projects/tuxpaint/files/tuxpaint/0.9.33-beta/tuxpaint-0.9.33-rc1.tar.gz/download
>
> * Tux Paint Config 0.0.24-rc1
>   https://sourceforge.net/projects/tuxpaint/files/tuxpaint-config/0.0.24-beta/tuxpaint-config-0.0.24-rc1.tar.gz/download
>
> * Tux Paint Stamps 2024-07-XX-rc1
>   https://sourceforge.net/projects/tuxpaint/files/tuxpaint-stamps/2024-07-XX-beta/tuxpaint-stamps-2024.07.06.tar.gz/download
>
>When you have time, please build versions based on these for your favorite
>platform, so we can have people beta test them.
>
>Tux Paint includes a number of changes and bugfixes since the last
>release, back in January:
>
> * A pair of new "Dither" magic tools
> * New "Filled Polygon" magic tool
> * New magic tool API call to retract an undo snapshot
>   (utilized by "Filled Polygon")
> * Update to "3D Glasses" magic tool
> * Option to un-group (one big list, no pagination) Magic tools
> * Some new, transparent, erasers
> * A few new brushes (Paint & Line tools)
> * Brushes can have descriptions
> * Font face/size shown when choosing/changing a font (Text & Label tools)
> * Click-and-release (no drag) with rotating brush would not draw anything;
>   now it draws as if you dragged "up"
> * Labels on UI buttons will now also word-wrap on dashes ("-"),
>   and support Unicode soft hyphens to hint where words may be broken
> * When exporting a drawing (via "Open" dialog), the name of the file
>   is shown, AND is placed in your Copy/Paste buffer
> * OS Trashcan support ("Erase" in "Open" dialog) on Haiku now, too
> * Snappier screen refresh on macOS
> * Workaround for bash-completion (newer versions) bug in some locales
>   (was due to Tux Paint's file being read before bash-completion's own
>   "000_bash_completion_compat.bash")
> * Some work towards supporting OS/2 builds
> * Universal bundling simplification for macOS
> * Appdate metadata updates for Appstream 1.0
> * Remove final coupla of RSVG library warnings during compliation
> * Removed some unused text rendering code
> * Updated Troubleshooting Guide to cover macOS, Haiku, and Linux
> * Docs made more consistent, re: where files go
> * Added process to run `indent` on "tp_magic_example.c" regularly
> * Doc styling modernization in FAQ, Env. Vars., & Advanced Stamp Howto.
> * Doc corrections re: old usage of "--fullscreen" (with no parameter)
> * Localization updates
> * Bugfix: Avoid invalid memory access in Linear Gradient (Fill tool)
>
>WHEW!  It's a lot!  Despite feeling like I haven't done anything with
>Tux Paint for a few months, I guess the truth is we were REALLY busy
>in the beginning of the year. :-)
>
>
>Tux Paint Config. adds a new checkbox (in "Simplification") for the
>magic tool ungrouping feature.  Otherwise, both Config. Tux Paint Stamps
>only had some localization updates since their last releases
>(also back in January).
>
>Thanks in advance!  For others up here in the northern hemisphere,
>I hope you're staying safe & cool!
>
>-bill!
>
>
>
>_______________________________________________
>Tuxpaint-maintainers mailing list
>Tux...@li...
>https://lists.sourceforge.net/lists/listinfo/tuxpaint-maintainers


-- 
Shin-ichi TOYAMA <dol...@wm...>

Re: [Tuxpaint-devel] [Tuxpaint-maintainers] Tux Paint 0.9.33-rc1 posted for beta builds

[Mark K. <tux...@cb...>]

Hi Bill,

macOS builds have been uploaded here:

   - https://dl.cbreak.org/TuxPaint-0.9.33-rc1.dmg
   - https://dl.cbreak.org/TuxPaint-Config-0.0.24-rc1.dmg
   - https://dl.cbreak.org/TuxPaint-Stamps-2024.07.06.dmg

Thanks,
Mark


On Sat, Jul 6, 2024 at 3:40 PM Bill Kendrick <nb...@so...> wrote:

>
> Hi all!  Today I tagged and cut release candidates of Tux Paint 0.9.33
> and friends:
>
>  * Tux Paint 0.9.33-rc1
>
> https://sourceforge.net/projects/tuxpaint/files/tuxpaint/0.9.33-beta/tuxpaint-0.9.33-rc1.tar.gz/download
>
>  * Tux Paint Config 0.0.24-rc1
>
> https://sourceforge.net/projects/tuxpaint/files/tuxpaint-config/0.0.24-beta/tuxpaint-config-0.0.24-rc1.tar.gz/download
>
>  * Tux Paint Stamps 2024-07-XX-rc1
>
> https://sourceforge.net/projects/tuxpaint/files/tuxpaint-stamps/2024-07-XX-beta/tuxpaint-stamps-2024.07.06.tar.gz/download
>
> When you have time, please build versions based on these for your favorite
> platform, so we can have people beta test them.
>
> Tux Paint includes a number of changes and bugfixes since the last
> release, back in January:
>
>  * A pair of new "Dither" magic tools
>  * New "Filled Polygon" magic tool
>  * New magic tool API call to retract an undo snapshot
>    (utilized by "Filled Polygon")
>  * Update to "3D Glasses" magic tool
>  * Option to un-group (one big list, no pagination) Magic tools
>  * Some new, transparent, erasers
>  * A few new brushes (Paint & Line tools)
>  * Brushes can have descriptions
>  * Font face/size shown when choosing/changing a font (Text & Label tools)
>  * Click-and-release (no drag) with rotating brush would not draw anything;
>    now it draws as if you dragged "up"
>  * Labels on UI buttons will now also word-wrap on dashes ("-"),
>    and support Unicode soft hyphens to hint where words may be broken
>  * When exporting a drawing (via "Open" dialog), the name of the file
>    is shown, AND is placed in your Copy/Paste buffer
>  * OS Trashcan support ("Erase" in "Open" dialog) on Haiku now, too
>  * Snappier screen refresh on macOS
>  * Workaround for bash-completion (newer versions) bug in some locales
>    (was due to Tux Paint's file being read before bash-completion's own
>    "000_bash_completion_compat.bash")
>  * Some work towards supporting OS/2 builds
>  * Universal bundling simplification for macOS
>  * Appdate metadata updates for Appstream 1.0
>  * Remove final coupla of RSVG library warnings during compliation
>  * Removed some unused text rendering code
>  * Updated Troubleshooting Guide to cover macOS, Haiku, and Linux
>  * Docs made more consistent, re: where files go
>  * Added process to run `indent` on "tp_magic_example.c" regularly
>  * Doc styling modernization in FAQ, Env. Vars., & Advanced Stamp Howto.
>  * Doc corrections re: old usage of "--fullscreen" (with no parameter)
>  * Localization updates
>  * Bugfix: Avoid invalid memory access in Linear Gradient (Fill tool)
>
> WHEW!  It's a lot!  Despite feeling like I haven't done anything with
> Tux Paint for a few months, I guess the truth is we were REALLY busy
> in the beginning of the year. :-)
>
>
> Tux Paint Config. adds a new checkbox (in "Simplification") for the
> magic tool ungrouping feature.  Otherwise, both Config. Tux Paint Stamps
> only had some localization updates since their last releases
> (also back in January).
>
> Thanks in advance!  For others up here in the northern hemisphere,
> I hope you're staying safe & cool!
>
> -bill!
>
>
>
> _______________________________________________
> Tuxpaint-maintainers mailing list
> Tux...@li...
> https://lists.sourceforge.net/lists/listinfo/tuxpaint-maintainers
>
>

[Tuxpaint-devel] Tux Paint 0.9.33-rc1 posted for beta builds

[Bill K. <nb...@so...>]

Hi all!  Today I tagged and cut release candidates of Tux Paint 0.9.33
and friends:

 * Tux Paint 0.9.33-rc1
   https://sourceforge.net/projects/tuxpaint/files/tuxpaint/0.9.33-beta/tuxpaint-0.9.33-rc1.tar.gz/download

 * Tux Paint Config 0.0.24-rc1
   https://sourceforge.net/projects/tuxpaint/files/tuxpaint-config/0.0.24-beta/tuxpaint-config-0.0.24-rc1.tar.gz/download

 * Tux Paint Stamps 2024-07-XX-rc1
   https://sourceforge.net/projects/tuxpaint/files/tuxpaint-stamps/2024-07-XX-beta/tuxpaint-stamps-2024.07.06.tar.gz/download

When you have time, please build versions based on these for your favorite
platform, so we can have people beta test them.

Tux Paint includes a number of changes and bugfixes since the last
release, back in January:

 * A pair of new "Dither" magic tools
 * New "Filled Polygon" magic tool
 * New magic tool API call to retract an undo snapshot
   (utilized by "Filled Polygon")
 * Update to "3D Glasses" magic tool
 * Option to un-group (one big list, no pagination) Magic tools
 * Some new, transparent, erasers
 * A few new brushes (Paint & Line tools)
 * Brushes can have descriptions
 * Font face/size shown when choosing/changing a font (Text & Label tools)
 * Click-and-release (no drag) with rotating brush would not draw anything;
   now it draws as if you dragged "up"
 * Labels on UI buttons will now also word-wrap on dashes ("-"),
   and support Unicode soft hyphens to hint where words may be broken
 * When exporting a drawing (via "Open" dialog), the name of the file
   is shown, AND is placed in your Copy/Paste buffer
 * OS Trashcan support ("Erase" in "Open" dialog) on Haiku now, too
 * Snappier screen refresh on macOS
 * Workaround for bash-completion (newer versions) bug in some locales
   (was due to Tux Paint's file being read before bash-completion's own
   "000_bash_completion_compat.bash")
 * Some work towards supporting OS/2 builds
 * Universal bundling simplification for macOS
 * Appdate metadata updates for Appstream 1.0
 * Remove final coupla of RSVG library warnings during compliation
 * Removed some unused text rendering code
 * Updated Troubleshooting Guide to cover macOS, Haiku, and Linux
 * Docs made more consistent, re: where files go
 * Added process to run `indent` on "tp_magic_example.c" regularly
 * Doc styling modernization in FAQ, Env. Vars., & Advanced Stamp Howto.
 * Doc corrections re: old usage of "--fullscreen" (with no parameter)
 * Localization updates
 * Bugfix: Avoid invalid memory access in Linear Gradient (Fill tool)

WHEW!  It's a lot!  Despite feeling like I haven't done anything with
Tux Paint for a few months, I guess the truth is we were REALLY busy
in the beginning of the year. :-)


Tux Paint Config. adds a new checkbox (in "Simplification") for the
magic tool ungrouping feature.  Otherwise, both Config. Tux Paint Stamps
only had some localization updates since their last releases
(also back in January).

Thanks in advance!  For others up here in the northern hemisphere,
I hope you're staying safe & cool!

-bill!

Re: [Tuxpaint-devel] Polygon fill messing with other tools drawing

[Bill K. <nb...@so...>]

On Sat, Jun 01, 2024 at 03:48:09PM +0200, Pere Pujal i Carabantes wrote:
<snip>
> Better :)
> Could be improved if a click in the starting point closes the polygon, 
> as it is now you have to click outside the starting point and drag into it,
> the following works for me.

Thanks!  For safety, I made the two arrays larger by one, since the
last thing that happens is one _more_ point is created, which has
the same position as the first point (index 0).  So if I were to add
a new point at MAX_PTS index into the array, that would go beyond
its capacity, otherwise.

I also bumped the number of points up to 100. (I did that last night
but forgot to commit. Zzzz)


<snip>
> Works fine as far as I've tested :), the only improvement I could imagine 
> is to use the first Undo just to clear the auxiliary stuff, 
> withouth undoing previous work, other Undo acting as of now.

I think I understand what you mean.  I need to play with it
more to make sure, and then I'll see what I can do.  At this
point, I'm glad that it seems to be working _at all_, though...
so any further improvements are just a bonus, IMO. :-D

 
> 2am, why this doesn't surprises me? XDD

It's the only time I get to really hack on Tux Paint these days.
Maybe once I retire, I can stop being an open source vampire. ;)

-bill!

Re: [Tuxpaint-devel] Polygon fill messing with other tools drawing

[Pere P. i C. <per...@gm...>]

El ds. 01 de 06 de 2024 a les 01:48 -0700, en/na Bill Kendrick va escriure:
> On Wed, May 29, 2024 at 10:06:07AM +0200, Pere Pujal i Carabantes wrote:
> > Hi Bill, and all,
> > 
> > A problem, start drawing a polygon and do as many points as possible (17?) 
> > then you are blocked, you can either switch out of the tool or drag the 
> > latest point to the origin closing the polygon, which is not very intuitive.
> > Assuming the only thing you can do in the tool is to close the polygon, 
> > I suggest to do this automatically.
> 
> I think we can raise the number of points.  In the meantime, I updated it
> so that clicking again will simply move the end point (rather than silently
> and confusingly doing _nothing_).

Better :)
Could be improved if a click in the starting point closes the polygon, 
as it is now you have to click outside the starting point and drag into it,
the following works for me.


git diff
diff --git a/magic/src/polyfill.c b/magic/src/polyfill.c
index 25e4cc436..6f1d51bd6 100644
--- a/magic/src/polyfill.c
+++ b/magic/src/polyfill.c
@@ -401,7 +401,7 @@ polyfill_release(magic_api * api, int which ATTRIBUTE_UNUSED,
   /* If they simply clicked the first point (without
      drawing to move it), and there are enough points, consider
      it a final placement of a new point! */
-  if (polyfill_editing == 0 && polyfill_dragged == 0 && polyfill_num_pts > 2 && polyfill_num_pts < MAX_PTS)
+  if (polyfill_editing == 0 && polyfill_dragged == 0 && polyfill_num_pts > 2 && polyfill_num_pts <= MAX_PTS)
   {
 #ifdef DEBUG
     printf("Clicked first point to end polygon!\n");



> 
> > Then there is the interaction with the Undo tool: draw say 5 points and go 
> > to another tool without closing the polygon, the helper lines and points 
> > disappear (by design?), hit Undo and they reappear, 
> > I'd suggest to either keep them in the drawing or erase them from the undo stack.
> 
> Okay, I've made an attempt to prevent the previews from landing in the
> undo history.  This is via a new Magic API function that magic tools may
> call: api->retract_undo().  It basically just rolls back `cur_undo` and
> `newest_undo` by one, so whatever was just snapped (during a mousedown
> event, just prior to the Magic tool's `_click()` from being called)
> gets "forgotten".
> 
> So for example, I can click a bunch of times to make a new polygon,
> and when I hit Undo, it goes back to the canvas as it appeared before
> I added the very first point.  And when I hit Redo, the entire polygon
> reappears in its final (non-preview) form.
> 
> HOPEFULLY this works well.  It's almost 2am, and I was tired many hours
> _before_ I tried tackling this. :-D
> 
> Before I go to bed I'm going to add info about this to the API docs.
> Hopefully in the next few days I can see about utilizing this with
> other Magic tools that offer "previews" that live beyond the
> (1) click, (2) drag, (3) release lifespan (e.g., Clone, and the
> Perspective drawing tools)... so they will stop "corrupting" the
> Undo history with their outline and crosshair nonsense. ;-)
> 
> This is quite a hack, I admit, so wish me luck!
> 
> And PLEASE TEST!  Bang on it as much as you can, and report back!

Works fine as far as I've tested :), the only improvement I could imagine 
is to use the first Undo just to clear the auxiliary stuff, 
withouth undoing previous work, other Undo acting as of now.

Best
Pere

2am, why this doesn't surprises me? XDD

> 
> Thanks,
> 
> PS - I also updated the description to mention that points may be
> merged.  (Sorry to translators for asking for updated localizations,
> and then immediately going in and messing with strings :-[ )
> 
> PPS - The commit (so far) that adds this new functionality is:
> https://sourceforge.net/p/tuxpaint/tuxpaint/ci/01afb5846c2b9d7c58961d38b27cd597d367d766/
> ("api->retract_undo() added to Magic API; used by Filled Polygon")
> 
> -bill!
> 
> 
> 
> _______________________________________________
> Tuxpaint-devel mailing list
> Tux...@li...
> https://lists.sourceforge.net/lists/listinfo/tuxpaint-devel

Re: [Tuxpaint-devel] Polygon fill messing with other tools drawing

[Bill K. <nb...@so...>]

On Wed, May 29, 2024 at 10:06:07AM +0200, Pere Pujal i Carabantes wrote:
> Hi Bill, and all,
> 
> A problem, start drawing a polygon and do as many points as possible (17?) 
> then you are blocked, you can either switch out of the tool or drag the 
> latest point to the origin closing the polygon, which is not very intuitive.
> Assuming the only thing you can do in the tool is to close the polygon, 
> I suggest to do this automatically.

I think we can raise the number of points.  In the meantime, I updated it
so that clicking again will simply move the end point (rather than silently
and confusingly doing _nothing_).


> Then there is the interaction with the Undo tool: draw say 5 points and go 
> to another tool without closing the polygon, the helper lines and points 
> disappear (by design?), hit Undo and they reappear, 
> I'd suggest to either keep them in the drawing or erase them from the undo stack.

Okay, I've made an attempt to prevent the previews from landing in the
undo history.  This is via a new Magic API function that magic tools may
call: api->retract_undo().  It basically just rolls back `cur_undo` and
`newest_undo` by one, so whatever was just snapped (during a mousedown
event, just prior to the Magic tool's `_click()` from being called)
gets "forgotten".

So for example, I can click a bunch of times to make a new polygon,
and when I hit Undo, it goes back to the canvas as it appeared before
I added the very first point.  And when I hit Redo, the entire polygon
reappears in its final (non-preview) form.

HOPEFULLY this works well.  It's almost 2am, and I was tired many hours
_before_ I tried tackling this. :-D

Before I go to bed I'm going to add info about this to the API docs.
Hopefully in the next few days I can see about utilizing this with
other Magic tools that offer "previews" that live beyond the
(1) click, (2) drag, (3) release lifespan (e.g., Clone, and the
Perspective drawing tools)... so they will stop "corrupting" the
Undo history with their outline and crosshair nonsense. ;-)

This is quite a hack, I admit, so wish me luck!

And PLEASE TEST!  Bang on it as much as you can, and report back!

Thanks,

PS - I also updated the description to mention that points may be
merged.  (Sorry to translators for asking for updated localizations,
and then immediately going in and messing with strings :-[ )

PPS - The commit (so far) that adds this new functionality is:
https://sourceforge.net/p/tuxpaint/tuxpaint/ci/01afb5846c2b9d7c58961d38b27cd597d367d766/
("api->retract_undo() added to Magic API; used by Filled Polygon")

-bill!

Re: [Tuxpaint-devel] Polygon fill messing with other tools drawing

[Pere P. i C. <per...@gm...>]

El dc. 29 de 05 de 2024 a les 10:06 +0200, en/na Pere Pujal i Carabantes va escriure:
> Hi Bill, and all,
> 
> A problem, start drawing a polygon and do as many points as possible (17?) 
> then you are blocked, you can either switch out of the tool or drag the 
> latest point to the origin closing the polygon, which is not very intuitive.
> Assuming the only thing you can do in the tool is to close the polygon, 
> I suggest to do this automatically.

I spoke too fast :( 
There is also the possibility of removing one or more points
that will let you be able to add some new ones.

Removing points is not mentioned in the UI tool description.


Pere


> 
> Then there is the interaction with the Undo tool: draw say 5 points and go 
> to another tool without closing the polygon, the helper lines and points 
> disappear (by design?), hit Undo and they reappear, 
> I'd suggest to either keep them in the drawing or erase them from the undo stack.
> 
> HTH
> Pere
> 
> El dc. 29 de 05 de 2024 a les 00:05 -0700, en/na Bill Kendrick va escriure:
> > On Sun, Apr 07, 2024 at 03:11:09PM +0200, Pere Pujal i Carabantes wrote:
> > > Hi all,
> > > 
> > > Tested the new polyfill stuff, it is nice :)
> > 
> > Hi Pere (and everyone),
> > 
> > I'd appreciate if you could test the Filled Polygon tool some more.
> > Also, please enjoy (and report any issues with!) some sound effects
> > that I just added.
> > 
> > There are different sounds for
> > 
> >  * adding a new point
> >  * dragging the new point / moving an existing one
> >  * dragging either end point next to the other, when 3+ points exist
> >    (you are "at risk" of completing the polygon ;) )
> >  * dragging one point into another, thus merging them
> >    (removing a point)
> >  * completing the polygon
> > 
> > 
> > I'm hoping to release a new version of Tux Paint soon,
> > ahead of a busy summer.  I'll post to -i18n and -maintainers
> > about this fact. :)
> > 
> > -bill!
> > 
> > 
> > _______________________________________________
> > Tuxpaint-devel mailing list
> > Tux...@li...
> > https://lists.sourceforge.net/lists/listinfo/tuxpaint-devel
> 

Re: [Tuxpaint-devel] Polygon fill messing with other tools drawing

[Pere P. i C. <per...@gm...>]

Hi Bill, and all,

A problem, start drawing a polygon and do as many points as possible (17?) 
then you are blocked, you can either switch out of the tool or drag the 
latest point to the origin closing the polygon, which is not very intuitive.
Assuming the only thing you can do in the tool is to close the polygon, 
I suggest to do this automatically.

Then there is the interaction with the Undo tool: draw say 5 points and go 
to another tool without closing the polygon, the helper lines and points 
disappear (by design?), hit Undo and they reappear, 
I'd suggest to either keep them in the drawing or erase them from the undo stack.

HTH
Pere

El dc. 29 de 05 de 2024 a les 00:05 -0700, en/na Bill Kendrick va escriure:
> On Sun, Apr 07, 2024 at 03:11:09PM +0200, Pere Pujal i Carabantes wrote:
> > Hi all,
> > 
> > Tested the new polyfill stuff, it is nice :)
> 
> Hi Pere (and everyone),
> 
> I'd appreciate if you could test the Filled Polygon tool some more.
> Also, please enjoy (and report any issues with!) some sound effects
> that I just added.
> 
> There are different sounds for
> 
>  * adding a new point
>  * dragging the new point / moving an existing one
>  * dragging either end point next to the other, when 3+ points exist
>    (you are "at risk" of completing the polygon ;) )
>  * dragging one point into another, thus merging them
>    (removing a point)
>  * completing the polygon
> 
> 
> I'm hoping to release a new version of Tux Paint soon,
> ahead of a busy summer.  I'll post to -i18n and -maintainers
> about this fact. :)
> 
> -bill!
> 
> 
> _______________________________________________
> Tuxpaint-devel mailing list
> Tux...@li...
> https://lists.sourceforge.net/lists/listinfo/tuxpaint-devel

Re: [Tuxpaint-devel] Polygon fill messing with other tools drawing

[Bill K. <nb...@so...>]

On Sun, Apr 07, 2024 at 03:11:09PM +0200, Pere Pujal i Carabantes wrote:
> Hi all,
> 
> Tested the new polyfill stuff, it is nice :)

Hi Pere (and everyone),

I'd appreciate if you could test the Filled Polygon tool some more.
Also, please enjoy (and report any issues with!) some sound effects
that I just added.

There are different sounds for

 * adding a new point
 * dragging the new point / moving an existing one
 * dragging either end point next to the other, when 3+ points exist
   (you are "at risk" of completing the polygon ;) )
 * dragging one point into another, thus merging them
   (removing a point)
 * completing the polygon


I'm hoping to release a new version of Tux Paint soon,
ahead of a busy summer.  I'll post to -i18n and -maintainers
about this fact. :)

-bill!

[Tuxpaint-devel] pencil, arrow and rotating_dash don't draw at single click, they need drag

[Pere P. i C. <per...@gm...>]

Hi all,

Was updating the Catalan translation and in the tests I've found 
that some brushes need drag to draw, the ones that have "rotate"
in their .dat file

HTH
Pere

Re: [Tuxpaint-devel] Polygon fill messing with other tools drawing

[Pere P. i C. <per...@gm...>]

El dl. 08 de 04 de 2024 a les 21:06 -0700, en/na Bill Kendrick va escriure:
> On Sun, Apr 07, 2024 at 03:11:09PM +0200, Pere Pujal i Carabantes wrote:
> > Hi all,
> > 
> > Tested the new polyfill stuff, it is nice :)
> > 
> > Just found a minor problem:
> 
> "Minor" X-D

Well, polyfill is WIP, I don't consider bugs critical if we are not near a release :)

> 
> 
> > Start Tux Paint, select the Polygon Fill tool.
> > select another tool and draw something.
> > Return to the Polygon Fill tool, see how everything you had drawn is lost.
> > 
> > The problem is polyfill_snapshot being kept and later blit into the canvas via
> > set_color() -> draw_preview() before switchin()
> > 
> > We could clean up polyfill_snapshot at switchout() and recreate it at each swcithin() or
> > we could set some marker, mark it at switchout, clean it up at switchin() and only blit polyfill_snapshot
> > if the marker allows it, that would allow to reuse polyfill_snapshot and not destroy/recreate it
> > at each switchout()/switchin() cycle.
> 
> For now, I've set a variable to tell whether switchin() has been
> called yet.  To me, it seems strange that I'm calling a Magic tool's
> set_color() BEFORE its switchin() has been called.  But rather than
> change that (and potentially break lots of other tools), I've opened a
> ticket. :-)
> 
>   https://sourceforge.net/p/tuxpaint/bugs/286/
> 
> I also addressed an issue I already knew about, where the in-progress
> polygon preview (the lines and big red & green boxes) would remain on
> the canvas when switching to a different tool.


Oh, I thouth it was on purpose, to let children with something painted 
on the screen, in fact the Undo tool still recovers them.


> 
> I believe I solved that by simply blitting the tool's own snapshot
> back to the canvas on switchout().  (And since it makes a fresh
> snapshot after every polygon has been completed, this works.)
> 
> Adjustments like this may help some of the other Magic tools that
> "act weird" when you're in the middle of using them, but then
> switch away.
> 
> I've also thought it might be nice to provide a way for Magic
> tools to say "I can handle the 'Undo' command myself", e.g.
> for Filled Polygon tool, it would remove the most-recently
> added point.  Then, if there's no more work for them to do,
> they can tell Tux Paint that it should do it's normal Undo
> process.
> 
> Prior to that, I also thought it might be interesting to provide a
> way for Magic tools to provide an 'overlay' SDL_Surface which
> Tux Paint would draw on top everything else, rather than having
> to abuse the main `canvas` surface to draw previews, crosshairs,
> grids, etc.
> 
> Things are getting tricky. :)
> 
> -bill!


Currently magic tools that need multiple clicks to do their work 
are tricky, especially when faced to the Undo tool.

Pere


> 

Re: [Tuxpaint-devel] Polygon fill messing with other tools drawing

[Bill K. <nb...@so...>]

On Sun, Apr 07, 2024 at 03:11:09PM +0200, Pere Pujal i Carabantes wrote:
> Hi all,
> 
> Tested the new polyfill stuff, it is nice :)
> 
> Just found a minor problem:

"Minor" X-D


> Start Tux Paint, select the Polygon Fill tool.
> select another tool and draw something.
> Return to the Polygon Fill tool, see how everything you had drawn is lost.
> 
> The problem is polyfill_snapshot being kept and later blit into the canvas via
> set_color() -> draw_preview() before switchin()
> 
> We could clean up polyfill_snapshot at switchout() and recreate it at each swcithin() or
> we could set some marker, mark it at switchout, clean it up at switchin() and only blit polyfill_snapshot
> if the marker allows it, that would allow to reuse polyfill_snapshot and not destroy/recreate it
> at each switchout()/switchin() cycle.

For now, I've set a variable to tell whether switchin() has been
called yet.  To me, it seems strange that I'm calling a Magic tool's
set_color() BEFORE its switchin() has been called.  But rather than
change that (and potentially break lots of other tools), I've opened a
ticket. :-)

  https://sourceforge.net/p/tuxpaint/bugs/286/

I also addressed an issue I already knew about, where the in-progress
polygon preview (the lines and big red & green boxes) would remain on
the canvas when switching to a different tool.

I believe I solved that by simply blitting the tool's own snapshot
back to the canvas on switchout().  (And since it makes a fresh
snapshot after every polygon has been completed, this works.)

Adjustments like this may help some of the other Magic tools that
"act weird" when you're in the middle of using them, but then
switch away.

I've also thought it might be nice to provide a way for Magic
tools to say "I can handle the 'Undo' command myself", e.g.
for Filled Polygon tool, it would remove the most-recently
added point.  Then, if there's no more work for them to do,
they can tell Tux Paint that it should do it's normal Undo
process.

Prior to that, I also thought it might be interesting to provide a
way for Magic tools to provide an 'overlay' SDL_Surface which
Tux Paint would draw on top everything else, rather than having
to abuse the main `canvas` surface to draw previews, crosshairs,
grids, etc.

Things are getting tricky. :)

-bill!

[Tuxpaint-devel] Polygon fill messing with other tools drawing

[Pere P. i C. <per...@gm...>]

Hi all,

Tested the new polyfill stuff, it is nice :)

Just found a minor problem:
Start Tux Paint, select the Polygon Fill tool.
select another tool and draw something.
Return to the Polygon Fill tool, see how everything you had drawn is lost.

The problem is polyfill_snapshot being kept and later blit into the canvas via
set_color() -> draw_preview() before switchin()

We could clean up polyfill_snapshot at switchout() and recreate it at each swcithin() or
we could set some marker, mark it at switchout, clean it up at switchin() and only blit polyfill_snapshot
if the marker allows it, that would allow to reuse polyfill_snapshot and not destroy/recreate it
at each switchout()/switchin() cycle.

HTH
Pere

Re: [Tuxpaint-devel] 2-points selection freezes when joining the 2 points

[Bill K. <nb...@so...>]

On Sun, Jan 21, 2024 at 12:52:45AM +0100, Pere Pujal i Carabantes wrote:
<snip>
> I've played a little with it and really enjoyed it :)
> The right point escaping the left one is amazing :)
> Is this the first easter egg in Tux Paint?

Hahah.  No, it's just a suboptimal and lazy solution to
the problem.  But I suppose it is kind of fun.  Just waiting
for a user to report it as a bug, 5 or 10 years from now. ;)

-bill!

Re: [Tuxpaint-devel] 2-points selection freezes when joining the 2 points

[Pere P. i C. <per...@gm...>]

El ds. 20 de 01 de 2024 a les 15:07 -0800, en/na Bill Kendrick va escriure:
> On Sat, Jan 20, 2024 at 09:29:35PM +0100, Pere Pujal i Carabantes wrote:
> > Just found this: magic 2-point selection, if you let one of the points in place 
> > and drag the other next/over to it, Tux Paint freezes.
> 
> Mended, thanks!  I glanced over the rest of the code for
> slope calculations to see if any other spot might crash
> due to a divide-by-zero, and didn't see any.
> (Usually there's a safety check, or it's impossible for
> the points to be in the same X position; this was done
> for 2-Pt Persp's vanishing points, but only on _release_,
> not drag!)

I've played a little with it and really enjoyed it :)
The right point escaping the left one is amazing :)
Is this the first easter egg in Tux Paint?

Best
Pere

Re: [Tuxpaint-devel] magic di/tri metric some strings may be changed from click to click and drag?

[Bill K. <nb...@so...>]

Ooops, forgot to call _drag() from _click() for these tools.
I think that got it.

-bill!

On Sat, Jan 20, 2024 at 11:18:24PM +0100, Pere Pujal i Carabantes wrote:
> Hi all,
> 
> Dimetric selection:
> Click in your drawing to adjust the angle used by the dimetric projection
> Just clicking works sometimes, click and drag works always.
> 
> Same for Oblique selection.
> 
> Trimetric selection:
> Click in your drawing to adjust the angles used by the trimetric projection painting tool.
> Only click works very few times, click-pointing the lines and drag them works always.
> 
> HTH
> Pere
> 
> 
> _______________________________________________
> Tuxpaint-devel mailing list
> Tux...@li...
> https://lists.sourceforge.net/lists/listinfo/tuxpaint-devel

-- 
-bill!
Sent from my computer

Re: [Tuxpaint-devel] 2-points selection freezes when joining the 2 points

[Bill K. <nb...@so...>]

On Sat, Jan 20, 2024 at 09:29:35PM +0100, Pere Pujal i Carabantes wrote:
> Just found this: magic 2-point selection, if you let one of the points in place 
> and drag the other next/over to it, Tux Paint freezes.

Mended, thanks!  I glanced over the rest of the code for
slope calculations to see if any other spot might crash
due to a divide-by-zero, and didn't see any.
(Usually there's a safety check, or it's impossible for
the points to be in the same X position; this was done
for 2-Pt Persp's vanishing points, but only on _release_,
not drag!)


> I've not been able to reproduce with 3-points selection.

Thanks!

-bill!

[Tuxpaint-devel] magic di/tri metric some strings may be changed from click to click and drag?

[Pere P. i C. <per...@gm...>]

Hi all,

Dimetric selection:
Click in your drawing to adjust the angle used by the dimetric projection
Just clicking works sometimes, click and drag works always.

Same for Oblique selection.

Trimetric selection:
Click in your drawing to adjust the angles used by the trimetric projection painting tool.
Only click works very few times, click-pointing the lines and drag them works always.

HTH
Pere

[Tuxpaint-devel] 2-points selection freezes when joining the 2 points

[Pere P. i C. <per...@gm...>]

Just found this: magic 2-point selection, if you let one of the points in place 
and drag the other next/over to it, Tux Paint freezes.

I've not been able to reproduce with 3-points selection.

HTH
Pere

[Tuxpaint-devel] Magic tools now report an "order" integer

[Bill K. <nb...@so...>]

Magic tools are now queried for an 'order' value (an integer),
which is used as the sorting method for organizing the various
tools within each group.

I've just assigned some values to every single Magic tool
in every plugin (.c) file.  Whew!

This allows us to place related Magic tools next to each
other, rather than having them organized somewhat arbitrarily
by their name (which of course differs for each language!)

I've been thinking about doing this, especially after adding
numerous related tools which make sense to list in a certain
order (Isometric, Dimetric, Trimetric, Oblique), rather
than alphabetically (in English, they appeared in the order:
Dimetric, Isometric, Oblique, Trimetric).  Thanks to Shin-ichi
for mentioning this, which was the nudge I needed to actually
get it done. ;)

Note that the numbers are relative to other tools within the
same group, and remember that a particular plugin source file
may place tools in different groups than each other.
(For exmaple, "swirls.c" has both the "Circles" and "Rays"
distortion effects, and the "Fur" painting tool.)

I thought about creating a 'global' header file for
the entire set of Magic tools that ship with Tux Paint,
but since it was already an overwhelming task to modify
62 source files, AND think about how to organize the
approx. ten dozen tools, I figured this was good enough
for now.  Time for bed. :-)

Please try it out and let me know if you notice any
issues, or have suggestions on how to improve the
ordering of things.

(This WILL have a "who moved my cheese!?" effect on users,
but frankly so does adding new Magic tools, which get
inserted in the groups... and so did adding groups to
begin with!)

-- 
-bill!
Sent from my computer

Re: [Tuxpaint-devel] New perspective drawing tools & complexity setting

[Shin-ichi T. <dol...@wm...>]

On Tue, 2 Jan 2024 22:44:52 -0800, Bill Kendrick wrote:
>I _believe_ I've corrected it. Please `git pull` and rebuild, and
>tell me if you can still replicate it :)

Confirmed it is fixed.

>> In addition, I observed crash on windows when switching magic tool categories.
>> Unfortunately I have not found the step to reproduce it so far.
>
>Hrm, I cannot replicate in Linux.  I tried all three of the new
>complexity levels.
>
>Oh, question -- did you rebuild all of the Magic tools from scratch?
>(Hrm, I suppose you must have, for them to load at all, since they
>need to match the Magic API version.)  Hmm... please tell me what
>you discover.

At first, Tuxpaint crashed every time when "ARTISTIC" group was selected.
After that I once removed tuxpaint.cfg (I should have keep it's copy....) seeing
above strange value for complexity. Then, I've lost the way to reproduce the crash.

Sorry for the vague information.

-- 
Shin-ichi TOYAMA <dol...@wm...>

Re: [Tuxpaint-devel] New perspective drawing tools & complexity setting

[Bill K. <nb...@so...>]

On Tue, Jan 02, 2024 at 12:59:28PM +0900, Shin-ichi TOYAMA wrote:
> Hi!
> 
> I noticed that complexity is incorrectly set to "qwerty.layout" in personal config file.
> 
> This happens with following steps.
> 
>  1) start tuxpaint-config
>  2) set complexity to "(no override).
>  3) apply and quit.
>  4) start tuxpaint-config
>  5) change any setting other than complexity.
>  6) apply and quit

Hrm I was able to replicate it by leaving the setting
blank (which should NOT have been an option -- I forgot to
add the new widget to the appropriate routine in `defaults.cxx`),
then change something else so I could click "Apply" to save.

I _believe_ I've corrected it. Please `git pull` and rebuild, and
tell me if you can still replicate it :)


> In addition, I observed crash on windows when switching magic tool categories.
> Unfortunately I have not found the step to reproduce it so far.

Hrm, I cannot replicate in Linux.  I tried all three of the new
complexity levels.

Oh, question -- did you rebuild all of the Magic tools from scratch?
(Hrm, I suppose you must have, for them to load at all, since they
need to match the Magic API version.)  Hmm... please tell me what
you discover.

Luc, Mark, and Pere, when you have time can you also test the new
features on Haiku, macOS, and Android?

Thanks in advance!

-bill!