springframework-developer — Spring Framework developers list

Re: [Springframework-developer] Re: Formatting in the face of tab usage

[Dmitriy K. <dko...@ru...>]

space-based indentation setup of 4 characters would work for me. +1

Dmitriy.

tho...@tr... wrote:

>Quoting Colin Sampaleanu <col...@ex...>:
>
>  
>
>>I would personally be very happy to switch to using a
>>space-based (2 or 4 chars per indent level) indentation setup instead,
>>to avoid the problems with hard tab usage.
>>
>>    
>>
>
>+1
>
>Thomas
>
>
>
>-------------------------------------------------------
>This SF.Net email is sponsored by BEA Weblogic Workshop
>FREE Java Enterprise J2EE developer tools!
>Get your free copy of BEA WebLogic Workshop 8.1 today.
>http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click
>_______________________________________________
>Springframework-developer mailing list
>Spr...@li...
>https://lists.sourceforge.net/lists/listinfo/springframework-developer
>  
>

Re: [Springframework-developer] Re: Formatting in the face of tab usage

[<tho...@tr...>]

Quoting Colin Sampaleanu <col...@ex...>:

> I would personally be very happy to switch to using a
> space-based (2 or 4 chars per indent level) indentation setup instead,
> to avoid the problems with hard tab usage.
>

+1

Thomas

RE: [Springframework-developer] Re: Formatting in the face of tab usage

[Rob H. <ro...@ca...>]

Would a solution to the issue of formatting be to modify the Ant script to
check the code out of CVS, run it through Jalopy and then check it back in?
This could be done every so often to keep code formatted in a standard way.

Rob

-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf Of
Colin Sampaleanu
Sent: 27 July 2004 17:18
To: spr...@li...
Subject: [Springframework-developer] Re: Formatting in the face of tab usage

Also, last fall when we discussed tab usage, we all agreed that there 
were issues sometimes with hard tab usage, but basically decided to 
leave things as-is for the time being, with it probably being revisited 
in the future. I would personally be very happy to switch to using a 
space-based (2 or 4 chars per indent level) indentation setup instead, 
to avoid the problems with hard tab usage. With hard tab usage, if 
people don't have discipline and start adding in spaces, it quickly 
breaks down.

Colin


Colin Sampaleanu wrote:

> I was looking at DefaultXmlBeanDefinitionParser, and it's clear that 
> whoever formatted it (Juergen I guess) is using an editor with hard 
> tabs set to 2 characters (not the more common 4 or 8). I say this 
> because for some method calls, the continuation line lines up method 
> args, but only if tabs are set to 2. If they are 4 or 8, the 
> continuation line is _way_ over to the right.
>
> While I'm not a big fan of hard tabs, as per our discussion last fall, 
> I can live with them. But what this means is that any continuation 
> lines need to be simply one or more tabs farther in than the line 
> before it. If you format lines so that you use hard tabs to line up 
> with some non-tab text in a line above, this will completely mess up 
> for other people using different tab settings. Ditto with adding some 
> real spaces (with or without tabs) at the beginning of the line. 
> Essentially _all_ indentation has to be based only on tabs.
>
> Colin
>
>
>
>




-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

Re: [Springframework-developer] Formatting in the face of tab usage

[<jue...@we...>]

I see, you refer to the parameter aligning in new lines, which I do have =
set in my IDEA code style. That's indeed messing up things for other tab =
sizes, when usign hard tabs.

So we should probably not use parameter aligning as long as we stay with =
hard tabs then... But it just looks nicer, IMO - if the tab size matches =
;-)

Juergen


-----Original Message-----
From: spr...@li...
[mailto:spr...@li...]On Behalf
Of Colin Sampaleanu
Sent: Tuesday, July 27, 2004 6:15 PM
To: spr...@li...
Subject: [Springframework-developer] Formatting in the face of tab usage


I was looking at DefaultXmlBeanDefinitionParser, and it's clear that=20
whoever formatted it (Juergen I guess) is using an editor with hard tabs =

set to 2 characters (not the more common 4 or 8). I say this because for =

some method calls, the continuation line lines up method args, but only=20
if tabs are set to 2. If they are 4 or 8, the continuation line is _way_ =

over to the right.

While I'm not a big fan of hard tabs, as per our discussion last fall, I =

can live with them. But what this means is that any continuation lines=20
need to be simply one or more tabs farther in than the line before it.=20
If you format lines so that you use hard tabs to line up with some=20
non-tab text in a line above, this will completely mess up for other=20
people using different tab settings. Ditto with adding some real spaces=20
(with or without tabs) at the beginning of the line. Essentially _all_=20
indentation has to be based only on tabs.

Colin






-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=3D4721&alloc_id=3D10040&op=3Dclick
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

[Springframework-developer] Re: Formatting in the face of tab usage

[Colin S. <col...@ex...>]

Also, last fall when we discussed tab usage, we all agreed that there 
were issues sometimes with hard tab usage, but basically decided to 
leave things as-is for the time being, with it probably being revisited 
in the future. I would personally be very happy to switch to using a 
space-based (2 or 4 chars per indent level) indentation setup instead, 
to avoid the problems with hard tab usage. With hard tab usage, if 
people don't have discipline and start adding in spaces, it quickly 
breaks down.

Colin


Colin Sampaleanu wrote:

> I was looking at DefaultXmlBeanDefinitionParser, and it's clear that 
> whoever formatted it (Juergen I guess) is using an editor with hard 
> tabs set to 2 characters (not the more common 4 or 8). I say this 
> because for some method calls, the continuation line lines up method 
> args, but only if tabs are set to 2. If they are 4 or 8, the 
> continuation line is _way_ over to the right.
>
> While I'm not a big fan of hard tabs, as per our discussion last fall, 
> I can live with them. But what this means is that any continuation 
> lines need to be simply one or more tabs farther in than the line 
> before it. If you format lines so that you use hard tabs to line up 
> with some non-tab text in a line above, this will completely mess up 
> for other people using different tab settings. Ditto with adding some 
> real spaces (with or without tabs) at the beginning of the line. 
> Essentially _all_ indentation has to be based only on tabs.
>
> Colin
>
>
>
>

[Springframework-developer] Formatting in the face of tab usage

[Colin S. <col...@ex...>]

I was looking at DefaultXmlBeanDefinitionParser, and it's clear that 
whoever formatted it (Juergen I guess) is using an editor with hard tabs 
set to 2 characters (not the more common 4 or 8). I say this because for 
some method calls, the continuation line lines up method args, but only 
if tabs are set to 2. If they are 4 or 8, the continuation line is _way_ 
over to the right.

While I'm not a big fan of hard tabs, as per our discussion last fall, I 
can live with them. But what this means is that any continuation lines 
need to be simply one or more tabs farther in than the line before it. 
If you format lines so that you use hard tabs to line up with some 
non-tab text in a line above, this will completely mess up for other 
people using different tab settings. Ditto with adding some real spaces 
(with or without tabs) at the beginning of the line. Essentially _all_ 
indentation has to be based only on tabs.

Colin

[Springframework-developer] Crypto Support

[Rob H. <ro...@ca...>]

Are there any plans to add support for cryptography to Spring?

I was thinking that we could have FactoryBeans to create instances of
MessageDigest, Cipher, SecureRandom etc and then something like
MessageDigestTemplate, CipherTemplate that could use the beans define to
perform crypto services.

Rob

Re: [Springframework-developer] Final preparations for 1.1 RC1

[<jue...@we...>]

OK, thanks! :-)
=20
Juergen
=20

________________________________

Von: spr...@li... im Auftrag =
von Darren Davison
Gesendet: Di 27.07.2004 13:01
An: spr...@li...
Betreff: Re: [Springframework-developer] Final preparations for 1.1 RC1




> Darren, any thoughts on the current macros, particularly regarding the
> "springBind" and "springBindEscaped" naming? See the discussion in the
> mails below.
>
> It's already somewhat urgent, as I'd like to release 1.1 RC1 tonight =
:-)

Sorry, I thought it had been decided already :)

I reckon we should go with what's in CVS now.  Given Velocity's =
difficulty
with overloading, the need to be consistent as far as possible with
FreeMarker and the need for both to respect the context parameter for
default escaping, I can't think of any better way to organise or name
them.

The ref docs were modified and committed last night, so they're alredy
consistent with what's currently in the macro files.

Regards,

--
Darren Davison
Public Key: http://www.davison.uk.net/pages/key.htm




-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

Re: [Springframework-developer] Final preparations for 1.1 RC1

[Darren D. <da...@da...>]

> Darren, any thoughts on the current macros, particularly regarding the
> "springBind" and "springBindEscaped" naming? See the discussion in the
> mails below.
>
> It's already somewhat urgent, as I'd like to release 1.1 RC1 tonight :-=
)

Sorry, I thought it had been decided already :)

I reckon we should go with what's in CVS now.  Given Velocity's difficult=
y
with overloading, the need to be consistent as far as possible with
FreeMarker and the need for both to respect the context parameter for
default escaping, I can't think of any better way to organise or name
them.

The ref docs were modified and committed last night, so they're alredy
consistent with what's currently in the macro files.

Regards,

--=20
Darren Davison
Public Key: http://www.davison.uk.net/pages/key.htm

Re: [Springframework-developer] Final preparations for 1.1 RC1

[<jue...@we...>]

Darren, any thoughts on the current macros, particularly regarding the =
"springBind" and "springBindEscaped" naming? See the discussion in the =
mails below.
=20
It's already somewhat urgent, as I'd like to release 1.1 RC1 tonight :-)
=20
Juergen
=20

________________________________

Von: spr...@li... im Auftrag =
von j=FCrgen h=F6ller [werk3AT]
Gesendet: Sa 24.07.2004 21:28
An: spr...@li...
Betreff: Re: [Springframework-developer] Final preparations for 1.1 RC1



As far I see, there is no such overloading of macros in Velocity: If we =
have different parameters, we need to define a separate macro.

Even in FreeMarker, there's just the option to define a fixed default =
for optional parameters: no support for simply "not specified" (falling =
back to the default HTML escape setting in our case). That's why I =
suggest to use a different macro name there too, analogous to Velocity.

So the remaining issue are the names: "springBind" (default HTML escape =
setting) and "springBindEscaped" (explicitly specified HTML escape =
setting)?

Juergen


________________________________

Von: spr...@li... im Auftrag =
von Matt Raible
Gesendet: Sa 24.07.2004 20:44
An: spr...@li...
Betreff: Re: [Springframework-developer] Final preparations for 1.1 RC1



It would be nice if the method name didn't have to change and we could
just control the rendering of the variable.  Probably not possible, but
something similar to JSP 2.0 where you use ${status.errorMessage} to
print out escaped XML and <c:out value=3D"${status.errorMessage}"
escapeXml=3D"false"/> if you want to print HTML.

I don't see a problem with having two separate methods: springBind and
springBindEscaped - just as long as its documented.  Though it might be
nicer to have #springBind(path) and #springBind(path false) - where you
have to use two parameters to escape XML.

Matt

On Jul 24, 2004, at 10:19 AM, j=FCrgen h=F6ller [werk3AT] wrote:

> Actually, the same issue occurs with FreeMarker too: We specify
> "escape=3Dfalse" there, so do not participate in any default. This =
needs
> to be addressed: We should allow to work with the defaultHtmlEscape
> value here too.
>
> While we could introduce a further "escape" value for "use default",
> offering a special method signature for it, it's probably clearer two
> offer two FreeMarker macros: "spring:bind" which never takes an
> "escape" parameter (i.e. always uses the default), and
> "spring:bindEscaped" which takes a required "escape" parameter. This
> would be analogous to Velocity again then.
>
> However, there's still the naming issue: "bind" uses the default HTML
> escape setting. But how to the name the version that takes an explicit
> HTML escape parameter? Is there a better name than "bindEscaped"?
>
> This is easier with JSP tags, where there can be a true tag-internal
> default if the "setHtmlEscape" method was not called... As far as I
> can see, even FreeMarker just allows for an explicitly specified
> default in the macro definition: It cannot seamlessly invoke either
> RequestContext.createBindStatus(path) respectively
> RequestContext.createBindStatus(path, htmlEscape), in our concrete
> case.
>
> Juergen
>
>
> ________________________________
>
> Von: spr...@li... im Auftrag
> von j=FCrgen h=F6ller [werk3AT]
> Gesendet: Sa 24.07.2004 15:12
> An: spr...@li...
> Betreff: Re: [Springframework-developer] Final preparations for 1.1 =
RC1
>
>
>
> Darren,
>
> Oops, I forgot to discuss that one: The reason why I removed the
> htmlEscape property from the "springBind" macro is to be able to
> participate in a RequestContext-level default, e.g. set via
> springMacroRequestContext.setDefaultHtmlEscape(true). Note that the
> createBindStatus invocation on RequestContext uses the
> defaultHtmlEscape flag then.
>
> I've just adapted the RequestContext implementation a bit further to
> also be able to participate in a ServletContext-level default, just
> like our JSP tags can, i.e. a "defaultHtmlEscape" context-param in
> web.xml. JSP tags and Velocity/FreeMarker macros can then even share
> such an application-wide default. I'll commit this promptly.
>
> Actually, the "springBindEscaped" macro should rather take an explicit
> htmlEscape parameter, to be able to override defaultHtmlEscape=3Dtrue =
to
> false for a specific macro. Hmm, what name could we use for this?
> "springBindWithExplicitEscape" is clearly too long... "springBind"
> with overloaded signature is not possible in Velocity... maybe still
> "springBindEscaped", but just with an explicit parameter?
>
>
> Matt,
>
> Note that the "springMacroRequestContext" is not really meant to be
> accessed directly; it is mainly meant to be used by Spring-provided
> macros. If you want to use a RequestContext in your own expressions,
> always specify the "requestContextAttribute" accordingly. We should
> highlight that in the docs.
>
>
> Juergen
>
>
> ________________________________
>
> Von: spr...@li... im Auftrag
> von Darren Davison
> Gesendet: Sa 24.07.2004 10:18
> An: spr...@li...
> Betreff: Re: [Springframework-developer] Final preparations for 1.1 =
RC1
>
>
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Saturday 24 July 2004 01:09, Matt Raible wrote:
>> I tried this out today and it works well.  The only thing I saw that
>> might cause confusion for users is there are 2 macros for Velocity
>> (#springBind and #springBindEscaped) - whereas FreeMarker has one w/
>> an
>> "escape" parameter.  I imagine that folks using FreeMarker might be
>> migrating from Velocity, so making the macros consistent might be
>> helpful.  Who knows - just a thought.
>
> FreeMarker has a default value of false for the 2nd param so you only
> need
> supply it to override it.  Velocity can't do that.
>
> The other options for Velocity are:
>
>  * always supply the second parameter in every call to springBind
>
>  * use a globally scoped, well-known variable defined in user
> templates.
>
>
> I prefer personally to always require the additional parameter.  It's
> more
> consistent with FM and won't cause user templates to break if they
> migrate
> them to FM using the automatic conversion tool they have available.
>
> What do you think?
>
>
>> I would make sure and document that the name
>> "springMacroRequestContext"
>> can be overridden by specifying a "requestContextAttribute" property.
>> It's much easier to write $rc.getMessage() than
>> $springMacroRequestContext.getMessage(). ;-)
>
> I will, thanks.
>
> - --
> Darren Davison
> Public Key: http://www.davison.uk.net/pages/key.htm
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.4 (GNU/Linux)
>
> iD8DBQFBAhtIKLMLAN01aw0RAisgAKCfjnl6dzgkdQ91o9lUrUvtd9RGWQCfRJNq
> cn71Z/8ovFjaDLQRxtBwTfo=3D
> =3Dlvg2
> -----END PGP SIGNATURE-----
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=CCk
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer




-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

RE: [Springframework-developer] Final preparations for 1.1 RC1

[Matt R. <li...@ra...>]

> -----Original Message-----
> From: spr...@li...=20
> [mailto:spr...@li...]
>  On Behalf Of Darren Davison
> Sent: Saturday, July 24, 2004 2:11 AM
>=20
> On Saturday 24 July 2004 01:13, Matt Raible wrote:
>=20
> > FYI...
> >
> > This doesn't work:
> >
> > <#import "spring.ftl" as spring />
>=20
> hmm.. it works ok for me.

I just tried a build from last night and I still get the same behavior.
My FreeMarker templates are in WEB-INF/freemarker, my
"templateLoaderPath" (on  FreeMarkerConfigurer) is "/".  Here is the
error I get:

WEB-INF/freemarker/spring.ftl

javax.servlet.ServletException: Error reading imported file
WEB-INF/freemarker/spring.ftl
	at
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServle
t.java:338)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)

Matt

>=20
> > But this does:
> >
> > <#import "/spring.ftl" as spring />
> >
> > Just thought it should be documented.
>=20
> - --=20
> Darren Davison
> Public Key: http://www.davison.uk.net/pages/key.htm
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.4 (GNU/Linux)
>=20
> iD8DBQFBAhmMKLMLAN01aw0RAuNlAKCJkf8+pnwIP4Bt31VwninHric7jgCeIA7v
> w/4rPbU0TC06WZLKkIzVczw=3D
> =3DWfZk
> -----END PGP SIGNATURE-----
>=20
>=20
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.=20
http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=CCk
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

Re: [Springframework-developer] HibernateDaoSupport

[Colin S. <col...@ex...>]

Sure, I think that would work fine.   (It's very much debatable, but I 
think allowCreate=false would probably have been a better default given 
that it would work in about 98% of deployment scenarios and catch errors 
with tx setup, but that's in no way an option to change to now as it 
would break a lot of people's existing deployments.)

Colin

jürgen höller [werk3AT] wrote:

>Colin,
>
>I see your point. We could keep setSessionFactory as final, but let it delegate to a non-final protected createHibernateTemplate(SessionFactory) method that could be overridden in subclasses, even allowing to plug in custom HibernateTemplate subclasses. That's a quite clean and very flexible solution, IMO. I'd be happy to adapt HibernateDaoSupport, JdoDaoSupport and co accordingly.
>
>Let's also not forget that we're talking about a convenience base class here: For special needs, it's trivial to create a custom base class that does not derive from HibernateDaoSupport in the first place. We "just" need to cover 95% of use cases here. I agree that allowCreate=false is quite common, though, so we should cover that; also, setting the flushMode: createHibernateTemplate would cover both.
>
>Juergen
>
>
>-----Original Message-----
>From: spr...@li...
>[mailto:spr...@li...]On Behalf
>Of Colin Sampaleanu
>Sent: Monday, July 26, 2004 3:16 PM
>To: spr...@li...
>Subject: Re: [Springframework-developer] HibernateDaoSupport
>
>
>Juergen,
>
>Personally, I do feel the class has somewhat of a 'smell' as it is now, 
>although part of the reason is that setSessionFactory itself is doing 
>work instead of this stuff being done in the init method (I realize this 
>is to allow the thing to work without the init method ever being 
>called). The issue to me though is the fact that I have seen on a number 
>of occassions people get burned by the default allowCreate flag being 
>true. They mess up their tx settings, and have no tx, but don't realize 
>it because the sessions are still being created. If instead they were 
>using the flag with a false value (at absolutely no pain for most 
>situations when using HibernateTransactionManager or another tx manger 
>eith HibernateInterceptor), they automatically get an error when their 
>DAO is not running in a tx. So I feel it is important to have some 
>relatively easy way to override this, at least so that some team lead or 
>architect can enforce this. I think it's not really necessary to have 
>the default HibernateDaoSupport allow setting this by DAOs which derive 
>directly, it's not a big deal to ask people to subclass it to change the 
>handing of this, and just use that common user variant as their 
>superclass. So taking out the setters and getters is not a big deal. Now 
>with regards to allowing the default flag handling to be overriden by a 
>subclass though, allowing setSessionFactory to be overriden would work 
>fine, although arguably it's not much cleaner than still having the 
>field there (for the default value) which a subclass can override in a 
>constructor. If setSessionFactory were to be made non-final like this 
>then we need to document much more clearly (javadoc) that that method is 
>actually responsible for creating a template if none is set, in the 
>default impl.
>
>Regards,
>Colin
>
>
>jürgen höller [werk3AT] wrote:
>
>  
>
>>Colin,
>>
>>I've just had a look at the new "defaultTemplateAllowCreateValue" flag in HibernateDaoSupport, and I'm frankly not happy with it. We have a special check whether the HibernateTemplate is self-created etc, indicating - for me at least - that something is wrong there. I see your use case, which is worth addressing, but I think the current approach is not ideal.
>>
>>This is not really how our XxxDaoSupport classes are meant to be used. In the case of HibernateDaoSupport: either pass in a SessionFactory *or* a preconfigured HibernateTemplate. If you want a default value for HibernateTemplate's "allowCreate" flag, why not set up a HibernateTemplate bean in your context, configure it with "allowCreate"=false and pass it to all your DAOs? This would work nicely with the old HibernateDaoSupport implementation, without any special checks...
>>
>>My two main concerns are 1. consistency, i.e. that JdoDaoSupport and the others would have to be coded in a similar fashion and 2. future extensions, i.e. what happens if there's a further flag on HibernateTemplate that you want to set via your DAO? Particularly in the latter case, I'm not keen on having that sort of "if-self-created-then" properties on the DAO: They confuse things, and just apply when passing in a SessionFactory (not when passing in a HibernateTemplate), which is not immediately obvious.
>>
>>To allow for programmatic setting of such HibernateTemplate properties, we could turn setSessionFactory non-final, allowing it to override with a version that builds a custom HibernateTemplate for that SessionFactory. That would be much cleaner, IMO, and easy to adapt in JdoDaoSupport and co. Our data access templates and DAO base classes are among the most popular parts of Spring, so it's important to indicate a clear strategy there.
>>
>>All things considered, I quite strongly believe that we should use to the old HibernateDaoSupport implementation again, just turning setSessionFactory non-final to allow for programmatic overriding. For context-driven configuration, let's recommend to pass in a preconfigured HibernateTemplate bean. Can I convince you of this?
>>
>>Unfortunately, I'm already in a bit of a hurry here: I'd like to - finally! - get 1.1 RC1 out tomorrow.
>>
>>Juergen
>>
>>
>>________________________________
>>
>>Von: spr...@li... im Auftrag von Colin Sampaleanu
>>Gesendet: Do 15.07.2004 16:02
>>An: spr...@li...
>>Betreff: Re: [Springframework-developer] HibernateDaoSupport
>>
>>
>>
>>I don't like that solution, because it will then also affect any
>>HibernateTemplate that is passed in. The current code does not touch any
>>template that is passed in. These changes do not want to modify that
>>behaviour, but rather allow the default value for allowCreate on _new_
>>templates created to be specified. And I think there are two ways that
>>people would want to play with the flag: either make their own subclass
>>which sets the flag to false, and that becomes the superclass of all
>>their DAOs, or alternately, do not use a subclass at all, but in some
>>(or all) DAOs, specifically set the default value.
>>
>>Colin
>>
>>jürgen höller [werk3AT] wrote:
>>
>> 
>>
>>    
>>
>>>Colin,
>>>
>>>What about simply invoking
>>>
>>>getHibernateTemplate().setAllowCreate(false);
>>>
>>>in the initDao implementation of your subclass?
>>>
>>>Juergen
>>>
>>>
>>>________________________________
>>>
>>>Von: spr...@li... im Auftrag von Colin Sampaleanu
>>>Gesendet: Do 15.07.2004 05:34
>>>An: spr...@li...
>>>Betreff: [Springframework-developer] HibernateDaoSupport
>>>
>>>
>>>
>>>Juergen,
>>>
>>>The existing code in HibernateDaoSupport created a HibernateTemplate
>>>with the allowCreate flag as true by default, and as the
>>>setSessionFactory method where the template was created was final, there
>>>was no way to override this. I have created a protected field called
>>>defaultTemplateAllowCreateValue (true by default to maintain existing
>>>behaviour), which a user HibernateDaoSupport subclass may override.
>>>Additionally, I have added a setter for this default value, so a DAO
>>>instance can be set to true or false specifically (without having to
>>>subclass). This value does not affect any HibernateTemplate passed in
>>>explicitly.
>>>
>>>Colin
>>>   
>>>      
>>>

Re: [Springframework-developer] HibernateDaoSupport

[<jue...@we...>]

Colin,

I see your point. We could keep setSessionFactory as final, but let it =
delegate to a non-final protected =
createHibernateTemplate(SessionFactory) method that could be overridden =
in subclasses, even allowing to plug in custom HibernateTemplate =
subclasses. That's a quite clean and very flexible solution, IMO. I'd be =
happy to adapt HibernateDaoSupport, JdoDaoSupport and co accordingly.

Let's also not forget that we're talking about a convenience base class =
here: For special needs, it's trivial to create a custom base class that =
does not derive from HibernateDaoSupport in the first place. We "just" =
need to cover 95% of use cases here. I agree that allowCreate=3Dfalse is =
quite common, though, so we should cover that; also, setting the =
flushMode: createHibernateTemplate would cover both.

Juergen


-----Original Message-----
From: spr...@li...
[mailto:spr...@li...]On Behalf
Of Colin Sampaleanu
Sent: Monday, July 26, 2004 3:16 PM
To: spr...@li...
Subject: Re: [Springframework-developer] HibernateDaoSupport


Juergen,

Personally, I do feel the class has somewhat of a 'smell' as it is now,=20
although part of the reason is that setSessionFactory itself is doing=20
work instead of this stuff being done in the init method (I realize this =

is to allow the thing to work without the init method ever being=20
called). The issue to me though is the fact that I have seen on a number =

of occassions people get burned by the default allowCreate flag being=20
true. They mess up their tx settings, and have no tx, but don't realize=20
it because the sessions are still being created. If instead they were=20
using the flag with a false value (at absolutely no pain for most=20
situations when using HibernateTransactionManager or another tx manger=20
eith HibernateInterceptor), they automatically get an error when their=20
DAO is not running in a tx. So I feel it is important to have some=20
relatively easy way to override this, at least so that some team lead or =

architect can enforce this. I think it's not really necessary to have=20
the default HibernateDaoSupport allow setting this by DAOs which derive=20
directly, it's not a big deal to ask people to subclass it to change the =

handing of this, and just use that common user variant as their=20
superclass. So taking out the setters and getters is not a big deal. Now =

with regards to allowing the default flag handling to be overriden by a=20
subclass though, allowing setSessionFactory to be overriden would work=20
fine, although arguably it's not much cleaner than still having the=20
field there (for the default value) which a subclass can override in a=20
constructor. If setSessionFactory were to be made non-final like this=20
then we need to document much more clearly (javadoc) that that method is =

actually responsible for creating a template if none is set, in the=20
default impl.

Regards,
Colin


j=FCrgen h=F6ller [werk3AT] wrote:

>Colin,
>=20
>I've just had a look at the new "defaultTemplateAllowCreateValue" flag =
in HibernateDaoSupport, and I'm frankly not happy with it. We have a =
special check whether the HibernateTemplate is self-created etc, =
indicating - for me at least - that something is wrong there. I see your =
use case, which is worth addressing, but I think the current approach is =
not ideal.
>=20
>This is not really how our XxxDaoSupport classes are meant to be used. =
In the case of HibernateDaoSupport: either pass in a SessionFactory *or* =
a preconfigured HibernateTemplate. If you want a default value for =
HibernateTemplate's "allowCreate" flag, why not set up a =
HibernateTemplate bean in your context, configure it with =
"allowCreate"=3Dfalse and pass it to all your DAOs? This would work =
nicely with the old HibernateDaoSupport implementation, without any =
special checks...
>=20
>My two main concerns are 1. consistency, i.e. that JdoDaoSupport and =
the others would have to be coded in a similar fashion and 2. future =
extensions, i.e. what happens if there's a further flag on =
HibernateTemplate that you want to set via your DAO? Particularly in the =
latter case, I'm not keen on having that sort of "if-self-created-then" =
properties on the DAO: They confuse things, and just apply when passing =
in a SessionFactory (not when passing in a HibernateTemplate), which is =
not immediately obvious.
>=20
>To allow for programmatic setting of such HibernateTemplate properties, =
we could turn setSessionFactory non-final, allowing it to override with =
a version that builds a custom HibernateTemplate for that =
SessionFactory. That would be much cleaner, IMO, and easy to adapt in =
JdoDaoSupport and co. Our data access templates and DAO base classes are =
among the most popular parts of Spring, so it's important to indicate a =
clear strategy there.
>=20
>All things considered, I quite strongly believe that we should use to =
the old HibernateDaoSupport implementation again, just turning =
setSessionFactory non-final to allow for programmatic overriding. For =
context-driven configuration, let's recommend to pass in a preconfigured =
HibernateTemplate bean. Can I convince you of this?
>=20
>Unfortunately, I'm already in a bit of a hurry here: I'd like to - =
finally! - get 1.1 RC1 out tomorrow.
>=20
>Juergen
>=20
>
>________________________________
>
>Von: spr...@li... im Auftrag =
von Colin Sampaleanu
>Gesendet: Do 15.07.2004 16:02
>An: spr...@li...
>Betreff: Re: [Springframework-developer] HibernateDaoSupport
>
>
>
>I don't like that solution, because it will then also affect any
>HibernateTemplate that is passed in. The current code does not touch =
any
>template that is passed in. These changes do not want to modify that
>behaviour, but rather allow the default value for allowCreate on _new_
>templates created to be specified. And I think there are two ways that
>people would want to play with the flag: either make their own subclass
>which sets the flag to false, and that becomes the superclass of all
>their DAOs, or alternately, do not use a subclass at all, but in some
>(or all) DAOs, specifically set the default value.
>
>Colin
>
>j=FCrgen h=F6ller [werk3AT] wrote:
>
> =20
>
>>Colin,
>>
>>What about simply invoking
>>
>> getHibernateTemplate().setAllowCreate(false);
>>
>>in the initDao implementation of your subclass?
>>
>>Juergen
>>
>>
>>________________________________
>>
>>Von: spr...@li... im Auftrag =
von Colin Sampaleanu
>>Gesendet: Do 15.07.2004 05:34
>>An: spr...@li...
>>Betreff: [Springframework-developer] HibernateDaoSupport
>>
>>
>>
>>Juergen,
>>
>>The existing code in HibernateDaoSupport created a HibernateTemplate
>>with the allowCreate flag as true by default, and as the
>>setSessionFactory method where the template was created was final, =
there
>>was no way to override this. I have created a protected field called
>>defaultTemplateAllowCreateValue (true by default to maintain existing
>>behaviour), which a user HibernateDaoSupport subclass may override.
>>Additionally, I have added a setter for this default value, so a DAO
>>instance can be set to true or false specifically (without having to
>>subclass). This value does not affect any HibernateTemplate passed in
>>explicitly.
>>
>>Colin
>>   =20
>>




-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=3D4721&alloc_id=3D10040&op=3Dclick
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

Re: [Springframework-developer] HibernateDaoSupport

[Colin S. <col...@ex...>]

Juergen,

Personally, I do feel the class has somewhat of a 'smell' as it is now, 
although part of the reason is that setSessionFactory itself is doing 
work instead of this stuff being done in the init method (I realize this 
is to allow the thing to work without the init method ever being 
called). The issue to me though is the fact that I have seen on a number 
of occassions people get burned by the default allowCreate flag being 
true. They mess up their tx settings, and have no tx, but don't realize 
it because the sessions are still being created. If instead they were 
using the flag with a false value (at absolutely no pain for most 
situations when using HibernateTransactionManager or another tx manger 
eith HibernateInterceptor), they automatically get an error when their 
DAO is not running in a tx. So I feel it is important to have some 
relatively easy way to override this, at least so that some team lead or 
architect can enforce this. I think it's not really necessary to have 
the default HibernateDaoSupport allow setting this by DAOs which derive 
directly, it's not a big deal to ask people to subclass it to change the 
handing of this, and just use that common user variant as their 
superclass. So taking out the setters and getters is not a big deal. Now 
with regards to allowing the default flag handling to be overriden by a 
subclass though, allowing setSessionFactory to be overriden would work 
fine, although arguably it's not much cleaner than still having the 
field there (for the default value) which a subclass can override in a 
constructor. If setSessionFactory were to be made non-final like this 
then we need to document much more clearly (javadoc) that that method is 
actually responsible for creating a template if none is set, in the 
default impl.

Regards,
Colin


jürgen höller [werk3AT] wrote:

>Colin,
> 
>I've just had a look at the new "defaultTemplateAllowCreateValue" flag in HibernateDaoSupport, and I'm frankly not happy with it. We have a special check whether the HibernateTemplate is self-created etc, indicating - for me at least - that something is wrong there. I see your use case, which is worth addressing, but I think the current approach is not ideal.
> 
>This is not really how our XxxDaoSupport classes are meant to be used. In the case of HibernateDaoSupport: either pass in a SessionFactory *or* a preconfigured HibernateTemplate. If you want a default value for HibernateTemplate's "allowCreate" flag, why not set up a HibernateTemplate bean in your context, configure it with "allowCreate"=false and pass it to all your DAOs? This would work nicely with the old HibernateDaoSupport implementation, without any special checks...
> 
>My two main concerns are 1. consistency, i.e. that JdoDaoSupport and the others would have to be coded in a similar fashion and 2. future extensions, i.e. what happens if there's a further flag on HibernateTemplate that you want to set via your DAO? Particularly in the latter case, I'm not keen on having that sort of "if-self-created-then" properties on the DAO: They confuse things, and just apply when passing in a SessionFactory (not when passing in a HibernateTemplate), which is not immediately obvious.
> 
>To allow for programmatic setting of such HibernateTemplate properties, we could turn setSessionFactory non-final, allowing it to override with a version that builds a custom HibernateTemplate for that SessionFactory. That would be much cleaner, IMO, and easy to adapt in JdoDaoSupport and co. Our data access templates and DAO base classes are among the most popular parts of Spring, so it's important to indicate a clear strategy there.
> 
>All things considered, I quite strongly believe that we should use to the old HibernateDaoSupport implementation again, just turning setSessionFactory non-final to allow for programmatic overriding. For context-driven configuration, let's recommend to pass in a preconfigured HibernateTemplate bean. Can I convince you of this?
> 
>Unfortunately, I'm already in a bit of a hurry here: I'd like to - finally! - get 1.1 RC1 out tomorrow.
> 
>Juergen
> 
>
>________________________________
>
>Von: spr...@li... im Auftrag von Colin Sampaleanu
>Gesendet: Do 15.07.2004 16:02
>An: spr...@li...
>Betreff: Re: [Springframework-developer] HibernateDaoSupport
>
>
>
>I don't like that solution, because it will then also affect any
>HibernateTemplate that is passed in. The current code does not touch any
>template that is passed in. These changes do not want to modify that
>behaviour, but rather allow the default value for allowCreate on _new_
>templates created to be specified. And I think there are two ways that
>people would want to play with the flag: either make their own subclass
>which sets the flag to false, and that becomes the superclass of all
>their DAOs, or alternately, do not use a subclass at all, but in some
>(or all) DAOs, specifically set the default value.
>
>Colin
>
>jürgen höller [werk3AT] wrote:
>
>  
>
>>Colin,
>>
>>What about simply invoking
>>
>> getHibernateTemplate().setAllowCreate(false);
>>
>>in the initDao implementation of your subclass?
>>
>>Juergen
>>
>>
>>________________________________
>>
>>Von: spr...@li... im Auftrag von Colin Sampaleanu
>>Gesendet: Do 15.07.2004 05:34
>>An: spr...@li...
>>Betreff: [Springframework-developer] HibernateDaoSupport
>>
>>
>>
>>Juergen,
>>
>>The existing code in HibernateDaoSupport created a HibernateTemplate
>>with the allowCreate flag as true by default, and as the
>>setSessionFactory method where the template was created was final, there
>>was no way to override this. I have created a protected field called
>>defaultTemplateAllowCreateValue (true by default to maintain existing
>>behaviour), which a user HibernateDaoSupport subclass may override.
>>Additionally, I have added a setter for this default value, so a DAO
>>instance can be set to true or false specifically (without having to
>>subclass). This value does not affect any HibernateTemplate passed in
>>explicitly.
>>
>>Colin
>>    
>>

Re: [Springframework-developer] HibernateDaoSupport

[<jue...@we...>]

Colin,
=20
I've just had a look at the new "defaultTemplateAllowCreateValue" flag =
in HibernateDaoSupport, and I'm frankly not happy with it. We have a =
special check whether the HibernateTemplate is self-created etc, =
indicating - for me at least - that something is wrong there. I see your =
use case, which is worth addressing, but I think the current approach is =
not ideal.
=20
This is not really how our XxxDaoSupport classes are meant to be used. =
In the case of HibernateDaoSupport: either pass in a SessionFactory *or* =
a preconfigured HibernateTemplate. If you want a default value for =
HibernateTemplate's "allowCreate" flag, why not set up a =
HibernateTemplate bean in your context, configure it with =
"allowCreate"=3Dfalse and pass it to all your DAOs? This would work =
nicely with the old HibernateDaoSupport implementation, without any =
special checks...
=20
My two main concerns are 1. consistency, i.e. that JdoDaoSupport and the =
others would have to be coded in a similar fashion and 2. future =
extensions, i.e. what happens if there's a further flag on =
HibernateTemplate that you want to set via your DAO? Particularly in the =
latter case, I'm not keen on having that sort of "if-self-created-then" =
properties on the DAO: They confuse things, and just apply when passing =
in a SessionFactory (not when passing in a HibernateTemplate), which is =
not immediately obvious.
=20
To allow for programmatic setting of such HibernateTemplate properties, =
we could turn setSessionFactory non-final, allowing it to override with =
a version that builds a custom HibernateTemplate for that =
SessionFactory. That would be much cleaner, IMO, and easy to adapt in =
JdoDaoSupport and co. Our data access templates and DAO base classes are =
among the most popular parts of Spring, so it's important to indicate a =
clear strategy there.
=20
All things considered, I quite strongly believe that we should use to =
the old HibernateDaoSupport implementation again, just turning =
setSessionFactory non-final to allow for programmatic overriding. For =
context-driven configuration, let's recommend to pass in a preconfigured =
HibernateTemplate bean. Can I convince you of this?
=20
Unfortunately, I'm already in a bit of a hurry here: I'd like to - =
finally! - get 1.1 RC1 out tomorrow.
=20
Juergen
=20

________________________________

Von: spr...@li... im Auftrag =
von Colin Sampaleanu
Gesendet: Do 15.07.2004 16:02
An: spr...@li...
Betreff: Re: [Springframework-developer] HibernateDaoSupport



I don't like that solution, because it will then also affect any
HibernateTemplate that is passed in. The current code does not touch any
template that is passed in. These changes do not want to modify that
behaviour, but rather allow the default value for allowCreate on _new_
templates created to be specified. And I think there are two ways that
people would want to play with the flag: either make their own subclass
which sets the flag to false, and that becomes the superclass of all
their DAOs, or alternately, do not use a subclass at all, but in some
(or all) DAOs, specifically set the default value.

Colin

j=FCrgen h=F6ller [werk3AT] wrote:

>Colin,
>
>What about simply invoking
>
>  getHibernateTemplate().setAllowCreate(false);
>
>in the initDao implementation of your subclass?
>
>Juergen
>
>
>________________________________
>
>Von: spr...@li... im Auftrag =
von Colin Sampaleanu
>Gesendet: Do 15.07.2004 05:34
>An: spr...@li...
>Betreff: [Springframework-developer] HibernateDaoSupport
>
>
>
>Juergen,
>
>The existing code in HibernateDaoSupport created a HibernateTemplate
>with the allowCreate flag as true by default, and as the
>setSessionFactory method where the template was created was final, =
there
>was no way to override this. I have created a protected field called
>defaultTemplateAllowCreateValue (true by default to maintain existing
>behaviour), which a user HibernateDaoSupport subclass may override.
>Additionally, I have added a setter for this default value, so a DAO
>instance can be set to true or false specifically (without having to
>subclass). This value does not affect any HibernateTemplate passed in
>explicitly.
>
>Colin
>=20
>




-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=3D4721&alloc_id=3D10040&op=3Dclick
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

[Springframework-developer] spring build.63 Build Successful

[<al...@jt...>]

<html><head>
<style>
.white { color:#FFFFFF }.index { background-color:#FFFFFF }.index-passed { =
color:#004400 }.index-failed { color:#FF0000; font-weight:bold }.index-head=
er { font-weight:bold }.link { font-family:arial,helvetica,sans-serif; font=
-size:10pt; color:#FFFFFF; text-decoration:none; }.tab-table { margin: 0em =
0em 0.5em 0em; }.tabs { font-family:arial,helvetica,sans-serif; font-size:8=
pt; color:#000000; font-weight:bold; padding: 0em 2em; background-color:#EE=
EEEE; }.tabs-link { color:#000000; text-decoration:none; }.tabs-link:visite=
d { color:#000000; text-decoration:none; }.tabs-selected { font-family:aria=
l,helvetica,sans-serif; font-size:8pt; color:#000000; font-weight:bold; pad=
ding: 0em 2em; }.tabs-selected { border: inset; }.header-title { font-famil=
y:arial,helvetica,sans-serif; font-size:12pt; color:#000000; font-weight:bo=
ld; }.header-label { font-weight:bold; }.header-data { font-family:arial,he=
lvetica,sans-serif; font-size:10pt; color:#000000; }.modifications-data { f=
ont-family:arial,helvetica,sans-serif; font-size:8pt; color:#000000; }.modi=
fications-sectionheader { background-color:#000066; font-family:arial,helve=
tica,sans-serif; font-size:10pt; color:#FFFFFF; }.modifications-oddrow { ba=
ckground-color:#CCCCCC }.modifications-evenrow { background-color:#FFFFCC }=
.changelists-oddrow { background-color:#CCCCCC }.changelists-evenrow { back=
ground-color:#FFFFCC }.changelists-file-spacer { background-color:#FFFFFF }=
.changelists-file-evenrow { background-color:#EEEEEE }.changelists-file-odd=
row { background-color:#FFFFEE }.changelists-file-header { background-color=
:#666666; font-family:arial,helvetica,sans-serif; font-size:8pt; color:#FFF=
FFF; }.compile-data { font-family:arial,helvetica,sans-serif; font-size:8pt=
; color:#000000; }.compile-error-data { font-family:arial,helvetica,sans-se=
rif; font-size:8pt; color:#FF0000; }.compile-warn-data { font-family:arial,=
helvetica,sans-serif; font-size:8pt; color:#CC9900; }.compile-sectionheader=
 { background-color:#000066; font-family:arial,helvetica,sans-serif; font-s=
ize:10pt; color:#FFFFFF; }.distributables-data { font-family:arial,helvetic=
a,sans-serif; font-size:8pt; color:#000000; }.distributables-sectionheader =
{ background-color:#000066; font-family:arial,helvetica,sans-serif; font-si=
ze:10pt; color:#FFFFFF; }.distributables-oddrow { background-color:#CCCCCC =
}.unittests-sectionheader { background-color:#000066; font-family:arial,hel=
vetica,sans-serif; font-size:10pt; color:#FFFFFF; }.unittests-oddrow { back=
ground-color:#CCCCCC }.unittests-data { font-family:arial,helvetica,sans-se=
rif; font-size:8pt; color:#000000; }.unittests-error { font-family:arial,he=
lvetica,sans-serif; font-size:8pt; color:#FF0000; }.checkstyle-oddrow { bac=
kground-color:#CCCCCC }.checkstyle-data { font-family:arial,helvetica,sans-=
serif; font-size:8pt; color:#000000; }.checkstyle-sectionheader { backgroun=
d-color:#000066; font-family:arial,helvetica,sans-serif; font-size:10pt; co=
lor:#FFFFFF; }
</style>
</head><body>
<p>
<table width=3D"98%" border=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=
=3D"center"><tr><td class=3D"header-title">BUILD COMPLETE&nbsp;-&nbsp;     =
               build.63</td></tr><tr><td class=3D"header-data"><span class=
=3D"header-label">Date of build:&nbsp;</span>07/26/2004 00:16:02</td></tr><=
tr><td class=3D"header-data"><span class=3D"header-label">Time to build:&nb=
sp;</span>13 minutes 20 seconds</td></tr><tr><td class=3D"header-data"><spa=
n class=3D"header-label">Last changed:&nbsp;</span>07/25/2004 18:13:23</td>=
</tr><tr><td class=3D"header-data"><span class=3D"header-label">Last log en=
try:&nbsp;</span>Removed overridden nop serialization tests--this superclas=
s test now passes</td></tr></table><p>
<table xmlns=3D"http://www.w3.org/TR/html4/strict.dtd" width=3D"98%" border=
=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=3D"center"/><p>
<p>
<table xmlns=3D"http://www.w3.org/TR/html4/strict.dtd" width=3D"98%" border=
=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=3D"center"><tr><td class=
=3D"compile-sectionheader">                        &nbsp;Errors/Warnings: (=
6)                    </td></tr><tr><td><pre class=3D"compile-error-data">N=
ote: Some input files use or override a deprecated API.<br class=3D"none"/>=
Note: Recompile with -deprecation for details.Note: /jteam/build/checkout/s=
pring/spring/mock/org/springframework/mock/web/MockHttpSession.java uses or=
 overrides a deprecated API.<br class=3D"none"/>Note: Recompile with -depre=
cation for details.<br class=3D"none"/>Note: Some input files use or overri=
de a deprecated API.<br class=3D"none"/>Note: Recompile with -deprecation f=
or details.<br class=3D"none"/></pre></td></tr></table><p>
<p>
<table width=3D"98%" border=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=
=3D"center"><tr><td colspan=3D"4" class=3D"unittests-sectionheader">       =
            &nbsp;Unit Tests: (1470)                </td></tr><tr><td><tabl=
e width=3D"98%" border=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=3D"c=
enter"><tr><td class=3D"unittests-data">                failure            =
</td><td width=3D"40%" class=3D"unittests-data">testHomePage</td><td width=
=3D"40%" class=3D"unittests-data">org.springframework.apptests.buildtest.Al=
lTests</td></tr></table></td></tr><tr></tr><tr><td colspan=3D"2">&nbsp;</td=
></tr><tr><td colspan=3D"4" class=3D"unittests-sectionheader">             =
       &nbsp;Unit Test Error Details:&nbsp;(1)                </td></tr><tr=
><td class=3D"unittests-data" colspan=3D"2">                Test:&nbsp;test=
HomePage</td></tr><tr><td class=3D"unittests-data" colspan=3D"2">          =
      Class:&nbsp;org.springframework.apptests.buildtest.AllTests</td></tr>=
<tr><td class=3D"unittests-data" colspan=3D"2">                Type: junit.=
framework.AssertionFailedError</td></tr><tr><td class=3D"unittests-data" co=
lspan=3D"2">                Message: Exception while testing URL http://loc=
alhost:13084/buildtest:java.io.IOException</td></tr><tr><td class=3D"unitte=
sts-error" colspan=3D"2"><pre>junit.framework.AssertionFailedError: Excepti=
on while testing URL http://localhost:13084/buildtest:java.io.IOException<b=
r>=09at org.springframework.apptests.buildtest.AllTests.testHomePage(Unknow=
n Source)<br>=09at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Meth=
od)<br>=09at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccess=
orImpl.java:39)<br>=09at sun.reflect.DelegatingMethodAccessorImpl.invoke(De=
legatingMethodAccessorImpl.java:25)<br></pre></td></tr><tr><td colspan=3D"2=
">&nbsp;</td></tr></table><p>
<table width=3D"98%" border=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=
=3D"center"><tr><td colspan=3D"4" class=3D"modifications-sectionheader">   =
                 &nbsp;Modifications since last build:&nbsp;               =
     (31)                </td></tr><tr class=3D"modifications-evenrow"><td =
class=3D"modifications-data">modified</td><td class=3D"modifications-data">=
johnsonr</td><td class=3D"modifications-data">test/org/springframework/aop/=
framework/OptimizedCglibProxyTests.java</td><td class=3D"modifications-data=
">Removed overridden nop serialization tests--this superclass test now pass=
es</td></tr><tr class=3D"modifications-oddrow"><td class=3D"modifications-d=
ata">modified</td><td class=3D"modifications-data">johnsonr</td><td class=
=3D"modifications-data">test/org/springframework/aop/support/AopUtilsTests.=
java</td><td class=3D"modifications-data">Added tests that deserialization =
restores canonical instances of framework classes</td></tr><tr class=3D"mod=
ifications-evenrow"><td class=3D"modifications-data">added</td><td class=3D=
"modifications-data">johnsonr</td><td class=3D"modifications-data">src/org/=
springframework/aop/target/EmptyTargetSource.java</td><td class=3D"modifica=
tions-data">Pulled EmptyTargetSource out into top-level class. It now imple=
ments readReplace()to ensure equality tests work correctly after serializat=
ion.</td></tr><tr class=3D"modifications-oddrow"><td class=3D"modifications=
-data">modified</td><td class=3D"modifications-data">johnsonr</td><td class=
=3D"modifications-data">src/org/springframework/aop/framework/AdvisedSuppor=
t.java</td><td class=3D"modifications-data">Pulled EmptyTargetSource out in=
to top-level class. It now implements readReplace()to ensure equality tests=
 work correctly after serialization.</td></tr><tr class=3D"modifications-ev=
enrow"><td class=3D"modifications-data">modified</td><td class=3D"modificat=
ions-data">johnsonr</td><td class=3D"modifications-data">src/org/springfram=
ework/aop/framework/Cglib2AopProxy.java</td><td class=3D"modifications-data=
">Added root cause in throwing AopConfigException in readObject()</td></tr>=
<tr class=3D"modifications-oddrow"><td class=3D"modifications-data">modifie=
d</td><td class=3D"modifications-data">johnsonr</td><td class=3D"modificati=
ons-data">src/org/springframework/aop/framework/JdkDynamicAopProxy.java</td=
><td class=3D"modifications-data">Added root cause in throwing AopConfigExc=
eption in readObject()</td></tr><tr class=3D"modifications-evenrow"><td cla=
ss=3D"modifications-data">modified</td><td class=3D"modifications-data">joh=
nsonr</td><td class=3D"modifications-data">src/org/springframework/aop/inte=
rceptor/ExposeInvocationInterceptor.java</td><td class=3D"modifications-dat=
a">Added readResolve() method so that canonical instance is used on deseria=
lization</td></tr><tr class=3D"modifications-oddrow"><td class=3D"modificat=
ions-data">modified</td><td class=3D"modifications-data">johnsonr</td><td c=
lass=3D"modifications-data">test/org/springframework/aop/target/HotSwappabl=
eTargetSourceTests.java</td><td class=3D"modifications-data">Made HotSwappa=
bleTargetSource serializable</td></tr><tr class=3D"modifications-evenrow"><=
td class=3D"modifications-data">modified</td><td class=3D"modifications-dat=
a">johnsonr</td><td class=3D"modifications-data">src/org/springframework/ao=
p/target/HotSwappableTargetSource.java</td><td class=3D"modifications-data"=
>Made HotSwappableTargetSource serializable</td></tr><tr class=3D"modificat=
ions-oddrow"><td class=3D"modifications-data">modified</td><td class=3D"mod=
ifications-data">johnsonr</td><td class=3D"modifications-data">src/org/spri=
ngframework/aop/support/DynamicMethodMatcherPointcutAdvisor.java</td><td cl=
ass=3D"modifications-data">Made serializable</td></tr><tr class=3D"modifica=
tions-evenrow"><td class=3D"modifications-data">modified</td><td class=3D"m=
odifications-data">johnsonr</td><td class=3D"modifications-data">src/org/sp=
ringframework/aop/support/StaticMethodMatcherPointcutAdvisor.java</td><td c=
lass=3D"modifications-data">Made serializable</td></tr><tr class=3D"modific=
ations-oddrow"><td class=3D"modifications-data">modified</td><td class=3D"m=
odifications-data">johnsonr</td><td class=3D"modifications-data">src/org/sp=
ringframework/aop/support/UnionPointcut.java</td><td class=3D"modifications=
-data">Made serializable</td></tr><tr class=3D"modifications-evenrow"><td c=
lass=3D"modifications-data">modified</td><td class=3D"modifications-data">j=
ohnsonr</td><td class=3D"modifications-data">src/org/springframework/aop/Ta=
rgetSource.java</td><td class=3D"modifications-data">Improved javadoc</td><=
/tr><tr class=3D"modifications-oddrow"><td class=3D"modifications-data">mod=
ified</td><td class=3D"modifications-data">johnsonr</td><td class=3D"modifi=
cations-data">src/org/springframework/aop/support/MethodMatchers.java</td><=
td class=3D"modifications-data">Made inner classes serializable</td></tr><t=
r class=3D"modifications-evenrow"><td class=3D"modifications-data">modified=
</td><td class=3D"modifications-data">johnsonr</td><td class=3D"modificatio=
ns-data">src/org/springframework/aop/support/ClassFilters.java</td><td clas=
s=3D"modifications-data">Made framework implementations of AOP interfaces S=
erializable.</td></tr><tr class=3D"modifications-oddrow"><td class=3D"modif=
ications-data">modified</td><td class=3D"modifications-data">johnsonr</td><=
td class=3D"modifications-data">src/org/springframework/aop/support/Composa=
blePointcut.java</td><td class=3D"modifications-data">Made framework implem=
entations of AOP interfaces Serializable.</td></tr><tr class=3D"modificatio=
ns-evenrow"><td class=3D"modifications-data">modified</td><td class=3D"modi=
fications-data">johnsonr</td><td class=3D"modifications-data">src/org/sprin=
gframework/aop/support/NameMatchMethodPointcut.java</td><td class=3D"modifi=
cations-data">Made framework implementations of AOP interfaces Serializable=
.</td></tr><tr class=3D"modifications-oddrow"><td class=3D"modifications-da=
ta">modified</td><td class=3D"modifications-data">johnsonr</td><td class=3D=
"modifications-data">src/org/springframework/aop/support/RootClassFilter.ja=
va</td><td class=3D"modifications-data">Made framework implementations of A=
OP interfaces Serializable.</td></tr><tr class=3D"modifications-evenrow"><t=
d class=3D"modifications-data">modified</td><td class=3D"modifications-data=
">johnsonr</td><td class=3D"modifications-data">src/org/springframework/aop=
/support/UnionPointcut.java</td><td class=3D"modifications-data">Made frame=
work implementations of AOP interfaces Serializable.</td></tr><tr class=3D"=
modifications-oddrow"><td class=3D"modifications-data">modified</td><td cla=
ss=3D"modifications-data">johnsonr</td><td class=3D"modifications-data">tes=
t/org/springframework/beans/Person.java</td><td class=3D"modifications-data=
">Added setter methods</td></tr><tr class=3D"modifications-evenrow"><td cla=
ss=3D"modifications-data">modified</td><td class=3D"modifications-data">joh=
nsonr</td><td class=3D"modifications-data">/changelog.txt</td><td class=3D"=
modifications-data">Noted deprecations in AOP package</td></tr><tr class=3D=
"modifications-oddrow"><td class=3D"modifications-data">added</td><td class=
=3D"modifications-data">johnsonr</td><td class=3D"modifications-data">test/=
org/springframework/aop/support/RegexpMethodPointcutAdvisorIntegrationTests=
.java</td><td class=3D"modifications-data">Overhauled RegexpMethodPointcut =
support to support serialization and make iteasier to support other than Pe=
rl5 regexp syntax</td></tr><tr class=3D"modifications-evenrow"><td class=3D=
"modifications-data">deleted</td><td class=3D"modifications-data">johnsonr<=
/td><td class=3D"modifications-data">test/org/springframework/aop/support/R=
egexpMethodPointcutAroundAdvisorIntegrationTests.java</td><td class=3D"modi=
fications-data">Overhauled RegexpMethodPointcut support to support serializ=
ation and make iteasier to support other than Perl5 regexp syntax</td></tr>=
<tr class=3D"modifications-oddrow"><td class=3D"modifications-data">modifie=
d</td><td class=3D"modifications-data">johnsonr</td><td class=3D"modificati=
ons-data">test/org/springframework/aop/support/RegexpMethodPointcutTests.ja=
va</td><td class=3D"modifications-data">Overhauled RegexpMethodPointcut sup=
port to support serialization and make iteasier to support other than Perl5=
 regexp syntax</td></tr><tr class=3D"modifications-evenrow"><td class=3D"mo=
difications-data">modified</td><td class=3D"modifications-data">johnsonr</t=
d><td class=3D"modifications-data">test/org/springframework/aop/support/reg=
expSetterTests.xml</td><td class=3D"modifications-data">Overhauled RegexpMe=
thodPointcut support to support serialization and make iteasier to support =
other than Perl5 regexp syntax</td></tr><tr class=3D"modifications-oddrow">=
<td class=3D"modifications-data">added</td><td class=3D"modifications-data"=
>johnsonr</td><td class=3D"modifications-data">src/org/springframework/aop/=
support/AbstractRegexpMethodPointcut.java</td><td class=3D"modifications-da=
ta">Overhauled RegexpMethodPointcut support to support serialization and ma=
ke iteasier to support other than Perl5 regexp syntax</td></tr><tr class=3D=
"modifications-evenrow"><td class=3D"modifications-data">added</td><td clas=
s=3D"modifications-data">johnsonr</td><td class=3D"modifications-data">src/=
org/springframework/aop/support/Perl5RegexpMethodPointcut.java</td><td clas=
s=3D"modifications-data">Overhauled RegexpMethodPointcut support to support=
 serialization and make iteasier to support other than Perl5 regexp syntax<=
/td></tr><tr class=3D"modifications-oddrow"><td class=3D"modifications-data=
">modified</td><td class=3D"modifications-data">johnsonr</td><td class=3D"m=
odifications-data">src/org/springframework/aop/support/RegexpMethodPointcut=
.java</td><td class=3D"modifications-data">Overhauled RegexpMethodPointcut =
support to support serialization and make iteasier to support other than Pe=
rl5 regexp syntax</td></tr><tr class=3D"modifications-evenrow"><td class=3D=
"modifications-data">modified</td><td class=3D"modifications-data">johnsonr=
</td><td class=3D"modifications-data">src/org/springframework/aop/support/R=
egexpMethodPointcutAdvisor.java</td><td class=3D"modifications-data">Overha=
uled RegexpMethodPointcut support to support serialization and make iteasie=
r to support other than Perl5 regexp syntax</td></tr><tr class=3D"modificat=
ions-oddrow"><td class=3D"modifications-data">modified</td><td class=3D"mod=
ifications-data">johnsonr</td><td class=3D"modifications-data">test/org/spr=
ingframework/aop/interceptor/NopInterceptor.java</td><td class=3D"modificat=
ions-data">SerializableNopInterceptor now preserves count (previously count=
 field wasin non-serializable superclass)</td></tr><tr class=3D"modificatio=
ns-evenrow"><td class=3D"modifications-data">modified</td><td class=3D"modi=
fications-data">johnsonr</td><td class=3D"modifications-data">test/org/spri=
ngframework/aop/interceptor/SerializableNopInterceptor.java</td><td class=
=3D"modifications-data">SerializableNopInterceptor now preserves count (pre=
viously count field wasin non-serializable superclass)</td></tr></table><p>
<table width=3D"98%" border=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=
=3D"center"><tr><td class=3D"distributables-sectionheader">                =
        &nbsp;Deployments by this build:&nbsp;(8)                    </td><=
/tr><tr><td class=3D"distributables-data">Building jar: /jteam/build/checko=
ut/spring/spring/dist/spring.jar</td></tr><tr class=3D"distributables-oddro=
w"><td class=3D"distributables-data">Building war: /jteam/build/checkout/sp=
ring/spring/autobuilds/apps/buildtest/dist/buildtest.war</td></tr><tr><td c=
lass=3D"distributables-data">Building war: /jteam/build/checkout/spring/spr=
ing/autobuilds/apps/buildtest/dist/buildtest.war</td></tr><tr class=3D"dist=
ributables-oddrow"><td class=3D"distributables-data">Building war: /jteam/b=
uild/checkout/spring/spring/autobuilds/apps/buildtest/dist/buildtest.war</t=
d></tr><tr><td class=3D"distributables-data">Building jar: /jteam/build/che=
ckout/spring/spring/autobuilds/apps/jpetstore/war/WEB-INF/lib/jpetstore.jar=
</td></tr><tr class=3D"distributables-oddrow"><td class=3D"distributables-d=
ata">Building war: /jteam/build/checkout/spring/spring/autobuilds/apps/jpet=
store/dist/jpetstore.war</td></tr><tr><td class=3D"distributables-data">Bui=
lding jar: /jteam/build/checkout/spring/spring/autobuilds/apps/jpetstore/wa=
r/WEB-INF/lib/jpetstore.jar</td></tr><tr class=3D"distributables-oddrow"><t=
d class=3D"distributables-data">Building war: /jteam/build/checkout/spring/=
spring/autobuilds/apps/jpetstore/dist/jpetstore.war</td></tr></table>
</body></html>

[Springframework-developer] Empty values conversion for BeanWrapperImpl

[Diego D. <di...@gm...>]

Hi,
   in class BeanWrapperImpl, is it possible that a method like 

doTypeConversionIfNecessary(String, String, Object, Object, Class) 

consider empty strings ("", even nulls) as 'zeroes' values for the binding
destination? That is, if the mapping targets to a boolean, an empty string
mean false, 0 for an int/Integer, etc

   Don't you find useful? If you do, how would it be the mechanism to
proceed? Thank you in advance

-- 
______________________________________
   Diego A. Dagum (di...@gm...)
                  (di...@bi...)
   icq: Tarang@
   msn: Tarang@

+++ GMX DSL-Tarife 3 Monate gratis* +++ Nur bis 25.7.2004 +++
Bis 24.000 MB oder 300 Freistunden inkl. http://www.gmx.net/de/go/dsl

RE: [Springframework-developer] Final preparations for 1.1 RC1

[Rob H. <ro...@ca...>]

This can be achieved using custom directives in Velocity, i.e you can =
have a
varied number of parameters and you can specify defaults for each one. =
The
only drawback is that directives have to be coded in Java and are not =
quite
as easy to build as macros since you have to interact directly with the =
AST
constructed by the parser.

Rob

-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf =
Of
j=FCrgen h=F6ller [werk3AT]
Sent: 24 July 2004 20:29
To: spr...@li...
Subject: Re: [Springframework-developer] Final preparations for 1.1 RC1

As far I see, there is no such overloading of macros in Velocity: If we =
have
different parameters, we need to define a separate macro.
=20
Even in FreeMarker, there's just the option to define a fixed default =
for
optional parameters: no support for simply "not specified" (falling back =
to
the default HTML escape setting in our case). That's why I suggest to =
use a
different macro name there too, analogous to Velocity.
=20
So the remaining issue are the names: "springBind" (default HTML escape
setting) and "springBindEscaped" (explicitly specified HTML escape =
setting)?
=20
Juergen
=20

________________________________

Von: spr...@li... im Auftrag =
von
Matt Raible
Gesendet: Sa 24.07.2004 20:44
An: spr...@li...
Betreff: Re: [Springframework-developer] Final preparations for 1.1 RC1



It would be nice if the method name didn't have to change and we could
just control the rendering of the variable.  Probably not possible, but
something similar to JSP 2.0 where you use ${status.errorMessage} to
print out escaped XML and <c:out value=3D"${status.errorMessage}"
escapeXml=3D"false"/> if you want to print HTML.

I don't see a problem with having two separate methods: springBind and
springBindEscaped - just as long as its documented.  Though it might be
nicer to have #springBind(path) and #springBind(path false) - where you
have to use two parameters to escape XML.

Matt

On Jul 24, 2004, at 10:19 AM, j=FCrgen h=F6ller [werk3AT] wrote:

> Actually, the same issue occurs with FreeMarker too: We specify
> "escape=3Dfalse" there, so do not participate in any default. This =
needs
> to be addressed: We should allow to work with the defaultHtmlEscape
> value here too.
>
> While we could introduce a further "escape" value for "use default",
> offering a special method signature for it, it's probably clearer two
> offer two FreeMarker macros: "spring:bind" which never takes an
> "escape" parameter (i.e. always uses the default), and
> "spring:bindEscaped" which takes a required "escape" parameter. This
> would be analogous to Velocity again then.
>
> However, there's still the naming issue: "bind" uses the default HTML
> escape setting. But how to the name the version that takes an explicit
> HTML escape parameter? Is there a better name than "bindEscaped"?
>
> This is easier with JSP tags, where there can be a true tag-internal
> default if the "setHtmlEscape" method was not called... As far as I
> can see, even FreeMarker just allows for an explicitly specified
> default in the macro definition: It cannot seamlessly invoke either
> RequestContext.createBindStatus(path) respectively
> RequestContext.createBindStatus(path, htmlEscape), in our concrete
> case.
>
> Juergen
>
>
> ________________________________
>
> Von: spr...@li... im Auftrag
> von j=FCrgen h=F6ller [werk3AT]
> Gesendet: Sa 24.07.2004 15:12
> An: spr...@li...
> Betreff: Re: [Springframework-developer] Final preparations for 1.1 =
RC1
>
>
>
> Darren,
>
> Oops, I forgot to discuss that one: The reason why I removed the
> htmlEscape property from the "springBind" macro is to be able to
> participate in a RequestContext-level default, e.g. set via
> springMacroRequestContext.setDefaultHtmlEscape(true). Note that the
> createBindStatus invocation on RequestContext uses the
> defaultHtmlEscape flag then.
>
> I've just adapted the RequestContext implementation a bit further to
> also be able to participate in a ServletContext-level default, just
> like our JSP tags can, i.e. a "defaultHtmlEscape" context-param in
> web.xml. JSP tags and Velocity/FreeMarker macros can then even share
> such an application-wide default. I'll commit this promptly.
>
> Actually, the "springBindEscaped" macro should rather take an explicit
> htmlEscape parameter, to be able to override defaultHtmlEscape=3Dtrue =
to
> false for a specific macro. Hmm, what name could we use for this?
> "springBindWithExplicitEscape" is clearly too long... "springBind"
> with overloaded signature is not possible in Velocity... maybe still
> "springBindEscaped", but just with an explicit parameter?
>
>
> Matt,
>
> Note that the "springMacroRequestContext" is not really meant to be
> accessed directly; it is mainly meant to be used by Spring-provided
> macros. If you want to use a RequestContext in your own expressions,
> always specify the "requestContextAttribute" accordingly. We should
> highlight that in the docs.
>
>
> Juergen
>
>
> ________________________________
>
> Von: spr...@li... im Auftrag
> von Darren Davison
> Gesendet: Sa 24.07.2004 10:18
> An: spr...@li...
> Betreff: Re: [Springframework-developer] Final preparations for 1.1 =
RC1
>
>
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Saturday 24 July 2004 01:09, Matt Raible wrote:
>> I tried this out today and it works well.  The only thing I saw that
>> might cause confusion for users is there are 2 macros for Velocity
>> (#springBind and #springBindEscaped) - whereas FreeMarker has one w/
>> an
>> "escape" parameter.  I imagine that folks using FreeMarker might be
>> migrating from Velocity, so making the macros consistent might be
>> helpful.  Who knows - just a thought.
>
> FreeMarker has a default value of false for the 2nd param so you only
> need
> supply it to override it.  Velocity can't do that.
>
> The other options for Velocity are:
>
>  * always supply the second parameter in every call to springBind
>
>  * use a globally scoped, well-known variable defined in user
> templates.
>
>
> I prefer personally to always require the additional parameter.  It's
> more
> consistent with FM and won't cause user templates to break if they
> migrate
> them to FM using the automatic conversion tool they have available.
>
> What do you think?
>
>
>> I would make sure and document that the name
>> "springMacroRequestContext"
>> can be overridden by specifying a "requestContextAttribute" property.
>> It's much easier to write $rc.getMessage() than
>> $springMacroRequestContext.getMessage(). ;-)
>
> I will, thanks.
>
> - --
> Darren Davison
> Public Key: http://www.davison.uk.net/pages/key.htm
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.4 (GNU/Linux)
>
> iD8DBQFBAhtIKLMLAN01aw0RAisgAKCfjnl6dzgkdQ91o9lUrUvtd9RGWQCfRJNq
> cn71Z/8ovFjaDLQRxtBwTfo=3D
> =3Dlvg2
> -----END PGP SIGNATURE-----
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=CCk
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer




-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

RE: [Springframework-developer] Velocity, XSLT integration

[Stefan D S. <ste...@us...>]

can someone post the code that is available for Tiles and Velocity integr=
ation? I am in need of it for my current project. Thank you.




Friday, July 23, 2004 9:28 AM
To: <spr...@li...>
cc: =

From: "Rob Harrop" <ro...@ca...>
Subject: RE: [Springframework-developer] Velocity, XSLT integration


I=92m guessing that we would have to add support for both Velocity and XS=
LT under Tiles. That way you could use Tiles to perform the layout and th=
en use Velocity views for one tile and XSLT for another.
 =

I am going to finish some JMX stuff up today and then take a look at this=
 Velocity integration over the weekend, because I need it for a project. =
If I have time I will look at XSLT as well.

Rob
 =




From: spr...@li... [mailto:sprin=
gfr...@li...] On Behalf Of Stefan D S=
ookraj
Sent: 23 July 2004 12:51
To: spr...@li...
Subject: [Springframework-developer] Velocity, XSLT integration
 =

On the subject of view integration, how would I integrate Velocity and XS=
LT views? I have my left nav bar done in velocity and do not want to redu=
ndanly redo the logic for XSLT. How can I use Velocity for the left nav, =
header and footer and XSLT for the main content area? Is this possible an=
d is there an example? Thank you.
 =

 =

 =

 =

 =

 =

Friday, July 23, 2004 6:09 AM
To: <spr...@li...>
cc: =

From: "Alef Arendsen" <al...@jt...>
Subject: RE: [Springframework-developer] Velocity, Tiles and Spring
I had a short email chat with Pavl Muller on this... He's sent me his cod=
e for integration tiles with velocity (TilesVelocityView and even views m=
ixing velocity and jsp in different Tiles I believe). I'll forward it to =
you. Didn't have the time to look at it yet...
 =

alef
 =

 =




From: spr...@li... [mailto:sprin=
gfr...@li...] On Behalf Of Rob Harrop=

Sent: Friday, July 23, 2004 11:15 AM
To: spr...@li...
Subject: [Springframework-developer] Velocity, Tiles and Spring
All,
 =

I have a quick question  what is the best way of using Velocity as the co=
mponent views for a Tiles-based view in Spring?
 =

Rob=

[Springframework-developer] spring build.62 Build Successful

[<al...@jt...>]

<html><head>
<style>
.white { color:#FFFFFF }.index { background-color:#FFFFFF }.index-passed { =
color:#004400 }.index-failed { color:#FF0000; font-weight:bold }.index-head=
er { font-weight:bold }.link { font-family:arial,helvetica,sans-serif; font=
-size:10pt; color:#FFFFFF; text-decoration:none; }.tab-table { margin: 0em =
0em 0.5em 0em; }.tabs { font-family:arial,helvetica,sans-serif; font-size:8=
pt; color:#000000; font-weight:bold; padding: 0em 2em; background-color:#EE=
EEEE; }.tabs-link { color:#000000; text-decoration:none; }.tabs-link:visite=
d { color:#000000; text-decoration:none; }.tabs-selected { font-family:aria=
l,helvetica,sans-serif; font-size:8pt; color:#000000; font-weight:bold; pad=
ding: 0em 2em; }.tabs-selected { border: inset; }.header-title { font-famil=
y:arial,helvetica,sans-serif; font-size:12pt; color:#000000; font-weight:bo=
ld; }.header-label { font-weight:bold; }.header-data { font-family:arial,he=
lvetica,sans-serif; font-size:10pt; color:#000000; }.modifications-data { f=
ont-family:arial,helvetica,sans-serif; font-size:8pt; color:#000000; }.modi=
fications-sectionheader { background-color:#000066; font-family:arial,helve=
tica,sans-serif; font-size:10pt; color:#FFFFFF; }.modifications-oddrow { ba=
ckground-color:#CCCCCC }.modifications-evenrow { background-color:#FFFFCC }=
.changelists-oddrow { background-color:#CCCCCC }.changelists-evenrow { back=
ground-color:#FFFFCC }.changelists-file-spacer { background-color:#FFFFFF }=
.changelists-file-evenrow { background-color:#EEEEEE }.changelists-file-odd=
row { background-color:#FFFFEE }.changelists-file-header { background-color=
:#666666; font-family:arial,helvetica,sans-serif; font-size:8pt; color:#FFF=
FFF; }.compile-data { font-family:arial,helvetica,sans-serif; font-size:8pt=
; color:#000000; }.compile-error-data { font-family:arial,helvetica,sans-se=
rif; font-size:8pt; color:#FF0000; }.compile-warn-data { font-family:arial,=
helvetica,sans-serif; font-size:8pt; color:#CC9900; }.compile-sectionheader=
 { background-color:#000066; font-family:arial,helvetica,sans-serif; font-s=
ize:10pt; color:#FFFFFF; }.distributables-data { font-family:arial,helvetic=
a,sans-serif; font-size:8pt; color:#000000; }.distributables-sectionheader =
{ background-color:#000066; font-family:arial,helvetica,sans-serif; font-si=
ze:10pt; color:#FFFFFF; }.distributables-oddrow { background-color:#CCCCCC =
}.unittests-sectionheader { background-color:#000066; font-family:arial,hel=
vetica,sans-serif; font-size:10pt; color:#FFFFFF; }.unittests-oddrow { back=
ground-color:#CCCCCC }.unittests-data { font-family:arial,helvetica,sans-se=
rif; font-size:8pt; color:#000000; }.unittests-error { font-family:arial,he=
lvetica,sans-serif; font-size:8pt; color:#FF0000; }.checkstyle-oddrow { bac=
kground-color:#CCCCCC }.checkstyle-data { font-family:arial,helvetica,sans-=
serif; font-size:8pt; color:#000000; }.checkstyle-sectionheader { backgroun=
d-color:#000066; font-family:arial,helvetica,sans-serif; font-size:10pt; co=
lor:#FFFFFF; }
</style>
</head><body>
<p>
<table width=3D"98%" border=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=
=3D"center"><tr><td class=3D"header-title">BUILD COMPLETE&nbsp;-&nbsp;     =
               build.62</td></tr><tr><td class=3D"header-data"><span class=
=3D"header-label">Date of build:&nbsp;</span>07/25/2004 00:15:45</td></tr><=
tr><td class=3D"header-data"><span class=3D"header-label">Time to build:&nb=
sp;</span>13 minutes 19 seconds</td></tr><tr><td class=3D"header-data"><spa=
n class=3D"header-label">Last changed:&nbsp;</span>07/24/2004 16:21:01</td>=
</tr><tr><td class=3D"header-data"><span class=3D"header-label">Last log en=
try:&nbsp;</span>The state of the object is checked in afterPropertiesSet()=
 as the use of this interceptor is intended via IoC container. Changed the =
test to accomodate this.</td></tr></table><p>
<table xmlns=3D"http://www.w3.org/TR/html4/strict.dtd" width=3D"98%" border=
=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=3D"center"/><p>
<p>
<table xmlns=3D"http://www.w3.org/TR/html4/strict.dtd" width=3D"98%" border=
=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=3D"center"><tr><td class=
=3D"compile-sectionheader">                        &nbsp;Errors/Warnings: (=
6)                    </td></tr><tr><td><pre class=3D"compile-error-data">N=
ote: Some input files use or override a deprecated API.<br class=3D"none"/>=
Note: Recompile with -deprecation for details.Note: /jteam/build/checkout/s=
pring/spring/mock/org/springframework/mock/web/MockHttpSession.java uses or=
 overrides a deprecated API.<br class=3D"none"/>Note: Recompile with -depre=
cation for details.<br class=3D"none"/>Note: Some input files use or overri=
de a deprecated API.<br class=3D"none"/>Note: Recompile with -deprecation f=
or details.<br class=3D"none"/></pre></td></tr></table><p>
<p>
<table width=3D"98%" border=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=
=3D"center"><tr><td colspan=3D"4" class=3D"unittests-sectionheader">       =
            &nbsp;Unit Tests: (1470)                </td></tr><tr><td><tabl=
e width=3D"98%" border=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=3D"c=
enter"><tr><td class=3D"unittests-data">                failure            =
</td><td width=3D"40%" class=3D"unittests-data">testHomePage</td><td width=
=3D"40%" class=3D"unittests-data">org.springframework.apptests.buildtest.Al=
lTests</td></tr></table></td></tr><tr></tr><tr><td colspan=3D"2">&nbsp;</td=
></tr><tr><td colspan=3D"4" class=3D"unittests-sectionheader">             =
       &nbsp;Unit Test Error Details:&nbsp;(1)                </td></tr><tr=
><td class=3D"unittests-data" colspan=3D"2">                Test:&nbsp;test=
HomePage</td></tr><tr><td class=3D"unittests-data" colspan=3D"2">          =
      Class:&nbsp;org.springframework.apptests.buildtest.AllTests</td></tr>=
<tr><td class=3D"unittests-data" colspan=3D"2">                Type: junit.=
framework.AssertionFailedError</td></tr><tr><td class=3D"unittests-data" co=
lspan=3D"2">                Message: Exception while testing URL http://loc=
alhost:13084/buildtest:java.io.IOException</td></tr><tr><td class=3D"unitte=
sts-error" colspan=3D"2"><pre>junit.framework.AssertionFailedError: Excepti=
on while testing URL http://localhost:13084/buildtest:java.io.IOException<b=
r>=09at org.springframework.apptests.buildtest.AllTests.testHomePage(Unknow=
n Source)<br>=09at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Meth=
od)<br>=09at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccess=
orImpl.java:39)<br>=09at sun.reflect.DelegatingMethodAccessorImpl.invoke(De=
legatingMethodAccessorImpl.java:25)<br></pre></td></tr><tr><td colspan=3D"2=
">&nbsp;</td></tr></table><p>
<table width=3D"98%" border=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=
=3D"center"><tr><td colspan=3D"4" class=3D"modifications-sectionheader">   =
                 &nbsp;Modifications since last build:&nbsp;               =
     (24)                </td></tr><tr class=3D"modifications-evenrow"><td =
class=3D"modifications-data">modified</td><td class=3D"modifications-data">=
dkopylenko</td><td class=3D"modifications-data">test/org/springframework/co=
ntext/EventPublicationInterceptorTests.java</td><td class=3D"modifications-=
data">The state of the object is checked in afterPropertiesSet() as the use=
 of this interceptor is intended via IoC container. Changed the test to acc=
omodate this.</td></tr><tr class=3D"modifications-oddrow"><td class=3D"modi=
fications-data">modified</td><td class=3D"modifications-data">robharrop</td=
><td class=3D"modifications-data">src/org/springframework/aop/framework/Cgl=
ib2AopProxy.java</td><td class=3D"modifications-data">Made Cglib Proxies Se=
rializable</td></tr><tr class=3D"modifications-evenrow"><td class=3D"modifi=
cations-data">modified</td><td class=3D"modifications-data">robharrop</td><=
td class=3D"modifications-data">test/org/springframework/aop/framework/Cgli=
bProxyTests.java</td><td class=3D"modifications-data">Made Cglib Proxies Se=
rializable</td></tr><tr class=3D"modifications-oddrow"><td class=3D"modific=
ations-data">modified</td><td class=3D"modifications-data">johnsonr</td><td=
 class=3D"modifications-data">src/org/springframework/aop/ClassFilter.java<=
/td><td class=3D"modifications-data">Pulled TrueClassFilter out of ClassFil=
ter interface to make it serializable</td></tr><tr class=3D"modifications-e=
venrow"><td class=3D"modifications-data">added</td><td class=3D"modificatio=
ns-data">johnsonr</td><td class=3D"modifications-data">src/org/springframew=
ork/aop/TrueClassFilter.java</td><td class=3D"modifications-data">Pulled Tr=
ueClassFilter out of ClassFilter interface to make it serializable</td></tr=
><tr class=3D"modifications-oddrow"><td class=3D"modifications-data">modifi=
ed</td><td class=3D"modifications-data">johnsonr</td><td class=3D"modificat=
ions-data">src/org/springframework/aop/support/ControlFlowPointcut.java</td=
><td class=3D"modifications-data">Made serializable</td></tr><tr class=3D"m=
odifications-evenrow"><td class=3D"modifications-data">modified</td><td cla=
ss=3D"modifications-data">johnsonr</td><td class=3D"modifications-data">tes=
t/org/springframework/transaction/interceptor/AbstractTransactionAspectTest=
s.java</td><td class=3D"modifications-data">Fixed test breakages, due to in=
correct construction of DefaultTransactionStatus</td></tr><tr class=3D"modi=
fications-oddrow"><td class=3D"modifications-data">modified</td><td class=
=3D"modifications-data">johnsonr</td><td class=3D"modifications-data">test/=
org/springframework/beans/ITestBean.java</td><td class=3D"modifications-dat=
a">Backed out making ITestBean extend Person--broke several tests that depe=
ndedon hierarchy</td></tr><tr class=3D"modifications-evenrow"><td class=3D"=
modifications-data">modified</td><td class=3D"modifications-data">johnsonr<=
/td><td class=3D"modifications-data">test/org/springframework/aop/framework=
/AbstractAopProxyTests.java</td><td class=3D"modifications-data">Backed out=
 making ITestBean extend Person--broke several tests that dependedon hierar=
chy</td></tr><tr class=3D"modifications-oddrow"><td class=3D"modifications-=
data">modified</td><td class=3D"modifications-data">johnsonr</td><td class=
=3D"modifications-data">test/org/springframework/aop/framework/JdkDynamicPr=
oxyTests.java</td><td class=3D"modifications-data">Backed out making ITestB=
ean extend Person--broke several tests that dependedon hierarchy</td></tr><=
tr class=3D"modifications-evenrow"><td class=3D"modifications-data">modifie=
d</td><td class=3D"modifications-data">johnsonr</td><td class=3D"modificati=
ons-data">/changelog.txt</td><td class=3D"modifications-data">Noted invocab=
leClone() method on ReflectiveMethodInvocation</td></tr><tr class=3D"modifi=
cations-oddrow"><td class=3D"modifications-data">added</td><td class=3D"mod=
ifications-data">johnsonr</td><td class=3D"modifications-data">test/org/spr=
ingframework/aop/interceptor/SerializableNopInterceptor.java</td><td class=
=3D"modifications-data">Added ProxyFactoryBean proxy serialization tests</t=
d></tr><tr class=3D"modifications-evenrow"><td class=3D"modifications-data"=
>modified</td><td class=3D"modifications-data">johnsonr</td><td class=3D"mo=
difications-data">test/org/springframework/beans/ITestBean.java</td><td cla=
ss=3D"modifications-data">Added ProxyFactoryBean proxy serialization tests<=
/td></tr><tr class=3D"modifications-oddrow"><td class=3D"modifications-data=
">added</td><td class=3D"modifications-data">johnsonr</td><td class=3D"modi=
fications-data">test/org/springframework/beans/Person.java</td><td class=3D=
"modifications-data">Added ProxyFactoryBean proxy serialization tests</td><=
/tr><tr class=3D"modifications-evenrow"><td class=3D"modifications-data">ad=
ded</td><td class=3D"modifications-data">johnsonr</td><td class=3D"modifica=
tions-data">test/org/springframework/beans/SerializablePerson.java</td><td =
class=3D"modifications-data">Added ProxyFactoryBean proxy serialization tes=
ts</td></tr><tr class=3D"modifications-oddrow"><td class=3D"modifications-d=
ata">modified</td><td class=3D"modifications-data">johnsonr</td><td class=
=3D"modifications-data">test/org/springframework/aop/framework/AbstractAopP=
roxyTests.java</td><td class=3D"modifications-data">Added ProxyFactoryBean =
proxy serialization tests</td></tr><tr class=3D"modifications-evenrow"><td =
class=3D"modifications-data">modified</td><td class=3D"modifications-data">=
johnsonr</td><td class=3D"modifications-data">test/org/springframework/aop/=
framework/JdkDynamicProxyTests.java</td><td class=3D"modifications-data">Ad=
ded ProxyFactoryBean proxy serialization tests</td></tr><tr class=3D"modifi=
cations-oddrow"><td class=3D"modifications-data">modified</td><td class=3D"=
modifications-data">johnsonr</td><td class=3D"modifications-data">test/org/=
springframework/aop/framework/ProxyFactoryBeanTests.java</td><td class=3D"m=
odifications-data">Added ProxyFactoryBean proxy serialization tests</td></t=
r><tr class=3D"modifications-evenrow"><td class=3D"modifications-data">adde=
d</td><td class=3D"modifications-data">johnsonr</td><td class=3D"modificati=
ons-data">test/org/springframework/aop/framework/serializationTests.xml</td=
><td class=3D"modifications-data">Added ProxyFactoryBean proxy serializatio=
n tests</td></tr><tr class=3D"modifications-oddrow"><td class=3D"modificati=
ons-data">modified</td><td class=3D"modifications-data">johnsonr</td><td cl=
ass=3D"modifications-data">src/org/springframework/aop/TruePointcut.java</t=
d><td class=3D"modifications-data">Added readResolve() method to TruePointc=
ut to ensure that equals() works onproxies after deserialization by enforci=
ng only one canonical instance of TruePointcut is found</td></tr><tr class=
=3D"modifications-evenrow"><td class=3D"modifications-data">modified</td><t=
d class=3D"modifications-data">johnsonr</td><td class=3D"modifications-data=
">test/org/springframework/aop/framework/AbstractAopProxyTests.java</td><td=
 class=3D"modifications-data">Added readResolve() method to TruePointcut to=
 ensure that equals() works onproxies after deserialization by enforcing on=
ly one canonical instance of TruePointcut is found</td></tr><tr class=3D"mo=
difications-oddrow"><td class=3D"modifications-data">modified</td><td class=
=3D"modifications-data">johnsonr</td><td class=3D"modifications-data">src/o=
rg/springframework/aop/framework/JdkDynamicAopProxy.java</td><td class=3D"m=
odifications-data">logger now static to avoid need for serialization tricks=
</td></tr><tr class=3D"modifications-evenrow"><td class=3D"modifications-da=
ta">modified</td><td class=3D"modifications-data">dkopylenko</td><td class=
=3D"modifications-data">src/org/springframework/transaction/interceptor/Tra=
nsactionAspectSupport.java</td><td class=3D"modifications-data">Does not wr=
ite the log message "Invoking commit for transaction on..." if a target obj=
ect participates in existing transaction to avoid user confusion</td></tr><=
tr class=3D"modifications-oddrow"><td class=3D"modifications-data">modified=
</td><td class=3D"modifications-data">dkopylenko</td><td class=3D"modificat=
ions-data">src/org/springframework/context/event/EventPublicationIntercepto=
r.java</td><td class=3D"modifications-data">Added back the initialization c=
heck via InitializingBean</td></tr></table><p>
<table width=3D"98%" border=3D"0" cellspacing=3D"0" cellpadding=3D"2" align=
=3D"center"><tr><td class=3D"distributables-sectionheader">                =
        &nbsp;Deployments by this build:&nbsp;(8)                    </td><=
/tr><tr><td class=3D"distributables-data">Building jar: /jteam/build/checko=
ut/spring/spring/dist/spring.jar</td></tr><tr class=3D"distributables-oddro=
w"><td class=3D"distributables-data">Building war: /jteam/build/checkout/sp=
ring/spring/autobuilds/apps/buildtest/dist/buildtest.war</td></tr><tr><td c=
lass=3D"distributables-data">Building war: /jteam/build/checkout/spring/spr=
ing/autobuilds/apps/buildtest/dist/buildtest.war</td></tr><tr class=3D"dist=
ributables-oddrow"><td class=3D"distributables-data">Building war: /jteam/b=
uild/checkout/spring/spring/autobuilds/apps/buildtest/dist/buildtest.war</t=
d></tr><tr><td class=3D"distributables-data">Building jar: /jteam/build/che=
ckout/spring/spring/autobuilds/apps/jpetstore/war/WEB-INF/lib/jpetstore.jar=
</td></tr><tr class=3D"distributables-oddrow"><td class=3D"distributables-d=
ata">Building war: /jteam/build/checkout/spring/spring/autobuilds/apps/jpet=
store/dist/jpetstore.war</td></tr><tr><td class=3D"distributables-data">Bui=
lding jar: /jteam/build/checkout/spring/spring/autobuilds/apps/jpetstore/wa=
r/WEB-INF/lib/jpetstore.jar</td></tr><tr class=3D"distributables-oddrow"><t=
d class=3D"distributables-data">Building war: /jteam/build/checkout/spring/=
spring/autobuilds/apps/jpetstore/dist/jpetstore.war</td></tr></table>
</body></html>

Re: [Springframework-developer] Final preparations for 1.1 RC1

[Matt R. <li...@ra...>]

On Jul 24, 2004, at 1:28 PM, j=FCrgen h=F6ller [werk3AT] wrote:
>
> So the remaining issue are the names: "springBind" (default HTML=20
> escape setting) and "springBindEscaped" (explicitly specified HTML=20
> escape setting)?

Using these names sounds good to me.

Matt

Re: [Springframework-developer] Final preparations for 1.1 RC1

[<jue...@we...>]

Sure - I still recommend to specify a brief "requestContextAttribute" =
name like "rc" for custom usage, though.
=20
The "springMacroRequestContext" should rather be considered an =
implementation detail of the Spring-provided macros, to be activated by =
the "exposeSpringMacroHelpers" flag.
=20
Juergen
=20

________________________________

Von: spr...@li... im Auftrag =
von Matt Raible
Gesendet: Sa 24.07.2004 20:46
An: spr...@li...
Betreff: Re: [Springframework-developer] Final preparations for 1.1 RC1




On Jul 24, 2004, at 7:12 AM, j=FCrgen h=F6ller [werk3AT] wrote:
> Note that the "springMacroRequestContext" is not really meant to be
> accessed directly; it is mainly meant to be used by Spring-provided
> macros. If you want to use a RequestContext in your own expressions,
> always specify the "requestContextAttribute" accordingly. We should
> highlight that in the docs.
>

Right, but it actually does work if you use it.  To me, setting the
requestContextAttribute value seems to simply provide an alias for it.=20
Is it doing more than that?

>> I would make sure and document that the name
>> "springMacroRequestContext"
>> can be overridden by specifying a "requestContextAttribute" property.
>> It's much easier to write $rc.getMessage() than
>> $springMacroRequestContext.getMessage(). ;-)
>



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

Re: [Springframework-developer] Final preparations for 1.1 RC1

[<jue...@we...>]

As far I see, there is no such overloading of macros in Velocity: If we =
have different parameters, we need to define a separate macro.
=20
Even in FreeMarker, there's just the option to define a fixed default =
for optional parameters: no support for simply "not specified" (falling =
back to the default HTML escape setting in our case). That's why I =
suggest to use a different macro name there too, analogous to Velocity.
=20
So the remaining issue are the names: "springBind" (default HTML escape =
setting) and "springBindEscaped" (explicitly specified HTML escape =
setting)?
=20
Juergen
=20

________________________________

Von: spr...@li... im Auftrag =
von Matt Raible
Gesendet: Sa 24.07.2004 20:44
An: spr...@li...
Betreff: Re: [Springframework-developer] Final preparations for 1.1 RC1



It would be nice if the method name didn't have to change and we could
just control the rendering of the variable.  Probably not possible, but
something similar to JSP 2.0 where you use ${status.errorMessage} to
print out escaped XML and <c:out value=3D"${status.errorMessage}"
escapeXml=3D"false"/> if you want to print HTML.

I don't see a problem with having two separate methods: springBind and
springBindEscaped - just as long as its documented.  Though it might be
nicer to have #springBind(path) and #springBind(path false) - where you
have to use two parameters to escape XML.

Matt

On Jul 24, 2004, at 10:19 AM, j=FCrgen h=F6ller [werk3AT] wrote:

> Actually, the same issue occurs with FreeMarker too: We specify
> "escape=3Dfalse" there, so do not participate in any default. This =
needs
> to be addressed: We should allow to work with the defaultHtmlEscape
> value here too.
>
> While we could introduce a further "escape" value for "use default",
> offering a special method signature for it, it's probably clearer two
> offer two FreeMarker macros: "spring:bind" which never takes an
> "escape" parameter (i.e. always uses the default), and
> "spring:bindEscaped" which takes a required "escape" parameter. This
> would be analogous to Velocity again then.
>
> However, there's still the naming issue: "bind" uses the default HTML
> escape setting. But how to the name the version that takes an explicit
> HTML escape parameter? Is there a better name than "bindEscaped"?
>
> This is easier with JSP tags, where there can be a true tag-internal
> default if the "setHtmlEscape" method was not called... As far as I
> can see, even FreeMarker just allows for an explicitly specified
> default in the macro definition: It cannot seamlessly invoke either
> RequestContext.createBindStatus(path) respectively
> RequestContext.createBindStatus(path, htmlEscape), in our concrete
> case.
>
> Juergen
>
>
> ________________________________
>
> Von: spr...@li... im Auftrag
> von j=FCrgen h=F6ller [werk3AT]
> Gesendet: Sa 24.07.2004 15:12
> An: spr...@li...
> Betreff: Re: [Springframework-developer] Final preparations for 1.1 =
RC1
>
>
>
> Darren,
>
> Oops, I forgot to discuss that one: The reason why I removed the
> htmlEscape property from the "springBind" macro is to be able to
> participate in a RequestContext-level default, e.g. set via
> springMacroRequestContext.setDefaultHtmlEscape(true). Note that the
> createBindStatus invocation on RequestContext uses the
> defaultHtmlEscape flag then.
>
> I've just adapted the RequestContext implementation a bit further to
> also be able to participate in a ServletContext-level default, just
> like our JSP tags can, i.e. a "defaultHtmlEscape" context-param in
> web.xml. JSP tags and Velocity/FreeMarker macros can then even share
> such an application-wide default. I'll commit this promptly.
>
> Actually, the "springBindEscaped" macro should rather take an explicit
> htmlEscape parameter, to be able to override defaultHtmlEscape=3Dtrue =
to
> false for a specific macro. Hmm, what name could we use for this?
> "springBindWithExplicitEscape" is clearly too long... "springBind"
> with overloaded signature is not possible in Velocity... maybe still
> "springBindEscaped", but just with an explicit parameter?
>
>
> Matt,
>
> Note that the "springMacroRequestContext" is not really meant to be
> accessed directly; it is mainly meant to be used by Spring-provided
> macros. If you want to use a RequestContext in your own expressions,
> always specify the "requestContextAttribute" accordingly. We should
> highlight that in the docs.
>
>
> Juergen
>
>
> ________________________________
>
> Von: spr...@li... im Auftrag
> von Darren Davison
> Gesendet: Sa 24.07.2004 10:18
> An: spr...@li...
> Betreff: Re: [Springframework-developer] Final preparations for 1.1 =
RC1
>
>
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Saturday 24 July 2004 01:09, Matt Raible wrote:
>> I tried this out today and it works well.  The only thing I saw that
>> might cause confusion for users is there are 2 macros for Velocity
>> (#springBind and #springBindEscaped) - whereas FreeMarker has one w/
>> an
>> "escape" parameter.  I imagine that folks using FreeMarker might be
>> migrating from Velocity, so making the macros consistent might be
>> helpful.  Who knows - just a thought.
>
> FreeMarker has a default value of false for the 2nd param so you only
> need
> supply it to override it.  Velocity can't do that.
>
> The other options for Velocity are:
>
>  * always supply the second parameter in every call to springBind
>
>  * use a globally scoped, well-known variable defined in user
> templates.
>
>
> I prefer personally to always require the additional parameter.  It's
> more
> consistent with FM and won't cause user templates to break if they
> migrate
> them to FM using the automatic conversion tool they have available.
>
> What do you think?
>
>
>> I would make sure and document that the name
>> "springMacroRequestContext"
>> can be overridden by specifying a "requestContextAttribute" property.
>> It's much easier to write $rc.getMessage() than
>> $springMacroRequestContext.getMessage(). ;-)
>
> I will, thanks.
>
> - --
> Darren Davison
> Public Key: http://www.davison.uk.net/pages/key.htm
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.4 (GNU/Linux)
>
> iD8DBQFBAhtIKLMLAN01aw0RAisgAKCfjnl6dzgkdQ91o9lUrUvtd9RGWQCfRJNq
> cn71Z/8ovFjaDLQRxtBwTfo=3D
> =3Dlvg2
> -----END PGP SIGNATURE-----
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=CCk
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

Re: [Springframework-developer] Final preparations for 1.1 RC1

[Matt R. <li...@ra...>]

On Jul 24, 2004, at 7:12 AM, j=FCrgen h=F6ller [werk3AT] wrote:
> Note that the "springMacroRequestContext" is not really meant to be=20
> accessed directly; it is mainly meant to be used by Spring-provided=20
> macros. If you want to use a RequestContext in your own expressions,=20=

> always specify the "requestContextAttribute" accordingly. We should=20
> highlight that in the docs.
>

Right, but it actually does work if you use it.  To me, setting the=20
requestContextAttribute value seems to simply provide an alias for it. =20=

Is it doing more than that?

>> I would make sure and document that the name=20
>> "springMacroRequestContext"
>> can be overridden by specifying a "requestContextAttribute" property.
>> It's much easier to write $rc.getMessage() than
>> $springMacroRequestContext.getMessage(). ;-)
>

Re: [Springframework-developer] Final preparations for 1.1 RC1

[Matt R. <li...@ra...>]

It would be nice if the method name didn't have to change and we could=20=

just control the rendering of the variable.  Probably not possible, but=20=

something similar to JSP 2.0 where you use ${status.errorMessage} to=20
print out escaped XML and <c:out value=3D"${status.errorMessage}"=20
escapeXml=3D"false"/> if you want to print HTML.

I don't see a problem with having two separate methods: springBind and=20=

springBindEscaped - just as long as its documented.  Though it might be=20=

nicer to have #springBind(path) and #springBind(path false) - where you=20=

have to use two parameters to escape XML.

Matt

On Jul 24, 2004, at 10:19 AM, j=FCrgen h=F6ller [werk3AT] wrote:

> Actually, the same issue occurs with FreeMarker too: We specify=20
> "escape=3Dfalse" there, so do not participate in any default. This =
needs=20
> to be addressed: We should allow to work with the defaultHtmlEscape=20
> value here too.
>
> While we could introduce a further "escape" value for "use default",=20=

> offering a special method signature for it, it's probably clearer two=20=

> offer two FreeMarker macros: "spring:bind" which never takes an=20
> "escape" parameter (i.e. always uses the default), and=20
> "spring:bindEscaped" which takes a required "escape" parameter. This=20=

> would be analogous to Velocity again then.
>
> However, there's still the naming issue: "bind" uses the default HTML=20=

> escape setting. But how to the name the version that takes an explicit=20=

> HTML escape parameter? Is there a better name than "bindEscaped"?
>
> This is easier with JSP tags, where there can be a true tag-internal=20=

> default if the "setHtmlEscape" method was not called... As far as I=20
> can see, even FreeMarker just allows for an explicitly specified=20
> default in the macro definition: It cannot seamlessly invoke either=20
> RequestContext.createBindStatus(path) respectively=20
> RequestContext.createBindStatus(path, htmlEscape), in our concrete=20
> case.
>
> Juergen
>
>
> ________________________________
>
> Von: spr...@li... im Auftrag=20=

> von j=FCrgen h=F6ller [werk3AT]
> Gesendet: Sa 24.07.2004 15:12
> An: spr...@li...
> Betreff: Re: [Springframework-developer] Final preparations for 1.1 =
RC1
>
>
>
> Darren,
>
> Oops, I forgot to discuss that one: The reason why I removed the=20
> htmlEscape property from the "springBind" macro is to be able to=20
> participate in a RequestContext-level default, e.g. set via=20
> springMacroRequestContext.setDefaultHtmlEscape(true). Note that the=20
> createBindStatus invocation on RequestContext uses the=20
> defaultHtmlEscape flag then.
>
> I've just adapted the RequestContext implementation a bit further to=20=

> also be able to participate in a ServletContext-level default, just=20
> like our JSP tags can, i.e. a "defaultHtmlEscape" context-param in=20
> web.xml. JSP tags and Velocity/FreeMarker macros can then even share=20=

> such an application-wide default. I'll commit this promptly.
>
> Actually, the "springBindEscaped" macro should rather take an explicit=20=

> htmlEscape parameter, to be able to override defaultHtmlEscape=3Dtrue =
to=20
> false for a specific macro. Hmm, what name could we use for this?=20
> "springBindWithExplicitEscape" is clearly too long... "springBind"=20
> with overloaded signature is not possible in Velocity... maybe still=20=

> "springBindEscaped", but just with an explicit parameter?
>
>
> Matt,
>
> Note that the "springMacroRequestContext" is not really meant to be=20
> accessed directly; it is mainly meant to be used by Spring-provided=20
> macros. If you want to use a RequestContext in your own expressions,=20=

> always specify the "requestContextAttribute" accordingly. We should=20
> highlight that in the docs.
>
>
> Juergen
>
>
> ________________________________
>
> Von: spr...@li... im Auftrag=20=

> von Darren Davison
> Gesendet: Sa 24.07.2004 10:18
> An: spr...@li...
> Betreff: Re: [Springframework-developer] Final preparations for 1.1 =
RC1
>
>
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Saturday 24 July 2004 01:09, Matt Raible wrote:
>> I tried this out today and it works well.  The only thing I saw that
>> might cause confusion for users is there are 2 macros for Velocity
>> (#springBind and #springBindEscaped) - whereas FreeMarker has one w/=20=

>> an
>> "escape" parameter.  I imagine that folks using FreeMarker might be
>> migrating from Velocity, so making the macros consistent might be
>> helpful.  Who knows - just a thought.
>
> FreeMarker has a default value of false for the 2nd param so you only=20=

> need
> supply it to override it.  Velocity can't do that.
>
> The other options for Velocity are:
>
>  * always supply the second parameter in every call to springBind
>
>  * use a globally scoped, well-known variable defined in user=20
> templates.
>
>
> I prefer personally to always require the additional parameter.  It's=20=

> more
> consistent with FM and won't cause user templates to break if they=20
> migrate
> them to FM using the automatic conversion tool they have available.
>
> What do you think?
>
>
>> I would make sure and document that the name=20
>> "springMacroRequestContext"
>> can be overridden by specifying a "requestContextAttribute" property.
>> It's much easier to write $rc.getMessage() than
>> $springMacroRequestContext.getMessage(). ;-)
>
> I will, thanks.
>
> - --
> Darren Davison
> Public Key: http://www.davison.uk.net/pages/key.htm
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.4 (GNU/Linux)
>
> iD8DBQFBAhtIKLMLAN01aw0RAisgAKCfjnl6dzgkdQ91o9lUrUvtd9RGWQCfRJNq
> cn71Z/8ovFjaDLQRxtBwTfo=3D
> =3Dlvg2
> -----END PGP SIGNATURE-----
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=3Dick
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_idG21&alloc_id=10040&op=CCk
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer