#166 Bug in example of applying overconstrained model detection

[Michael Hucka]

This bug was reported to sbml-team by Andreas Draeger and his student Alexander Doerr:

SBML L2v2, L2v3, L2v4, in the appendix describing the algorithm for detecting overconstrained models, the example states that one has to generate a vertex for compartment "C" because of constant="false". But in the example model given there, there is no such value set for compartment "C". The description of a compartment stats that the default value of constant is true thus there should not be a vertex for compartment "C".

This bug was caught for L3v1 RC1 by Sven Sahle, but we never filed issue reports for the relevant L2 specifications.

I believe what we have to do is treat in the same way all the L2 specifications that have this issue. The solution is simply modify the specifications to remove the compartment C from the description of the application of the algorithm, which is exactly what was done for the L3v1 RC1 specification.

[Frank Bergmann]

I agree with the proposed change and that it should be done.

[Lucian Smith]

I agree with the proposed change and that it should be done.

[Sven Sahle]

I am accepting this issue as valid.

[Lucian Smith]

I agree with the proposed change and that it should be done.

[Darren Wilkinson]

I agree with the proposed change and that it should be done.

[Sven Sahle]

I agree with the proposed change and that it should be done.

[Sarah Keating]

I agree with the proposed change and that it should be done.

[Chris Myers]

I am accepting this issue as valid.

[Nicolas Le Novère]

This looks like this was accepted.

[Lucian Smith]

Fixed in SVN for L2v5, and will be part of the forthcoming release of that specification.