#382 spatial package reports incorrect line numbers on errors

[GerardW]

spatial - experimental
Library correctly reports many SBML errors as defined by the spatial proposal at the time of release, but on incorrect line numbers. (e.g. in one model, an error on a CompartmentMapping on line 125 reported line 179, which contained a species. Many of the calls to logPackageError use default (0,0) values for the line and column parameters. I've added the line / column numbers on some of the calls (patch attached).

[Sarah Keating]

Hi Gerard

Thanks for the report - you in fact spotted a bug in our generation code !

Just FYI: normally we do not worry at all about validation until we have a stabilised spec. The errors being reported at present are those that can be established when reading spatial - i.e. are required attributes present/are they the correct type/ are the attributes actually valid attribute name etc and as you have no doubt noticed they all report the same error number. Ultimately these will correspond to a list of validation rules from the specification.

Thanks

Sarah

[Frank Bergmann]

This is in SVN now ...

thanks
Frank