#377 exported symbols on Windows

[Andy Somogyi]

Many of the sbml Validator objects are missing the LIBSBML_EXTERN macro so they don't export properly on Windows, and unfortunately, I have to support Windows.

The list of changes I made to build and run properly on Windows is in this commit:
https://github.com/sys-bio/roadrunner/commit/0ac0ac166473649ec7421dea4030f54f50f3fccd

[Andy Somogyi]

I am, however it looks like I can enable / disable specific checks with

SBMLDocument::setConsistencyChecks and then call SBMLDocument::checkConsistency.

I'll change my code to perform validation this way.

So, go ahead and close this ticket.

thanks

On Sep 4, 2014, at 4:40 AM, Sarah Keating wrote:

Hi Andy

Could you clarify whether you are in fact using the different validators explicitly ? We have never had any issues with these being internal and no one has asked about using them - but if you are the first it would be great to know your use case.

Thanks

Sarah

[libsbml:#377] exported symbols on Windows

Status: open
Version: libSBML-5.10.2
Priority:
Created: Mon Aug 25, 2014 05:01 PM UTC by Andy Somogyi
Last Updated: Tue Aug 26, 2014 06:24 AM UTC
Owner: nobody

Many of the sbml Validator objects are missing the LIBSBML_EXTERN macro so they don't export properly on Windows, and unfortunately, I have to support Windows.

The list of changes I made to build and run properly on Windows is in this commit:
https://github.com/sys-bio/roadrunner/commit/0ac0ac166473649ec7421dea4030f54f50f3fccd

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/sbml/libsbml/377/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

[Sarah Keating]

Thanks Andy

[Frank Bergmann]

NOTICE NOTICE NOTICE
The comments associated with this ticket were lost in late 2014.
The SBML Team manually recovered the comments. The text is appended below.
NOTICE NOTICE NOTICE

---

Comment By: Frank Bergmann (fbergmann)
Date: 2014-08-26 06:24

The validators you found were meant to be internal. They are also not exposed through the language bindings. The reason for this is that these validators have been wrapped in the:

SBMLInternalValidator

And they are applied automatically in checkConsistency, based on what the validation flags are on the document.

The only validators exported are the SBMLValidator (baseclass) so applications can implement new validators, SBMLInternalValidator wrapping all previous validators and SBMLExternalValidator for invoking external validation.

I can not imagine a use case where all other validation classes would be needed (or helpful) when called externally. But i will discuss this with Sarah when she is back.

All the best
Frank

---

Comment By: Sarah Keating (sarahkeating)
Date: 2014-09-04 08:40

Hi Andy

Could you clarify whether you are in fact using the different validators explicitly ? We have never had any issues with these being internal and no one has asked about using them - but if you are the first it would be great to know your use case.

Thanks

Sarah

---

Comment By: Andy Somogyi (asomogyi)
Date: 2014-09-04 12:31

I am, however it looks like I can enable / disable specific checks with

SBMLDocument::setConsistencyChecks and then call SBMLDocument::checkConsistency.

I'll change my code to perform validation this way.

So, go ahead and close this ticket.

thanks

On Sep 4, 2014, at 4:40 AM, Sarah Keating wrote:

Hi Andy

Could you clarify whether you are in fact using the different validators explicitly ? We have never had any issues with these being internal and no one has asked about using them - but if you are the first it would be great to know your use case.

Thanks

Sarah

[libsbml:#377] exported symbols on Windows

Status: open
Version: libSBML-5.10.2
Priority:
Created: Mon Aug 25, 2014 05:01 PM UTC by Andy Somogyi
Last Updated: Tue Aug 26, 2014 06:24 AM UTC
Owner: nobody

Many of the sbml Validator objects are missing the LIBSBML_EXTERN macro so they don't export properly on Windows, and unfortunately, I have to support Windows.

The list of changes I made to build and run properly on Windows is in this commit:
https://github.com/sys-bio/roadrunner/commit/0ac0ac166473649ec7421dea4030f54f50f3fccd

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/sbml/libsbml/377/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

---

Comment By: Sarah Keating (sarahkeating)
Date: 2014-09-04 14:57

Thanks Andy