Menu

#375 cmake uninstall

libSBML-5.10.2
closed
nobody
None
2015-05-01
2014-08-23
No

The CMakeLists.txt in 5.10.2 adds an 'uninstall' target.

This is fine, except that it frequently conflicts with other CMake files when this is used as a sub-project.

The quick and easy fix is to re-name this target as 'libsbml-uninstall'

I changed the

ADD_CUSTOM_TARGET(uninstall

to

ADD_CUSTOM_TARGET(libsbml-uninstall

on line 1081 of the CMakeLists.txt and it works fine.

Related

libSBML: #375

Discussion

  • Frank Bergmann

    Frank Bergmann - 2015-01-20

    NOTICE NOTICE NOTICE
    The comments associated with this ticket were lost in late 2014.
    The SBML Team manually recovered the comments. The text is appended below.
    NOTICE NOTICE NOTICE


    Comment By: Frank Bergmann (fbergmann)
    Date: 2014-08-26 06:17

    Hello Andy,

    the uninstall target is primarily intended for those, that previously ran 'make uninstall' after a gnumake configuration, and found the functionality lacking. Renaming the target will not help this primary usecase.

    The best I could offer you would be to allow the target to be renamed in case that the libSBML project is not the principle project. That should be the case whenever the CMAKE_SOURCE_DIR differs from the ROOT dir.

    would that help?


    Comment By: Andy Somogyi (asomogyi)
    Date: 2014-08-26 06:45

    I think that should work.

    If its the primary, there is no reason to change it, as it only causes issues when it conflicts with other sub-projects.

    On Aug 26, 2014, at 2:17 AM, Frank Bergmann wrote:

    Hello Andy,

    the uninstall target is primarily intended for those, that previously ran 'make uninstall' after a gnumake configuration, and found the functionality lacking. Renaming the target will not help this primary usecase.

    The best I could offer you would be to allow the target to be renamed in case that the libSBML project is not the principle project. That should be the case whenever the CMAKE_SOURCE_DIR differs from the ROOT dir.

    would that help?

    [libsbml:#375] cmake uninstall

    Status: open
    Version: libSBML-5.10.2
    Priority:
    Created: Sat Aug 23, 2014 08:21 PM UTC by Andy Somogyi
    Last Updated: Sat Aug 23, 2014 08:21 PM UTC
    Owner: nobody

    The CMakeLists.txt in 5.10.2 adds an 'uninstall' target.

    This is fine, except that it frequently conflicts with other CMake files when this is used as a sub-project.

    The quick and easy fix is to re-name this target as 'libsbml-uninstall'

    I changed the

    ADD_CUSTOM_TARGET(uninstall

    to

    ADD_CUSTOM_TARGET(libsbml-uninstall

    on line 1081 of the CMakeLists.txt and it works fine.

    Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/sbml/libsbml/375/

    To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

     

    Related

    libSBML: #375

  • Sarah Keating

    Sarah Keating - 2015-05-01
    • status: open --> closed
    • Priority: -->
     
  • Sarah Keating

    Sarah Keating - 2015-05-01

    I am closing this as it has been noted on Pivotal Tracker but is a low priority.

     

Log in to post a comment.