Re: [Roundup-users] Reactor functions get all old values, not just changed old values. (possible breaking change)

[John R. <ro...@ie...>]

Hi Ralf:

I have opened https://issues.roundup-tracker.org/issue2551433

My plan unless we get more feedback (hello anybody besides Ralf??) is
to force upgrading of
reactors by changing oldvalues to contain the values only for
properties that have changed.

-- rouilj

On Mon, Oct 5, 2026 at 12:18 PM Ralf Schlatterbeck <rs...@ru...> wrote:
>
> On Mon, Oct 05, 2026 at 10:52:44AM -0400, John Rouillard wrote:
> > > > is ok but a bare:
> > > >    oldvalues['some_unchanged_prop']
> > > > will fail if I strip unchanged properties.
> ...
> > I see three options:
> >
> >   1) update the docs to indicate the current code
> >   2) change the code to only include changed database items and
> > everybody needs to audit their reactors.
> >   3) provide two paths with/without unchanged props and a switch(in
> > config.ini or interfaces.py) to remove
> >        unchanged props (default is to include them).
> >
> > 1 is easiest, but I really want "'unchanged prop' in oldvalues" to
> > work because it reduces cognitive load by matching
> >     auditors and eliminates unneeded database accesses to compare values.
> >
> > 2 is preferred but makes upgrading more difficult.
> >
> > 3 adds another switch that most people won't know about, clutters
> > config.ini and increases testing burden.
>
> I would prefer 2)
> In the past we have often had some docs on upgrading.
>
> I *think* that I would be one of the persons with lots of new reactors.
> And I think it is doable: I can simply grep for oldvalues (I'm pretty
> sure I've never called this parameter of my reactors differently) and
> check all occurrences.
>
> And since nobody complained so far that the docs are wrong on the
> contents of oldvalues, I *think* that not too many people have written
> their own reactors using that feature...
>
> And future reactors can become easier...
>
> Kind regards
> Ralf
> --
> Dr. Ralf Schlatterbeck                  Tel:   +43/2243/26465-16
> Open Source Consulting                  www:   www.runtux.com
> Reichergasse 131, A-3411 Weidling       email: of...@ru...