phppgadmin-devel — For Developers Only

[ppa-dev] What to do about bytea bug...

[Robert T. <ro...@xz...>]

I spoke with ioguix a few days ago on irc about releasing a new
version of PPA, and that I had hoped to take another crack at solving
the bytea problem. For those not familiar with it, the quick summary
is that if you attempt to insert or edit bytea data via PPA, it will
modify the data so that essentially you end up with corrupted data.
Unfortunately, the way PPA works, just editing another field of a
bytea row will also cause PPA to also update the bytea column, as we
update all values for a given row when any value is updated.

Now, I've tried a few different methods of trying to fix this, but
could come up with no working set of escape and unescape options that
would prevent this. (And as a note, it's made trickier because you
have to support multiple encoding formats, though I came up with
workarounds for that). At this point, I'm somewhat of the opinion it
can't be done. Now, I'd be happy for someone else to take a look and
show me the error of my ways, but barring that, I've spent the last
few days trying to come up with a work-around.

My initial idea was to just not allow editing of bytea data via PPA,
but I've run into some problems there as well, for example, if you
don't allow inserts of bytea data, then anyone who has a not null
bytea column would never be able to insert row data into their table.
That doesn't really seem like a good option.

So, barring someone figuring out a way to make this actually work, we
need to come up with a better work-around, or I guess just release the
next version with his bug in place. FWIW, this bug is in the current
stable version of PPA, so we're not making things worse, but it's kind
of frightening to know we have a subtle data corrupting behavior in
PPA.

Thoughts?

--
Robert Treat
conjecture: xzilla.net
consulting: omniti.com

Re: [ppa-dev] Database designer plugin

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 07/01/2013 20:29, Diorman Colmenares wrote:
> Hello to everyone!

Hello Diorman !

> I have been working on the development of this project using the
> version of phpPgAdmin that has the plugin architecture. I would
> like to get some feedback about the functionalities developed so
> far as well as features you might think are needed to be included.

You better want to use the official -dev branch of PPA instead of the
one of Leonardo you describe in your README. The plugin arche has been
commited in the official release, but with a lot of fixes and changes.

See plugin included there if you need some examples.

Thank you, I'm sure your plugin will be a must-have at some point !!

> 
> This version lacks both REVERSE ENGINEER and FORWARD ENGINEER
> features. I will add these functionalities soon as this project is
> quite useless without them. This version is just for testing
> purpose.
> 
> As you will notice, you must run some SQL commads to get the
> plugin working, and that is one thing I would like to discuss
> thoroughly. Do you think that creating a PostgreSQL database is the
> best way to store the diagrams?. I have been thinking about using
> SQLite instead in order to get the plugin working  "out of the
> box". I would like you to give me some opinions about the possible
> advantages or disadvanges either option might bring along. For
> instance, using the PostgreSQL database makes difficult things like
> preventing users from querying diagrams they are not suppose to
> see. On the other hand, using SQLite some people could say that is
> rather contradictory having to install/enable a php extension of
> another database engine to be able to use a tool meant to manage
> PostgreSQL. Though I don't think that is a big deal, the final 
> decision is up to all of you.
> 
> You can follow the installation instructions from the README.md
> file here -> https://github.com/diorman/DBDesigner ... and you can
> download the project from the links below (tar.gz) -->
> https://github.com/diorman/DBDesigner/archive/1.0-BETA.tar.gz (zip)
> ------> https://github.com/diorman/DBDesigner/archive/1.0-BETA.zip
> 
> Thanks in advance for your feedback and if you have any doubt or
> problem don't hesitate to contact me
> 
> Cheers!
> 

Re: [ppa-dev] Database designer plugin

[Diorman C. <dex...@gm...>]

Hi,

Thanks for your comments. If you have time please review the current
version of the plugin
https://github.com/diorman/DBDesigner/archive/1.1-BETA.tar.gz all the basic
functionality is done.

Cheers

Re: [ppa-dev] Database designer plugin

[Lou P. <lou...@co...>]

Diorman,

Looks like a super project! And thanks for your hard work. (haven't yet had a chance to review...)

But my gut sense on your question is: Use PostgreSQL!

I'd agree that using SQLite wouldn't be a huge barrier in terms of setting it up as the engine back end for your project, but definitely would win on 'weird factor'. And, though I didn't quite understand this: 'For instance, using the PostgreSQL database makes difficult things like preventing users from querying diagrams they are not suppose to see.', it sounds like you're thinking about things which can be easily handled with PostgreSQL's very robust privileges - or in schemas, for that matter.

Tks again for your efforts. Though I haven't used phpPgAdmin in some time, we do get frequent requests from cleints for more robust 'designer/architect' functionality.

Lou Picciano

----- Original Message -----
From: Diorman Colmenares <dex...@gm...>
To: phppgadmin-devel <php...@li...>
Sent: Mon, 07 Jan 2013 19:29:10 -0000 (UTC)
Subject: [ppa-dev] Database designer plugin

Hello to everyone!
I have been working on the development of this project using the version of phpPgAdmin that has the plugin architecture. I would like to get some feedback about the functionalities developed so far as well as features you might think are needed to be included.
This version lacks both REVERSE ENGINEER and FORWARD ENGINEER features. I will add these functionalities soon as this project is quite useless without them. This version is just for testing purpose.
As you will notice, you must run some SQL commads to get the plugin working, and that is one thing I would like to discuss thoroughly. Do you think that creating a PostgreSQL database is the best way to store the diagrams?. I have been thinking about using SQLite instead in order to get the plugin working  "out of the box". I would like you to give me some opinions about the possible advantages or disadvanges either option might bring along. For instance, using the PostgreSQL database makes difficult things like preventing users from querying diagrams they are not suppose to see. On the other hand, using SQLite some people could say that is rather contradictory having to install/enable a php extension of another database engine to be able to use a tool meant to manage PostgreSQL. Though I don't think that is a big deal, the final decision is up to all of you.
You can follow the installation instructions from the README.md file here -> https://github.com/diorman/DBDesigner ... and you can download the project from the links below(tar.gz) --> https://github.com/diorman/DBDesigner/archive/1.0-BETA.tar.gz(zip) ------> https://github.com/diorman/DBDesigner/archive/1.0-BETA.zip
Thanks in advance for your feedback and if you have any doubt or problem don't hesitate to contact me
Cheers!

Re: [ppa-dev] Database designer plugin

[Karl O. P. <ko...@me...>]

Hi Diorman,

You might the irc channel (#phppgadmin on irc.freenode.net)
to be a useful way to get feedback.

I don't know anything about the plugin architecture, but
I have thought that it would be useful to have someplace
in pg where things could be stored.   Reports come to
mind.  Without really thinking any further I'd be inclined
to have a db for ppa.  An alternative would be a schema
in every db, but that sounds clunky.  Given that we know
that pg is installed using sqlite seems like it would
require additional administrative headache.

No matter what permission management is going to be
annoying.

No db, then can't use the feature....

Of course I speak for no one but myself.

On 01/07/2013 01:29:10 PM, Diorman Colmenares wrote:
> Hello to everyone!
> 
> I have been working on the development of this project using the
> version of
> phpPgAdmin that has the plugin architecture. I would like to get some
> feedback about the functionalities developed so far as well as
> features you
> might think are needed to be included.
> 
> This version lacks both REVERSE ENGINEER and FORWARD ENGINEER
> features. I
> will add these functionalities soon as this project is quite useless
> without them. This version is just for testing purpose.
> 
> As you will notice, you must run some SQL commads to get the plugin
> working, and that is one thing I would like to discuss thoroughly. Do
> you
> think that creating a PostgreSQL database is the best way to store 
> the
> diagrams?. I have been thinking about using SQLite instead in order 
> to
> get
> the plugin working  "out of the box". I would like you to give me 
> some
> opinions about the possible advantages or disadvanges either option
> might
> bring along. For instance, using the PostgreSQL database makes
> difficult
> things like preventing users from querying diagrams they are not
> suppose to
> see. On the other hand, using SQLite some people could say that is
> rather contradictory having to install/enable a php extension of
> another
> database engine to be able to use a tool meant to manage PostgreSQL.
> Though
> I don't think that is a big deal, the final decision is up to all of
> you.
> 
> You can follow the installation instructions from the README.md file
> here
> -> https://github.com/diorman/DBDesigner ... and you can download the
> project from the links below
> (tar.gz) --> https://github.com/diorman/DBDesigner/archive/1.0-
> BETA.tar.gz
> (zip) ------> https://github.com/diorman/DBDesigner/archive/1.0-
> BETA.zip
> 
> Thanks in advance for your feedback and if you have any doubt or
> problem
> don't hesitate to contact me
> 
> Cheers!
> 

------quoted attachment------
> ------------------------------------------------------------------------------
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills
> current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. SALE $99.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122412

------quoted attachment------
> _______________________________________________
> phpPgAdmin-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel
> 




Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

[ppa-dev] Database designer plugin

[Diorman C. <dex...@gm...>]

Hello to everyone!

I have been working on the development of this project using the version of
phpPgAdmin that has the plugin architecture. I would like to get some
feedback about the functionalities developed so far as well as features you
might think are needed to be included.

This version lacks both REVERSE ENGINEER and FORWARD ENGINEER features. I
will add these functionalities soon as this project is quite useless
without them. This version is just for testing purpose.

As you will notice, you must run some SQL commads to get the plugin
working, and that is one thing I would like to discuss thoroughly. Do you
think that creating a PostgreSQL database is the best way to store the
diagrams?. I have been thinking about using SQLite instead in order to get
the plugin working  "out of the box". I would like you to give me some
opinions about the possible advantages or disadvanges either option might
bring along. For instance, using the PostgreSQL database makes difficult
things like preventing users from querying diagrams they are not suppose to
see. On the other hand, using SQLite some people could say that is
rather contradictory having to install/enable a php extension of another
database engine to be able to use a tool meant to manage PostgreSQL. Though
I don't think that is a big deal, the final decision is up to all of you.

You can follow the installation instructions from the README.md file here
-> https://github.com/diorman/DBDesigner ... and you can download the
project from the links below
(tar.gz) --> https://github.com/diorman/DBDesigner/archive/1.0-BETA.tar.gz
(zip) ------> https://github.com/diorman/DBDesigner/archive/1.0-BETA.zip

Thanks in advance for your feedback and if you have any doubt or problem
don't hesitate to contact me

Cheers!

[ppa-dev] Patch for ALTER TABLE CLUSTER ON

[phb07 <ph...@ap...>]

Hi all,

Under my Christmas Tree, I have found the attached patch ;-).

As far as I can understand, it adds a capability to the alter table 
functionality, namely to specify, change or remove a clustered index 
definition.
It does the equivalent of the "ALTER TABLE CLUSTER ON ..." and "ALTER 
TABLE SET WITHOUT CLUSTER" sql statements.

The patch should apply on the HEAD.
It only works for postgres version >= 8.0 as 7.4 doesn't support the SET 
WITHOUT CLUSTER clause.

Unfortunately, Christmas Father has not tested this patch with pg7.4.
He has not included additional Selenium regression test too (he is not 
yet familiar with this nice tool ;-)).

Let me know what you think about this patch (as a first patch supplied, 
it may need some refinements). I will forward to its author...

With my best wishes,
Philippe Beaudoin (beaud76)

Re: [ppa-dev] Crudgen 0.1 a CRUD generator using phppgadmin plugin's architecure

[Miguel U. <mig...@sk...>]

Oh sorry, there were problems when coding the video. Here is the correct 
link: http://www.youtube.com/watch?v=ZjMyptlcYg4 put in on HD to see the 
video at better quality

-- 
Visita http://www.skatox.com/ : Blog de Informática, Linux, Playstation 3, Windows, Software Libre, Videojuegos, Java y mucho mas....

Re: [ppa-dev] Crudgen 0.1 a CRUD generator using phppgadmin plugin's architecure

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 23/11/2012 04:16, Miguel Useche wrote:
> Hello guys,

Hello Miguel !

Just a quick note: your video is not available and I couldn't find it
when digging in youtbe...

Could you send us the good link ?

Cheers,

> I wrote you like 3 years ago to create a CRUD generator, finally
> after all this time, 3 re-wrotes and after the developing of the
> plugin architecture, i've finished a simple CRUD generator for PPA,
> it uses the plugin architecture made by Leonardo so no code
> modifications are necessary.
> 
> I've made a simple video ( http://youtu.be/VvdvHnsSCq4 ) to explain
> what it does, so you don't need to install it to see it working.
> Currently it doesn't do the following:
> 
> * It doesn't save search or display criteria parameters at
> reporting pages when switching pages (like ordering column, search
> terms, results per page, etc). * I cannot delete records of tables
> without primary keys (honestly, i don't know much about database so
> i need information about this) * It doesn't search items by foreing
> keys values, only for the table's foreign key value (like the id) *
> If you go to the reporting page it doesn't go back automatically.
> 
> I've attached a zip folder with the plugin, if you're using the
> version of PPA with plugin support, just copy it to the plugin
> folder and follow the installation options at the README file, also
> the source code is hosted at:
> https://github.com/Skatox/phppgadmin/tree/crudgen , I made some 
> parts 3 years ago when i was finishing univeristy, even if i
> reviewed it might have some bad code or non-optimum logic.
> 
> I'll appreciate any feedback i would like to make this plugin to
> enter to the stable code as an example of what you can do with the
> plugin architecture.
> 
> Video link: http://youtu.be/VvdvHnsSCq4 (sorry for my english)
> 
> 
> 
> ------------------------------------------------------------------------------
>
> 
Monitor your physical, virtual and cloud infrastructure from a single
> web console. Get in-depth insight into apps, servers, databases,
> vmware, SAP, cloud infrastructure, etc. Download 30-day Free
> Trial. Pricing starts from $795 for 25 servers or applications! 
> http://p.sf.net/sfu/zoho_dev2dev_nov
> 
> 
> 
> _______________________________________________ phpPgAdmin-devel
> mailing list php...@li... 
> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel

[ppa-dev] Crudgen 0.1 a CRUD generator using phppgadmin plugin's architecure

[Miguel U. <mig...@sk...>]

Hello guys,

I wrote you like 3 years ago to create a CRUD generator, finally after 
all this time, 3 re-wrotes and after the developing of the plugin 
architecture,
i've finished a simple CRUD generator for PPA, it uses the plugin 
architecture made by Leonardo so no code modifications are necessary.

I've made a simple video ( http://youtu.be/VvdvHnsSCq4 ) to explain what 
it does, so you don't need to install it to see it working. Currently it 
doesn't do the following:

* It doesn't save search or display criteria parameters at reporting 
pages when switching pages (like ordering column, search terms, results 
per page,
etc).
* I cannot delete records of tables  without primary keys (honestly, i 
don't know much about database so i need information about this)
* It doesn't search items by foreing keys values, only for the table's 
foreign key value (like the id)
* If you go to the reporting page it doesn't go back automatically.

I've attached a zip folder with the plugin, if you're using the version 
of PPA with plugin support, just copy it to the plugin folder and follow 
the
installation options at the README file, also the source code is hosted 
at: https://github.com/Skatox/phppgadmin/tree/crudgen , I made some 
parts 3 years ago when i was finishing univeristy, even
if i reviewed it might have some bad code or non-optimum logic.

I'll appreciate any feedback i would like to make this plugin to enter 
to the stable code as an example of what you can do with the plugin 
architecture.

  Video link: http://youtu.be/VvdvHnsSCq4 (sorry for my english)

-- 
Visita http://www.skatox.com/ : Blog de Informática, Linux, Playstation 3, Windows, Software Libre, Videojuegos, Java y mucho mas....

[ppa-dev] PG hex bytea conversion functions

[Karl O. P. <ko...@me...>]

Houdy,

This works for me.

----------------<snip>------------
<?php

function raw2byteahex($r) {
  // $r   A php string containing raw bytes.
  // Returns:  A pg bytea escaped string in pg's hex representation.
  //
  // Remarks:
  // (Does not deal with "double escapeing" the \ for the parser,
  // quoting, or any of that sort of stuff.)
  //
  // Php happens to use lower case hex, as does pg.

  return '\x' . bin2hex($r);
}

function byteahex2raw($b) {
  // $b   A php string containing pg's bytea hex representation.
  //      (Assumed to be a valid representation.)
  // Returns:  A php string with raw bytes.

  // In php 5.4.0 or later we can do this.
  // Screw around comparing php versions if you so desire.
  //  return hex2bin(str_replace(' ', '', substr($b, 2)));

  return pack('H*', str_replace(' ', '', substr($b, 2)));
}

printf("%s\n", raw2byteahex(byteahex2raw('\xDEADBEEF')));

?>
----------------<snip>------------


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Bug in head as of 2012-09-19?

[Jehan-Guillaume (i. de R. <io...@fr...>]

Fixed in HEAD.

Thank you for the report !

On 26/09/2012 22:41, Karl O. Pinc wrote:
> On 09/25/2012 09:57:45 PM, Karl O. Pinc wrote:
>> On 09/24/2012 11:00:16 AM, Jehan-Guillaume (ioguix) de Rorthais 
>> wrote:
>>> On 24/09/2012 17:06, Karl O. Pinc wrote:
>>>> Hi,
>>>> 
>>>> I'm running head as of 2012-09-19 with pg 9.2.0 and got the 
>>>> following report from a user:
>>>> 
>>>> ---------------------------<snip>----------------- I'm having
>>>> trouble working with my schema.  When I go to import a 
>>>> table, things seem to go smoothly but then all the data
>>>> columns in my
>>> import
>>>> file are dumped into a single phppgadmin column called
>>>> "actions";
>>> the
>>>> columns I had created in phppgadmin for the data are left
>>>> empty.
>>> This
>>>> happens regardless of whether the import table structure is
>>>> csv
>> or
>> 
>>>> text.
>>> 
>>> 
>>> No bug...but again, I'm not sure to understand this report.
> 
> The problem is that display.php displays a column heading "Action"
> under which buttons are supposed to appear, even when there's no
> keys on the table and hence no buttons appear.
> 
> create table foo(id int, data text); insert into foo(id, data)
> values (1, 'bar');
> 
> Go browse the table.  You'll see an extra "Action" column heading.
> 
> The attached patch fixes the problem.  I took only a localized look
> at the code so I can't say whether this is the best possible fix.
> (Should the code really be counting buttons? Makes sense in
> context....)
> 
> 
> Karl <ko...@me...> Free Software:  "You don't pay back, you pay
> forward." -- Robert A. Heinlein
> 

[ppa-dev] Ubuntu suckage?

[Karl O. P. <ko...@me...>]

Regards an annoying session log message,

(I wonder if this is just an Ubuntu problem....
Probably.)

Putting my notes here, in case they're useful.

[16:41:29]<karlpinc> I am, FYI, seeing this bug on Ubuntu Lucid LTS:  
[Fri Oct  
                     26 17:05:48 2012] [error] [client 68.34.81.88] PHP 
       
                     Notice:  session_start(): ps_files_cleanup_dir:    
       
                     opendir(/var/lib/php5) failed: Permission denied 
(13) in   
                     /srv/var/www/https/phpPgAdmin-head/libraries/
lib.inc.php   
                     on line 56, referer: 
[16:43:25]<karlpinc> The probem is that the session is timing out and 
the OS    
                     is not giving php x permission on the directory 
where      
                     state is stored.  This is probably appropriate for 
the     
                     OS, but we get this message.
[16:44:52]<karlpinc> It's not clear to me what can be done in ppa.  I'm 
       
                     thinking the solution is for ppa to have it's own 
login    
                     timeout that's significatly shorter than the php 
session   
                     timeout/garbage collection....  Any good ideas?
[16:48:56]<karlpinc> We should at least have something in the FAQ and 
give      
                     people some guidance.

Google sez:
http://steffe.se/?p=474
Which says to put an @ in front of the session_start(),
which is totally the wrong thing to do.

http://vvv.tobiassjosten.net/php/php-session-garbage-collection/
Has a nice analysis, and suggests turning off session garbage
collection, which is also ungood.

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

[ppa-dev] Data import patches

[Karl O. P. <ko...@me...>]

Hi,

I've been working on data import and have a number of
patches.  These can all be applied with 'patch -p1'.

The patches fall in 3 categories:

A) Allow import to replace existing table content.

I've already submitted this patch but am re-submitting
the same patch as

01replace_on_import_patch

In theory the rest of the patches are independent
of this patch, but since they touch the same code
this patch should be applied first.


B) Allow import into views.

The idea here is that if somebody's gone to the
trouble of putting an insert trigger on a view
then they'll either be able to insert to the view
or they'll get some sort of useful error message.
So, we only display the import tab for the view
if there's an insert trigger on the view.

02move_printimport.patch
Moves the printing of the import page
from tblproperties.php to classes/Misc.php.

03abstract_import.patch
Abstracts the notion of what can be imported.

04import_views.patch
Allows import into views which have an insert trigger.
Note that the test for which views have an insert
trigger should work, because the relevant catalogs have
not changed, back to 7.4.  However, I've not tested
it on anything but 9.2.


C) Replace view content only when views support
deletion.

Again, the assumption is that if there's a
delete trigger on the view then the trigger does something
useful.

05generalize_trigger_check.patch
Reworks the test for insert trigger to support
testing for any sort of trigger.  (And delete
triggers specifically.)

06no_replace_when_unable.patch
Allow replacement of view content only when there's
a delete trigger on the view.

Let me know what you think.

Thanks.

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

P.S.  I did B) all at once, since I didn't know where
I was going with it.  Splitting it into smaller patches
was a PITA.   Was this worth my time?

[ppa-dev] Patch, replace existing table content on import

[Karl O. P. <ko...@me...>]

Hi,

Attached is a patch which allows the user to replace
existing table content on data import.  Hence,
old data is removed and new data replace in a single
transaction.

Against head.

I don't know what the deal is with selenium tests.
I pressed the button, got errors in the logs,
and decided to send the patch to you and get feedback.

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

[ppa-dev] The "right way" to process multiple user-supplied sql statements

[Karl O. P. <ko...@me...>]

Hi,

So, after long pursuing what now seem the wrong path,
if ppa is to take
multiple sql statements from the user's
entry on the free-form sql page and supply
the user with results from all the statements
the way forward now seems clear.
(For me this has been the holy grail, to have
ppa be interactive in the same way that psql is.)

The libpq functions PQsendQuery() and PQgetResult()
put the burden of distinguishing one sql statement
from another on libpq.  These functions are in php,
but not in adodb or pdo.

http://www.postgresql.org/docs/9.2/static/libpq-async.html

It seems clear that we want to avoid having write and
maintain an SQL statement parser in ppa if at all possible.  Since
libpq supplies a parser I think that if we want this feature
we need to use what libpq supplies.  I don't see this feature
getting into either adodb or even pdo any time soon,
if ever, since they are supposed to be cross-database
abstractions, other databases in so far as I am aware
do not have this feature, and neither adodb nor pdo
is likely to implement a parser in order to supply
the feature across all databases.

As I see it there are only 2 possible approaches:
hack the functionality into adodb and maintain
that patch forever. or use the postgres functions
built into php, including PQsendQuery() and
PQgetResult(), when processing user supplied sql.
Although postgres will not then be abstracted away
in the user-supplied query processing code,
and will be different from the rest of the code, I don't
see this as a huge obstacle for reasons that 
I'd be happy to go into.

So, my inclination is to go ahead and implement the
ability to process multiple user-supplied sql statements
using php's postgres db functions.  But I want some
consensus before I get started, this time.  :-)

I'd like to discuss all options.  Can this be on the
table?  How should we proceed, email, irc, or ???

Thanks,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] The password change process needs help

[Karl O. P. <ko...@me...>]

On 09/30/2012 02:57:29 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 27/09/2012 19:34, Karl O. Pinc wrote:

> > Attached patch adds a todo item to make password changing
> > more secure.
> 
> Could you please post this as a feature request instead of a patch ?

I added a bug and made it private.  Artifact 3573308.
> 
> Thank you !

Thanks for holding down the fort and doing the boring
work.



Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Bug when not in schema and click on priviliges tab

[Karl O. P. <ko...@me...>]

On 09/30/2012 02:53:58 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 27/09/2012 19:06, Karl O. Pinc wrote:
> > Hi,
> > 
> > After logging in, click on a db, then go to privileges tab.
> 
> Thank you for your report and patch. I committed it with a small
> change
> (using isset instead of array_key_exists).

Thanks.

<nit>
My thought is that if, for some reason, it's coming from
the client's http message and is NULL, then that needs to be
either tested for explicitly or let go through the
rest of the logic and either succeed or raise whatever php error
comes along.  Otherwise you're just covering up
whatever bug is causing the NULL to come from
the client by suppressing a php error message,
or introducing a new bug by not processing the
NULL properly.
</nit>



Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Force a langauge to exist

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 27/09/2012 19:29, Karl O. Pinc wrote:
> Hi,
> 
> I can't seem to reproduce it

Committed, even if I couldn't reproduce it...

Thank you again tonight

> (but I suspect that if you
> deleted all your cookies, had the default config langauge
> set to 'auto' and login and go straight to changing your
> password you would get the error) but I'm seeing errors
> like this in my logs:
> 
> [Thu Sep 27 10:46:37 2012] [error] [client 128.164.152.10] PHP Notice:  
> Undefined variable: _language in /srv/var/www/https/phpPgAdmin-head/
> libraries/lib.inc.php on line 185, referer: 
> https://gombemi.ccas.gwu.edu/phpPgAdmin-head/roles.php?action=confchangepassword&server=%3A5435%3Adisable
> 
> The problem is that there's no language.  Shouldn't
> there _always_ be a language?  The attached patch
> ensures there's a language.
> 
> Against git head.
> 
> Regards,
> 
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein

Re: [ppa-dev] Bug when no server groups are defined in conf/config.inc.php

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 26/09/2012 21:40, Karl O. Pinc wrote:
> HI,
> 
> When running head against pg 9.2 I get messages like:

Thank you for your report, fixed !

> [Wed Sep 26 15:06:36 2012] [error] [client 69.17.73.250] PHP Notice:  
> Undefined index: srv_groups in /srv/var/www/https/phpPgAdmin-head/
> classes/Misc.php on line 2192, referer: https://gombemi.ccas.gwu.edu/
> phpPgAdmin-head/browser.php
> [Wed Sep 26 15:06:36 2012] [error] [client 69.17.73.250] PHP Warning:  
> Invalid argument supplied for foreach() in /srv/var/www/https/
> phpPgAdmin-head/classes/Misc.php on line 2192, referer: 
> https://gombemi.ccas.gwu.edu/phpPgAdmin-head/browser.php
> 
> I'm using a relatively stock config, no server groups
> are defined.  (The default config has server group
> definitions commented out.)
> 
> The attached patch seems to fix the problem, although
> I'm not sure it's the right thing to do.
> 
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein
> 

Re: [ppa-dev] The password change process needs help

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 27/09/2012 19:34, Karl O. Pinc wrote:
> Hi,

Hi,

> Attached patch adds a todo item to make password changing
> more secure.

Could you please post this as a feature request instead of a patch ?

Thank you !

> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein

Re: [ppa-dev] Bug when not in schema and click on priviliges tab

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 27/09/2012 19:06, Karl O. Pinc wrote:
> Hi,
> 
> After logging in, click on a db, then go to privileges tab.

Thank you for your report and patch. I committed it with a small change
(using isset instead of array_key_exists).

Cheers,

> The logs show:
> 
> 
> [Thu Sep 27 13:01:04 2012] [error] [client 69.17.73.250] PHP Notice:  
> Undefined index: schema in /srv/var/www/https/phpPgAdmin-head/
> privileges.php on line 286, referer: https://gombemi.ccas.gwu.edu/
> phpPgAdmin-head/schemas.php?subject=database&server=%3A5435%
> 3Adisable&database=gombemi
> [Thu Sep 27 13:01:04 2012] [error] [client 69.17.73.250] PHP Notice:  
> Undefined index: schema in /srv/var/www/https/phpPgAdmin-head/
> privileges.php on line 321, referer: 
> https://gombemi.ccas.gwu.edu/phpPgAdmin-head/schemas.php?subject=database&server=%3A5435%3Adisable&database=gombemi
> 
> The attached patch fixes this.
> 
> Against git head.
> 
> 
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein
> 
> 
> 
> 
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://ad.doubleclick.net/clk;258768047;13503038;j?
> http://info.appdynamics.com/FreeJavaPerformanceDownload.html
> 
> 
> 
> _______________________________________________
> phpPgAdmin-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel

[ppa-dev] The password change process needs help

[Karl O. P. <ko...@me...>]

Hi,

Attached patch adds a todo item to make password changing
more secure.


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

[ppa-dev] Force a langauge to exist

[Karl O. P. <ko...@me...>]

Hi,

I can't seem to reproduce it (but I suspect that if you
deleted all your cookies, had the default config langauge
set to 'auto' and login and go straight to changing your
password you would get the error) but I'm seeing errors
like this in my logs:

[Thu Sep 27 10:46:37 2012] [error] [client 128.164.152.10] PHP Notice:  
Undefined variable: _language in /srv/var/www/https/phpPgAdmin-head/
libraries/lib.inc.php on line 185, referer: 
https://gombemi.ccas.gwu.edu/phpPgAdmin-head/roles.php?action=confchangepassword&server=%3A5435%3Adisable

The problem is that there's no language.  Shouldn't
there _always_ be a language?  The attached patch
ensures there's a language.

Against git head.

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

[ppa-dev] Bug when not in schema and click on priviliges tab

[Karl O. P. <ko...@me...>]

Hi,

After logging in, click on a db, then go to privileges tab.

The logs show:


[Thu Sep 27 13:01:04 2012] [error] [client 69.17.73.250] PHP Notice:  
Undefined index: schema in /srv/var/www/https/phpPgAdmin-head/
privileges.php on line 286, referer: https://gombemi.ccas.gwu.edu/
phpPgAdmin-head/schemas.php?subject=database&server=%3A5435%
3Adisable&database=gombemi
[Thu Sep 27 13:01:04 2012] [error] [client 69.17.73.250] PHP Notice:  
Undefined index: schema in /srv/var/www/https/phpPgAdmin-head/
privileges.php on line 321, referer: 
https://gombemi.ccas.gwu.edu/phpPgAdmin-head/schemas.php?subject=database&server=%3A5435%3Adisable&database=gombemi

The attached patch fixes this.

Against git head.


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein