Re: [ppa-dev] Bug when not in schema and click on priviliges tab

[Karl O. P. <ko...@me...>]

On 09/30/2012 02:53:58 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 27/09/2012 19:06, Karl O. Pinc wrote:
> > Hi,
> > 
> > After logging in, click on a db, then go to privileges tab.
> 
> Thank you for your report and patch. I committed it with a small
> change
> (using isset instead of array_key_exists).

Thanks.

<nit>
My thought is that if, for some reason, it's coming from
the client's http message and is NULL, then that needs to be
either tested for explicitly or let go through the
rest of the logic and either succeed or raise whatever php error
comes along.  Otherwise you're just covering up
whatever bug is causing the NULL to come from
the client by suppressing a php error message,
or introducing a new bug by not processing the
NULL properly.
</nit>



Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein