Menu
▾
▴
phppgadmin-devel — For Developers Only
You can subscribe to this list here.
| 2001 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(21) |
Nov
(47) |
Dec
(26) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2002 |
Jan
(152) |
Feb
(216) |
Mar
(53) |
Apr
(50) |
May
(34) |
Jun
(14) |
Jul
(69) |
Aug
(27) |
Sep
(86) |
Oct
(36) |
Nov
(23) |
Dec
(61) |
| 2003 |
Jan
(100) |
Feb
(50) |
Mar
(94) |
Apr
(48) |
May
(127) |
Jun
(102) |
Jul
(64) |
Aug
(65) |
Sep
(68) |
Oct
(57) |
Nov
(43) |
Dec
(68) |
| 2004 |
Jan
(39) |
Feb
(41) |
Mar
(84) |
Apr
(21) |
May
(115) |
Jun
(102) |
Jul
(125) |
Aug
(79) |
Sep
(65) |
Oct
(44) |
Nov
(66) |
Dec
(31) |
| 2005 |
Jan
(65) |
Feb
(51) |
Mar
(117) |
Apr
(50) |
May
(61) |
Jun
(24) |
Jul
(42) |
Aug
(52) |
Sep
(16) |
Oct
(21) |
Nov
(48) |
Dec
(9) |
| 2006 |
Jan
(15) |
Feb
(5) |
Mar
(8) |
Apr
(1) |
May
(33) |
Jun
(47) |
Jul
(103) |
Aug
(36) |
Sep
(1) |
Oct
(25) |
Nov
(11) |
Dec
(5) |
| 2007 |
Jan
(19) |
Feb
(12) |
Mar
(12) |
Apr
(61) |
May
(9) |
Jun
(66) |
Jul
(47) |
Aug
(12) |
Sep
(23) |
Oct
(13) |
Nov
(24) |
Dec
(12) |
| 2008 |
Jan
(4) |
Feb
(16) |
Mar
(3) |
Apr
(1) |
May
(2) |
Jun
(15) |
Jul
(2) |
Aug
(2) |
Sep
(3) |
Oct
(20) |
Nov
(7) |
Dec
(25) |
| 2009 |
Jan
(5) |
Feb
|
Mar
|
Apr
(5) |
May
|
Jun
(12) |
Jul
|
Aug
(1) |
Sep
(2) |
Oct
(2) |
Nov
(1) |
Dec
(1) |
| 2010 |
Jan
(1) |
Feb
|
Mar
(44) |
Apr
(15) |
May
(51) |
Jun
(30) |
Jul
(38) |
Aug
(43) |
Sep
(34) |
Oct
(9) |
Nov
(31) |
Dec
(15) |
| 2011 |
Jan
(15) |
Feb
(3) |
Mar
(9) |
Apr
(4) |
May
(53) |
Jun
(45) |
Jul
(4) |
Aug
(11) |
Sep
(2) |
Oct
(8) |
Nov
(3) |
Dec
(3) |
| 2012 |
Jan
(1) |
Feb
(1) |
Mar
(5) |
Apr
|
May
|
Jun
(2) |
Jul
|
Aug
(2) |
Sep
(14) |
Oct
(6) |
Nov
(5) |
Dec
(1) |
| 2013 |
Jan
(32) |
Feb
(26) |
Mar
(19) |
Apr
(46) |
May
(55) |
Jun
(37) |
Jul
(2) |
Aug
|
Sep
|
Oct
(1) |
Nov
|
Dec
(1) |
| 2014 |
Jan
|
Feb
(7) |
Mar
(2) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(2) |
| 2015 |
Jan
|
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2018 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(1) |
Nov
|
Dec
|
|
From: Jehan-Guillaume (i. de R. <io...@fr...> - 2011-10-18 22:36:23
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 19/10/2011 00:29, Miguel Useche wrote: > Yes i would like to, I could add some non-documented stuff. I just added you, with the login name "skatox". You should receive an email with your password pretty soon. > I'll try to dedicate 3 hours a week to create and improve the CRUD > plugin so i could find some problems with the documentation along the > whole process. Excellent ! Thank you ! > El 18/10/11 17:43, Jehan-Guillaume (ioguix) de Rorthais escribió: > We talked about that with Leonardo before lunch at pgconf.eu. > > Miguel, do you want a wiki account so you can contribute to the > documentation... and fix the doc when you think it is needed ? > > On 08/10/2011 20:56, Miguel Useche wrote: >>>> I just found some documentation bug at Misc.php. On line 1678 there is a >>>> new $place variable added as the fourth parameter, but in the >>>> documentation says it is on the last position, so you should fix the >>>> documentation to avoid misunderstand. Is simple but it confused me a >>>> little bit. >>>> >>>> El 26/08/11 07:55, Leonardo Sápiras escribió: >>>>> Hi devs, >>>>> >>>>>> Congrats bro, I'll try to make some time before next version of PPA to >>>>>> migrate mi CRUD to your plugin architecture. >>>>> Thanks Miguel :) >>>>> >>>>> The documentation that explains how to create plugins for phpPgAdmin >>>>> can be found at >>>>> [http://phppgadmin.sourceforge.net/doku.php?id=devs:plugins_documentation]. >>>>> >>>>> >>>>> Cheers! >>>>> >>>>> >>>>> -- >>>>> Atenciosamente >>>>> Leonardo Augusto Sápiras >>>>> [http://www.leonardosapiras.com.br] >>>>> >>>>> >>>>> >>>>> 2011/8/23 Miguel Useche<mig...@sk...>: >>>>>> Congrats bro, I'll try to make some time before next version of PPA to >>>>>> migrate mi CRUD to your plugin architecture. >>>>>> >>>>>> El 23/08/2011 09:25 a.m., Leonardo Sápiras escribió: >>>>>> >>>>>> Jehan, Andreas and devs, >>>>>> >>>>>> Attached the patches with all our work. >>>>>> >>>>>> 2011/8/22 Andreas 'ads' Scherbaum<ad...@wa...>: >>>>>> [...] >>>>>> >>>>>> I read it and sent some changes to Leonardo (on IRC). >>>>>> What I also mentioned: he should add some info, where new plugins >>>>>> should be >>>>>> published, so every user knows about them. And it probably makes >>>>>> sense to >>>>>> add some license information. >>>>>> >>>>>> Will not the plugins' license be the same of phpPgAdmin one? Do the >>>>>> plugins need to have specific licenses? Why? >>>>>> >>>>>> In general: well done. Thanks Leonardo. >>>>>> >>>>>> Thanks you guys :) >>>>>> >>>>>> >>>>>> -- >>>>>> Atenciosamente >>>>>> Leonardo Augusto Sápiras >>>>>> [http://www.leonardosapiras.com.br] >>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> >>>>>> Get a FREE DOWNLOAD! and learn more about uberSVN rich system, >>>>>> user administration capabilities and model configuration. Take >>>>>> the hassle out of deploying and managing Subversion and the >>>>>> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> phpPgAdmin-devel mailing list >>>>>> php...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel >>>>>> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6d/14ACgkQxWGfaAgowiLOrwCfUtw+rYoYd+qtSIMLKI83Q/Fp xLkAn1VHUiwKrslZo/LHS+ZfWmt3Y8xq =d4Jh -----END PGP SIGNATURE----- |
|
From: Jehan-Guillaume (i. de R. <io...@fr...> - 2011-10-18 22:13:39
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 We talked about that with Leonardo before lunch at pgconf.eu. Miguel, do you want a wiki account so you can contribute to the documentation... and fix the doc when you think it is needed ? On 08/10/2011 20:56, Miguel Useche wrote: > I just found some documentation bug at Misc.php. On line 1678 there is a > new $place variable added as the fourth parameter, but in the > documentation says it is on the last position, so you should fix the > documentation to avoid misunderstand. Is simple but it confused me a > little bit. > > El 26/08/11 07:55, Leonardo Sápiras escribió: >> Hi devs, >> >>> Congrats bro, I'll try to make some time before next version of PPA to >>> migrate mi CRUD to your plugin architecture. >> Thanks Miguel :) >> >> The documentation that explains how to create plugins for phpPgAdmin >> can be found at >> [http://phppgadmin.sourceforge.net/doku.php?id=devs:plugins_documentation]. >> >> Cheers! >> >> >> -- >> Atenciosamente >> Leonardo Augusto Sápiras >> [http://www.leonardosapiras.com.br] >> >> >> >> 2011/8/23 Miguel Useche<mig...@sk...>: >>> Congrats bro, I'll try to make some time before next version of PPA to >>> migrate mi CRUD to your plugin architecture. >>> >>> El 23/08/2011 09:25 a.m., Leonardo Sápiras escribió: >>> >>> Jehan, Andreas and devs, >>> >>> Attached the patches with all our work. >>> >>> 2011/8/22 Andreas 'ads' Scherbaum<ad...@wa...>: >>> [...] >>> >>> I read it and sent some changes to Leonardo (on IRC). >>> What I also mentioned: he should add some info, where new plugins should be >>> published, so every user knows about them. And it probably makes sense to >>> add some license information. >>> >>> Will not the plugins' license be the same of phpPgAdmin one? Do the >>> plugins need to have specific licenses? Why? >>> >>> In general: well done. Thanks Leonardo. >>> >>> Thanks you guys :) >>> >>> >>> -- >>> Atenciosamente >>> Leonardo Augusto Sápiras >>> [http://www.leonardosapiras.com.br] >>> >>> >>> ------------------------------------------------------------------------------ >>> Get a FREE DOWNLOAD! and learn more about uberSVN rich system, >>> user administration capabilities and model configuration. Take >>> the hassle out of deploying and managing Subversion and the >>> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 >>> >>> >>> _______________________________________________ >>> phpPgAdmin-devel mailing list >>> php...@li... >>> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel >>> > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6d+gkACgkQxWGfaAgowiLHDACdFlhN2w9Wo5Vk0yci9f6enwQg oLcAoIzMelzMB+4oMugdS/wLs6RTINsX =VBA9 -----END PGP SIGNATURE----- |
|
From: Leonardo S. <l.s...@gm...> - 2011-10-17 23:08:41
|
Thanks for see that Miguel. I will fix it ASAP. -- Atenciosamente Leonardo Augusto Sápiras [http://www.leonardosapiras.com.br] 2011/10/8 Miguel Useche <mig...@sk...> > I just found some documentation bug at Misc.php. On line 1678 there is a > new $place variable added as the fourth parameter, but in the documentation > says it is on the last position, so you should fix the documentation to > avoid misunderstand. Is simple but it confused me a little bit. > > El 26/08/11 07:55, Leonardo Sápiras escribió: > > Hi devs, >> >> Congrats bro, I'll try to make some time before next version of PPA to >>> migrate mi CRUD to your plugin architecture. >>> >> Thanks Miguel :) >> >> The documentation that explains how to create plugins for phpPgAdmin >> can be found at >> [http://phppgadmin.**sourceforge.net/doku.php?id=** >> devs:plugins_documentation<http://phppgadmin.sourceforge.net/doku.php?id=devs:plugins_documentation> >> ]. >> >> Cheers! >> >> >> -- >> Atenciosamente >> Leonardo Augusto Sápiras >> [http://www.leonardosapiras.**com.br <http://www.leonardosapiras.com.br>] >> >> >> >> 2011/8/23 Miguel Useche<mig...@sk...**>: >> >>> Congrats bro, I'll try to make some time before next version of PPA to >>> migrate mi CRUD to your plugin architecture. >>> >>> El 23/08/2011 09:25 a.m., Leonardo Sápiras escribió: >>> >>> Jehan, Andreas and devs, >>> >>> Attached the patches with all our work. >>> >>> 2011/8/22 Andreas 'ads' Scherbaum<adsmail@wars-nicht.**de<ad...@wa...> >>> >: >>> [...] >>> >>> I read it and sent some changes to Leonardo (on IRC). >>> What I also mentioned: he should add some info, where new plugins should >>> be >>> published, so every user knows about them. And it probably makes sense to >>> add some license information. >>> >>> Will not the plugins' license be the same of phpPgAdmin one? Do the >>> plugins need to have specific licenses? Why? >>> >>> In general: well done. Thanks Leonardo. >>> >>> Thanks you guys :) >>> >>> >>> -- >>> Atenciosamente >>> Leonardo Augusto Sápiras >>> [http://www.leonardosapiras.**com.br <http://www.leonardosapiras.com.br> >>> ] >>> >>> >>> ------------------------------**------------------------------** >>> ------------------ >>> Get a FREE DOWNLOAD! and learn more about uberSVN rich system, >>> user administration capabilities and model configuration. Take >>> the hassle out of deploying and managing Subversion and the >>> tools developers use with it. http://p.sf.net/sfu/wandisco-**d2d-2<http://p.sf.net/sfu/wandisco-d2d-2> >>> >>> >>> ______________________________**_________________ >>> phpPgAdmin-devel mailing list >>> phpPgAdmin-devel@lists.**sourceforge.net<php...@li...> >>> https://lists.sourceforge.net/**lists/listinfo/phppgadmin-**devel<https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel> >>> >>> > -- > Visita http://www.skatox.com/ : Blog de Informática, Linux, Playstation 3, > Windows, Software Libre, Videojuegos, Java y mucho mas.... > > |
|
From: Miguel U. <mig...@sk...> - 2011-10-08 19:32:30
|
I just found some documentation bug at Misc.php. On line 1678 there is a new $place variable added as the fourth parameter, but in the documentation says it is on the last position, so you should fix the documentation to avoid misunderstand. Is simple but it confused me a little bit. El 26/08/11 07:55, Leonardo Sápiras escribió: > Hi devs, > >> Congrats bro, I'll try to make some time before next version of PPA to >> migrate mi CRUD to your plugin architecture. > Thanks Miguel :) > > The documentation that explains how to create plugins for phpPgAdmin > can be found at > [http://phppgadmin.sourceforge.net/doku.php?id=devs:plugins_documentation]. > > Cheers! > > > -- > Atenciosamente > Leonardo Augusto Sápiras > [http://www.leonardosapiras.com.br] > > > > 2011/8/23 Miguel Useche<mig...@sk...>: >> Congrats bro, I'll try to make some time before next version of PPA to >> migrate mi CRUD to your plugin architecture. >> >> El 23/08/2011 09:25 a.m., Leonardo Sápiras escribió: >> >> Jehan, Andreas and devs, >> >> Attached the patches with all our work. >> >> 2011/8/22 Andreas 'ads' Scherbaum<ad...@wa...>: >> [...] >> >> I read it and sent some changes to Leonardo (on IRC). >> What I also mentioned: he should add some info, where new plugins should be >> published, so every user knows about them. And it probably makes sense to >> add some license information. >> >> Will not the plugins' license be the same of phpPgAdmin one? Do the >> plugins need to have specific licenses? Why? >> >> In general: well done. Thanks Leonardo. >> >> Thanks you guys :) >> >> >> -- >> Atenciosamente >> Leonardo Augusto Sápiras >> [http://www.leonardosapiras.com.br] >> >> >> ------------------------------------------------------------------------------ >> Get a FREE DOWNLOAD! and learn more about uberSVN rich system, >> user administration capabilities and model configuration. Take >> the hassle out of deploying and managing Subversion and the >> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 >> >> >> _______________________________________________ >> phpPgAdmin-devel mailing list >> php...@li... >> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel >> -- Visita http://www.skatox.com/ : Blog de Informática, Linux, Playstation 3, Windows, Software Libre, Videojuegos, Java y mucho mas.... |
|
From: Jehan-Guillaume (i. de R. <io...@fr...> - 2011-10-03 09:24:35
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 ==== Version 5.0.3 ==== Released: 3rd October 2011 This third update of the phpPgAdmin 5.0 branch brings some bug and security fixes. Details bellow. ==== Download ==== To download phpPgAdmin 5.0.3 right now, visit: http://phppgadmin.sourceforge.net/doku.php?id=download ==== Changelog ==== Some bug fixes. * Fix bug with enable/disable triggers on multiple triggers (Dawid 'DeyV' Polak) * Fix bug #3353670: Error when executing a report with paging * Fix bug with OpenBSD about where setting application_name using PGOPTIONS was raising an ERROR * Two security fix about code injection, reported by Mateusz Goik, fixed by ioguix * Fix character-encoding problem with autocomplete Regards, - -- The phpPgAdmin Team -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6Jf0wACgkQxWGfaAgowiK/tgCfYdBZ62ZUrMOxkcMk2IiLLxjN vHcAnAqyinMefOE+ly3d2Dk7c3gDgpXt =bkz0 -----END PGP SIGNATURE----- |
|
From: Jehan-Guillaume (i. de R. <io...@fr...> - 2011-10-03 09:08:17
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dear packagers, We released phpPgAdmin 5.0.3 today. Mostly bug and security fixes. You can download it directly from sf.net: https://sourceforge.net/projects/phppgadmin/files/phpPgAdmin%20%5Bstable%5D/phpPgAdmin-5.0/ I am available by email or on IRC (freenode.net #phppgadmin) if you have any question. And thanks again for your support ! - -- The phpPgAdmin Team -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6Je3kACgkQxWGfaAgowiJ9CQCcCCRbZDVrNFjqis8p8w2kfoMS 9XMAn2LBS49kK7tbuwD0EYjcrTREMFuh =dhqI -----END PGP SIGNATURE----- |
|
From: Jehan-Guillaume (i. de R. <io...@fr...> - 2011-09-28 21:27:32
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey, Thank you for this report. These XSS has been fixed in both 5.1-dev and current 5.0 branch. Snapshot for both branches are available here: http://github.com/phppgadmin/phppgadmin We will plan a release soon. Cheers, On 12/09/2011 14:33, metalog wrote: > 1. > display.php?page=1&server=[serwer]&database=[database]&subject=table&return_url=[XSS]&return_desc=[XSS] > example: > http://phppgadmin.kattare.com/phppgadmin/display.php?server=localhost%3A5481%3Aallow&database=postgres&schema=concerto&table=Teacher&subject=table&return_url=%22%3E%3Cscript%3Ealert%28document.cookie%29;%3C/script%3E&return_desc=%3Cscript%3Ealert%28document.cookie%29;%3C/script%3E > > <li><a href=""><script>alert(document.cookie);</script>"><script>alert(document.cookie);</script></a></li> > > 2. > redirect.php?subject=table&server=[serwer]&database=[database]&schema=[schema]&table=[XSS] > > example: > http://phppgadmin.kattare.com/phppgadmin/redirect.php?subject=table&server=localhost%3A5481%3Aallow&database=postgres&schema=concerto&table=%3C/title%3E%3Cscript%3Ealert%28document.cookie%29;%3C/script%3E > > <title>phpPgAdmin - Tabele - </title><script>alert(document.cookie);</script></title> > > > I agree to put my first name and last name in the changelog. > > Mateusz Goik -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6DkTsACgkQxWGfaAgowiLH9QCfRybIva+IoQTsiQXkqwkTJNTO S1UAn0bTduEPOGA0uc6e/1uYd5oDN1rx =05ZB -----END PGP SIGNATURE----- |
|
From: metalog <me...@me...> - 2011-09-12 12:52:22
|
1. display.php?page=1&server=[serwer]&database=[database]&subject=table&return_url=[XSS]&return_desc=[XSS] example: http://phppgadmin.kattare.com/phppgadmin/display.php?server=localhost%3A5481%3Aallow&database=postgres&schema=concerto&table=Teacher&subject=table&return_url=%22%3E%3Cscript%3Ealert%28document.cookie%29;%3C/script%3E&return_desc=%3Cscript%3Ealert%28document.cookie%29;%3C/script%3E <li><a href=""><script>alert(document.cookie);</script>"><script>alert(document.cookie);</script></a></li> 2. redirect.php?subject=table&server=[serwer]&database=[database]&schema=[schema]&table=[XSS] example: http://phppgadmin.kattare.com/phppgadmin/redirect.php?subject=table&server=localhost%3A5481%3Aallow&database=postgres&schema=concerto&table=%3C/title%3E%3Cscript%3Ealert%28document.cookie%29;%3C/script%3E <title>phpPgAdmin - Tabele - </title><script>alert(document.cookie);</script></title> I agree to put my first name and last name in the changelog. Mateusz Goik |
|
From: Leonardo S. <l.s...@gm...> - 2011-08-26 12:25:50
|
Hi devs, > Congrats bro, I'll try to make some time before next version of PPA to > migrate mi CRUD to your plugin architecture. Thanks Miguel :) The documentation that explains how to create plugins for phpPgAdmin can be found at [http://phppgadmin.sourceforge.net/doku.php?id=devs:plugins_documentation]. Cheers! -- Atenciosamente Leonardo Augusto Sápiras [http://www.leonardosapiras.com.br] 2011/8/23 Miguel Useche <mig...@sk...>: > Congrats bro, I'll try to make some time before next version of PPA to > migrate mi CRUD to your plugin architecture. > > El 23/08/2011 09:25 a.m., Leonardo Sápiras escribió: > > Jehan, Andreas and devs, > > Attached the patches with all our work. > > 2011/8/22 Andreas 'ads' Scherbaum <ad...@wa...>: > [...] > > I read it and sent some changes to Leonardo (on IRC). > What I also mentioned: he should add some info, where new plugins should be > published, so every user knows about them. And it probably makes sense to > add some license information. > > Will not the plugins' license be the same of phpPgAdmin one? Do the > plugins need to have specific licenses? Why? > > In general: well done. Thanks Leonardo. > > Thanks you guys :) > > > -- > Atenciosamente > Leonardo Augusto Sápiras > [http://www.leonardosapiras.com.br] > > > ------------------------------------------------------------------------------ > Get a FREE DOWNLOAD! and learn more about uberSVN rich system, > user administration capabilities and model configuration. Take > the hassle out of deploying and managing Subversion and the > tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 > > > _______________________________________________ > phpPgAdmin-devel mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel > |
|
From: Leonardo S. <l.s...@gm...> - 2011-08-23 13:55:57
|
Jehan, Andreas and devs, Attached the patches with all our work. 2011/8/22 Andreas 'ads' Scherbaum <ad...@wa...>: [...] > I read it and sent some changes to Leonardo (on IRC). > What I also mentioned: he should add some info, where new plugins should be > published, so every user knows about them. And it probably makes sense to > add some license information. Will not the plugins' license be the same of phpPgAdmin one? Do the plugins need to have specific licenses? Why? > In general: well done. Thanks Leonardo. Thanks you guys :) -- Atenciosamente Leonardo Augusto Sápiras [http://www.leonardosapiras.com.br] |
|
From: Andreas 'a. S. <ad...@wa...> - 2011-08-22 21:20:04
|
Hi all, Am 16.08.2011 00:32, schrieb Jehan-Guillaume (ioguix) de Rorthais: > On 16/08/2011 00:21, Leonardo Sápiras wrote: > >> In the Google Summer of Code program 2011 I developed a new plugin >> architecture for phpPgAdmin. And I was helped for Sr. Jehan-Guillaume >> de Rorthais and Sr. Andreas Scherbaum, my mentors. > > Yeah, Leonardo did a good job during this whole summer. He sticked to > the plan and did a bit more... Absolutely. And we did not make it easy with all of our comments and change requests ;-) >> There is a documentation in the phpPgAdmin website >> [http://phppgadmin.sourceforge.net/] that will help you to develop >> news plugins. For while this documentation is inside a developer area, >> so you will need to create a user to access it. > > Same here. I didn't reviewed the documentation completely. There's a > bunch of spelling/wording to fix. If any of you english spoken guys want > to give a hands, again, you're welcome ! I read it and sent some changes to Leonardo (on IRC). What I also mentioned: he should add some info, where new plugins should be published, so every user knows about them. And it probably makes sense to add some license information. In general: well done. Thanks Leonardo. -- Andreas 'ads' Scherbaum German PostgreSQL User Group European PostgreSQL User Group - Board of Directors Volunteer Regional Contact, Germany - PostgreSQL Project |
|
From: Leonardo S. <l.s...@gm...> - 2011-08-17 20:35:11
|
Dear Jehan,
2011/8/16 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>:
> Here is some notes, comments and reviews while reading/fixing your
> documentation.
>
> #0
> look at the diffs on your page in the wiki. I fixed some spelling,
> wording and even pieces of code. Please, consider all of them carefully,
> comment and double check everything is ok for you.
>
> Moreover, I added some warning notes in it you need to fix.
Ok, thanks for you suggestions and fix :)
I removed some comments I worked, and answered other in the own documentation.
> #1
> in plugins/<plugin_name>/plugin.php:__construct
> "parent::__construct($language, $plugin_directory);" is false. You don't
> need to pass "$plugin_director" anymore. Check in "classes/Plugin.php",
> this constructor doesn't take a second parameter anymore.
>
> Hence, your minimal constructor in "plugins/<plugin_name>/plugin.php"
> should be:
>
> function __construct($language) {
> parent::__construct($language);
> }
True, code fixed.
> Which is much more clean :)
>
> #2
> I hadn't time to review the the browser tree parts yet...
>
> Overall, the documentation isn't detailed enough. you really have to
> think about the developers that will read it for the first time and that
> have no knowledge at all about PPA's code yet.
>
> If it takes them too much time to understand the documentation and
> technical parts, thay might just walk away from PPA.
Ok, I have done some changes in the documentation, like writing
comments inside code, in a attempt to explain better it.
Feel free to tell me if there are missing more details there.
> Thanks.
Thanks :)
--
Atenciosamente
Leonardo Augusto Sápiras
[http://www.leonardosapiras.com.br]
|
|
From: Jehan-Guillaume (i. de R. <io...@fr...> - 2011-08-16 12:56:27
|
Here is some notes, comments and reviews while reading/fixing your
documentation.
#0
look at the diffs on your page in the wiki. I fixed some spelling,
wording and even pieces of code. Please, consider all of them carefully,
comment and double check everything is ok for you.
Moreover, I added some warning notes in it you need to fix.
#1
in plugins/<plugin_name>/plugin.php:__construct
"parent::__construct($language, $plugin_directory);" is false. You don't
need to pass "$plugin_director" anymore. Check in "classes/Plugin.php",
this constructor doesn't take a second parameter anymore.
Hence, your minimal constructor in "plugins/<plugin_name>/plugin.php"
should be:
function __construct($language) {
parent::__construct($language);
}
Which is much more clean :)
#2
I hadn't time to review the the browser tree parts yet...
Overall, the documentation isn't detailed enough. you really have to
think about the developers that will read it for the first time and that
have no knowledge at all about PPA's code yet.
If it takes them too much time to understand the documentation and
technical parts, thay might just walk away from PPA.
Thanks.
|
|
From: Jehan-Guillaume (i. de R. <io...@fr...> - 2011-08-15 22:32:22
|
On 16/08/2011 00:21, Leonardo Sápiras wrote: > Hi developers, Hey all, Hey Leonardo, > In the Google Summer of Code program 2011 I developed a new plugin > architecture for phpPgAdmin. And I was helped for Sr. Jehan-Guillaume > de Rorthais and Sr. Andreas Scherbaum, my mentors. Yeah, Leonardo did a good job during this whole summer. He sticked to the plan and did a bit more... > The project's description can be found at [http://goo.gl/nr09z]. > > I have created two plugins so far, one is a simple example that uses > all features that this architecture provides. The another one is a > report plugin. I moved the reports.php code to be this plugin. This "report" plugin, based on the old report feature in PPA wasn't planned at first. Thank you Leonardo, it'll be a good and useful demo for this plugin architecture ! > I invite you developers, to create more plugins using this > architecture. This will be a great opportunity to test its features > and find others that this project didn't have in the original > proposal. Well, I will just ask you guys to stand back a bit and wait for a final bunch of reviews/feedback. I mostly reviewed the code, but hadn't time to test it properly. Moreover, I feel like there might be some last itchy things I would like to scratch a bit. Obviously, if any of you want to give a help on this final tour, you're welcome ! > There is a documentation in the phpPgAdmin website > [http://phppgadmin.sourceforge.net/] that will help you to develop > news plugins. For while this documentation is inside a developer area, > so you will need to create a user to access it. Same here. I didn't reviewed the documentation completely. There's a bunch of spelling/wording to fix. If any of you english spoken guys want to give a hands, again, you're welcome ! > Attached a patch with this project. Thank you again Leonardo :) > Regards! > > -- > Atenciosamente > Leonardo Augusto Sápiras > [http://www.leonardosapiras.com.br] |
|
From: Leonardo S. <l.s...@gm...> - 2011-08-15 22:21:33
|
Hi developers, In the Google Summer of Code program 2011 I developed a new plugin architecture for phpPgAdmin. And I was helped for Sr. Jehan-Guillaume de Rorthais and Sr. Andreas Scherbaum, my mentors. The project's description can be found at [http://goo.gl/nr09z]. I have created two plugins so far, one is a simple example that uses all features that this architecture provides. The another one is a report plugin. I moved the reports.php code to be this plugin. I invite you developers, to create more plugins using this architecture. This will be a great opportunity to test its features and find others that this project didn't have in the original proposal. There is a documentation in the phpPgAdmin website [http://phppgadmin.sourceforge.net/] that will help you to develop news plugins. For while this documentation is inside a developer area, so you will need to create a user to access it. Attached a patch with this project. Regards! -- Atenciosamente Leonardo Augusto Sápiras [http://www.leonardosapiras.com.br] |
|
From: Andreas 'a. S. <ad...@wa...> - 2011-08-14 14:53:29
|
Hi, Am 01.08.2011 18:35, schrieb Diorman Colmenares: > > No more questions, then I will wait for documentation :) You can already get the source code from Leonardo and build your own module. No need to wait for the final documentation. Would be nice to see one or more additional modules just after GSoC ends. Regards, -- Andreas 'ads' Scherbaum German PostgreSQL User Group European PostgreSQL User Group - Board of Directors Volunteer Regional Contact, Germany - PostgreSQL Project |
|
From: Diorman C. <dex...@gm...> - 2011-08-01 16:35:12
|
No more questions, then I will wait for documentation :) On Mon, Aug 1, 2011 at 11:56 AM, Leonardo Sápiras <l.s...@gm...>wrote: > Diorman and ppa-devs, > > Thanks for the interesting. > > I have already finished the integration between an Example plugin > and the ppa parts were proposed, like browser tree, action buttons, > navigation links, top links, tabs and trail. > > Now, I am working in my mentors reviews. After I finish it, I will > work on the project documentation. > > Let me know if you have more questions about that :) > > Cheers ! > > -- > Atenciosamente > Leonardo Augusto Sápiras > [http://www.leonardosapiras.com.br] > > > > 2011/8/1 Diorman Colmenares <dex...@gm...>: > > Hey guys > > I want to know what is going on with the plugin architecture development. > > I'm really interesting in finally releasing my project (Database > designer) > > as a redistributable plugin. Maybe in few days I will have some kind of > free > > time and I don't want to waste it :) > > Att Diorman Colmenares > > > ------------------------------------------------------------------------------ > > Got Input? Slashdot Needs You. > > Take our quick survey online. Come on, we don't ask for help often. > > Plus, you'll get a chance to win $100 to spend on ThinkGeek. > > http://p.sf.net/sfu/slashdot-survey > > > > _______________________________________________ > > phpPgAdmin-devel mailing list > > php...@li... > > https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel > > > > > |
|
From: Leonardo S. <l.s...@gm...> - 2011-08-01 16:27:23
|
Diorman and ppa-devs, Thanks for the interesting. I have already finished the integration between an Example plugin and the ppa parts were proposed, like browser tree, action buttons, navigation links, top links, tabs and trail. Now, I am working in my mentors reviews. After I finish it, I will work on the project documentation. Let me know if you have more questions about that :) Cheers ! -- Atenciosamente Leonardo Augusto Sápiras [http://www.leonardosapiras.com.br] 2011/8/1 Diorman Colmenares <dex...@gm...>: > Hey guys > I want to know what is going on with the plugin architecture development. > I'm really interesting in finally releasing my project (Database designer) > as a redistributable plugin. Maybe in few days I will have some kind of free > time and I don't want to waste it :) > Att Diorman Colmenares > ------------------------------------------------------------------------------ > Got Input? Slashdot Needs You. > Take our quick survey online. Come on, we don't ask for help often. > Plus, you'll get a chance to win $100 to spend on ThinkGeek. > http://p.sf.net/sfu/slashdot-survey > > _______________________________________________ > phpPgAdmin-devel mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel > > |
|
From: Diorman C. <dex...@gm...> - 2011-08-01 16:13:16
|
Hey guys I want to know what is going on with the plugin architecture development. I'm really interesting in finally releasing my project (Database designer) as a redistributable plugin. Maybe in few days I will have some kind of free time and I don't want to waste it :) Att Diorman Colmenares |
|
From: Leonardo S. <l.s...@gm...> - 2011-07-29 16:44:38
|
Jehan, > Review based on the diff between e70eb46..197c702 > > #1 > shouldn't "printTopbar" have the same code than "printNavLinks" in > regards with escaping simple attributes and the href one where we need > to escape the parameters as well? Yes, done. > #2 > in Misc.php:1137,1139,1157 > Why did you add html_entity_decode here ? You shouldn't, we need to keep > this part of code encoded! Ok, removed. > #3 in Misc.php:1138,1140,1169 > Why did you removed htmlspecialchars there ? Again, you shouldn't > because of code escaping ! Ok, I back that code, but with htmlentities. > #4 > plugins/Example/plugin.php:97,215,... > That seems wrong as well. I know it's about double encoding here, but we > are are doing html encoding in printActionUrl and decoding it right > after. it's a non-sens. You probably should focus on the place where the > second escaping happen. Yes, removed. > #5 > plugins/Example/plugin.php:121,135,...,827,... > Why do you urlencode here ? Shouldn't this task be done in the decorator > value_url() function called from printActionUrl... Done. > #6 > plugins/Example/plugin.php:441,447,... > I don't like the syntaxe where you call a function in a string. Prefer > explicit concatenation. Done. > That's all so far. Pay attention to the '...' in this review, it means I > saw a bunch of them but didn't list them all here. Yes, I review all. Thanks for your review Jehan :) -- Atenciosamente Leonardo Augusto Sápiras [http://www.leonardosapiras.com.br] |
|
From: Jehan-Guillaume (i. de R. <io...@fr...> - 2011-07-27 20:03:28
|
Review based on the diff between e70eb46..197c702 #1 shouldn't "printTopbar" have the same code than "printNavLinks" in regards with escaping simple attributes and the href one where we need to escape the parameters as well? #2 in Misc.php:1137,1139,1157 Why did you add html_entity_decode here ? You shouldn't, we need to keep this part of code encoded! #3 in Misc.php:1138,1140,1169 Why did you removed htmlspecialchars there ? Again, you shouldn't because of code escaping ! #4 plugins/Example/plugin.php:97,215,... That seems wrong as well. I know it's about double encoding here, but we are are doing html encoding in printActionUrl and decoding it right after. it's a non-sens. You probably should focus on the place where the second escaping happen. #5 plugins/Example/plugin.php:121,135,...,827,... Why do you urlencode here ? Shouldn't this task be done in the decorator value_url() function called from printActionUrl... #6 plugins/Example/plugin.php:441,447,... I don't like the syntaxe where you call a function in a string. Prefer explicit concatenation. That's all so far. Pay attention to the '...' in this review, it means I saw a bunch of them but didn't list them all here. |
|
From: Leonardo S. <l.s...@gm...> - 2011-07-07 14:37:41
|
Jehan and developers,
2011/7/5 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>:
> Review based on the full diff between master and
> e70eb46236f79ab6e47a5e97a7ccdf20505def4f
>
> Didn't test it, only reviewed the the code.
>
> #1
> in classes/Misc.php:1098
> in classes/Misc.php:1101
> $attr and $link['content'] should be escaped here. A malicious plugin might
> inject code here.
$attr escaped.
In portuguese the word 'History' will be write 'Histórico'
instead of 'Histórico'. Why does it happen?
> #2
> in classes/Misc.php:1137
> Instead of using $sql_url the way it is right now, I would either drop it or
> keep "&action=" out of the variable. It makes the code a bit more
> understandable/readable IMHO...
Changed
> #3
> in classes/Misc.php:printNavLinks()
> Same comments than in #1
If I escape $navlink['content'] I will have the same problem of #1.
> #4
> in classes/Misc.php:1260
> Why did you remove "htmlspecialchars" around "$crumb['text']" here ?
Because I had problems with accentuation, as I had in #1.
> #5
> in classes/Misc.php:printTable()
> $place should be defaulted to ''. Then, line 1687, the test should be:
> "if ($place == '') {".
>
> Moreover, why do you test the existence of $place ? Do we have some
> printTable call around were we don't want plugins to add actions ? If we
> don't, then I suggest to move $place parameter between $actions and $nodata
> in the function definition and make it non-optional.
Ok, order changed and useless conditional removed.
> #7
> in classes/Misc.php:printTable():1771-1777
> I guess $action['url'], $action['title'] and $action['target'] should be
> escaped here.
> Plus, double check $misc->printUrlVars is doing a proper work.
Sorry, I didn't understand that. IIRC I didn't mess in this code.
> #8
> in colproperties.php:269
> Erm, bad copy/paste ? :)
Hmn, yeah, fixed.
> #9
> in display.php
> We shouldn't have a 'displaybuttons' hook, it should be a 'actionbuttons'.
Why? I thought we would have a different hook. Do you mean we should
use the same 'actionbuttons' hook?
> #10
> in display.php:550
> $button['url'] and $button['title'] should be escaped here.
How to escape it? With htmlentities?
If I escape $button['url'], the '&' that were previous escaped for
'&' will be displayed as '&amp;' breaking the link.
If I use htmlentities for $button['title'], we will have problems with
words with accentuation. Like I said at #1.
> #12
> in display.php:638
> You don't need to use a variable here
Dropped
> #13
> in domains.php:208
> bad copy/paste, it should be $lang['strname']
Fixed
> #14
> in domains.php:225
> bad copy/paste, there's no multiaction in this table.
> (but feel free to add it if you want after the gsoc ;))
Removed.
> #15
> in groups.php:92
> See #14
Fixed
> #16
> in groups.php:96
> The default string to print when no user are in the group is 'strnousers',
> as it was in the original code.
Fixed
> #17
> in opclasses.php:54
> The label should be miss the action ('opclass-opclass' ?)
Changed.
>
> that's all :)
>
Thanks for review :)
The changes can be found at [http://bit.ly/qbmCJ9]
--
Atenciosamente
Leonardo Augusto Sápiras
[http://www.leonardosapiras.com.br]
|
|
From: Jehan-Guillaume (i. de R. <io...@fr...> - 2011-07-05 20:09:09
|
Review based on the full diff between master and
e70eb46236f79ab6e47a5e97a7ccdf20505def4f
Didn't test it, only reviewed the the code.
#1
in classes/Misc.php:1098
in classes/Misc.php:1101
$attr and $link['content'] should be escaped here. A malicious plugin
might inject code here.
#2
in classes/Misc.php:1137
Instead of using $sql_url the way it is right now, I would either drop
it or keep "&action=" out of the variable. It makes the code a bit more
understandable/readable IMHO...
#3
in classes/Misc.php:printNavLinks()
Same comments than in #1
#4
in classes/Misc.php:1260
Why did you remove "htmlspecialchars" around "$crumb['text']" here ?
#5
in classes/Misc.php:printTable()
$place should be defaulted to ''. Then, line 1687, the test should be:
"if ($place == '') {".
Moreover, why do you test the existence of $place ? Do we have some
printTable call around were we don't want plugins to add actions ? If we
don't, then I suggest to move $place parameter between $actions and
$nodata in the function definition and make it non-optional.
#7
in classes/Misc.php:printTable():1771-1777
I guess $action['url'], $action['title'] and $action['target'] should be
escaped here.
Plus, double check $misc->printUrlVars is doing a proper work.
#8
in colproperties.php:269
Erm, bad copy/paste ? :)
#9
in display.php
We shouldn't have a 'displaybuttons' hook, it should be a 'actionbuttons'.
#10
in display.php:550
$button['url'] and $button['title'] should be escaped here.
#12
in display.php:638
You don't need to use a variable here
#13
in domains.php:208
bad copy/paste, it should be $lang['strname']
#14
in domains.php:225
bad copy/paste, there's no multiaction in this table.
(but feel free to add it if you want after the gsoc ;))
#15
in groups.php:92
See #14
#16
in groups.php:96
The default string to print when no user are in the group is
'strnousers', as it was in the original code.
#17
in opclasses.php:54
The label should be miss the action ('opclass-opclass' ?)
that's all :)
|
|
From: Leonardo S. <l.s...@gm...> - 2011-06-20 16:20:38
|
Jehan and Andreas, >>> Thoughts ? >> >> My thought is: there should be only one such function. >> Having two different functions or functionality in place leads to >> future excuses to build more "workarounds". > > I 100% agree > >> Now is a good time to do it right, refactoring is already going on. > > Theoretically, yes, it would be the good time. But... > >> But: this is only my opinion, and I admit, I have no real idea how much >> work it is. Looked into the display.php but can't make an assumption >> here. > > I have a pretty good idea. It *might* be doable, but it gonna take a lot > of time and some design discussions. display.php is much more > complicated than others because of header links, icons in cells, links > on icon, ajax stuff, ... > > That's why I prefer either NOT hooking there or having a workaround. > > However, we might have a 3rd way: what about creating a 7th kind of hook > ? Does this place has some more needs or specificities than the other > actions ? I refactored those pages [https://gist.github.com/1029110], except display.php. Now they are using the Misc->printTable. For display.php, I created a 7th kind of hook. The code can be found at [http://bit.ly/m0rUyo]. Cheers. -- Atenciosamente Leonardo Augusto Sápiras [http://www.leonardosapiras.com.br] 2011/6/17 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>: > On 16/06/2011 20:35, Andreas 'ads' Scherbaum wrote: >> >> Hi, >> >> Am 16.06.2011 15:15, schrieb Jehan-Guillaume (ioguix) de Rorthais: >>> On 16/06/2011 15:05, Leonardo Sápiras wrote: >>>> Developers, >>>> >>>> I have created a hook for action buttons in PPA >>>> [http://wiki.postgresql.org/images/b/bd/Ppa_gsoc2011_screen.jpg]. Now >>>> I will refactor the the pages that shows it. >>>> >>>> [...] >>>> >>>> My question is, about the second one, can I put the hook directly in >>>> those places [https://gist.github.com/1029110]? >>> >>> I checked your list of file not using printTable. >>> IMO you should refactor the code to use printTable for all of them but >>> the display.php. >>> >>> I already tried to refactor display.php to use printTable in the past. >>> It sounds feasible, but it would take way too much time. I am wondering >>> if we need to hook a plugin action for each lines of a result set...my >>> opinion is that we could probably ignore this one. >>> >>> Thoughts ? >> >> My thought is: there should be only one such function. >> Having two different functions or functionality in place leads to >> future excuses to build more "workarounds". > > I 100% agree > >> Now is a good time to do it right, refactoring is already going on. > > Theoretically, yes, it would be the good time. But... > >> But: this is only my opinion, and I admit, I have no real idea how much >> work it is. Looked into the display.php but can't make an assumption >> here. > > I have a pretty good idea. It *might* be doable, but it gonna take a lot > of time and some design discussions. display.php is much more > complicated than others because of header links, icons in cells, links > on icon, ajax stuff, ... > > That's why I prefer either NOT hooking there or having a workaround. > > However, we might have a 3rd way: what about creating a 7th kind of hook > ? Does this place has some more needs or specificities than the other > actions ? > >> Regards > > > ------------------------------------------------------------------------------ > EditLive Enterprise is the world's most technically advanced content > authoring tool. Experience the power of Track Changes, Inline Image > Editing and ensure content is compliant with Accessibility Checking. > http://p.sf.net/sfu/ephox-dev2dev > _______________________________________________ > phpPgAdmin-devel mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel > |
|
From: Jehan-Guillaume (i. de R. <io...@fr...> - 2011-06-17 08:25:52
|
On 16/06/2011 20:35, Andreas 'ads' Scherbaum wrote: > > Hi, > > Am 16.06.2011 15:15, schrieb Jehan-Guillaume (ioguix) de Rorthais: >> On 16/06/2011 15:05, Leonardo Sápiras wrote: >>> Developers, >>> >>> I have created a hook for action buttons in PPA >>> [http://wiki.postgresql.org/images/b/bd/Ppa_gsoc2011_screen.jpg]. Now >>> I will refactor the the pages that shows it. >>> >>> [...] >>> >>> My question is, about the second one, can I put the hook directly in >>> those places [https://gist.github.com/1029110]? >> >> I checked your list of file not using printTable. >> IMO you should refactor the code to use printTable for all of them but >> the display.php. >> >> I already tried to refactor display.php to use printTable in the past. >> It sounds feasible, but it would take way too much time. I am wondering >> if we need to hook a plugin action for each lines of a result set...my >> opinion is that we could probably ignore this one. >> >> Thoughts ? > > My thought is: there should be only one such function. > Having two different functions or functionality in place leads to > future excuses to build more "workarounds". I 100% agree > Now is a good time to do it right, refactoring is already going on. Theoretically, yes, it would be the good time. But... > But: this is only my opinion, and I admit, I have no real idea how much > work it is. Looked into the display.php but can't make an assumption > here. I have a pretty good idea. It *might* be doable, but it gonna take a lot of time and some design discussions. display.php is much more complicated than others because of header links, icons in cells, links on icon, ajax stuff, ... That's why I prefer either NOT hooking there or having a workaround. However, we might have a 3rd way: what about creating a 7th kind of hook ? Does this place has some more needs or specificities than the other actions ? > Regards |
14 messages has been excluded from this view by a project administrator.
