phppgadmin-devel — For Developers Only

Re: [ppa-dev] Bug in head as of 2012-09-19?

[Karl O. P. <ko...@me...>]

On 09/25/2012 09:57:45 PM, Karl O. Pinc wrote:
> On 09/24/2012 11:00:16 AM, Jehan-Guillaume (ioguix) de Rorthais 
> wrote:
> > On 24/09/2012 17:06, Karl O. Pinc wrote:
> > > Hi,
> > > 
> > > I'm running head as of 2012-09-19 with pg 9.2.0 and got the
> > > following report from a user:
> > > 
> > > ---------------------------<snip>-----------------
> > > I'm having trouble working with my schema.  When I go to import a 
> > > table,
> > > things seem to go smoothly but then all the data columns in my
> > import
> > > file are dumped into a single phppgadmin column called "actions";
> > the
> > > columns I had created in phppgadmin for the data are left empty. 
> > This
> > > happens regardless of whether the import table structure is csv 
> or
> 
> > > text.
> > 
> > 
> > No bug...but again, I'm not sure to understand this report.

The problem is that display.php displays a column heading
"Action" under which buttons are supposed to appear,
even when there's no keys on the table and hence no
buttons appear.

create table foo(id int, data text);
insert into foo(id, data) values (1, 'bar');

Go browse the table.  You'll see an extra "Action" column
heading.

The attached patch fixes the problem.  I took only a localized
look at the code so I can't say whether this is the best
possible fix.  (Should the code really be counting buttons?
Makes sense in context....)


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

[ppa-dev] Bug when no server groups are defined in conf/config.inc.php

[Karl O. P. <ko...@me...>]

HI,

When running head against pg 9.2 I get messages like:

[Wed Sep 26 15:06:36 2012] [error] [client 69.17.73.250] PHP Notice:  
Undefined index: srv_groups in /srv/var/www/https/phpPgAdmin-head/
classes/Misc.php on line 2192, referer: https://gombemi.ccas.gwu.edu/
phpPgAdmin-head/browser.php
[Wed Sep 26 15:06:36 2012] [error] [client 69.17.73.250] PHP Warning:  
Invalid argument supplied for foreach() in /srv/var/www/https/
phpPgAdmin-head/classes/Misc.php on line 2192, referer: 
https://gombemi.ccas.gwu.edu/phpPgAdmin-head/browser.php

I'm using a relatively stock config, no server groups
are defined.  (The default config has server group
definitions commented out.)

The attached patch seems to fix the problem, although
I'm not sure it's the right thing to do.

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Bug in head as of 2012-09-19?

[Karl O. P. <ko...@me...>]

On 09/24/2012 11:00:16 AM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 24/09/2012 17:06, Karl O. Pinc wrote:
> > Hi,
> > 
> > I'm running head as of 2012-09-19 with pg 9.2.0 and got the
> > following report from a user:
> > 
> > ---------------------------<snip>-----------------
> > I'm having trouble working with my schema.  When I go to import a 
> > table,
> > things seem to go smoothly but then all the data columns in my
> import
> > file are dumped into a single phppgadmin column called "actions";
> the
> > columns I had created in phppgadmin for the data are left empty. 
> This
> > happens regardless of whether the import table structure is csv or 
> > text.
> 
> I'm not sure to understand this bug report. I tried:
> 
>   * "create table like..." to duplicate a table
>   * export the first table's data in a CSV file
>   * import the CSV file to the new table
>   * read the new table content.
> 
> No bug...but again, I'm not sure to understand this report.

I have not fully investigated, but if there is a problem it may
have to do with schemas.  If you have your own schema but it
is not in the database's default search_path (as "$user")
then that might be where this problem shows up.

You would create a table in your schema, but uploading into
it would do something odd.  (Exactly what I'm not sure since
I've not reproduced the problem.  I just fixed the search_path
to include $user and now I don't have the problem.)

I await hearing from the user to see if the problem is fixed
for them.  If so I'll have to poke about further and try
to reproduce the original problem so it can be fixed.
(It's unclear exactly when this will happen.)
Meanwhile I wanted to write back so you're all kept informed.

> 
> > Also, when I select one of the tables in my schema, I am
> automatically
> > brought to the import data window instead of a browse view.  This 
> > seemed
> > a bit odd to me.
> 
> This one is the "normal" behaviour though. We keep track of "last 
> tab"
> for each level (server, database, schema, table, view, ...) to show 
> it
> automatically when you come back to this level.

Ok.  Makes sense.

This does seem a little bit of a lot of state
for the user to keep in their head so they know what
to expect when they click on soemthing.
I suppose the state all goes away on logout, which
happens fairly quickly on inactivity so
everything resets to default fairly often.
(I don't have a better idea this hot minute
in any case, except for something like limiting
such state to the 20 most recently visited pages
or some such.  And I'm not sure this is really
a better idea.)

Thanks for the help.



Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Bug in head as of 2012-09-19?

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 24/09/2012 17:06, Karl O. Pinc wrote:
> Hi,
> 
> I'm running head as of 2012-09-19 with pg 9.2.0 and got the
> following report from a user:
> 
> ---------------------------<snip>-----------------
> I'm having trouble working with my schema.  When I go to import a 
> table,
> things seem to go smoothly but then all the data columns in my import
> file are dumped into a single phppgadmin column called "actions"; the
> columns I had created in phppgadmin for the data are left empty.  This
> happens regardless of whether the import table structure is csv or 
> text.

I'm not sure to understand this bug report. I tried:

  * "create table like..." to duplicate a table
  * export the first table's data in a CSV file
  * import the CSV file to the new table
  * read the new table content.

No bug...but again, I'm not sure to understand this report.

> Also, when I select one of the tables in my schema, I am automatically
> brought to the import data window instead of a browse view.  This 
> seemed
> a bit odd to me.

This one is the "normal" behaviour though. We keep track of "last tab"
for each level (server, database, schema, table, view, ...) to show it
automatically when you come back to this level.

> ---------------------------<snip>-----------------
> 
> I've not yet looked into it but thought I'd report it here
> in case someone can send me a clue.
> 
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein

[ppa-dev] Bug in head as of 2012-09-19?

[Karl O. P. <ko...@me...>]

Hi,

I'm running head as of 2012-09-19 with pg 9.2.0 and got the
following report from a user:

---------------------------<snip>-----------------
I'm having trouble working with my schema.  When I go to import a 
table,
things seem to go smoothly but then all the data columns in my import
file are dumped into a single phppgadmin column called "actions"; the
columns I had created in phppgadmin for the data are left empty.  This
happens regardless of whether the import table structure is csv or 
text.

Also, when I select one of the tables in my schema, I am automatically
brought to the import data window instead of a browse view.  This 
seemed
a bit odd to me.
---------------------------<snip>-----------------

I've not yet looked into it but thought I'd report it here
in case someone can send me a clue.

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] translation to Lithuanian language

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 17/09/2012 12:09, Egidijus wrote:
> Hello,

Hi,

> I go to the official website http://phppgadmin.sourceforge.net and
> downloaded all newest packages of phpPgAdmin (Released: /22th march 2012)/:
> [snip]

Ok, I understand, the lithuanian language has been added in our -dev
branch in may 2011, but not in our stable branch...

Please, download one of our snapshot from the download page, ie.:

  https://github.com/phppgadmin/phppgadmin/zipball/master

Any patch to improve/fix this translation is welcome!

Thank you for your work!

> Best regards,
> Egidijus
>  
>  
> -----Pirminis laiškas-----
> From: Jehan-Guillaume (ioguix) de Rorthais
> Sent: Monday, September 17, 2012 10:57 AM
> To: Egidijus
> Subject: Re: translation to Lithuanian language
>  
> Hello,
>  
> Sorry for delay, but I start watching at your patch.
>  
> It seems we already have a "Lithuanian" translation, referenced as "'lt'
> => 'lithuanian'" in translation.php. Why do you overwrite it in your
> patch ? Is it the same language ?
>  
> Moreover, could you send us your patch in full UTF-8 ? without recoding ?
>  
> Thank you.
>  
> On 12/08/2012 20:27, Egidijus wrote:
>> Hello,
>> 
>> phpPgAdmin hasn't translation into the Lithuanian language yet. So, I
>> did a translation of the "english.php" file to Lithuanian language. I
>> used my individual experience during translation.
>> I attached "lithuania.php" and  "translations.php" files for you. Both
>> files are prepared (recoded) for usage. I already use this Lithuanian
>> translation of phpPgAdmin in my own server. Everything works fine. You
>> can add these translation files to the newest packages of phpPgAdmin.
>> 
>> If you have questions please ask me.
>> 
>> Best regards,
>> Egidijus
>> 
>>
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>> From: Jehan-Guillaume (ioguix) de Rorthais
>> Sent: Wednesday, August 08, 2012 1:55 PM
>> To: Egidijus
>> Subject: Re: Warning during "Processes" browsing
>> 
>> Ok, I understood my mistake...
>> 
>> I already fixed this bug in the past on our -dev branch, but hadn't
>> backported it to 5.0. Here is the link to the patch:
>> 
>> 
>>
> https://github.com/phppgadmin/phppgadmin/commit/4e7fc159a48612b47e9e9de6b91776d4fa96b732
>> 
>> Thank you for reporting !
>> 
>> 
>> 
>> On 08/08/2012 12:35, Egidijus wrote:
>>> Hello,
>>>
>>> The lines around 6473 in file /phpPgAdmin/classes/database/Postgres.php
>>> are:
>>>
>>> /**
>>> * Determines whether or not a user is a super user
>>> * @param $username The username of the user
>>> * @return True if is a super user, false otherwise
>>> */
>>> function isSuperUser($username) {
>>>        $this->clean($username);
>>>
>>>        if (function_exists('pg_parameter_status')) {
>>>                $val = pg_parameter_status($this->conn->_connectionID,
>>> 'is_superuser');
>>>                if ($val !== false) return $val == 'on';
>>>        }
>>>
>>>        $sql = "SELECT usesuper FROM pg_user WHERE usename='{$username}'";
>>>
>>>        $usesuper = $this->selectField($sql, 'usesuper');
>>>        if ($usesuper == -1) return false;
>>>        else return $usesuper == 't';
>>> }
>>>
>>> I got this warning "Missing argument 1 for Postgres::isSuperUser()" in
>>> all cases: I was SuperUser and I was simple user (not super user). This
>>> is a global problem.
>>>
>>> When you find this problem and fix it. Please, inform me. I update my
>>> "phpPgAdmin 5.0.4". Thanks in advance.
>>>
>>> Best regards,
>>> Egidijus
>>>
>>>
>>>
>>> -----Pirminis laiškas----- From: Jehan-Guillaume (ioguix) de Rorthais
>>> Sent: Wednesday, August 08, 2012 11:33 AM
>>> To: Egidijus
>>> Subject: Re: Warning during "Processes" browsing
>>>
>>> On 08/08/2012 09:02, Egidijus wrote:
>>>> My software:
>>>> PostgreSQL 9.1.4
>>>> phpPgAdmin 5.0.4
>>>> PHP 5.3.8
>>>>
>>>> Hello,
>>>
>>> Hello,
>>>
>>>> I select my database and try to open "Processes" tab in menu of
>>>> phpPgAdmin 5.0.4. I'm getting these message:
>>>>
>>>> Warning: Missing argument 1 for Postgres::isSuperUser(), called in
>>>> /usr/local/www/phpPgAdmin/database.php on line 462 and defined in
>>>> /usr/local/www/phpPgAdmin/classes/database/Postgres.php on line 6473
>>>>
>>>> What does it mean? Can it be a bug of phpPgAdmin 5.0.4 ?
>>>
>>> It might be yes. However, I can't reproduce this issue.
>>>
>>> Could you please show me the lines around 6473, in particular, do you
>>> have this:
>>>
>>>  function isSuperUser($username = '') {
>>>
>>> ?
>>>
>>>> Thanks in advance for your answer.
>>>>
>>>> Best regards,
>>>> Egidijus
>  

Re: [ppa-dev] translation to Lithuanian language

[Jehan-Guillaume (i. de R. <io...@fr...>]

Hello,

Sorry for delay, but I start watching at your patch.

It seems we already have a "Lithuanian" translation, referenced as "'lt'
=> 'lithuanian'" in translation.php. Why do you overwrite it in your
patch ? Is it the same language ?

Moreover, could you send us your patch in full UTF-8 ? without recoding ?

Thank you.

On 12/08/2012 20:27, Egidijus wrote:
> Hello,
>  
> phpPgAdmin hasn't translation into the Lithuanian language yet. So, I
> did a translation of the "english.php" file to Lithuanian language. I
> used my individual experience during translation.
> I attached "lithuania.php" and  "translations.php" files for you. Both
> files are prepared (recoded) for usage. I already use this Lithuanian
> translation of phpPgAdmin in my own server. Everything works fine. You
> can add these translation files to the newest packages of phpPgAdmin.
>  
> If you have questions please ask me.
>  
> Best regards,
> Egidijus
>  
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> From: Jehan-Guillaume (ioguix) de Rorthais
> Sent: Wednesday, August 08, 2012 1:55 PM
> To: Egidijus
> Subject: Re: Warning during "Processes" browsing
>  
> Ok, I understood my mistake...
>  
> I already fixed this bug in the past on our -dev branch, but hadn't
> backported it to 5.0. Here is the link to the patch:
>  
>  
> https://github.com/phppgadmin/phppgadmin/commit/4e7fc159a48612b47e9e9de6b91776d4fa96b732
>  
> Thank you for reporting !
>  
>  
>  
> On 08/08/2012 12:35, Egidijus wrote:
>> Hello,
>>
>> The lines around 6473 in file /phpPgAdmin/classes/database/Postgres.php
>> are:
>>
>> /**
>> * Determines whether or not a user is a super user
>> * @param $username The username of the user
>> * @return True if is a super user, false otherwise
>> */
>> function isSuperUser($username) {
>>        $this->clean($username);
>>
>>        if (function_exists('pg_parameter_status')) {
>>                $val = pg_parameter_status($this->conn->_connectionID,
>> 'is_superuser');
>>                if ($val !== false) return $val == 'on';
>>        }
>>
>>        $sql = "SELECT usesuper FROM pg_user WHERE usename='{$username}'";
>>
>>        $usesuper = $this->selectField($sql, 'usesuper');
>>        if ($usesuper == -1) return false;
>>        else return $usesuper == 't';
>> }
>>
>> I got this warning "Missing argument 1 for Postgres::isSuperUser()" in
>> all cases: I was SuperUser and I was simple user (not super user). This
>> is a global problem.
>>
>> When you find this problem and fix it. Please, inform me. I update my
>> "phpPgAdmin 5.0.4". Thanks in advance.
>>
>> Best regards,
>> Egidijus
>>
>>
>>
>> -----Pirminis laiškas----- From: Jehan-Guillaume (ioguix) de Rorthais
>> Sent: Wednesday, August 08, 2012 11:33 AM
>> To: Egidijus
>> Subject: Re: Warning during "Processes" browsing
>>
>> On 08/08/2012 09:02, Egidijus wrote:
>>> My software:
>>> PostgreSQL 9.1.4
>>> phpPgAdmin 5.0.4
>>> PHP 5.3.8
>>>
>>> Hello,
>>
>> Hello,
>>
>>> I select my database and try to open "Processes" tab in menu of
>>> phpPgAdmin 5.0.4. I'm getting these message:
>>>
>>> Warning: Missing argument 1 for Postgres::isSuperUser(), called in
>>> /usr/local/www/phpPgAdmin/database.php on line 462 and defined in
>>> /usr/local/www/phpPgAdmin/classes/database/Postgres.php on line 6473
>>>
>>> What does it mean? Can it be a bug of phpPgAdmin 5.0.4 ?
>>
>> It might be yes. However, I can't reproduce this issue.
>>
>> Could you please show me the lines around 6473, in particular, do you
>> have this:
>>
>>  function isSuperUser($username = '') {
>>
>> ?
>>
>>> Thanks in advance for your answer.
>>>
>>> Best regards,
>>> Egidijus

Re: [ppa-dev] phpPgAdmin translation

[Jehan-Guillaume (i. de R. <io...@fr...>]

Hi,

Thank you for your translation !

Sorry for the late answer, I seen your other mails, but hadn't time to
deal with them yet.

I'll commit your translation as soon as possible.

Thank you !

On 17/08/2012 07:34, Egidijus Paliulis wrote:
> Hello
>  
> phpPgAdmin hasn't translation into the Lithuanian language yet. I
> attached "lithuania.php" and "translations.php" files for you. Both
> files are prepared (recoded) for usage. I already use this Lithuanian
> translation of phpPgAdmin in my own server. Everything works fine. You
> can add these translation files to the newest packages of phpPgAdmin.
>  
> If you have questions please ask me.
>  
> Best regards,
> Egidijus Paliulis

Re: [ppa-dev] Bug in PHP 5.4

[Jehan-Guillaume (i. de R. <io...@fr...>]

Hello Miguel,

On 08/06/2012 15:35, Miguel Useche wrote:
> Hello guys, i was testing ppa with PHP4 and it throws a error with 
> standart and the software stops. It says that only variables can be 
> passed as reference, if i change the 23 line of 
> classes/database/Connection.php to:
> 
> $this->conn = ADONewConnection('postgres7');
> 
> The problem solves, but i don't know how this affects older versions of 
> PHP.

Yeah, we heard about this problem, there's a couple of them around

> 
> Should i make a patch of this? to integrate it to the official release?

No, we'll fix them a bit later when we'll have time to study it.

Thank you !

[ppa-dev] Bug in PHP 5.4

[Miguel U. <mig...@sk...>]

Hello guys, i was testing ppa with PHP4 and it throws a error with 
standart and the software stops. It says that only variables can be 
passed as reference, if i change the 23 line of 
classes/database/Connection.php to:

$this->conn = ADONewConnection('postgres7');

The problem solves, but i don't know how this affects older versions of 
PHP.

Should i make a patch of this? to integrate it to the official release?

-- 
Visita http://www.skatox.com/ : Blog de Informática, Linux, Playstation 3, Windows, Software Libre, Videojuegos, Java y mucho mas....

Re: [ppa-dev] Releasing phpPgAdmin 5.0.4

[Devrim G. <de...@gu...>]

Hi

On Thu, 2012-03-22 at 15:22 +0100, Jehan-Guillaume (ioguix) de Rorthais
wrote:

> We released phpPgAdmin 5.0.4 today. Mostly bug and security fixes.

Fedora, Red Hat, CentOS and Scientific Linux packages are available
through community RPM repository. Fedora and EPEL repos will pick them
in 5 and 12 days respectively.

Regards,
-- 
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Community: devrim~PostgreSQL.org, devrim.gunduz~linux.org.tr
http://www.gunduz.org  Twitter: http://twitter.com/devrimgunduz

Re: [ppa-dev] Releasing phpPgAdmin 5.0.4

[Jehan-Guillaume (i. de R. <jg...@da...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 28/03/2012 15:35, Devrim GÜNDÜZ wrote:
> Hi
> 
> On Thu, 2012-03-22 at 15:22 +0100, Jehan-Guillaume (ioguix) de Rorthais
> wrote:
> 
>> We released phpPgAdmin 5.0.4 today. Mostly bug and security fixes.
> 
> Fedora, Red Hat, CentOS and Scientific Linux packages are available
> through community RPM repository. Fedora and EPEL repos will pick them
> in 5 and 12 days respectively.

Thank you Devrim !

> Regards,

- -- 
Jehan-Guillaume (ioguix) de Rorthais
http://www.dalibo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9zFQkACgkQXu9L1HbaT6K+dQCg8JoS3e4l/YACMiUdnMrBWH0f
LCEAn1EiQsg7jpaYNbYvqkJTRQzD6WQu
=bCxg
-----END PGP SIGNATURE-----

Re: [ppa-dev] Bugs in PHPPgAdmin 5.0.4

[Jehan-Guillaume (i. de R. <io...@fr...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 25/03/2012 23:52, radu i. wrote:
> Hi,

Hello,

> Your app is great stuff. I would rate as 9.5 from 10 !!!
> I tried to contact you to report this bug but I cannot found
> any bug report on your website, so I write here.

Our bug tracker is on sourceforge:

  http://sourceforge.net/tracker/?group_id=37132&atid=418980

> Please notice 2 bugs:
> 
> === BUG #1 (major)
> 
> There is a bug in PHPPgAdmin 5.0.3 and 5.0.4 (I did not test
> with previous versions).
> If I dump a DB with pg_dump and then import via PhpPgAdmin,
> text fields will contain an extra line after import via
> PhpPgAdmin.
> 
> it should be:
> Line1
> Line2
> 
> but is:
> Line1
> (... this is the extra line)
> Line2
> 
> If I import directly with PHP using pg_query method is all fine.
> If I import with PgAdmin3 is all fine.
> But when I import with PhpPgAdmin the above problem occurs
> (adding an extra line).
> 
> Please note that I tried with all 3 combinations as:
> \\n (Unix)
> \\r\\n (DOS)
> \\r (Mac)
> and all 3 gives the problem with PhpPgAdmin.

I'm not sure to understand what you mean here.

AFAIU, You dumped your database using pg_dump, then, upload the SQL file
using phpPgAdmin (SQL tab in the database/schema level) ?

Doing this, I can not reproduce your bug.

> === Bug #2 (minor)
> 
> After upgrading to 5.0.4 from 5.0.3, the slony menu entry
> appears but slony is set to false.
> It appears that in 5.0.4 slony menu links cannot be disabled
> in any case, even if slony is set to false (off) in config.

Fixed in our dev repository. This was a regression I introdiced while
fixing a PHP warning :/

Thank you for your report !

> 
> Cheers,
> Radu
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9wKrQACgkQxWGfaAgowiIOWACfRlh81SpqFlg2fVIjyYaHTzlb
LD4AnAsw2MEbdh2xAnqD1wwkiv9NkRdt
=dR1K
-----END PGP SIGNATURE-----

[ppa-dev] phpPgAdmin 5.0.4 released !

[Jehan-Guillaume (i. de R. <jg...@da...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

==== Version 5.0.4 ====

Released: 22th March 2011

This fourth update of the phpPgAdmin 5.0 branch brings some bug and
security fixes. Details bellow.

==== Download ====

To download phpPgAdmin 5.0.4 right now, visit:

http://phppgadmin.sourceforge.net/doku.php?id=download

==== Changelog ====

Some bug fixes.

* Fix #3468882 "UPDATE single row with varchar key: empty where clause",
reported by "Dirk Kraemer"
* Fix XSS in function.php, reported by Mateusz Goik
* Fix bug where renaming a tablespace was leading to an error
* Fix a bug where clicking to "Show all schemas" on schema privilege
page leads back to the latest tab used in database level
* Fix a bug when executing a query from the history
* Fix bad confirmation message when droping an autovacuum table setup
* Fix bug #3429633 '"Back" link from "Browse" leads to error'
* Fix a PHP warning when Slony conf parameters are not set
* Show cancel/kill actions in process page only if role is a superuser
* Some more small code cleanup and fixes.


Regards,
- -- 
The phpPgAdmin Teamom

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9rSHwACgkQXu9L1HbaT6KvOQCgs70rn9nPqm/FKKr90tk3XaDc
JN8AoI8JUVpWQ9q7EZBQkc9l32nujf+C
=4Iyr
-----END PGP SIGNATURE-----

[ppa-dev] Releasing phpPgAdmin 5.0.4

[Jehan-Guillaume (i. de R. <jg...@da...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dear packagers,

We released phpPgAdmin 5.0.4 today. Mostly bug and security fixes.

You can download it directly from sf.net:

https://sourceforge.net/projects/phppgadmin/files/phpPgAdmin%20%5Bstable%5D/phpPgAdmin-5.0/

I am available by email or on IRC (freenode.net #phppgadmin) if you have
any question.

And thanks again for your support !

- -- 
The phpPgAdmin Team
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9rNZEACgkQXu9L1HbaT6JPBgCg0M5hq1nxTzwgccnQ6P6B82Kx
YoQAn2NX24mqhL0K5R/mfjPXcmXcDzw4
=xgOB
-----END PGP SIGNATURE-----

[ppa-dev] XSS in functions.php (listing functions)

[metalog <me...@me...>]

Hello.

XSS in functions.php (listing functions)

If you add a function called "><script>alert(333)</script>.The code will
be executed. In case of problems with the addition of functions (with
that name), please use the "pgAdmin" and then see what is happening in
phpPgAdmin.

I agree to put my name in changelog.

Mateusz Goik.

Re: [ppa-dev] phpPgAdmin new plugin architecture

[Diorman C. <dex...@gm...>]

Hey,

I'm developing a plugin and I found a problem. When the language set in the
browser has the country part (i.e. 'en-us'), ppa fails to determine the
language and the most affected part is the plugin manager due the var
$_language is not set, getting the next error

Notice: Undefined variable: _language in .../libraries/lib.inc.php on line
256 Call Stack: 0.0000 633960 1. {main}() .../index.php:0 0.0011 741184 2.
include_once('.../libraries/lib.inc.php') .../index.php:11

I downloaded the ppa application from this link
http://phppgadmin.sourceforge.net/doku.php?id=devs:start

I think this code replacement could work to fix this behavior. If the
language(i.e. 'en-us') is not found and it has the dash character, We need
to split the string to get the first part and try again

File: libraries/lib.inc.php at line: 142

THIS IS THE CURRENT CODE!!!

foreach($_m as $_l) {  // $_l[1] = language tag, [2] = quality
if (!isset($_l[2])) $_l[2] = 1;  // Default quality to 1
if ($_l[2] > 0 && $_l[2] <= 1 && isset($availableLanguages[$_l[1]])) {
// Build up array of (quality => language_file)
$_acceptLang[$_l[2]] = $availableLanguages[$_l[1]];
}
}

THIS IS THE CODE I PROPOSE!!!

foreach($_m as $_l) {  // $_l[1] = language tag, [2] = quality
if (!isset($_l[2])) $_l[2] = 1;  // Default quality to 1
if ($_l[2] > 0 && $_l[2] <= 1 && isset($availableLanguages[$_l[1]])) {
// Build up array of (quality => language_file)
$_acceptLang[$_l[2]] = $availableLanguages[$_l[1]];
}
// this is the new part I propose
else {
$dash_pos = strpos($_l[1], '-');
if($dash_pos !== FALSE){
$_l[1] = substr ($_l[1], 0, $dash_pos);
if ($_l[2] > 0 && $_l[2] <= 1 && isset($availableLanguages[$_l[1]])) {
$_acceptLang[$_l[2]] = $availableLanguages[$_l[1]];
}
}
}
}


I hope this could be helpful for you

Regards!

[ppa-dev] PPA UTF-8 only core

[Jehan-Guillaume (i. de R. <io...@fr...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Following the work we have done with Nozomi Anzai from SRA OSS last
summer, I polished a bit the patch, updated the TRANSLATORS and
lang/README file, removed not needed anymore files and committed the
patch in a new branch (utf-8) of the official phpPgAdmin repo:

  https://github.com/phppgadmin/phppgadmin/tree/utf-8

This patch is important in different ways:

  * security reasons: it paves the way to a better htmlentities
escaping, which will be the subject of a futur patch. No more UTF-7
security issues !
  * no more recode stuffs. Easier to create/update a translation file
  * simpler code: it removes some kind of complexity
  * plugin architectures: clean some pieces of code that are
show-stopper right now. I've got a fix for that, but it would be even
cleaner.

Developers, translators, could you please get the current code in this
branch and make some tests ? you can either:

  git clone git://github.com/phppgadmin/phppgadmin.git
  git checkout -t origin/utf-8

or directly download the archive:

  * zip: https://github.com/phppgadmin/phppgadmin/zipball/utf-8
  * tar.gz: https://github.com/phppgadmin/phppgadmin/tarball/utf-8

Thank you for your feedbacks !
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk79p6wACgkQxWGfaAgowiKrqACggiOL45rCA9FgWZ1JZqElwhNu
Pt8An12KjTOXl/UGYkP33t20MlNZGHUg
=L7BW
-----END PGP SIGNATURE-----

[ppa-dev] Change in the selenium tests architecture

[Jehan-Guillaume (i. de R. <io...@fr...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

while working on integrating code coverage, I realized I could remove
the build_tests.php alltogether, making our functional tests fully
automatics.

So I commited my patch in master last night:


https://github.com/phppgadmin/phppgadmin/commit/3c0c7c0da2e0c7fb6dd73106c396646f7dd1d3bc

Now, running tests is just a matter of:
  * setting up your "tests/selenium/config.test.php"
  * running the tests: just follow the selenium link in the intro page.

I have now a pending PoC for integrating PHP-code-coverage in PPA
(remember http://swsoft.nsu.ru/~abaturin/results-74-91/ ?).

It require some php setup and is not able yet to add files that are not
touched by the selenium tests (the one with 0% tested), but it is
already pretty useful.

cheers
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk79oSgACgkQxWGfaAgowiLZ+gCbBMTRwuthL1J6q0HWWv3+7g+G
gNQAoJReqEzhRYnD1H0IGloILLTjmEno
=ssjy
-----END PGP SIGNATURE-----

[ppa-dev] Fixing bug #3429633 '"Back" link from "Browse" leads to error'

[Jehan-Guillaume (i. de R. <io...@fr...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

This is a pretty hot subject for some reasons. First this bug forbid me
to finish Leonardo's plugin architecture, second the old design of these
links is just wrong and finally, we need to fix this bug.

PFA my patch that refactor this part of the code. It makes it a bit more
rigid and introduce a regression:
We don't have the back link anymore when browsing data through FK links
in plain HTML (ie. without javascript/ajax activated).

I believe we'll be able to fix this regression later with a dedicated
algo, but it doesn't seems that important presently considering the
"back" button from any browser without javascript is good enough for
this anyway.

It's pretty important to go over this as I have a bunch of work waiting
for this that I would like to push forward :/

Thank you for your tests and comments.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk78visACgkQxWGfaAgowiJlRgCcCdqn/Agzg9OCNDRLDUPAzffP
8wAAn1t171yOpG06yJut39U5swir2Kge
=gYDx
-----END PGP SIGNATURE-----

Re: [ppa-dev] blue/green theme fix

[Tomasz P. <go...@po...>]

Hi,

On Tue, Nov 01, 2011 at 23:11:05 +0100, Jehan-Guillaume (ioguix) de Rorthais wrote:

>>>> theme. I've resolved one more issue (image links of constraints which
>>>> can't be block-displayed) 
> 
> I would rather add a specific class for each constraints image, not a
> generic one in the <a> tag. would it helps you ?

Sure, they just need to be enumerated in CSS file:

td a:not(.help):not(.img):not(......)

> About the table comment, I am just not agree with your code. I would
> rather add the following code to any comment column definition:
[...]
> Yes, it's a larger patch, but it does make more sense to me put this
> properties in the column definition itself than in a code that is
> supposed to be generic.

It's fine for me as long as this column is distinguishable in CSS
description (p.comment, td.comment). I've just took '<p class=\"message\">'
(from {admin,classes/Misc}.php) as an example.

>> this time to handle Null checkbox in
>> block way (clicking on entire cell area works). Introduced DOM elements
>> and CSS solutions might be used in other styles as well (especially the
>> block links). 
> 
> I don't understant why you need to introduce both <label> AND <span>.

This is nothing more than CSS hack to made block element vertically
middle-aligned (at least in Fx 3.6), which is The Thing CSS doesn't
support at all...

> Here, label doesn't really make sens to me as there's actually no label,
> but as I understand it, it would be the only way to be able to click the
> entire cell.
> Can we remove the span ?

Well, you need both to have entire cell clickable AND vertical middle
align of checkbox element. One of them (I can't remember which now) can
be removed and you still be able to click anywhere within the cell
borders (which is the main purpose, that should be used in all the
themes), but checkbox will be positioned at the top of the cell (this
was only secondary objective - links in my theme are not vertically
positioned).
It's up to you, if you prefer proper DOM vs nice look. Please check this
in mainstream browsers, maybe it will ease choice of one vs another.
Especially, if my solution doesn't work fully in Fx4+, Chrome, Opera, IE9+ -
I can focus on clickability only (with reasonable DOM), not alignment.

-- 
Tomasz Pala <go...@pl...>

Re: [ppa-dev] blue/green theme fix

[Jehan-Guillaume (i. de R. <io...@fr...>]

Hello,

On 21/10/2011 00:19, Tomasz Pala wrote:
> On Wed, Feb 16, 2011 at 16:06:24 +0100, Tomasz Pala wrote:
> 
>>> theme. I've resolved one more issue (image links of constraints which
>>> can't be block-displayed) 

I would rather add a specific class for each constraints image, not a
generic one in the <a> tag. would it helps you ?

I thought about adding specific class to many different buttons-like
links, links and image in the past but never took the time to give it a
try.

It would help having a theme using icons to replace completely some
text, the actions buttons as instances (edit, alter, drop, privilege, ...).

>>> and made better display of column comments
>>> (now it would be consistent with table comments) - please review
>>> attached patch.

About the table comment, I am just not agree with your code. I would
rather add the following code to any comment column definition:

  'params' => array('class' => 'comment')

As instance:
  ...
  'comment' => array(
    'title' => $lang['strcomment'],
    'field' => field('relcomment'),
    'params' => array('class' => 'comment')
  ),
  ...

Yes, it's a larger patch, but it does make more sense to me put this
properties in the column definition itself than in a code that is
supposed to be generic.

>> Apart from new p.message color the patch doesn't differ from previous
>> one.
> 
> Once again I've updated this theme,

Thank you.

> this time to handle Null checkbox in
> block way (clicking on entire cell area works). Introduced DOM elements
> and CSS solutions might be used in other styles as well (especially the
> block links). 

I don't understant why you need to introduce both <label> AND <span>.
Here, label doesn't really make sens to me as there's actually no label,
but as I understand it, it would be the only way to be able to click the
entire cell.
Can we remove the span ?

> Note, this is the last time I'm sending this, as my last
> patches were left unreplied.

I hear you. I'm sorry for being silent for such long time, but I'm sure
you can understand a project just can't rely on only one person neither.
If you want PPA to be a bit more alive, you should rather stay around
and help.

Thank you.

Re: [ppa-dev] [ppa-help] Paginate results by default

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 26/10/2011 18:25, rj...@ig... wrote:
> The following data was submitted on 2011/10/26 16:25.
> 
> Name
> 		Renato Alves
> PostgreSQL ver.
> 		8.4.8
> phpPgAdmin ver.
> 		5.0.3
> Comments
> 		Dear Developers and Maintainers of phpPgAdmin,
> 
> On several occasions we have found ourselves in trouble by having users doing queries on the interface that output a considerable amount of results while forgetting to activate the "paginate results" option.
> 
> In the past we have changed the code to set this form field to active by default. However this requires patching the code on every update.
> 
> My question is therefore if there is any option/setting that we can set in order to have pagination active by default. If there isn't, would it be possible to include this option in a future release?

Hello,

It's a rather simple feature request.

I have committed it in our current dev branch:

  https://github.com/phppgadmin/phppgadmin/

for a snapshot:
  https://github.com/phppgadmin/phppgadmin/zipball/master

Cheers,

> 
> Kind regards,
> Renato

-- 
ioguix

Re: [ppa-dev] blue/green theme fix

[Tomasz P. <go...@po...>]

On Wed, Feb 16, 2011 at 16:06:24 +0100, Tomasz Pala wrote:

>> theme. I've resolved one more issue (image links of constraints which
>> can't be block-displayed) and made better display of column comments
>> (now it would be consistent with table comments) - please review
>> attached patch.
> 
> Apart from new p.message color the patch doesn't differ from previous
> one.

Once again I've updated this theme, this time to handle Null checkbox in
block way (clicking on entire cell area works). Introduced DOM elements
and CSS solutions might be used in other styles as well (especially the
block links). Note, this is the last time I'm sending this, as my last
patches were left unreplied.

-- 
Tomasz Pala <go...@pl...>

Re: [ppa-dev] phpPgAdmin new plugin architecture

[Miguel U. <mig...@sk...>]

Yes i would like to, I could add some non-documented stuff.

I'll try to dedicate 3 hours a week to create and improve the CRUD 
plugin so i could find some problems with the documentation along the 
whole process.

El 18/10/11 17:43, Jehan-Guillaume (ioguix) de Rorthais escribió:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> We talked about that with Leonardo before lunch at pgconf.eu.
>
> Miguel, do you want a wiki account so you can contribute to the
> documentation... and fix the doc when you think it is needed ?
>
> On 08/10/2011 20:56, Miguel Useche wrote:
>> I just found some documentation bug at Misc.php. On line 1678 there is a
>> new $place variable added as the fourth parameter, but in the
>> documentation says it is on the last position, so you should fix the
>> documentation to avoid misunderstand. Is simple but it confused me a
>> little bit.
>>
>> El 26/08/11 07:55, Leonardo Sápiras escribió:
>>>     Hi devs,
>>>
>>>> Congrats bro, I'll try to make some time before next version of PPA to
>>>> migrate mi CRUD to your plugin architecture.
>>> Thanks Miguel :)
>>>
>>> The documentation that explains how to create plugins for phpPgAdmin
>>> can be found at
>>> [http://phppgadmin.sourceforge.net/doku.php?id=devs:plugins_documentation].
>>>
>>>    Cheers!
>>>
>>>
>>> --
>>> Atenciosamente
>>> Leonardo Augusto Sápiras
>>> [http://www.leonardosapiras.com.br]
>>>
>>>
>>>
>>> 2011/8/23 Miguel Useche<mig...@sk...>:
>>>> Congrats bro, I'll try to make some time before next version of PPA to
>>>> migrate mi CRUD to your plugin architecture.
>>>>
>>>> El 23/08/2011 09:25 a.m., Leonardo Sápiras escribió:
>>>>
>>>>     Jehan, Andreas and devs,
>>>>
>>>>     Attached the patches with all our work.
>>>>
>>>> 2011/8/22 Andreas 'ads' Scherbaum<ad...@wa...>:
>>>> [...]
>>>>
>>>> I read it and sent some changes to Leonardo (on IRC).
>>>> What I also mentioned: he should add some info, where new plugins should be
>>>> published, so every user knows about them. And it probably makes sense to
>>>> add some license information.
>>>>
>>>> Will not the plugins' license be the same of phpPgAdmin one? Do the
>>>> plugins need to have specific licenses? Why?
>>>>
>>>> In general: well done. Thanks Leonardo.
>>>>
>>>> Thanks you guys :)
>>>>
>>>>
>>>> --
>>>> Atenciosamente
>>>> Leonardo Augusto Sápiras
>>>> [http://www.leonardosapiras.com.br]
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
>>>> user administration capabilities and model configuration. Take
>>>> the hassle out of deploying and managing Subversion and the
>>>> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
>>>>
>>>>
>>>> _______________________________________________
>>>> phpPgAdmin-devel mailing list
>>>> php...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel
>>>>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk6d+gkACgkQxWGfaAgowiLHDACdFlhN2w9Wo5Vk0yci9f6enwQg
> oLcAoIzMelzMB+4oMugdS/wLs6RTINsX
> =VBA9
> -----END PGP SIGNATURE-----

-- 
Visita http://www.skatox.com/ : Blog de Informática, Linux, Playstation 3, Windows, Software Libre, Videojuegos, Java y mucho mas....