phppgadmin-devel — For Developers Only

Re: [ppa-dev] New PPA website

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 07/03/2011 14:51, Nicola Soranzo wrote:
> Alle domenica 6 marzo 2011, Jehan-Guillaume (ioguix) de Rorthais ha scritto:
>> Hey ppa devs,
> ...
>>
>> Doing so, I updated the FAQ:
>>     * added 2 new questions
>>     * updated 3 or 4 of them
>>     * removed one very old question
>>
>> Please, have a look on it and report any error or misspelling.
>
> Hi Jehan,
> a few typos in the updated FAQ:
> Question 3: connexion ->  connection , seprated ->  separated , After changing -
>> after changing
> Question 6: every pages ->  every page , rely ->  relies , PHP have ->  PHP has ,
> server have ->  server has , were ->  where

Fixed !

Thank you for your review and fixes :)

> Best,
> Nicola

Re: [ppa-dev] New PPA website

[Nicola S. <nso...@ti...>]

Alle domenica 6 marzo 2011, Jehan-Guillaume (ioguix) de Rorthais ha scritto:
> Hey ppa devs,
...
> 
> Doing so, I updated the FAQ:
>    * added 2 new questions
>    * updated 3 or 4 of them
>    * removed one very old question
> 
> Please, have a look on it and report any error or misspelling.

Hi Jehan,
a few typos in the updated FAQ:
Question 3: connexion -> connection , seprated -> separated , After changing -
> after changing
Question 6: every pages -> every page , rely -> relies , PHP have -> PHP has , 
server have -> server has , were -> where

Best,
Nicola

-- 
Nicola Soranzo, Ph.D.

Personal: http://nsoranzo.altervista.org

My PGP key: http://nsoranzo.altervista.org/key.asc

[ppa-dev] New PPA website

[Jehan-Guillaume (i. de R. <io...@fr...>]

Hey ppa devs,

So I finally moved our old website to dokuwiki:

   http://phppgadmin.sf.net

My main goals are:

   * store project related files in the wiki instead of the old and 
deprecated CVS
   * remove the website to our old CVS repo
   * drop the CVS repo on sf.net
   * easier to update when releasing a new version
   * easier to maintain the FAQ
   * share some rights with anyone who want to contribute to the website

Doing so, I updated the FAQ:
   * added 2 new questions
   * updated 3 or 4 of them
   * removed one very old question

Please, have a look on it and report any error or misspelling.

Old website is still accessible at:

   http://phppgadmin.sf.net/old-site/

Feel free to answer to this mail if you want an account on this wiki.

Cheers,
-- 
Jehan-Guillaume (ioguix) de Rorthais

[ppa-dev] [PATCH] urls for direct login to a server

[Gerd v. E. <li...@eg...>]

Hi,

I use phpPgAdmin with just one server, phpPgAdmin and postgresql are installed 
on the same machine. When I open the URL of phpPgAdmin I always have to select 
a db server tough. To open the login screen for one db server I have to do one 
or two additional clicks. I have seen no possibility to encode the db to login 
at in the url. This annoys my users.

So I created the attached patch. With it you can e.g. link to

http://dbserver.lan/phpPgAdmin/index.php?dblogin=%3A5432%3A

and the login to the local db instantly opens without breaking any of the 
frames or other negative side effects.

Kind regards,

Gerd

-- 
Address (better: trap) for people I really don't want to get mail from:
jo...@ca...

[ppa-dev] [PATCH] fix truncating UTF-8 chars

[Gerd v. E. <li...@eg...>]

Hi,

my database is configured to use UTF-8 and my database contains a lot of non-
ascii chars (German Umlauts).

When I browse a database the strings shown are truncated to a maximum number 
of characters per field. When a non-ascii char is at the maximum numbers of 
chars shown per field, it is broken without care for UTF-8, resulting in an 
invalid character shown.

The attached patch fixes it. But it requires the php multibyte extension.

Kind regards,

Gerd
-- 
Address (better: trap) for people I really don't want to get mail from:
jo...@ca...

[ppa-dev] test captcha from PPA website

[<io...@fr...>]

The following data was submitted on 2011/03/02 23:00.



====== E-mail ======

Name
		ioguix test captcha
PostgreSQL ver.
		9.0
phpPgAdmin ver.
		5.0
Comments
		sorry to bother you with tests guys...

/ioguix

[ppa-dev] blah, yet another test

[<io...@fr...>]

The following data was submitted on 2011/03/02 21:33.



====== E-mail ======

Name
		ioguix yet another test
PostgreSQL ver.
		9.0
phpPgAdmin ver.
		5.0
Comments
		yes another test...

[ppa-dev] test from wiki form

[<io...@fr...>]

The following data was submitted on 2011/03/02 21:13.



====== E-mail ======

Name
		ioguix test
PostgreSQL ver.
		9.0
phpPgAdmin ver.
		5.1-dev
Comments
		testing the e-mail formular from the wiki on phppgadmin.sf.net/wiki

[ppa-dev] test from wiki form

[<io...@fr...>]

The following data was submitted on 2011/03/02 21:08.



====== E-mail ======

Name
		ioguix test
PostgreSQL ver.
		9.0
phpPgAdmin ver.
		5.1-dev
Comments
		testing the e-mail formular from the wiki on phppgadmin.sf.net/wiki

[ppa-dev] blue/green theme fix

[Tomasz P. <go...@po...>]

On Fri, Feb 04, 2011 at 23:12:41 +0100, Tomasz Pala wrote:

> theme. I've resolved one more issue (image links of constraints which
> can't be block-displayed) and made better display of column comments
> (now it would be consistent with table comments) - please review
> attached patch.

Apart from new p.message color the patch doesn't differ from previous
one.

-- 
Tomasz Pala <go...@pl...>

[ppa-dev] Galician translation update

[Adrián C. F. <adr...@gm...>]

Hi again.

A fellow translator contacted me to suggest some changes to the current 
translations. I agreed with him, and as a result I updated Galician 
translation.

Also, he told me to use the Translate Toolkit tools (I had never use them 
before), which made it quite confortable to work with the translation :)

Re: [ppa-dev] Database SQL query form submit on Ctrl+Enter

[Tomasz P. <go...@po...>]

On Wed, Jan 19, 2011 at 00:50:18 +0100, Tomasz Pala wrote:

> Finally I did grep -n accessk /usr/share/phpPgAdmin/**/* 2>/dev/null and
> ported all the accesskeys I'm using to current 5.0.2 - see attached
> patch. However:

I forgot to mention that last chunks of that patch was tiny fix of my
theme. I've resolved one more issue (image links of constraints which
can't be block-displayed) and made better display of column comments
(now it would be consistent with table comments) - please review
attached patch.

-- 
Tomasz Pala <go...@pl...>

Re: [ppa-dev] Import data via compressed files

[Leonardo S. <l.s...@gm...>]

  Dear Jehan and PPA developers,

  Attached the alpha patch for this feature.

  I am only checking if the zip file has more than one file, showing a
message when it happens. Do you think interesting check if the
uncompressed gzip (or bzip or others) has a tar result? And showing a
message as well?

  I put the following 'TODO' comment in the code:

  "implement LZF, Phar, Rar types"

 Do you think interesting to keep this comment there? Or to put it in
the TODO file? Or Both?

 Any comment or suggestion about the patch?

 Cheers! :)

--
Atenciosamente
Leonardo



2011/1/10 Leonardo Sápiras <l.s...@gm...>:
>  Jehan, Carl and ppa developers:
>
>  Below I merged your answers with my comments :)
>
>> Mh, that's not what I meant.
>> There's a "SQL" tab in the database/schema level where we can upload
>> already upload a SQL script.
>
>  Ok
>
> [Carl comment]
>
>> I suspect this is going to interfere with my changes to user-submitted
>> sql processing.  I guess we'll just see how it goes.
>
> My intension is only deal with the upload function (executeScript in
> the Postgres class). If my patch interfere with yours, let me know,
> and together we solve it :)
>
>
>>>   I will handle it discovering the type of compressed file using the
>>> $_FILES[$name]['type'] var. Do you agree with that? Or think that
>>> would be more interesting use the file's extension to discover the
>>> compressed type? Or should I get the type with another way?
>>
>> Yeah, I suppose we can have different mode:
>>  * auto-detect, based on extension
>>  * user defined using radio button
>>
>>>   Another point is, in a first moment too, I will deal the compressed
>>> with one sql file. I am little confuse how to deal with more than one
>>> sql file.
>>
>> No, we will deal with one SQL file at a time. Don't mess with that.
>>
>>> In second moment, IMHO, the ppa should show the files
>>> uncompressed, asking the user what should be the order of import.
>>
>> I disagree. There's no point upload a compressed SQL script if we have to
>> send back its uncompressed version to the client over the network.
>
>  I think this feature would be interesting, but not returning all the
> uncompressed content to user, just the name of uncompressed files.
> Anyway, it's just an idea, and I don't know how deal with it for now.
> Maybe on future.
>
>>>   Above some comments that how uncompress the following type:
>>>
>>>   Zip: I will check if the php has the zip extension, if it hasn't the
>>> ppa will show a message that this extension is necessary to
>>> uncompress. More detais about the zip extension in
>>> [http://br.php.net/manual/en/book.zip.php];
>>
>> The zip is only supported since PHP 5.2.
>
>  Yes
>
>>
>>>   Gzip: I will use the zlib extension
>>> [http://br.php.net/manual/en/book.zlib.php];
>>>
>>>   Bzip: I will use the bzip2 library
>>> [http://br.php.net/manual/en/book.bzip2.php];
>>
>> Both gzip and bzip are not included in PHP by default.
>>
>> So you will have to check what are the compression supported by the PHP
>> installation before handling each of them, showing radios with supported
>> compression type, etc...
>
>  Yes, we will need to check if the PHP have this features. User
> defined using radio button is an interesting idea. This way we don't
> auto-detect and if the user send a compressed type different of its
> selection, the PHP uncompress function will not have success, so we
> print a message explaining some reasons for it fail.
>
>  Cheers!
>
> --
> Atenciosamente
> Leonardo
>
>
>
> 2011/1/10 Karl O. Pinc <ko...@me...>:
>> On 01/10/2011 09:28:07 AM, jg...@da... wrote:
>>>
>>> On Sun, 9 Jan 2011 16:14:07 -0200, Leonardo Sápiras
>>> <l.s...@gm...>
>>> wrote:
>>> > Hi Jehan and ppa developers,
>>> >
>>> >  Thanks for answer Jehan, above my answers:
>>> >
>>> >> Moreover, you could add this feature to the SQL script executor as
>>> well
>>> >> (SQL tab on database level).
>>> >
>>> >   Sure, I will do it there, creating a 'Import' tab on database
>>> level
>>> too.
>>>
>>> Mh, that's not what I meant.
>>> There's a "SQL" tab in the database/schema level where we can upload
>>> already upload a SQL script.
>>
>> I suspect this is going to interfere with my changes to user-submitted
>> sql processing.  I guess we'll just see how it goes.
>>
>>
>>
>> Karl <ko...@me...>
>> Free Software:  "You don't pay back, you pay forward."
>>                 -- Robert A. Heinlein
>>
>>
>

Re: [ppa-dev] Database SQL query form submit on Ctrl+Enter

[Tomasz P. <go...@po...>]

On Sat, Jan 08, 2011 at 14:02:08 +0100, Tomasz Pala wrote:

>> It would probably better to merge both of your ideas and, *if possible*,
>> avoid js and use the standard accesskey parameter ?
>> 
>> Tomasz, could you send us your patch ?
> 
> For now I've attached my old code I've send here a long time ago - it's
> pretty trivial, much of the work required is to choose some rational and
> sane accelerators. Later I can send you all the places I'm currently
> using shortcuts, coding this itself is not an issue.

Finally I did grep -n accessk /usr/share/phpPgAdmin/**/* 2>/dev/null and
ported all the accesskeys I'm using to current 5.0.2 - see attached
patch. However:

$ grep submit **/* | wc -l
279

show MUCH more places to handle - I've focused only on those I'm using
frequently. Again - all these awful:

echo "<input type=\"submit\" name=\"select\" accesskey=\"r\" value=\"{$lang['strselect']}\" />\n";

should be changed to some function/template/whatever rational system,
currently it only makes people to close their editors and abandon work.
At least some common buttons are possible to encode in some short ok(),
cancel() or so.

-- 
Tomasz Pala <go...@pl...>

Re: [ppa-dev] Import data via compressed files

[Leonardo S. <l.s...@gm...>]

 Jehan, Carl and ppa developers:

 Below I merged your answers with my comments :)

> Mh, that's not what I meant.
> There's a "SQL" tab in the database/schema level where we can upload
> already upload a SQL script.

 Ok

[Carl comment]

> I suspect this is going to interfere with my changes to user-submitted
> sql processing.  I guess we'll just see how it goes.

My intension is only deal with the upload function (executeScript in
the Postgres class). If my patch interfere with yours, let me know,
and together we solve it :)


>>   I will handle it discovering the type of compressed file using the
>> $_FILES[$name]['type'] var. Do you agree with that? Or think that
>> would be more interesting use the file's extension to discover the
>> compressed type? Or should I get the type with another way?
>
> Yeah, I suppose we can have different mode:
>  * auto-detect, based on extension
>  * user defined using radio button
>
>>   Another point is, in a first moment too, I will deal the compressed
>> with one sql file. I am little confuse how to deal with more than one
>> sql file.
>
> No, we will deal with one SQL file at a time. Don't mess with that.
>
>> In second moment, IMHO, the ppa should show the files
>> uncompressed, asking the user what should be the order of import.
>
> I disagree. There's no point upload a compressed SQL script if we have to
> send back its uncompressed version to the client over the network.

 I think this feature would be interesting, but not returning all the
uncompressed content to user, just the name of uncompressed files.
Anyway, it's just an idea, and I don't know how deal with it for now.
Maybe on future.

>>   Above some comments that how uncompress the following type:
>>
>>   Zip: I will check if the php has the zip extension, if it hasn't the
>> ppa will show a message that this extension is necessary to
>> uncompress. More detais about the zip extension in
>> [http://br.php.net/manual/en/book.zip.php];
>
> The zip is only supported since PHP 5.2.

  Yes

>
>>   Gzip: I will use the zlib extension
>> [http://br.php.net/manual/en/book.zlib.php];
>>
>>   Bzip: I will use the bzip2 library
>> [http://br.php.net/manual/en/book.bzip2.php];
>
> Both gzip and bzip are not included in PHP by default.
>
> So you will have to check what are the compression supported by the PHP
> installation before handling each of them, showing radios with supported
> compression type, etc...

  Yes, we will need to check if the PHP have this features. User
defined using radio button is an interesting idea. This way we don't
auto-detect and if the user send a compressed type different of its
selection, the PHP uncompress function will not have success, so we
print a message explaining some reasons for it fail.

  Cheers!

--
Atenciosamente
Leonardo



2011/1/10 Karl O. Pinc <ko...@me...>:
> On 01/10/2011 09:28:07 AM, jg...@da... wrote:
>>
>> On Sun, 9 Jan 2011 16:14:07 -0200, Leonardo Sápiras
>> <l.s...@gm...>
>> wrote:
>> > Hi Jehan and ppa developers,
>> >
>> >  Thanks for answer Jehan, above my answers:
>> >
>> >> Moreover, you could add this feature to the SQL script executor as
>> well
>> >> (SQL tab on database level).
>> >
>> >   Sure, I will do it there, creating a 'Import' tab on database
>> level
>> too.
>>
>> Mh, that's not what I meant.
>> There's a "SQL" tab in the database/schema level where we can upload
>> already upload a SQL script.
>
> I suspect this is going to interfere with my changes to user-submitted
> sql processing.  I guess we'll just see how it goes.
>
>
>
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                 -- Robert A. Heinlein
>
>

Re: [ppa-dev] Import data via compressed files

[Karl O. P. <ko...@me...>]

On 01/10/2011 09:28:07 AM, jg...@da... wrote:
> 
> On Sun, 9 Jan 2011 16:14:07 -0200, Leonardo Sápiras
> <l.s...@gm...>
> wrote:
> > Hi Jehan and ppa developers,
> > 
> >  Thanks for answer Jehan, above my answers:
> > 
> >> Moreover, you could add this feature to the SQL script executor as
> well
> >> (SQL tab on database level).
> > 
> >   Sure, I will do it there, creating a 'Import' tab on database
> level
> too.
> 
> Mh, that's not what I meant.
> There's a "SQL" tab in the database/schema level where we can upload
> already upload a SQL script.

I suspect this is going to interfere with my changes to user-submitted
sql processing.  I guess we'll just see how it goes.



Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Import data via compressed files

[<jg...@da...>]

On Sun, 9 Jan 2011 16:14:07 -0200, Leonardo Sápiras <l.s...@gm...>
wrote:
> Hi Jehan and ppa developers,
> 
>  Thanks for answer Jehan, above my answers:
> 
>> Moreover, you could add this feature to the SQL script executor as well
>> (SQL tab on database level).
> 
>   Sure, I will do it there, creating a 'Import' tab on database level
too.

Mh, that's not what I meant.
There's a "SQL" tab in the database/schema level where we can upload
already upload a SQL script.

So you don't have to create an import tab.

>> Before starting, can you explain how you will handle bzip/gzip/zip
>> decompression ?
> 
>   In a first moment, I think, this feature will only support bzip,
> gzip and zip, after we can deal with other types.
> 
>   I will handle it discovering the type of compressed file using the
> $_FILES[$name]['type'] var. Do you agree with that? Or think that
> would be more interesting use the file's extension to discover the
> compressed type? Or should I get the type with another way?

Yeah, I suppose we can have different mode: 
  * auto-detect, based on extension
  * user defined using radio button

>   Another point is, in a first moment too, I will deal the compressed
> with one sql file. I am little confuse how to deal with more than one
> sql file.

No, we will deal with one SQL file at a time. Don't mess with that.

> In second moment, IMHO, the ppa should show the files
> uncompressed, asking the user what should be the order of import.

I disagree. There's no point upload a compressed SQL script if we have to
send back its uncompressed version to the client over the network.

> 
>   Above some comments that how uncompress the following type:
> 
>   Zip: I will check if the php has the zip extension, if it hasn't the
> ppa will show a message that this extension is necessary to
> uncompress. More detais about the zip extension in
> [http://br.php.net/manual/en/book.zip.php];

The zip is only supported since PHP 5.2.

>   Gzip: I will use the zlib extension
> [http://br.php.net/manual/en/book.zlib.php];
> 
>   Bzip: I will use the bzip2 library
> [http://br.php.net/manual/en/book.bzip2.php];

Both gzip and bzip are not included in PHP by default. 

So you will have to check what are the compression supported by the PHP
installation before handling each of them, showing radios with supported
compression type, etc...

> 
>   Any comments or suggestions?

Read above ;)

> 
>   Cheers!
> 
> --
> Atenciosamente
> Leonardo
> 
> 
> 
> 2011/1/6 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Le 05/01/2011 23:45, Leonardo Sápiras a écrit :
>>>   Jehan and PPA developers,
>>
>> Hey Leonardo !
>>
>>>   Anyone has been working on the feature 'Allow import of data via
>>> compressed (bzip/gzip/zip) files'? If not, can I do it?
>>
>> It sounds interesting yes.
>>
>> Moreover, you could add this feature to the SQL script executor as well
>> (SQL tab on database level).
>>
>> Before starting, can you explain how you will handle bzip/gzip/zip
>> decompression ?
>>
>>> --
>>> Atenciosamente
>>> Leonardo
>>
>> Cheers,
>>
>> /ioguix
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.10 (GNU/Linux)
>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>>
>> iEYEARECAAYFAk0mUjEACgkQxWGfaAgowiJ4swCfT/1B72kEyl0YpRAEnNg8+I/B
>> PmsAn1u7M3PDAph9cjDqjFx+qvAG3Pa/
>> =Q54S
>> -----END PGP SIGNATURE-----
>>

-- 
Jehan-Guillaume (ioguix) de Rorthais
DBA
http://www.dalibo.com

Re: [ppa-dev] Import data via compressed files

[Leonardo S. <l.s...@gm...>]

  Hi Jehan and ppa developers,

 Thanks for answer Jehan, above my answers:

> Moreover, you could add this feature to the SQL script executor as well
> (SQL tab on database level).

  Sure, I will do it there, creating a 'Import' tab on database level too.

> Before starting, can you explain how you will handle bzip/gzip/zip
> decompression ?

  In a first moment, I think, this feature will only support bzip,
gzip and zip, after we can deal with other types.

  I will handle it discovering the type of compressed file using the
$_FILES[$name]['type'] var. Do you agree with that? Or think that
would be more interesting use the file's extension to discover the
compressed type? Or should I get the type with another way?

  Another point is, in a first moment too, I will deal the compressed
with one sql file. I am little confuse how to deal with more than one
sql file. In second moment, IMHO, the ppa should show the files
uncompressed, asking the user what should be the order of import.

  Above some comments that how uncompress the following type:

  Zip: I will check if the php has the zip extension, if it hasn't the
ppa will show a message that this extension is necessary to
uncompress. More detais about the zip extension in
[http://br.php.net/manual/en/book.zip.php];

  Gzip: I will use the zlib extension
[http://br.php.net/manual/en/book.zlib.php];

  Bzip: I will use the bzip2 library
[http://br.php.net/manual/en/book.bzip2.php];

  Any comments or suggestions?

  Cheers!

--
Atenciosamente
Leonardo



2011/1/6 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Le 05/01/2011 23:45, Leonardo Sápiras a écrit :
>>   Jehan and PPA developers,
>
> Hey Leonardo !
>
>>   Anyone has been working on the feature 'Allow import of data via
>> compressed (bzip/gzip/zip) files'? If not, can I do it?
>
> It sounds interesting yes.
>
> Moreover, you could add this feature to the SQL script executor as well
> (SQL tab on database level).
>
> Before starting, can you explain how you will handle bzip/gzip/zip
> decompression ?
>
>> --
>> Atenciosamente
>> Leonardo
>
> Cheers,
>
> /ioguix
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk0mUjEACgkQxWGfaAgowiJ4swCfT/1B72kEyl0YpRAEnNg8+I/B
> PmsAn1u7M3PDAph9cjDqjFx+qvAG3Pa/
> =Q54S
> -----END PGP SIGNATURE-----
>

Re: [ppa-dev] Database SQL query form submit on Ctrl+Enter

[Tomasz P. <go...@po...>]

Hello,

On Wed, Dec 29, 2010 at 18:46:26 +0100, Jehan-Guillaume (ioguix) de Rorthais wrote:

> Tomasz Pala, in copy of this mail, has another patch to add many other
> keyboard shortcut using the more trivial accesskey parameter.
> 
> It would probably better to merge both of your ideas and, *if possible*,
> avoid js and use the standard accesskey parameter ?
> 
> Tomasz, could you send us your patch ?

For now I've attached my old code I've send here a long time ago - it's
pretty trivial, much of the work required is to choose some rational and
sane accelerators. Later I can send you all the places I'm currently
using shortcuts, coding this itself is not an issue.

>>> Here is a simple usability improvement: database SQL query form submit
>>> on Ctrl+Enter.

I'm a right-handed person so keeping mouse in right hand it's very
inconvenient to use enter - that's why all my accelerators reside under
left hand (alt-a = select all, atr-r = run/execute; where alt is
browser-defined).

-- 
Tomasz Pala <go...@pl...>

Re: [ppa-dev] [general] Browsing on FK HiLight improvement

[Jehan-Guillaume (i. de R. <jg...@da...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 07/01/2011 03:23, Leonardo Sápiras a écrit :
>   Dear Jehan and PPA developers,
> 
[...]
> 
>   Ok, thanks for review Jehan ;)

Your are very welcome !

>   Attached a new patch (v5)

Pushed !
Thank you for this patch.

> --
> Atenciosamente
> Leonardo

- -- 
Jehan-Guillaume (ioguix) de Rorthais
DBA
http://www.dalibo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0nJj0ACgkQXu9L1HbaT6IHLACfepmeTpKiAQqvIuMcJvNnHWBW
lIsAn0YIB7tQdt26Zt55lJujiwGOP7j0
=sn5Q
-----END PGP SIGNATURE-----

Re: [ppa-dev] [general] Browsing on FK HiLight improvement

[Leonardo S. <l.s...@gm...>]

  Dear Jehan and PPA developers,

> What are those lines ?
>  /* get the current selected row of the main table */
>  jQuery.ppa.row = $(this).closest('tr');
>
> It seems to me they are useles, they appeared in v3 but I'm not sure why...

  Useless and removed :)

> This is a bug though:
>
> -
> -$(this).data('ref').closest('tr').find('a.'+refclass).closest('div').removeClass('highlight')
>  +$(this).data('ref').closest('tr').find('a.'+$(this).data('refclass')).closest('div').removeClass('highlight');

 Oh, ugly bug, fixed.

> Just waiting about the "jQuery.ppa.row" var then I'll commit it :)

  Ok, thanks for review Jehan ;)

  Attached a new patch (v5)

--
Atenciosamente
Leonardo



2011/1/6 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Le 05/01/2011 01:36, Leonardo Sápiras a écrit :
>>   Dear Jehan and PPA develpers,
>>
>>   Sorry the delay, below the answers.
>
> no problem :)
>
>>>>  I saw that when we have fk with multi columns, just the cell of the
>>>> link clicked have the highlight, so I am thinking if would be
>>>> necessary all cells (of the fk) have the highlight. Attached an
>>>> example of this situation in three images.
>>
>>> Indeed, you are perfectly right. Unfortunatly, from this piece of code, we don't
>>> have the information about the related FK. It probably needs some refactor or
>>> some complex block of code to take care of that. So I will leave it alone for
>>> now...at least until 5.0 is out.
>>
>>   Ok, attached a patch that solve this problem, can you take a look?
>
> Nice trick !
>
> But:
>
> What are those lines ?
>  /* get the current selected row of the main table */
>  jQuery.ppa.row = $(this).closest('tr');
>
> It seems to me they are useles, they appeared in v3 but I'm not sure why...
>
> This is a bug though:
>
> -
> -$(this).data('ref').closest('tr').find('a.'+refclass).closest('div').removeClass('highlight')
>  +$(this).data('ref').closest('tr').find('a.'+$(this).data('refclass')).closest('div').removeClass('highlight');
>
>
> Just waiting about the "jQuery.ppa.row" var then I'll commit it :)
>
> Thanks !
>
>>> I would go for the alternative one as soon as the 5.1 dev is open :)
>>
>>   Thanks :D
>>
>>
>>   Any comment or suggestion?
>>
>>   Cheers!
>>
>> --
>> Atenciosamente
>> Leonardo
>>
>>
>>
>> 2010/11/7 Jehan-Guillaume (ioguix) de Rorthais <jg...@da...>:
>> Le 23/10/2010 17:44, Leonardo Sápiras a écrit :
>>>>>   Dear Jehan and ppa-dev,
>>>>>
>>>>>> I wasn't quite happy with your algorithm using 'live' and putting it outside of
>>>>>> the 'success' block.
>>>>>>
>>>>>> IMO, this code is a bit simpler, and takes advantages of multi-block hovering to
>>>>>> actually highlight all the way from the first fields down to the hovered FK row.
>>>>>
>>>>>  Definitely your code is very simple, and I liked it, thanks :)
>>
>> Perfect :)
>>
>>>>>
>>>>>> It still need to use a class instead of hardcoded class.
>>>>>
>>>>>  Yup, I added a new class in the global.css (themes/global.css) as you
>>>>> said in your first answer.
>>
>> Thank you !
>>
>>>>>
>>>>>> Comments, bugs ?
>>>>>
>>>>>  I saw that when we have fk with multi columns, just the cell of the
>>>>> link clicked have the highlight, so I am thinking if would be
>>>>> necessary all cells (of the fk) have the highlight. Attached an
>>>>> example of this situation in three images.
>>
>> Indeed, you are perfectly right. Unfortunatly, from this piece of code, we don't
>> have the information about the related FK. It probably needs some refactor or
>> some complex block of code to take care of that. So I will leave it alone for
>> now...at least until 5.0 is out.
>>
>>>>>
>>>>>  Another thing, you can see in the 2.png, that I clicked in the first
>>>>> fk-image of the second cell, so all the cell has the highlight. So I
>>>>> thought in just highlight the icon's div.
>>
>> And you are perfectely right again :)
>>>>>
>>>>>   Is everything ok with the highlight color? Sorry, I am not an expert
>>>>> in designer :D
>>
>> I'm not either, so I'm ok with this one ;)
>>>>>
>>>>>   Attached the new patch, and an alternative patch highlighting the icon's div.
>>
>> I would go for the alternative one as soon as the 5.1 dev is open :)
>>
>>>>>
>>>>>   Comments?
>>>>>
>>>>> --
>>>>> Atenciosamente
>>>>> Leonardo
>>>>>
>>>>> 2010/10/22 Jehan-Guillaume (ioguix) de Rorthais <jg...@da...>
>>>>>>
>>>>> Here is my patch proposal.
>>>>>
>>>>> I wasn't quite happy with your algorithm using 'live' and putting it outside of
>>>>> the 'success' block.
>>>>>
>>>>> IMO, this code is a bit simpler, and takes advantages of multi-block hovering to
>>>>> actually highlight all the way from the first fields down to the hovered FK row.
>>>>>
>>>>> It still need to use a class instead of hardcoded class.
>>>>>
>>>>> Comments, bugs ?
>>>>>
>>>>> I think I will open a 5.0 branch so we can start pushing new piece of code (like
>>>>> this one) in master for next 5.1 and keep pushing fix for 5.0 in this new branch.
>>>>> Comment ?
>>>>>
>>>>> Le 22/10/2010 11:49, Jehan-Guillaume (ioguix) de Rorthais a écrit :
>>>>>>>> Le 22/10/2010 06:01, Leonardo Sápiras a écrit :
>>>>>>>>>   Dear Jehan,
>>>>>>>>
>>>>>>>> Hey Leonardo !
>>>>>>>>
>>>>>>>>
>>>>>>>>>   How are you? I hope you are fine.
>>>>>>>>
>>>>>>>> Yeah, I'm fine, thx :)
>>>>>>>> Hope you are doing well as well
>>>>>>>>
>>>>>>>>>   Well, sorry the great delay :)
>>>>>>>>
>>>>>>>> no worries. However, as we are in beta now, I will probably not include this
>>>>>>>> work in 5.0. It will wait for the next release. Hopefully, we'll release it
>>>>>>>> quickly !
>>>>>>>>
>>>>>>>>> but attached is the HiLight
>>>>>>>>> improvement for the Browsing on FK. Please, take a look and feel free
>>>>>>>>> to give suggestions or comments.
>>>>>>>>
>>>>>>>> bug: when closing a FK, it doesn't "unhighlight" the referencing field. So we
>>>>>>>> can endup with multiple highlighted field :)
>>>>>>>>
>>>>>>>> implementation:
>>>>>>>>   * adding a class in global.css about highlighting the bg would be better than
>>>>>>>> hardcoding it in the js code
>>>>>>>>   * I'm not sure you need to save the old background color. Just add/remove the
>>>>>>>> new highlight class when mousehover/mouseout
>>>>>>>>   * isn't it possible to put this code right in the "success" block of the ajax
>>>>>>>> call instead of adding a live action ?
>>>>>>>>
>>>>>>>> I'll give it a try
>>>>>>>>
>>>>>>>>
>>>>>>>>>   See you soon my friend.
>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Atenciosamente
>>>>>>>>> Leonardo Augusto Sápiras
>>>>>>>>> Taquara - RS
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>>
>>>>>>>> PS: attached your original patch so the ppa-dev mailing list can play with it as
>>>>>>>> well
>>>>>
>>
>>>
>>>
>>>
> -
> ------------------------------------------------------------------------------
> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
> to consolidate database storage, standardize their database environment,
> and,
> should the need arise, upgrade to a full multi-node Oracle RAC database
> without downtime or disruption
> http://p.sf.net/sfu/oracle-sfdevnl
>>>
>>>
> _______________________________________________
> phpPgAdmin-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk0mW2EACgkQxWGfaAgowiLgvgCeIOxKz6T/vv16B/Ld0lQp0/YP
> c8wAoJUtEu1qUJwTim+R9P9IWcjPE00Y
> =AVLH
> -----END PGP SIGNATURE-----
>

Re: [ppa-dev] [general] Browsing on FK HiLight improvement

[Jehan-Guillaume (i. de R. <io...@fr...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 05/01/2011 01:36, Leonardo Sápiras a écrit :
>   Dear Jehan and PPA develpers,
> 
>   Sorry the delay, below the answers.

no problem :)

>>>  I saw that when we have fk with multi columns, just the cell of the
>>> link clicked have the highlight, so I am thinking if would be
>>> necessary all cells (of the fk) have the highlight. Attached an
>>> example of this situation in three images.
> 
>> Indeed, you are perfectly right. Unfortunatly, from this piece of code, we don't
>> have the information about the related FK. It probably needs some refactor or
>> some complex block of code to take care of that. So I will leave it alone for
>> now...at least until 5.0 is out.
> 
>   Ok, attached a patch that solve this problem, can you take a look?

Nice trick !

But:

What are those lines ?
  /* get the current selected row of the main table */
  jQuery.ppa.row = $(this).closest('tr');

It seems to me they are useles, they appeared in v3 but I'm not sure why...

This is a bug though:

-
-$(this).data('ref').closest('tr').find('a.'+refclass).closest('div').removeClass('highlight')
 +$(this).data('ref').closest('tr').find('a.'+$(this).data('refclass')).closest('div').removeClass('highlight');


Just waiting about the "jQuery.ppa.row" var then I'll commit it :)

Thanks !

>> I would go for the alternative one as soon as the 5.1 dev is open :)
> 
>   Thanks :D
> 
> 
>   Any comment or suggestion?
> 
>   Cheers!
> 
> --
> Atenciosamente
> Leonardo
> 
> 
> 
> 2010/11/7 Jehan-Guillaume (ioguix) de Rorthais <jg...@da...>:
> Le 23/10/2010 17:44, Leonardo Sápiras a écrit :
>>>>   Dear Jehan and ppa-dev,
>>>>
>>>>> I wasn't quite happy with your algorithm using 'live' and putting it outside of
>>>>> the 'success' block.
>>>>>
>>>>> IMO, this code is a bit simpler, and takes advantages of multi-block hovering to
>>>>> actually highlight all the way from the first fields down to the hovered FK row.
>>>>
>>>>  Definitely your code is very simple, and I liked it, thanks :)
> 
> Perfect :)
> 
>>>>
>>>>> It still need to use a class instead of hardcoded class.
>>>>
>>>>  Yup, I added a new class in the global.css (themes/global.css) as you
>>>> said in your first answer.
> 
> Thank you !
> 
>>>>
>>>>> Comments, bugs ?
>>>>
>>>>  I saw that when we have fk with multi columns, just the cell of the
>>>> link clicked have the highlight, so I am thinking if would be
>>>> necessary all cells (of the fk) have the highlight. Attached an
>>>> example of this situation in three images.
> 
> Indeed, you are perfectly right. Unfortunatly, from this piece of code, we don't
> have the information about the related FK. It probably needs some refactor or
> some complex block of code to take care of that. So I will leave it alone for
> now...at least until 5.0 is out.
> 
>>>>
>>>>  Another thing, you can see in the 2.png, that I clicked in the first
>>>> fk-image of the second cell, so all the cell has the highlight. So I
>>>> thought in just highlight the icon's div.
> 
> And you are perfectely right again :)
>>>>
>>>>   Is everything ok with the highlight color? Sorry, I am not an expert
>>>> in designer :D
> 
> I'm not either, so I'm ok with this one ;)
>>>>
>>>>   Attached the new patch, and an alternative patch highlighting the icon's div.
> 
> I would go for the alternative one as soon as the 5.1 dev is open :)
> 
>>>>
>>>>   Comments?
>>>>
>>>> --
>>>> Atenciosamente
>>>> Leonardo
>>>>
>>>> 2010/10/22 Jehan-Guillaume (ioguix) de Rorthais <jg...@da...>
>>>>>
>>>> Here is my patch proposal.
>>>>
>>>> I wasn't quite happy with your algorithm using 'live' and putting it outside of
>>>> the 'success' block.
>>>>
>>>> IMO, this code is a bit simpler, and takes advantages of multi-block hovering to
>>>> actually highlight all the way from the first fields down to the hovered FK row.
>>>>
>>>> It still need to use a class instead of hardcoded class.
>>>>
>>>> Comments, bugs ?
>>>>
>>>> I think I will open a 5.0 branch so we can start pushing new piece of code (like
>>>> this one) in master for next 5.1 and keep pushing fix for 5.0 in this new branch.
>>>> Comment ?
>>>>
>>>> Le 22/10/2010 11:49, Jehan-Guillaume (ioguix) de Rorthais a écrit :
>>>>>>> Le 22/10/2010 06:01, Leonardo Sápiras a écrit :
>>>>>>>>   Dear Jehan,
>>>>>>>
>>>>>>> Hey Leonardo !
>>>>>>>
>>>>>>>
>>>>>>>>   How are you? I hope you are fine.
>>>>>>>
>>>>>>> Yeah, I'm fine, thx :)
>>>>>>> Hope you are doing well as well
>>>>>>>
>>>>>>>>   Well, sorry the great delay :)
>>>>>>>
>>>>>>> no worries. However, as we are in beta now, I will probably not include this
>>>>>>> work in 5.0. It will wait for the next release. Hopefully, we'll release it
>>>>>>> quickly !
>>>>>>>
>>>>>>>> but attached is the HiLight
>>>>>>>> improvement for the Browsing on FK. Please, take a look and feel free
>>>>>>>> to give suggestions or comments.
>>>>>>>
>>>>>>> bug: when closing a FK, it doesn't "unhighlight" the referencing field. So we
>>>>>>> can endup with multiple highlighted field :)
>>>>>>>
>>>>>>> implementation:
>>>>>>>   * adding a class in global.css about highlighting the bg would be better than
>>>>>>> hardcoding it in the js code
>>>>>>>   * I'm not sure you need to save the old background color. Just add/remove the
>>>>>>> new highlight class when mousehover/mouseout
>>>>>>>   * isn't it possible to put this code right in the "success" block of the ajax
>>>>>>> call instead of adding a live action ?
>>>>>>>
>>>>>>> I'll give it a try
>>>>>>>
>>>>>>>
>>>>>>>>   See you soon my friend.
>>>>>>>
>>>>>>>> --
>>>>>>>> Atenciosamente
>>>>>>>> Leonardo Augusto Sápiras
>>>>>>>> Taquara - RS
>>>>>>>
>>>>>>> Cheers,
>>>>>>>
>>>>>>> PS: attached your original patch so the ppa-dev mailing list can play with it as
>>>>>>> well
>>>>
> 
>>
>>
>>
-
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment,
and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
>>
>>
_______________________________________________
phpPgAdmin-devel mailing list
php...@li...
https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0mW2EACgkQxWGfaAgowiLgvgCeIOxKz6T/vv16B/Ld0lQp0/YP
c8wAoJUtEu1qUJwTim+R9P9IWcjPE00Y
=AVLH
-----END PGP SIGNATURE-----

Re: [ppa-dev] Import data via compressed files

[Jehan-Guillaume (i. de R. <io...@fr...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 05/01/2011 23:45, Leonardo Sápiras a écrit :
>   Jehan and PPA developers,

Hey Leonardo !

>   Anyone has been working on the feature 'Allow import of data via
> compressed (bzip/gzip/zip) files'? If not, can I do it?

It sounds interesting yes.

Moreover, you could add this feature to the SQL script executor as well
(SQL tab on database level).

Before starting, can you explain how you will handle bzip/gzip/zip
decompression ?

> --
> Atenciosamente
> Leonardo

Cheers,

/ioguix
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0mUjEACgkQxWGfaAgowiJ4swCfT/1B72kEyl0YpRAEnNg8+I/B
PmsAn1u7M3PDAph9cjDqjFx+qvAG3Pa/
=Q54S
-----END PGP SIGNATURE-----

[ppa-dev] Import data via compressed files

[Leonardo S. <l.s...@gm...>]

  Jehan and PPA developers,

  Anyone has been working on the feature 'Allow import of data via
compressed (bzip/gzip/zip) files'? If not, can I do it?

--
Atenciosamente
Leonardo

Re: [ppa-dev] [general] Browsing on FK HiLight improvement

[Leonardo S. <l.s...@gm...>]

  Dear Jehan and PPA develpers,

  Sorry the delay, below the answers.


>>  I saw that when we have fk with multi columns, just the cell of the
>> link clicked have the highlight, so I am thinking if would be
>> necessary all cells (of the fk) have the highlight. Attached an
>> example of this situation in three images.

> Indeed, you are perfectly right. Unfortunatly, from this piece of code, we don't
> have the information about the related FK. It probably needs some refactor or
> some complex block of code to take care of that. So I will leave it alone for
> now...at least until 5.0 is out.

  Ok, attached a patch that solve this problem, can you take a look?


> I would go for the alternative one as soon as the 5.1 dev is open :)

  Thanks :D


  Any comment or suggestion?

  Cheers!

--
Atenciosamente
Leonardo



2010/11/7 Jehan-Guillaume (ioguix) de Rorthais <jg...@da...>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Le 23/10/2010 17:44, Leonardo Sápiras a écrit :
>>   Dear Jehan and ppa-dev,
>>
>>> I wasn't quite happy with your algorithm using 'live' and putting it outside of
>>> the 'success' block.
>>>
>>> IMO, this code is a bit simpler, and takes advantages of multi-block hovering to
>>> actually highlight all the way from the first fields down to the hovered FK row.
>>
>>  Definitely your code is very simple, and I liked it, thanks :)
>
> Perfect :)
>
>>
>>> It still need to use a class instead of hardcoded class.
>>
>>  Yup, I added a new class in the global.css (themes/global.css) as you
>> said in your first answer.
>
> Thank you !
>
>>
>>> Comments, bugs ?
>>
>>  I saw that when we have fk with multi columns, just the cell of the
>> link clicked have the highlight, so I am thinking if would be
>> necessary all cells (of the fk) have the highlight. Attached an
>> example of this situation in three images.
>
> Indeed, you are perfectly right. Unfortunatly, from this piece of code, we don't
> have the information about the related FK. It probably needs some refactor or
> some complex block of code to take care of that. So I will leave it alone for
> now...at least until 5.0 is out.
>
>>
>>  Another thing, you can see in the 2.png, that I clicked in the first
>> fk-image of the second cell, so all the cell has the highlight. So I
>> thought in just highlight the icon's div.
>
> And you are perfectely right again :)
>>
>>   Is everything ok with the highlight color? Sorry, I am not an expert
>> in designer :D
>
> I'm not either, so I'm ok with this one ;)
>>
>>   Attached the new patch, and an alternative patch highlighting the icon's div.
>
> I would go for the alternative one as soon as the 5.1 dev is open :)
>
>>
>>   Comments?
>>
>> --
>> Atenciosamente
>> Leonardo
>>
>> 2010/10/22 Jehan-Guillaume (ioguix) de Rorthais <jg...@da...>
>>>
>> Here is my patch proposal.
>>
>> I wasn't quite happy with your algorithm using 'live' and putting it outside of
>> the 'success' block.
>>
>> IMO, this code is a bit simpler, and takes advantages of multi-block hovering to
>> actually highlight all the way from the first fields down to the hovered FK row.
>>
>> It still need to use a class instead of hardcoded class.
>>
>> Comments, bugs ?
>>
>> I think I will open a 5.0 branch so we can start pushing new piece of code (like
>> this one) in master for next 5.1 and keep pushing fix for 5.0 in this new branch.
>> Comment ?
>>
>> Le 22/10/2010 11:49, Jehan-Guillaume (ioguix) de Rorthais a écrit :
>>>>> Le 22/10/2010 06:01, Leonardo Sápiras a écrit :
>>>>>>   Dear Jehan,
>>>>>
>>>>> Hey Leonardo !
>>>>>
>>>>>
>>>>>>   How are you? I hope you are fine.
>>>>>
>>>>> Yeah, I'm fine, thx :)
>>>>> Hope you are doing well as well
>>>>>
>>>>>>   Well, sorry the great delay :)
>>>>>
>>>>> no worries. However, as we are in beta now, I will probably not include this
>>>>> work in 5.0. It will wait for the next release. Hopefully, we'll release it
>>>>> quickly !
>>>>>
>>>>>> but attached is the HiLight
>>>>>> improvement for the Browsing on FK. Please, take a look and feel free
>>>>>> to give suggestions or comments.
>>>>>
>>>>> bug: when closing a FK, it doesn't "unhighlight" the referencing field. So we
>>>>> can endup with multiple highlighted field :)
>>>>>
>>>>> implementation:
>>>>>   * adding a class in global.css about highlighting the bg would be better than
>>>>> hardcoding it in the js code
>>>>>   * I'm not sure you need to save the old background color. Just add/remove the
>>>>> new highlight class when mousehover/mouseout
>>>>>   * isn't it possible to put this code right in the "success" block of the ajax
>>>>> call instead of adding a live action ?
>>>>>
>>>>> I'll give it a try
>>>>>
>>>>>
>>>>>>   See you soon my friend.
>>>>>
>>>>>> --
>>>>>> Atenciosamente
>>>>>> Leonardo Augusto Sápiras
>>>>>> Taquara - RS
>>>>>
>>>>> Cheers,
>>>>>
>>>>> PS: attached your original patch so the ppa-dev mailing list can play with it as
>>>>> well
>>
>
> - --
> Jehan-Guillaume de Rorthais
> DBA
> http://www.dalibo.com
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkzXGrEACgkQXu9L1HbaT6KQPwCg/P5L6+k8pevRq065UnNDVs7H
> fZYAnjsxl9CiGE2rYxE3KLgkB/PtdnrU
> =pAhH
> -----END PGP SIGNATURE-----
>