phppgadmin-devel — For Developers Only

Re: [ppa-dev] New PPA architecture plugin

[Leonardo S. <l.s...@gm...>]

Thanks Jehan, below the answers:


>  * ./classes/plugins/PluginManager.php should be in
> ./classes/PluginManager.php

Ok, I moved it and dropped the plugins/ directory

>  * this comment is malformed :
>
>      // Plugins
>      // Add index to plugins that will be activated.
>      // Example: array('PluginExample', 'Slony', ...)
>      $conf['plugins'] = array();
>
>    I would write:
>
>      /** Plugins management
>      * Add plugin names to the following array to activate them
>      * Example: $conf['plugins'] = array('PluginExample', 'Slony');
>      */

Ok, changed


>  * we shouldn't require a Makefile in plugins/{$plugin_name}/lang/. Instead,
> we should patch lang/Makefile and other needed files to take care of plugins
> when executing "make all" or "make lang_name"

How can I do it? :)


>  * add a simple page to your plugin pluginExample where the links it adds to
> the interface point to. This page might just have a link to go back to PPA's
> server page.

Done


>  * rise a human understable error if a plugin given in configuration doesn't
> exists. Make sure to specify this is case sensitive.

Done


>  * couldn't we get rid of the "plugins/{$plugin_name}/lang/translations.php"
> file ?

Dropped


>  * why do we call a method from the plugin_manager to load translation ?
> couldn't we just check if the translation file exists and load it directly
> from the plugin class ?

I think all plugins will need to deal with translations, that's why I
put it in the PluginManager. Can be that?


>  * plugin should register themselves in the plugin_manager instead of doing
> it from lib.inc.php. ie. call "$plugin_manager->add_plugin($plugin)" from
> the plugin constructor.

Done, I also move a bunch of code from lib.inc.php to the
PluginManager constructor. I think it would be better to stay there,
but anyway, suggestions are welcome.


>  * I guess plugin can register their callback functions passing an array of
> function names in add_plugin as well.

Done


>  * IMO, attributes in plugins class don't need to be prefixed by 'plugin_'.
> Moreover, I would rename $this->plugin_name as $this->desc and
> $this->plugin_index as $this->name.

Ok, but I will not use more the $desc, because I realized that it will
have translation values, so I move it to lang files.


>  * don't use __CLASS__ but an explicit name. Here, PluginExample should be
> 'example'. It could be usefull and more human if we want to add a list of
> enabled plugins on the introduction page.

I changed to Example. Can be that?


> I might have some more comments in future, but let's discuss those first.

Sure :)

Jehan and Andreas, the link of all these commits is
[http://bit.ly/lRzW25]. Do you want a patch (all_in_one) with these
changes.

--
Atenciosamente
Leonardo Augusto Sápiras
[http://www.leonardosapiras.com.br]



2011/5/18 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>:
> On 11/05/2011 18:36, Leonardo Sápiras wrote:
>>
>>   Hi devs,
>>
>>   Following my GSoC activities
>>
>> [http://wiki.postgresql.org/wiki/New_phpPgAdmin_Plugin_Architecture_GSoC_2011],
>> Below some items that I have worked:
>>
>> [...]
>>
>>   Attached a patch with this. I also pushed it to a new branch in my
>> ppa fork, the GitHub link is [http://bit.ly/jGFbD2].
>>
>>   Jehan and Andreas, could you take a look at this?
>
> Here are my comments:
>
>  * ./classes/plugins/PluginManager.php should be in
> ./classes/PluginManager.php
>
>  * this comment is malformed :
>
>      // Plugins
>      // Add index to plugins that will be activated.
>      // Example: array('PluginExample', 'Slony', ...)
>      $conf['plugins'] = array();
>
>    I would write:
>
>      /** Plugins management
>      * Add plugin names to the following array to activate them
>      * Example: $conf['plugins'] = array('PluginExample', 'Slony');
>      */
>
>  * we shouldn't require a Makefile in plugins/{$plugin_name}/lang/. Instead,
> we should patch lang/Makefile and other needed files to take care of plugins
> when executing "make all" or "make lang_name"
>
>  * add a simple page to your plugin pluginExample where the links it adds to
> the interface point to. This page might just have a link to go back to PPA's
> server page.
>
>  * rise a human understable error if a plugin given in configuration doesn't
> exists. Make sure to specify this is case sensitive.
>
>  * couldn't we get rid of the "plugins/{$plugin_name}/lang/translations.php"
> file ?
>
>  * why do we call a method from the plugin_manager to load translation ?
> couldn't we just check if the translation file exists and load it directly
> from the plugin class ?
>
>  * plugin should register themselves in the plugin_manager instead of doing
> it from lib.inc.php. ie. call "$plugin_manager->add_plugin($plugin)" from
> the plugin constructor.
>
>  * I guess plugin can register their callback functions passing an array of
> function names in add_plugin as well.
>
>  * IMO, attributes in plugins class don't need to be prefixed by 'plugin_'.
> Moreover, I would rename $this->plugin_name as $this->desc and
> $this->plugin_index as $this->name.
>
>  * don't use __CLASS__ but an explicit name. Here, PluginExample should be
> 'example'. It could be usefull and more human if we want to add a list of
> enabled plugins on the introduction page.
>
> I might have some more comments in future, but let's discuss those first.
>
> Thx!
>
>>   Cheers!
>>
>> --
>> Atenciosamente
>> Leonardo Augusto Sápiras
>> [http://www.leonardosapiras.com.br]
>>
>>
>> ------------------------------------------------------------------------------
>> Achieve unprecedented app performance and reliability
>> What every C/C++ and Fortran developer should know.
>> Learn how Intel has extended the reach of its next-generation tools
>> to help boost performance applications - inlcuding clusters.
>> http://p.sf.net/sfu/intel-dev2devmay
>> _______________________________________________
>> phpPgAdmin-devel mailing list
>> php...@li...
>> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel
>
>

Re: [ppa-dev] New PPA architecture plugin

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 11/05/2011 18:36, Leonardo Sápiras wrote:
>    Hi devs,
>
>    Following my GSoC activities
> [http://wiki.postgresql.org/wiki/New_phpPgAdmin_Plugin_Architecture_GSoC_2011],
> Below some items that I have worked:
>
> [...]
>
>    Attached a patch with this. I also pushed it to a new branch in my
> ppa fork, the GitHub link is [http://bit.ly/jGFbD2].
>
>    Jehan and Andreas, could you take a look at this?

Here are my comments:

   * ./classes/plugins/PluginManager.php should be in 
./classes/PluginManager.php

   * this comment is malformed :

       // Plugins
       // Add index to plugins that will be activated.
       // Example: array('PluginExample', 'Slony', ...)
       $conf['plugins'] = array();

     I would write:

       /** Plugins management
       * Add plugin names to the following array to activate them
       * Example: $conf['plugins'] = array('PluginExample', 'Slony');
       */

   * we shouldn't require a Makefile in plugins/{$plugin_name}/lang/. 
Instead, we should patch lang/Makefile and other needed files to take 
care of plugins when executing "make all" or "make lang_name"

   * add a simple page to your plugin pluginExample where the links it 
adds to the interface point to. This page might just have a link to go 
back to PPA's server page.

   * rise a human understable error if a plugin given in configuration 
doesn't exists. Make sure to specify this is case sensitive.

   * couldn't we get rid of the 
"plugins/{$plugin_name}/lang/translations.php" file ?

   * why do we call a method from the plugin_manager to load translation 
? couldn't we just check if the translation file exists and load it 
directly from the plugin class ?

   * plugin should register themselves in the plugin_manager instead of 
doing it from lib.inc.php. ie. call 
"$plugin_manager->add_plugin($plugin)" from the plugin constructor.

   * I guess plugin can register their callback functions passing an 
array of function names in add_plugin as well.

   * IMO, attributes in plugins class don't need to be prefixed by 
'plugin_'. Moreover, I would rename $this->plugin_name as $this->desc 
and $this->plugin_index as $this->name.

   * don't use __CLASS__ but an explicit name. Here, PluginExample 
should be 'example'. It could be usefull and more human if we want to 
add a list of enabled plugins on the introduction page.

I might have some more comments in future, but let's discuss those first.

Thx!

>    Cheers!
>
> --
> Atenciosamente
> Leonardo Augusto Sápiras
> [http://www.leonardosapiras.com.br]
>
> ------------------------------------------------------------------------------
> Achieve unprecedented app performance and reliability
> What every C/C++ and Fortran developer should know.
> Learn how Intel has extended the reach of its next-generation tools
> to help boost performance applications - inlcuding clusters.
> http://p.sf.net/sfu/intel-dev2devmay
> _______________________________________________
> phpPgAdmin-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel

Re: [ppa-dev] Drop current ppa plugin architecture

[Leonardo S. <l.s...@gm...>]

Jehan,

 I merged the e-mails below

> Ok, I finished reviewing this patch.

Ok thanks, I did it too.

> You can merge it in your HEAD as soon as you commit the language stuff.

ok, I will do it now.

> Howevr, we will not pull it in official ppa repo yet. It might probably be
> better to wait for the end of the project.

ok

>> Do you know why it happpens?
>
> IIRC, it shouldn't impact the test, but try to make sure your interface is
> in english ?

 Yes, the problem was I make the test with my interface in portuguese.

 I don't have those problems using English. I made the tests again,
and it returned success.

77: run
1142: passed
0: failed


--
Atenciosamente
Leonardo Augusto Sápiras
[http://www.leonardosapiras.com.br]



2011/5/17 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>:
> On 16/05/2011 16:06, Jehan-Guillaume (ioguix) de Rorthais wrote:
>>
>> On 09/05/2011 11:16, Jehan-Guillaume (ioguix) de Rorthais wrote:
>>>
>>> On 03/05/2011 23:20, Jehan-Guillaume (ioguix) de Rorthais wrote:
>>>>
>>>> On 03/05/2011 02:16, Leonardo Sápiras wrote:
>>>>>
>>>>> Hi developers,
>>>>>
>>>>> My first activity, in the GSoC 2011, is drop the current plugin
>>>>> architecture. I dropped the code that has relation with it. This is
>>>>> necessary for I follow the next steps.
>>>>
>>>> yup
>>>>
>>>>> Attached my first patch. Andreas and Jehan, it's my first commit
>>>>> using git branches. Let me know if something is wrong.
>>>>
>>>> I don't have enough time today to review it seriously. I will in next
>>>> days !
>>>
>>> Sorry Leonardo, I hadn't time during the week end, my current week looks
>>> pretty crazy and I'm heading to the pgcon2011 on sunday...
>>>
>>> I really hope I could find some time during the week, I'll do my best,
>>> but I can't promise I will.
>>
>> you forgot the translations files.
>>
>> Here is a patch that drops all strings from language files related to
>> the slony plugin.
>>
>> It's based on Slony related categories found in the english.php file. I
>> did some scripting to find out strings that might still be used after
>> applying your patch and found just 2 of them: strexecute and strcluster.
>> Which actually makes a lot of sense as we use them in some other context.
>>
>> All other strings from those slony blocks in the english file are
>> dropped in this patch.
>>
>> Thx for your review and comment. Hopefully we'll be able to merge this
>> patches in your HEAD soon, then you'll be able to send us your first
>> pull request on github :)
>
> Ok, I finished reviewing this patch.
>
> You can merge it in your HEAD as soon as you commit the language stuff.
>
> Howevr, we will not pull it in official ppa repo yet. It might probably be
> better to wait for the end of the project.
>
> /ioguix
>

Re: [ppa-dev] Drop current ppa plugin architecture

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 16/05/2011 16:06, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 09/05/2011 11:16, Jehan-Guillaume (ioguix) de Rorthais wrote:
>> On 03/05/2011 23:20, Jehan-Guillaume (ioguix) de Rorthais wrote:
>>> On 03/05/2011 02:16, Leonardo Sápiras wrote:
>>>> Hi developers,
>>>>
>>>> My first activity, in the GSoC 2011, is drop the current plugin
>>>> architecture. I dropped the code that has relation with it. This is
>>>> necessary for I follow the next steps.
>>>
>>> yup
>>>
>>>> Attached my first patch. Andreas and Jehan, it's my first commit
>>>> using git branches. Let me know if something is wrong.
>>>
>>> I don't have enough time today to review it seriously. I will in next
>>> days !
>>
>> Sorry Leonardo, I hadn't time during the week end, my current week looks
>> pretty crazy and I'm heading to the pgcon2011 on sunday...
>>
>> I really hope I could find some time during the week, I'll do my best,
>> but I can't promise I will.
>
> you forgot the translations files.
>
> Here is a patch that drops all strings from language files related to
> the slony plugin.
>
> It's based on Slony related categories found in the english.php file. I
> did some scripting to find out strings that might still be used after
> applying your patch and found just 2 of them: strexecute and strcluster.
> Which actually makes a lot of sense as we use them in some other context.
>
> All other strings from those slony blocks in the english file are
> dropped in this patch.
>
> Thx for your review and comment. Hopefully we'll be able to merge this
> patches in your HEAD soon, then you'll be able to send us your first
> pull request on github :)

Ok, I finished reviewing this patch.

You can merge it in your HEAD as soon as you commit the language stuff.

Howevr, we will not pull it in official ppa repo yet. It might probably 
be better to wait for the end of the project.

/ioguix

Re: [ppa-dev] Drop current ppa plugin architecture

[Leonardo S. <l.s...@gm...>]

  Jehan, Andreas and devs,

> you forgot the translations files.

Opss, sorry :/

> Here is a patch that drops all strings from language files related to the
> slony plugin.
>
> It's based on Slony related categories found in the english.php file. I did
> some scripting to find out strings that might still be used after applying
> your patch and found just 2 of them: strexecute and strcluster. Which
> actually makes a lot of sense as we use them in some other context.
>
> All other strings from those slony blocks in the english file are dropped in
> this patch.

Wow, thanks :)


> Thx for your review and comment. Hopefully we'll be able to merge this
> patches in your HEAD soon, then you'll be able to send us your first pull
> request on github :)

I did some tests with Selenium, with PostgreSQL 8.0 -> 9.1 beta, and it returns:

"info(1305650271703): Executing: |clickAndWait | link=Databases |
Element link=Databases not found |
error(1305650271713): Element link=Databases not found
warn(1305650271715): currentTest.recordFailure: Element link=Databases
not found"

and

"info(1305650054459): Executing: |clickAndWait | link=Roles | |
error(1305650054465): Element link=Roles not found
warn(1305650054466): currentTest.recordFailure: Element link=Roles not found"

Do you know why it happpens?

I also put in my environment the PG 7.4, but I am having troubles with
this version and ppa authentication. I am trying fix it right now.

Thanks

--
Atenciosamente
Leonardo Augusto Sápiras
[http://www.leonardosapiras.com.br]



2011/5/16 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>:
> On 09/05/2011 11:16, Jehan-Guillaume (ioguix) de Rorthais wrote:
>>
>> On 03/05/2011 23:20, Jehan-Guillaume (ioguix) de Rorthais wrote:
>>>
>>> On 03/05/2011 02:16, Leonardo Sápiras wrote:
>>>>
>>>>     Hi developers,
>>>>
>>>>     My first activity, in the GSoC 2011, is drop the current plugin
>>>> architecture. I dropped the code that has relation with it. This is
>>>> necessary for I follow the next steps.
>>>
>>> yup
>>>
>>>>     Attached my first patch. Andreas and Jehan, it's my first commit
>>>> using git branches. Let me know if something is wrong.
>>>
>>> I don't have enough time today to review it seriously. I will in next
>>> days !
>>
>> Sorry Leonardo, I hadn't time during the week end, my current week looks
>> pretty crazy and I'm heading to the pgcon2011 on sunday...
>>
>> I really hope I could find some time during the week, I'll do my best,
>> but I can't promise I will.
>
> you forgot the translations files.
>
> Here is a patch that drops all strings from language files related to the
> slony plugin.
>
> It's based on Slony related categories found in the english.php file. I did
> some scripting to find out strings that might still be used after applying
> your patch and found just 2 of them: strexecute and strcluster. Which
> actually makes a lot of sense as we use them in some other context.
>
> All other strings from those slony blocks in the english file are dropped in
> this patch.
>
> Thx for your review and comment. Hopefully we'll be able to merge this
> patches in your HEAD soon, then you'll be able to send us your first pull
> request on github :)
>
>> Andreas, do you have some time on your side ?
>>
>> Anyway, Leonardo, this first step shouldn't impact your next steps code.
>> Please, keep going and start the next step, we'll catch up with you
>> quickly.
>>
>> Thank you guys.
>

Re: [ppa-dev] Drop current ppa plugin architecture

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 09/05/2011 11:16, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 03/05/2011 23:20, Jehan-Guillaume (ioguix) de Rorthais wrote:
>> On 03/05/2011 02:16, Leonardo Sápiras wrote:
>>>      Hi developers,
>>>
>>>      My first activity, in the GSoC 2011, is drop the current plugin
>>> architecture. I dropped the code that has relation with it. This is
>>> necessary for I follow the next steps.
>>
>> yup
>>
>>>      Attached my first patch. Andreas and Jehan, it's my first commit
>>> using git branches. Let me know if something is wrong.
>>
>> I don't have enough time today to review it seriously. I will in next days !
>
> Sorry Leonardo, I hadn't time during the week end, my current week looks
> pretty crazy and I'm heading to the pgcon2011 on sunday...
>
> I really hope I could find some time during the week, I'll do my best,
> but I can't promise I will.

you forgot the translations files.

Here is a patch that drops all strings from language files related to 
the slony plugin.

It's based on Slony related categories found in the english.php file. I 
did some scripting to find out strings that might still be used after 
applying your patch and found just 2 of them: strexecute and strcluster. 
Which actually makes a lot of sense as we use them in some other context.

All other strings from those slony blocks in the english file are 
dropped in this patch.

Thx for your review and comment. Hopefully we'll be able to merge this 
patches in your HEAD soon, then you'll be able to send us your first 
pull request on github :)

> Andreas, do you have some time on your side ?
>
> Anyway, Leonardo, this first step shouldn't impact your next steps code.
> Please, keep going and start the next step, we'll catch up with you quickly.
>
> Thank you guys.

Re: [ppa-dev] New PPA architecture plugin

[Leonardo S. <l.s...@gm...>]

  Jehan, Andreas and devs,

  Attached more changes. This commit can be found at
[http://bit.ly/ieQ5yt], and the change log is:

-Removed $Id from the comments
-Removed unnecessary languages from PluginExample/lang/Makefile
-Refactored some comments
-Made some changes in the function add_plugin in the PluginManager
-Removed some whitespaces
-Comment added in plugins/PluginExample/lang/convert.awk saying that
file was copied from lang/convert.awk

  Cheers :)

--
Atenciosamente
Leonardo Augusto Sápiras
[http://www.leonardosapiras.com.br]



2011/5/12 Leonardo Sápiras <l.s...@gm...>:
>  Jehan, Andreas and devs,
>
>  Attached the second version of the last patch. In this patch I have made:
>
> -Activation plugins changed in the ppa config.inc.php-dist file;
> -Dropped function manage_translation from plugin file;
> -Created function get_translation in the PluginExample to get the
> plugins translations;
> -Added entry to 'pt' => 'portuguese-br' in the  (Thanks for remember
> me about it Robert)
> plugins/lang/translation.php, following the comment extracted from
> lang/translation.php;
> -Small beauty changes in the comments;
> -Removed some whitespaces and extra tabs;
> -Removed commented debug from libraries/lib.inc.php;
>
>  I also pushed it to my GitHub branch, the link to this commit is
> [http://bit.ly/jaA5db].
>
>  Any comments? Is there anything missing or that might be changed?
>
>  Cheers
>
> --
> Atenciosamente
> Leonardo Augusto Sápiras
> [http://www.leonardosapiras.com.br]
>
>
>
> 2011/5/11 Leonardo Sápiras <l.s...@gm...>:
>> Jehan and devs,
>>
>> [...]
>>>
>>> woot, nice changelog !!
>>>
>>
>> Thanks
>>
>>>>   Jehan and Andreas, could you take a look at this?
>>>
>>> I really look forward having time to review all of this. Hopefully, on
>>> sunday and next week :)
>>
>> Ok, Robert has made some comments in the GitHub, I will work on that
>> and make more small improvements that I saw. Let me know If something
>> is missing or might be changed :D
>>
>> Thanks
>>
>>
>> --
>> Atenciosamente
>> Leonardo Augusto Sápiras
>> [http://www.leonardosapiras.com.br]
>>
>>
>>
>> 2011/5/11 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>:
>>> On 11/05/2011 18:36, Leonardo Sápiras wrote:
>>>>
>>>>   Hi devs,
>>>
>>> Hey,
>>>
>>>>   Following my GSoC activities
>>>>
>>>> [http://wiki.postgresql.org/wiki/New_phpPgAdmin_Plugin_Architecture_GSoC_2011],
>>>> Below some items that I have worked:
>>>>
>>>> -Included index 'plugins' in the $conf var;
>>>> -Included index 'PluginExample' in the $conf['plugins'] var;
>>>> -Created PluginManager class (classes/plugins/PluginManager.php) to
>>>> manage the plugins;
>>>> -Created plugins directory;
>>>> -Created basic structure of a plugin, PluginExample, with some example
>>>> functions;
>>>> -Updated file libraries/lib.inc.php, with the code to manager the plugins;
>>>> -Updated code that write the toplinks at classes/Misc.php;
>>>> -Created a hook example for the toplinks;
>>>> -Created default translation for the PluginExample (English);
>>>> -Created default translation for the PluginExample (Portuguese-BR);
>>>
>>> woot, nice changelog !!
>>>
>>>>   I created a simple hook on the toplinks (non-official yet), just to
>>>> test the plugin.
>>>>
>>>>   Attached a patch with this. I also pushed it to a new branch in my
>>>> ppa fork, the GitHub link is [http://bit.ly/jGFbD2].
>>>>
>>>>   Jehan and Andreas, could you take a look at this?
>>>
>>> I really look forward having time to review all of this. Hopefully, on
>>> sunday and next week :)
>>>
>>>>   Cheers!
>>>>
>>>> --
>>>> Atenciosamente
>>>> Leonardo Augusto Sápiras
>>>> [http://www.leonardosapiras.com.br]
>>>>
>>>
>>
>

Re: [ppa-dev] New PPA architecture plugin

[Leonardo S. <l.s...@gm...>]

  Jehan, Andreas and devs,

  Attached the second version of the last patch. In this patch I have made:

-Activation plugins changed in the ppa config.inc.php-dist file;
-Dropped function manage_translation from plugin file;
-Created function get_translation in the PluginExample to get the
plugins translations;
-Added entry to 'pt' => 'portuguese-br' in the  (Thanks for remember
me about it Robert)
plugins/lang/translation.php, following the comment extracted from
lang/translation.php;
-Small beauty changes in the comments;
-Removed some whitespaces and extra tabs;
-Removed commented debug from libraries/lib.inc.php;

 I also pushed it to my GitHub branch, the link to this commit is
[http://bit.ly/jaA5db].

 Any comments? Is there anything missing or that might be changed?

 Cheers

--
Atenciosamente
Leonardo Augusto Sápiras
[http://www.leonardosapiras.com.br]



2011/5/11 Leonardo Sápiras <l.s...@gm...>:
> Jehan and devs,
>
> [...]
>>
>> woot, nice changelog !!
>>
>
> Thanks
>
>>>   Jehan and Andreas, could you take a look at this?
>>
>> I really look forward having time to review all of this. Hopefully, on
>> sunday and next week :)
>
> Ok, Robert has made some comments in the GitHub, I will work on that
> and make more small improvements that I saw. Let me know If something
> is missing or might be changed :D
>
> Thanks
>
>
> --
> Atenciosamente
> Leonardo Augusto Sápiras
> [http://www.leonardosapiras.com.br]
>
>
>
> 2011/5/11 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>:
>> On 11/05/2011 18:36, Leonardo Sápiras wrote:
>>>
>>>   Hi devs,
>>
>> Hey,
>>
>>>   Following my GSoC activities
>>>
>>> [http://wiki.postgresql.org/wiki/New_phpPgAdmin_Plugin_Architecture_GSoC_2011],
>>> Below some items that I have worked:
>>>
>>> -Included index 'plugins' in the $conf var;
>>> -Included index 'PluginExample' in the $conf['plugins'] var;
>>> -Created PluginManager class (classes/plugins/PluginManager.php) to
>>> manage the plugins;
>>> -Created plugins directory;
>>> -Created basic structure of a plugin, PluginExample, with some example
>>> functions;
>>> -Updated file libraries/lib.inc.php, with the code to manager the plugins;
>>> -Updated code that write the toplinks at classes/Misc.php;
>>> -Created a hook example for the toplinks;
>>> -Created default translation for the PluginExample (English);
>>> -Created default translation for the PluginExample (Portuguese-BR);
>>
>> woot, nice changelog !!
>>
>>>   I created a simple hook on the toplinks (non-official yet), just to
>>> test the plugin.
>>>
>>>   Attached a patch with this. I also pushed it to a new branch in my
>>> ppa fork, the GitHub link is [http://bit.ly/jGFbD2].
>>>
>>>   Jehan and Andreas, could you take a look at this?
>>
>> I really look forward having time to review all of this. Hopefully, on
>> sunday and next week :)
>>
>>>   Cheers!
>>>
>>> --
>>> Atenciosamente
>>> Leonardo Augusto Sápiras
>>> [http://www.leonardosapiras.com.br]
>>>
>>
>

Re: [ppa-dev] Alter privileges for multiple tables

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 12/05/2011 16:13, Karl O. Pinc wrote:
> On 05/12/2011 08:58:04 AM, Jehan-Guillaume (ioguix) de Rorthais wrote:
>> On 12/05/2011 04:38, Karl O. Pinc wrote:
>>> On 05/11/2011 05:59:28 PM, Jehan-Guillaume (ioguix) de Rorthais
>> wrote:
>>>> On 11/05/2011 23:41, Jarek wrote:
>
>
>>
>> Yeah, I know pretty well debian's policy...
>> But here, even on sid PPA is a deprecated version !
>
> See Debian bug# 612316.
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612316

Thank you for updating this bug report :)

I mailed 3 or 4 times the debian packager when releasing, I never had 
answered...

>>> If someone was motivated they could package newer PPA
>>> versions for backports.debian.org, which has newer software for
>>> Debian stable.  Someone would also have to be responsible for
>>> keeping up with whatever needs doing regards security as well
>>> because the security team does not currently support backports.
>>
>> I'll try to find a packager, I don't have time myself. If you know
>> some...
>
> No, but I might find the time once I get my other ppa work finished.

Thx

> Karl<ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                   -- Robert A. Heinlein
>

Re: [ppa-dev] Alter privileges for multiple tables

[Karl O. P. <ko...@me...>]

On 05/12/2011 08:58:04 AM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 12/05/2011 04:38, Karl O. Pinc wrote:
> > On 05/11/2011 05:59:28 PM, Jehan-Guillaume (ioguix) de Rorthais
> wrote:
> >> On 11/05/2011 23:41, Jarek wrote:


> 
> Yeah, I know pretty well debian's policy...
> But here, even on sid PPA is a deprecated version !

See Debian bug# 612316.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612316

> 
> > If someone was motivated they could package newer PPA
> > versions for backports.debian.org, which has newer software for
> > Debian stable.  Someone would also have to be responsible for
> > keeping up with whatever needs doing regards security as well
> > because the security team does not currently support backports.
> 
> I'll try to find a packager, I don't have time myself. If you know
> some...

No, but I might find the time once I get my other ppa work finished.



Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Alter privileges for multiple tables

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 12/05/2011 04:38, Karl O. Pinc wrote:
> On 05/11/2011 05:59:28 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
>> On 11/05/2011 23:41, Jarek wrote:
>>> Hello!
>>
>> Hey,
>>
>>> 	Attached are modified files and diffs to phppgadmin
>> 4.2.3-1.1 from
>>> Debian stable distribution.
>>
>> Mh, Debian stable, testing or unstable have all deprecated version of
>> phpPgAdmin. Actually, I guess we need a new packager...
>
> FYI.  Debian stable itself does not change, unless there are security
> problems in which case the patch is backported into the existing
> version when possible.

Yeah, I know pretty well debian's policy...
But here, even on sid PPA is a deprecated version !

> If someone was motivated they could package newer PPA
> versions for backports.debian.org, which has newer software for
> Debian stable.  Someone would also have to be responsible for
> keeping up with whatever needs doing regards security as well
> because the security team does not currently support backports.

I'll try to find a packager, I don't have time myself. If you know some...

> Karl<ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                   -- Robert A. Heinlein
>

Re: [ppa-dev] Plugin requests/thoughts

[Karl O. P. <ko...@me...>]

On 05/11/2011 06:48:02 PM, Andreas 'ads' Scherbaum wrote:
> Am 09.05.2011 11:17, schrieb Jehan-Guillaume (ioguix) de Rorthais:
> > On 09/05/2011 20:13, Karl O. Pinc wrote:
> >> On 05/09/2011 01:07:41 PM, Jehan-Guillaume (ioguix) de Rorthais
> wrote:
> >>> On 09/05/2011 20:03, Jehan-Guillaume (ioguix) de Rorthais wrote:
> >>>> On 09/05/2011 19:54, Karl O. Pinc wrote:
> >>>>> On 05/09/2011 12:39:54 PM, Jehan-Guillaume (ioguix) de Rorthais
> >>> wrote:
> >>>>>> On 09/05/2011 19:29, Leonardo Sápiras wrote:
> >>>>>>>        Hi Karl,
> >>>>>>>
> >>>>>>>> I'm entirely ignorant of ppa and what plugins would do
> >>>>>>>> but wanted to write because I got a request from my users
> >>>>>>>> that might be able to be solved with a plugin.
> >>>>>>>>
> >>>>>>>> The request was to be able to associate hyperlinks with
> >>>>>>>> each table appearing in the browse view that reference
> >>>>>>>> the table's documentation.  Please let me know
> >>>>>>>> if the plugin architecture being considered would allow
> >>>>>>>> for such a plugin.
> >>>>>>>
> >>>>>>> What do you mean about "reference the table's documentation"?
> >>>>>> Sorry,
> >>>>>>> it's not clear for me, could you show some example?
> >>>>>>>
> >>>>>>> I am working in a new plugin architecture as a project by
> Google
> >>>>>>> Summer of Code. My proposal can be found at
> >>>>>>> [http://wiki.postgresql.org/wiki/
> >>>>>> New_phpPgAdmin_Plugin_Architecture_GSoC_2011].
> >>>>>>>
> >>>>>>> In this proposal, there are some things that the new
> >>> architecture
> >>>>>> will
> >>>>>>> be able to, among them, entries in the action buttons and
> >>>>>> navigation
> >>>>>>> links. If I understood you well, it will able you to create a
> >>>>>> plugin
> >>>>>>> on this architecture. If it won't, I will need to talk to my
> >>>>>> mentors
> >>>>>>> first (Jehan 'ioguix', and Andreas 'ads') before add one more
> >>> entry
> >>>>>> in
> >>>>>>> this project, but it would might be done after the GSoC :)
> >>>>>>>
> >>>>>>> Andreas and Jehan, what do you thing about it?
> 
> I think (and Jehan already pointed out) this is a good use case for
> the
> new module structure. Would be nice to have this module configurable.
> 
> Let's say you load the module, configure the base url and the
> documentation is in:
> 
> http://base_path/schema_name/table_name.html#column
> 
> Another way would be integrating postgresql_autodoc and similar
> tools here. As far as I know autodoc generates one big html file:
> 
> http://base_path/documentation.html#table_name
> 
> or
> 
> http://base_path/documentation.html#oid
> 
> 
> 
> But in the end this module is not part of GSoc, but it's a good idea
> anyway.

I can do the module so long as the plugin structure supports what
I want to do.  (I want arbitrary urls, for all practical purposes.)




Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Plugin requests/thoughts

[Andreas 'a. S. <ad...@wa...>]

Am 09.05.2011 11:17, schrieb Jehan-Guillaume (ioguix) de Rorthais:
> On 09/05/2011 20:13, Karl O. Pinc wrote:
>> On 05/09/2011 01:07:41 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
>>> On 09/05/2011 20:03, Jehan-Guillaume (ioguix) de Rorthais wrote:
>>>> On 09/05/2011 19:54, Karl O. Pinc wrote:
>>>>> On 05/09/2011 12:39:54 PM, Jehan-Guillaume (ioguix) de Rorthais
>>> wrote:
>>>>>> On 09/05/2011 19:29, Leonardo Sápiras wrote:
>>>>>>>        Hi Karl,
>>>>>>>
>>>>>>>> I'm entirely ignorant of ppa and what plugins would do
>>>>>>>> but wanted to write because I got a request from my users
>>>>>>>> that might be able to be solved with a plugin.
>>>>>>>>
>>>>>>>> The request was to be able to associate hyperlinks with
>>>>>>>> each table appearing in the browse view that reference
>>>>>>>> the table's documentation.  Please let me know
>>>>>>>> if the plugin architecture being considered would allow
>>>>>>>> for such a plugin.
>>>>>>>
>>>>>>> What do you mean about "reference the table's documentation"?
>>>>>> Sorry,
>>>>>>> it's not clear for me, could you show some example?
>>>>>>>
>>>>>>> I am working in a new plugin architecture as a project by Google
>>>>>>> Summer of Code. My proposal can be found at
>>>>>>> [http://wiki.postgresql.org/wiki/
>>>>>> New_phpPgAdmin_Plugin_Architecture_GSoC_2011].
>>>>>>>
>>>>>>> In this proposal, there are some things that the new
>>> architecture
>>>>>> will
>>>>>>> be able to, among them, entries in the action buttons and
>>>>>> navigation
>>>>>>> links. If I understood you well, it will able you to create a
>>>>>> plugin
>>>>>>> on this architecture. If it won't, I will need to talk to my
>>>>>> mentors
>>>>>>> first (Jehan 'ioguix', and Andreas 'ads') before add one more
>>> entry
>>>>>> in
>>>>>>> this project, but it would might be done after the GSoC :)
>>>>>>>
>>>>>>> Andreas and Jehan, what do you thing about it?

I think (and Jehan already pointed out) this is a good use case for the
new module structure. Would be nice to have this module configurable.

Let's say you load the module, configure the base url and the
documentation is in:

http://base_path/schema_name/table_name.html#column

Another way would be integrating postgresql_autodoc and similar
tools here. As far as I know autodoc generates one big html file:

http://base_path/documentation.html#table_name

or

http://base_path/documentation.html#oid



But in the end this module is not part of GSoc, but it's a good idea anyway.



> Hopefully, Andreas will be able to deal a bit with your proposal as well :)

Don't worry ;-)


Regards,

-- 
				Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project

Re: [ppa-dev] Alter privileges for multiple tables

[Karl O. P. <ko...@me...>]

On 05/11/2011 05:59:28 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 11/05/2011 23:41, Jarek wrote:
> > Hello!
> 
> Hey,
> 
> > 	Attached are modified files and diffs to phppgadmin
> 4.2.3-1.1 from
> > Debian stable distribution.
> 
> Mh, Debian stable, testing or unstable have all deprecated version of 
> phpPgAdmin. Actually, I guess we need a new packager...

FYI.  Debian stable itself does not change, unless there are security
problems in which case the patch is backported into the existing
version when possible.  

If someone was motivated they could package newer PPA
versions for backports.debian.org, which has newer software for
Debian stable.  Someone would also have to be responsible for
keeping up with whatever needs doing regards security as well
because the security team does not currently support backports.




Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] New PPA architecture plugin

[Leonardo S. <l.s...@gm...>]

Jehan and devs,

[...]
>
> woot, nice changelog !!
>

Thanks

>>   Jehan and Andreas, could you take a look at this?
>
> I really look forward having time to review all of this. Hopefully, on
> sunday and next week :)

Ok, Robert has made some comments in the GitHub, I will work on that
and make more small improvements that I saw. Let me know If something
is missing or might be changed :D

Thanks


--
Atenciosamente
Leonardo Augusto Sápiras
[http://www.leonardosapiras.com.br]



2011/5/11 Jehan-Guillaume (ioguix) de Rorthais <io...@fr...>:
> On 11/05/2011 18:36, Leonardo Sápiras wrote:
>>
>>   Hi devs,
>
> Hey,
>
>>   Following my GSoC activities
>>
>> [http://wiki.postgresql.org/wiki/New_phpPgAdmin_Plugin_Architecture_GSoC_2011],
>> Below some items that I have worked:
>>
>> -Included index 'plugins' in the $conf var;
>> -Included index 'PluginExample' in the $conf['plugins'] var;
>> -Created PluginManager class (classes/plugins/PluginManager.php) to
>> manage the plugins;
>> -Created plugins directory;
>> -Created basic structure of a plugin, PluginExample, with some example
>> functions;
>> -Updated file libraries/lib.inc.php, with the code to manager the plugins;
>> -Updated code that write the toplinks at classes/Misc.php;
>> -Created a hook example for the toplinks;
>> -Created default translation for the PluginExample (English);
>> -Created default translation for the PluginExample (Portuguese-BR);
>
> woot, nice changelog !!
>
>>   I created a simple hook on the toplinks (non-official yet), just to
>> test the plugin.
>>
>>   Attached a patch with this. I also pushed it to a new branch in my
>> ppa fork, the GitHub link is [http://bit.ly/jGFbD2].
>>
>>   Jehan and Andreas, could you take a look at this?
>
> I really look forward having time to review all of this. Hopefully, on
> sunday and next week :)
>
>>   Cheers!
>>
>> --
>> Atenciosamente
>> Leonardo Augusto Sápiras
>> [http://www.leonardosapiras.com.br]
>>
>

Re: [ppa-dev] Alter privileges for multiple tables

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 11/05/2011 23:41, Jarek wrote:
> Hello!

Hey,

> 	Attached are modified files and diffs to phppgadmin 4.2.3-1.1 from
> Debian stable distribution.

Mh, Debian stable, testing or unstable have all deprecated version of 
phpPgAdmin. Actually, I guess we need a new packager...
Do you sending us your patch against our current stable version, or even 
better our current dev tree ?

see:
   http://phppgadmin.sourceforge.net/doku.php?id=download

> 	With this modifications it is possible to select multiple tables in
> tables view and next grant or revoke privileges from pull down menu
> similar to Empty, Vacuum and so on.

nice :)

> 	In tables.php I've added new function doPrivileges, which is almost
> unmodified version of doAlter from privileges.php.
> 	To avoid code redundancy, it could be better to create new function,
> which will be included in both files, but I didn't want to make any
> architectural changes.

mh, I'll try to study that when reviewing.

> 	All my changes are marked in comments by: // Added by JT
> 	This changes my not work when the object is referred by oid, as I don't
> know when it happens.

I'll check that either.

Just a notice though, we don't have a lot of man power currently and 
most of it is focusing on the current GSoC project. I'll do my best to 
getting back to you as soon as I can.

Thank you for your patch !

>
> best regards
> Jaroslaw Tabor

[ppa-dev] Alter privileges for multiple tables

[Jarek <ja...@po...>]

Hello!

	Attached are modified files and diffs to phppgadmin 4.2.3-1.1 from
Debian stable distribution.
	With this modifications it is possible to select multiple tables in
tables view and next grant or revoke privileges from pull down menu
similar to Empty, Vacuum and so on.
	In tables.php I've added new function doPrivileges, which is almost
unmodified version of doAlter from privileges.php.
	To avoid code redundancy, it could be better to create new function,
which will be included in both files, but I didn't want to make any
architectural changes.
	All my changes are marked in comments by: // Added by JT
	This changes my not work when the object is referred by oid, as I don't
know when it happens.

best regards
Jaroslaw Tabor

Re: [ppa-dev] New PPA architecture plugin

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 11/05/2011 18:36, Leonardo Sápiras wrote:
>    Hi devs,

Hey,

>    Following my GSoC activities
> [http://wiki.postgresql.org/wiki/New_phpPgAdmin_Plugin_Architecture_GSoC_2011],
> Below some items that I have worked:
>
> -Included index 'plugins' in the $conf var;
> -Included index 'PluginExample' in the $conf['plugins'] var;
> -Created PluginManager class (classes/plugins/PluginManager.php) to
> manage the plugins;
> -Created plugins directory;
> -Created basic structure of a plugin, PluginExample, with some example
> functions;
> -Updated file libraries/lib.inc.php, with the code to manager the plugins;
> -Updated code that write the toplinks at classes/Misc.php;
> -Created a hook example for the toplinks;
> -Created default translation for the PluginExample (English);
> -Created default translation for the PluginExample (Portuguese-BR);

woot, nice changelog !!

>    I created a simple hook on the toplinks (non-official yet), just to
> test the plugin.
>
>    Attached a patch with this. I also pushed it to a new branch in my
> ppa fork, the GitHub link is [http://bit.ly/jGFbD2].
>
>    Jehan and Andreas, could you take a look at this?

I really look forward having time to review all of this. Hopefully, on 
sunday and next week :)

>    Cheers!
>
> --
> Atenciosamente
> Leonardo Augusto Sápiras
> [http://www.leonardosapiras.com.br]
>

Re: [ppa-dev] New PPA architecture plugin

[Leonardo S. <l.s...@gm...>]

 Opss, I forget the attachement :-)

--
Atenciosamente
Leonardo Augusto Sápiras
[http://www.leonardosapiras.com.br]



2011/5/11 Leonardo Sápiras <l.s...@gm...>:
>  Hi devs,
>
>  Following my GSoC activities
> [http://wiki.postgresql.org/wiki/New_phpPgAdmin_Plugin_Architecture_GSoC_2011],
> Below some items that I have worked:
>
> -Included index 'plugins' in the $conf var;
> -Included index 'PluginExample' in the $conf['plugins'] var;
> -Created PluginManager class (classes/plugins/PluginManager.php) to
> manage the plugins;
> -Created plugins directory;
> -Created basic structure of a plugin, PluginExample, with some example
> functions;
> -Updated file libraries/lib.inc.php, with the code to manager the plugins;
> -Updated code that write the toplinks at classes/Misc.php;
> -Created a hook example for the toplinks;
> -Created default translation for the PluginExample (English);
> -Created default translation for the PluginExample (Portuguese-BR);
>
>  I created a simple hook on the toplinks (non-official yet), just to
> test the plugin.
>
>  Attached a patch with this. I also pushed it to a new branch in my
> ppa fork, the GitHub link is [http://bit.ly/jGFbD2].
>
>  Jehan and Andreas, could you take a look at this?
>
>  Cheers!
>
> --
> Atenciosamente
> Leonardo Augusto Sápiras
> [http://www.leonardosapiras.com.br]
>

[ppa-dev] New PPA architecture plugin

[Leonardo S. <l.s...@gm...>]

  Hi devs,

  Following my GSoC activities
[http://wiki.postgresql.org/wiki/New_phpPgAdmin_Plugin_Architecture_GSoC_2011],
Below some items that I have worked:

-Included index 'plugins' in the $conf var;
-Included index 'PluginExample' in the $conf['plugins'] var;
-Created PluginManager class (classes/plugins/PluginManager.php) to
manage the plugins;
-Created plugins directory;
-Created basic structure of a plugin, PluginExample, with some example
functions;
-Updated file libraries/lib.inc.php, with the code to manager the plugins;
-Updated code that write the toplinks at classes/Misc.php;
-Created a hook example for the toplinks;
-Created default translation for the PluginExample (English);
-Created default translation for the PluginExample (Portuguese-BR);

  I created a simple hook on the toplinks (non-official yet), just to
test the plugin.

  Attached a patch with this. I also pushed it to a new branch in my
ppa fork, the GitHub link is [http://bit.ly/jGFbD2].

  Jehan and Andreas, could you take a look at this?

  Cheers!

--
Atenciosamente
Leonardo Augusto Sápiras
[http://www.leonardosapiras.com.br]

Re: [ppa-dev] Plugin requests/thoughts

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 09/05/2011 20:25, Karl O. Pinc wrote:
> On 05/09/2011 01:17:54 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
>> On 09/05/2011 20:13, Karl O. Pinc wrote:
>
>>> Yet another reason to get my patches into HEAD.  (And I'll be
>>> able to run HEAD in a production environment to work out the kinks
>>> too.)
>>
>> yeah :)
>>
>> please, remember to split it in small bunch of patrch so we can
>> understand/review/comment easily. Espacially during this summer as we
>> all have a lot of work :/
>
>
> It's a giant refactoring so while I'll try to do what I can there's
> going to be a big rip-and-replace sooner or later.
>
>> Hopefully, Andreas will be able to deal a bit with your proposal as
>> well :)
>
> We'll take it as it goes.
>
> Did that patch get in that enabled PHP's multibyte character support?

Nope.

And I don't really remember what was the problem. Now, I think we should 
try to use mb_* functions by default and throw an error we can 
optionally turn off from the conf if they are not available.

> I recall seeing one coming past this list.
> How to do that was a sticking point, or at least a sticky problem,
> and it'd be nice if that was resolved.
>
>
>
>
> Karl<ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                   -- Robert A. Heinlein
>

Re: [ppa-dev] Plugin requests/thoughts

[Karl O. P. <ko...@me...>]

On 05/09/2011 01:25:52 PM, Karl O. Pinc wrote:
> On 05/09/2011 01:17:54 PM, Jehan-Guillaume (ioguix) de Rorthais 
> wrote:
> > 
> > please, remember to split it in small bunch of patrch so we can 
> > understand/review/comment easily. Espacially during this summer as
> we 
> > all have a lot of work :/
> 
> 
> It's a giant refactoring so while I'll try to do what I can there's
> going to be a big rip-and-replace sooner or later.

Come to think of it it's mostly new code.  I no longer use
the browse code to display sql results.  The only big amount
of code that gets removed is the stuff that does the
COPY processing of uploaded files.


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Plugin requests/thoughts

[Karl O. P. <ko...@me...>]

On 05/09/2011 01:17:54 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 09/05/2011 20:13, Karl O. Pinc wrote:

> > Yet another reason to get my patches into HEAD.  (And I'll be
> > able to run HEAD in a production environment to work out the kinks
> > too.)
> 
> yeah :)
> 
> please, remember to split it in small bunch of patrch so we can 
> understand/review/comment easily. Espacially during this summer as we 
> all have a lot of work :/


It's a giant refactoring so while I'll try to do what I can there's
going to be a big rip-and-replace sooner or later.

> Hopefully, Andreas will be able to deal a bit with your proposal as
> well :)

We'll take it as it goes.

Did that patch get in that enabled PHP's multibyte character support?
I recall seeing one coming past this list.
How to do that was a sticking point, or at least a sticky problem,
and it'd be nice if that was resolved.




Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Plugin requests/thoughts

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 09/05/2011 20:13, Karl O. Pinc wrote:
> On 05/09/2011 01:07:41 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
>> On 09/05/2011 20:03, Jehan-Guillaume (ioguix) de Rorthais wrote:
>>> On 09/05/2011 19:54, Karl O. Pinc wrote:
>>>> On 05/09/2011 12:39:54 PM, Jehan-Guillaume (ioguix) de Rorthais
>> wrote:
>>>>> On 09/05/2011 19:29, Leonardo Sápiras wrote:
>>>>>>       Hi Karl,
>>>>>>
>>>>>>> I'm entirely ignorant of ppa and what plugins would do
>>>>>>> but wanted to write because I got a request from my users
>>>>>>> that might be able to be solved with a plugin.
>>>>>>>
>>>>>>> The request was to be able to associate hyperlinks with
>>>>>>> each table appearing in the browse view that reference
>>>>>>> the table's documentation.  Please let me know
>>>>>>> if the plugin architecture being considered would allow
>>>>>>> for such a plugin.
>>>>>>
>>>>>> What do you mean about "reference the table's documentation"?
>>>>> Sorry,
>>>>>> it's not clear for me, could you show some example?
>>>>>>
>>>>>> I am working in a new plugin architecture as a project by Google
>>>>>> Summer of Code. My proposal can be found at
>>>>>> [http://wiki.postgresql.org/wiki/
>>>>> New_phpPgAdmin_Plugin_Architecture_GSoC_2011].
>>>>>>
>>>>>> In this proposal, there are some things that the new
>> architecture
>>>>> will
>>>>>> be able to, among them, entries in the action buttons and
>>>>> navigation
>>>>>> links. If I understood you well, it will able you to create a
>>>>> plugin
>>>>>> on this architecture. If it won't, I will need to talk to my
>>>>> mentors
>>>>>> first (Jehan 'ioguix', and Andreas 'ads') before add one more
>> entry
>>>>> in
>>>>>> this project, but it would might be done after the GSoC :)
>>>>>>
>>>>>> Andreas and Jehan, what do you thing about it?
>>>>>
>>>>> I don't understand this part neither. I need a better
>> understanding
>>>>> before being able to answer if this plugin architecture will
>> support
>>>>> it
>>>>> out of the box, or if it will be a future enhancement (ie, after
>> the
>>>>> gsoc).
>>>>
>>>> I have a table, say "biograph".  It has documentation available
>>>> via an URL.
>>>> (http://papio.biology.duke.edu/babase_system_html/
>>>> ch03s01.html#BIOGRAPH)
>>>> All the other tables in this database have similar documentation.
>>>> When in ppa and presented with a list of all the tables in the
>>>> schema (the "tables" tab after having clicked on the schema)
>>>> I'd like a link (or button/whatever) to appear by each table so
>>>> that the user can go read the documentation on the table.
>>>>
>>>> I'd like the same functionality for views as well.
>>>
>>> Ok, so it will be possible by adding a button amongs the actions
>> and/or
>>> a new entry in the browser tree under each table (let's say after
>> the
>>> table export one).
>>>
>>> These are covered by points 1 and 5 here:
>>
>> actually, you can even add your link in tabs and navigation links
>> (points 2&  4)...Just pick your favorite ones.
>>
>> Or maybe you will want to create a plugin where you can set where the
>> links should appear in its conf file :)
>
> Good news.  Thanks.
>
> Yet another reason to get my patches into HEAD.  (And I'll be
> able to run HEAD in a production environment to work out the kinks
> too.)

yeah :)

please, remember to split it in small bunch of patrch so we can 
understand/review/comment easily. Espacially during this summer as we 
all have a lot of work :/

Hopefully, Andreas will be able to deal a bit with your proposal as well :)

> Karl<ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                   -- Robert A. Heinlein
>

Re: [ppa-dev] Plugin requests/thoughts

[Karl O. P. <ko...@me...>]

On 05/09/2011 01:07:41 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 09/05/2011 20:03, Jehan-Guillaume (ioguix) de Rorthais wrote:
> > On 09/05/2011 19:54, Karl O. Pinc wrote:
> >> On 05/09/2011 12:39:54 PM, Jehan-Guillaume (ioguix) de Rorthais
> wrote:
> >>> On 09/05/2011 19:29, Leonardo Sápiras wrote:
> >>>>      Hi Karl,
> >>>>
> >>>>> I'm entirely ignorant of ppa and what plugins would do
> >>>>> but wanted to write because I got a request from my users
> >>>>> that might be able to be solved with a plugin.
> >>>>>
> >>>>> The request was to be able to associate hyperlinks with
> >>>>> each table appearing in the browse view that reference
> >>>>> the table's documentation.  Please let me know
> >>>>> if the plugin architecture being considered would allow
> >>>>> for such a plugin.
> >>>>
> >>>> What do you mean about "reference the table's documentation"?
> >>> Sorry,
> >>>> it's not clear for me, could you show some example?
> >>>>
> >>>> I am working in a new plugin architecture as a project by Google
> >>>> Summer of Code. My proposal can be found at
> >>>> [http://wiki.postgresql.org/wiki/
> >>> New_phpPgAdmin_Plugin_Architecture_GSoC_2011].
> >>>>
> >>>> In this proposal, there are some things that the new 
> architecture
> >>> will
> >>>> be able to, among them, entries in the action buttons and
> >>> navigation
> >>>> links. If I understood you well, it will able you to create a
> >>> plugin
> >>>> on this architecture. If it won't, I will need to talk to my
> >>> mentors
> >>>> first (Jehan 'ioguix', and Andreas 'ads') before add one more
> entry
> >>> in
> >>>> this project, but it would might be done after the GSoC :)
> >>>>
> >>>> Andreas and Jehan, what do you thing about it?
> >>>
> >>> I don't understand this part neither. I need a better
> understanding
> >>> before being able to answer if this plugin architecture will
> support
> >>> it
> >>> out of the box, or if it will be a future enhancement (ie, after
> the
> >>> gsoc).
> >>
> >> I have a table, say "biograph".  It has documentation available
> >> via an URL.
> >> (http://papio.biology.duke.edu/babase_system_html/
> >> ch03s01.html#BIOGRAPH)
> >> All the other tables in this database have similar documentation.
> >> When in ppa and presented with a list of all the tables in the
> >> schema (the "tables" tab after having clicked on the schema)
> >> I'd like a link (or button/whatever) to appear by each table so
> >> that the user can go read the documentation on the table.
> >>
> >> I'd like the same functionality for views as well.
> >
> > Ok, so it will be possible by adding a button amongs the actions
> and/or
> > a new entry in the browser tree under each table (let's say after
> the
> > table export one).
> >
> > These are covered by points 1 and 5 here:
> 
> actually, you can even add your link in tabs and navigation links 
> (points 2 & 4)...Just pick your favorite ones.
> 
> Or maybe you will want to create a plugin where you can set where the 
> links should appear in its conf file :)

Good news.  Thanks.

Yet another reason to get my patches into HEAD.  (And I'll be
able to run HEAD in a production environment to work out the kinks
too.)


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein