#247 xfreerdp changed command line interface

[Kubax]

Hi,

freerdp seems to have changed the command line interface.
it is migrated from - to / they have some translation algorithm withing the program, but it seems to be buggy. It works for most things, except the ip:port.

This has to be ported to / notation so it will work in the future.

Here is the output without a valid ip:port (with ip:port it will just paste the --help)

[WARN][com.freerdp.client.common.cmdline] - Using deprecated command-line interface!
[WARN][com.freerdp.client.common.compatibility] - -a 24 -> /bpp:24
[WARN][com.freerdp.client.common.compatibility] - -g 1309x1051 -> /size:1309x1051 or /w:1309 /h:1051
[WARN][com.freerdp.client.common.compatibility] - -u Administrator -> /u:Administrator
[WARN][com.freerdp.client.common.compatibility] - (nil) -> /v:(nil)
[WARN][com.freerdp.client.common.compatibility] - 
[ERROR][com.freerdp.client.x11] - error: server hostname was not specified with /v:<server>[:port]

most things could be edited in pac_conn but i had to edit method/PACMethod_xfreerdp.pm aswell (because of the -a option in my case)

Sincerely,
Tobias Göbel

P.s. i'm useing arch linux. So this should be the most recent versions from both.

[Nerijus Baliūnas]

Fedora 21 has freerdp-1.2.0-0.2.beta.1.fc21 which also has the new options. I used the following rough patch (attached).

[Ondrej Ilcik]

Hi Nerijus, I just applied your patch but still can't get xfreerdp work. After applying patch, PAC Manager just throwing me full "xfreerdp --help" output.
I'm running freerdp-1.2.0-0.6.beta.1.fc21.2.x86_64

[Nerijus Baliūnas]

In my patch only some options are ported (that's why I called it rough). You have to adapt it if you use more options.

[Arnaud DUBOIS]

Here is a bit more complete patch to support xfreerdp new command line options.

Options can now be saved, embed in tab is supported and username/password is passed to xfreerdp.

I've tested it on Fedora 21 x86_64 with cinnamon 2.4.

There are still "strange things" like :

• "embed" automatically maximize PAC windows but use previous size
• errors on PACTerminal when closing a xfreerdp session (PID not found ? )

[Nerijus Baliūnas]

A few problems with the latest patch:
passwords are visible in ps output
if I change from rdesktop to xfreerdp (or back), Window size defaults to "Embed in Tab"

[piovisqui]

Is there any chance of this patch be update to work on Fedora 26?
PAC is the best app for sysadmins.

[Nerijus Baliūnas]

Attached patch works with above restrictions (not all options supported, Window size defaults to "Embed in Tab") on Fedora 26.

[piovisqui]

xenithorb packaged pac for FC26.

Pac package for Fedora 26