#1447 Don't break committing source files when some files are mapped from HTTP repos

[Kos Ivantsov]

Currently, if source files are mapped from HTTP and SVN, and the user tries to commit source files, OmegaT will try HTTP and fail with this thrown:

11016: Error: Failed to commit source files! (TF_COMMIT_ERROR)
11016: Error: java.lang.RuntimeException: Not supported 
11016: Error:   at org.omegat.core.team2.impl.HTTPRemoteRepository.addForCommit(HTTPRemoteRepository.java:127) 
11016: Error:   at org.omegat.core.team2.RemoteRepositoryProvider.addForCommit(RemoteRepositoryProvider.java:251) 
11016: Error:   at org.omegat.core.team2.RemoteRepositoryProvider$Mapping.copyFromProjectToRepo(RemoteRepositoryProvider.java:395) 
11016: Error:   at org.omegat.core.team2.RemoteRepositoryProvider.copyFilesFromProjectToRepo(RemoteRepositoryProvider.java:229) 
11016: Error:   at org.omegat.core.data.RealProject.commitSourceFiles(RealProject.java:1893) 
11016: Error:   at org.omegat.gui.main.ProjectUICommands$14.lambda$doInBackground$0(ProjectUICommands.java:874) 
11016: Error:   at org.omegat.core.Core.executeExclusively(Core.java:379) 
11016: Error:   at org.omegat.gui.main.ProjectUICommands$14.doInBackground(ProjectUICommands.java:872) 
11016: Error:   at org.omegat.gui.main.ProjectUICommands$14.doInBackground(ProjectUICommands.java:869) 
11016: Error:   at javax.swing.SwingWorker$1.call(SwingWorker.java:295) 
11016: Error:   at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
11016: Error:   at javax.swing.SwingWorker.run(SwingWorker.java:334) 
11016: Error:   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
11016: Error:   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
11016: Error:   at java.lang.Thread.run(Thread.java:748) 
11016: Error: Failed to commit source files! (TF_COMMIT_ERROR)
11016: Error: java.lang.RuntimeException: java.io.IOException: Failed to commit source files! 
11016: Error: Not supported 
11016: Error:   at org.omegat.gui.main.ProjectUICommands$14.lambda$doInBackground$0(ProjectUICommands.java:876) 
11016: Error:   at org.omegat.core.Core.executeExclusively(Core.java:379) 
11016: Error:   at org.omegat.gui.main.ProjectUICommands$14.doInBackground(ProjectUICommands.java:872) 
11016: Error:   at org.omegat.gui.main.ProjectUICommands$14.doInBackground(ProjectUICommands.java:869) 
11016: Error:   at javax.swing.SwingWorker$1.call(SwingWorker.java:295) 
11016: Error:   at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
11016: Error:   at javax.swing.SwingWorker.run(SwingWorker.java:334) 
11016: Error:   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
11016: Error:   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
11016: Error:   at java.lang.Thread.run(Thread.java:748) 
11016: Error: Caused by: java.io.IOException: Failed to commit source files! 
11016: Error: Not supported 
11016: Error:   at org.omegat.core.data.RealProject.commitSourceFiles(RealProject.java:1900) 
11016: Error:   at org.omegat.gui.main.ProjectUICommands$14.lambda$doInBackground$0(ProjectUICommands.java:874) 
11016: Error:   ... 9 more 
11016: Error: Caused by: java.lang.RuntimeException: Not supported 
11016: Error:   at org.omegat.core.team2.impl.HTTPRemoteRepository.addForCommit(HTTPRemoteRepository.java:127) 
11016: Error:   at org.omegat.core.team2.RemoteRepositoryProvider.addForCommit(RemoteRepositoryProvider.java:251) 
11016: Error:   at org.omegat.core.team2.RemoteRepositoryProvider$Mapping.copyFromProjectToRepo(RemoteRepositoryProvider.java:395) 
11016: Error:   at org.omegat.core.team2.RemoteRepositoryProvider.copyFilesFromProjectToRepo(RemoteRepositoryProvider.java:229) 
11016: Error:   at org.omegat.core.data.RealProject.commitSourceFiles(RealProject.java:1893) 
11016: Error:   ... 10 more

The files fetched by SVN may not even get a chance to be committed. It would seem much more logical if instead of failing on http and svn/git without proper privilages OmegaT would give a list of files that were not committed, and the reason why.
[#1329]

[Aaron Madlon-Kay]

I agree. The un-committable items should be skipped, noted in the log, and then a status message could be displayed at the end saying something like "Done. Some files not committed; see log for details.".