Menu

#863 Forced versioned /target in 4.1-compatible team projects

4.1
closed-invalid
5
2017-12-04
2017-05-12
No

Even if the main (or only) repository mapped as / doens't have target folder under version control (which might be a PM's intent), OmegaT adds target folder and its content to the repository without any apparent way to disable this behaviour. This behaviour doesn't seem to serve any practical purpose and seems to be a clear bug.

Discussion

  • Héctor Cartagena

    This is actually very annoying. Has it been fixed in 4.1.2 update 1? If not, what can we do to help speeding up the fix?

     
  • Didier Briel

    Didier Briel - 2017-08-23

    Has it been fixed in 4.1.2 update 1?

    No, otherwise it would have been mentionned here and in changes.txt.

    Didier

     
    • Héctor Cartagena

      Thanks, we look forward to it. Whatever we can do to help (other than coding), please let me know.

       
  • Kos Ivantsov

    Kos Ivantsov - 2017-10-13

    I've tried commenting out lines 640-649 in src/org/omegat/core/data/ReaProject.java, and it seems to to the trick (done locally). Would anyone be willing to review?

     
    • Didier Briel

      Didier Briel - 2017-10-13

      That would be more logical to comment from 636 to 650 (from 'if' to '}'.

      That's OK as a temporary workaround, but it would be better to not do it if /target it not mapped, and do it if /target is mapped, which was the initial intention.

      If you remove it completly, you lose the possibility to commit directly individual files into online repositories.

      Didier

       
      • Kos Ivantsov

        Kos Ivantsov - 2017-10-13

        Maybe there can be a menu item for commiting target files, similar to "Commit source files"?

         
        • Didier Briel

          Didier Briel - 2017-10-16

          That sounds reasonable.

          Didier

           
  • Kos Ivantsov

    Kos Ivantsov - 2017-10-13

    I'm working in two team projects with 5 translators, the same source material is being translated into two languages. Source files' size is over 180 MB (docx files with images), but the projects' repositories got over 1GB after just a couple days simply because of this bug. Each local project has both repositories mapped (one as /, and /omegat/project_save.tmx from the other one as /tm/tmx2source/LANG.tmx), and it makes the bloat situation even worse.

    The workaround was removing the git commit history and force-pushing the current state as initial commit, and then telling the team to redownload the project, but it requires a lot of extra effort, and leaves you without your commit history (which isn't the biggest problem in most cases, of course).

    --
    Kos

     
  • Didier Briel

    Didier Briel - 2017-10-16
    • assigned_to: Didier Briel
     
  • Didier Briel

    Didier Briel - 2017-10-16
    • status: open --> open-fixed
     
  • Didier Briel

    Didier Briel - 2017-10-16

    Fixed in SVN (/trunk, rev. 10115).

    Create Translated Documents doesn't commit target files anymore.

    For that, you have to use [feature-requests:#1341].

    Didier

     

    Related

    Feature Requests: #1341


    Last edit: Didier Briel 2017-10-18
  • Didier Briel

    Didier Briel - 2017-12-04
    • status: open-fixed --> closed-invalid
     
  • Didier Briel

    Didier Briel - 2017-12-04

    Fixed in the released version 4.1.3 of OmegaT.

    Didier

     

Log in to post a comment.