#820 Incorrect count of proposed changes in find/replace

[Samuel Murray]

What happens:

When doing a find/replace, and the user uses "Replace all", OmegaT warns the user with a message like "You are about to modify XYZ segments", with "XYZ" being the number of segments that will be modified.

However, currently XYZ is simply the number of segments in the search results. If the search results contain only segments that will not be changed, OmegaT still says "You are about to modify XYZ segments".

What should happen:

OmegaT should tell the user the correct number of segments that will be modified. In other words, only the count of segments that can be (will be) modified by OmegaT should be stated in the warning.

Also, if the search results contain no segments that will be modified, then the Replace and Replace all buttons should be greyed out.

[Aaron Madlon-Kay]

We will simply exclude orphan segments from the search when it is for Search & Replace, since orphans won't be affected. In addition, the Filter, Replace, and Replace All buttons will be disabled if there are no hits.

[Aaron Madlon-Kay]

Implemented in trunk.

[Kos Ivantsov]

Could it be backported to 3.6 too?

[Aaron Madlon-Kay]

Exclude orphan segments is already available in 3.6, and this change is essentially cosmetic. So is there any urgent need for it in 3.6?

[Kos Ivantsov]

Not urgent, no, of course not. But if 3.6 is still going to be released as Latest, and it will be around for quite a while as Standard, I guess it might help quite a few goolies if that option was enabled and hidden.

--
Kos

[Didier Briel]

I agree with Aaron. Since it was the first time I saw someone refusing to understand what were orphan segments, I think backporting it isn't worth developers' time.

Didier

[Didier Briel]

Fixed in the released version 4.0 of OmegaT.

Didier