Menu

#761 Color modes affect unexpected areas

3.5
closed-duplicate
nobody
None
5
2015-08-24
2015-08-23
No

A number of dialogs inherit from the default colors where they are not expected to:

(Text color) Labels:
Properties/Project Files/Statistics/Font/File Filters (& Edit)/Segmentation/Editing Behavior/Tag Processing/Saving and Output/Proxy Login/About/Conflict resolution

(Background/Text, etc.) Text area:
Search/Search-Replace/Validate tags/Scripting/External TMX/User's manual/Last Changes/Log

1 Attachments

Discussion

  • Jean-Christophe Helary

    • Attachments has changed:

    Diff:

    --- old
    +++ new
    @@ -0,0 +1 @@
    +Screen Shot 2015-08-23 at 15.07.34.png (24.6 kB; image/png)
    
     
  • Aaron Madlon-Kay

    The problem is that COLOR_BACKGROUND ("Background") and COLOR_FOREGROUND ("Text") are applied globally via the UIManager instead of just on the specific components we want:

        /** Apply Look and Feel modifications during inital setup and color modifications. */
        public static void setupLAF() {
            Color backgroundColor = Styles.EditorColor.COLOR_BACKGROUND.getColor();
            Color foregroundColor = Styles.EditorColor.COLOR_FOREGROUND.getColor();
            UIManager.put("TextPane.background", backgroundColor);
            UIManager.put("TextPane.foreground", foregroundColor);
            UIManager.put("TextPane.caretForeground", foregroundColor);
            UIManager.put("TextArea.background", backgroundColor);
            UIManager.put("TextArea.foreground", foregroundColor);
            UIManager.put("TextArea.caretForeground", foregroundColor);
            UIManager.put("EditorPane.background", backgroundColor);
            UIManager.put("EditorPane.foreground", foregroundColor);
            UIManager.put("EditorPane.caretForeground", foregroundColor);
        }
    

    TextAreas and TextPanes are used throughout the UI in places where this color manipulation is not desirable.

     

    Last edit: Aaron Madlon-Kay 2015-08-24
  • khagaroth

    khagaroth - 2015-08-24

    dupe of bug #725

     
  • Jean-Christophe Helary

    • status: open --> closed-duplicate
     

Log in to post a comment.