#1091 OmegaT default colors can be lost when a plugin fails to initialize

[Kos Ivantsov]

Since [#1386] was implemented, it became possible to add layout plugins. Thanks to Hiroshi's plugin skeleton it's is pretty easy to create new layouts. The problem is that when a jar file with such layout is placed into plugins folder, even without selecting the provided glossary renderer, OmegaT colors which weren't specifically defined by the user are changed. Customized colors remain intact. When the jar is removed, default values are restored.
See more detailed explanation of the issue.
Quite possible, it's a glossary layout plugin bug, but when the layouts which are available in OmegaT (Default and Dictionary) are compiled into separate jars and used as plugins, the same behaviour is observed.

[Hiroshi Miura]

It looks not an OmegaT bug but your plugin seems not to be configured correctly.

[Aaron Madlon-Kay]

@miurahr9 Is this not a bug given your work on https://github.com/omegat-org/omegat/pull/201 ? If a plugin throwing an exception on init causes us to lose some sort of configuration then that does seem like a bug.

[Hiroshi Miura]

It is a bug when plugin throw an exception on init,initialization of base plugins are not done.
@amake

https://github.com/omegat-org/omegat/pull/201 try to protect base plugins from a broken plugin.

[Aaron Madlon-Kay]

Ticket moved from /p/omegat/feature-requests/1607/

[Aaron Madlon-Kay]

Fixed in [4adb9b] on master.

[Hiroshi Miura]

released 6.0