#1077 Team projects fail to commit with enabled signing

[Mario Liebisch]

With OmegaT 5.5 and earlier, the program ignored a set user.signinkey values in the global (or local) Git configuration. Commits were never signed, even with a key set.
Starting with 5.6 this results in an exception, since OmegaT honors the value being set, yet isn't able to talk to the associated tools to sign the commit (but it won't skip signing either).

Using regular command line git results in the proper password prompts being shown.

Windows 11 x64
gpg4win/gpg v2.2.28

Reproduction:

• Use any OmegaT team project backed by a git repository.
• Create/import/use a GPG key pair (the key having a passphrase).
• Set user.signingkey to the key's identifier.
• Set user.program to gpg.
• Set gpg.program to the full path of gpg.exe.
• (In my case all gpg programs are in the global PATH, too.)
• Once you try to save any changes to the team project, the commit to the repository will fail with org.eclipse.jgit.api.errors.ServiceUnavailableException: Signing service is not available.

Global .gitconfig:

[user]
    name = Mario Liebisch
    email = me@example.com
    signingkey = 0123456789ABCDEF
    program = gpg
[gpg]
    program = C:\\Program Files (x86)\\GnuPG\\bin\\gpg.exe

Workaround for those with the same issue:
Remove the key globally or set your local OmegaT repository's value commit.gpgsign to false.
This will prevent signing for the OmegaT repository, while keep it intact for everything else.

[Hiroshi Miura]

GpgSigner abstract class has been supported from jGit 5.3.
OmegaT 5.5 uses jGit 4.11.8, and OmegaT 5.6 uses jGit 5.11.1

It is why the behavior changed for git signing.
Unfortunately OmegaT 5.6 does not have any GpgSigner related code, so the exception might be raised.

[Hiroshi Miura]

ref:

• JGit issue Bug 382212 - Support signing commits
• JGit dev docs: Implementation of Commit Signing in Eclipse
• jGit CommitCommandTest.java (git.eclipse.org)

[Hiroshi Miura]

This seems make Gpg signing working

diff --git a/build.gradle b/build.gradle
index fbcbde2b3..78ffd44c8 100644
--- a/build.gradle
+++ b/build.gradle
@@ -169,6 +169,8 @@ dependencies {
         implementation 'org.bouncycastle:bcprov-jdk15on:1.69'
         // For ssh agent support of jsch, Java16+ or junixsocket
         implementation 'com.kohlschutter.junixsocket:junixsocket-core:2.4.0'

+        // For gpg signing
+        implementation 'org.eclipse.jgit:org.eclipse.jgit.gpg.bc:5.11.1.202105131744-r'
         implementation 'org.tmatesoft.svnkit:svnkit:1.8.14'

         // Team project conflict resolution

 git log --show-signature -1
commit d27518b5483b12c550f52cc87a4243db470e0e68 (HEAD -> master, origin/master)
gpg: Signature made Thu Nov  4 21:37:45 2021 JST
gpg:                using RSA key 2C76F2EF91D05AB2989B1B139014DA25D2433AE3
gpg:                issuer "miurahr@linux.com"
gpg: Good signature from "Hiroshi Miura <miurahr@linux.com>" [ultimate]
Author: Hiroshi Miura <miurahr@linux.com>
Date:   Thu Nov 4 21:37:16 2021 +0900

    Translated by miurahr

[Hiroshi Miura]

https://github.com/omegat-org/omegat/pull/163

[Hiroshi Miura]

I've added a preference option and UI to select whether omegat sign a commit or not.

[Hiroshi Miura]

I've dropped preference option, and see git config whether sign or not.

[Hiroshi Miura]

A fix is merged [247954a7803cb6b1d5f1d2d26ac923ff0fa3a501].

[Hiroshi Miura]

released 6.0