A couple cmake issues

[Sole Architect]

There are two issues with compiling the current version of MTF mapper. The first is the minimum cmake required is so old that cmake throws an error when configuring, and refuses to continue:

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

While it can be worked around with the option, this is still rather annoying, especially for things like AUR where you expect things to just build as automatically as possible. Cmake 3.5 is quite old as well, so I don't think raising the minimum version to that to eliminate the error should be a problem.

The second, and more serious issue is the Eigen3 detection script when configuring with cmake. This fails to detect current versions of Eigen, quite probably because Eigen3 is now two major versions behind the current Eigen (5.0), and instead gives an error like this:

Eigen3 version .. found in /usr/include/eigen3, but at least version 2.91.0 is required

Eigen 5 is installed on my system (as it's needed for other software I have installed), and I cannot install Eigen 3 as it conflicts with Eigen 5. I'm not sure if Eigen 5 would work as a drop in replacement for Eigen 3, but if it would, can the script be updated to support it?

[Frans van den Bergh]

Thanks for reporting these issues. I have fixed them in r735. Hopefully.

Regards,
Frans

[dima]

FYI, mtfmapper is now in Debian. The patches used there would fix these:

https://salsa.debian.org/science-team/mtfmapper/-/tree/master/debian/patches?ref_type=heads