Re: [Mingw-w64-public] #943 __mingw_printf() does not print non-ASCII chars correctly.

[Jacek C. <ja...@co...>]

On 8/14/22 10:20, Takashi Yano wrote:
> On Sun, 14 Aug 2022 17:09:44 +0900
> Takashi Yano wrote:
>> I have built the partially fixed version (v6) attached, where only
>> printf, *putw* and fwrite are fixed, as well as the fully fixed
>> version (v7) attached. v7 patch is the modification of v5 where
>> the workaround code is moved into libmsvcr*.a from libmingwex.a.
>>
>> With v6 patch, printf and Case 1, 3 works correctly as well as
>> c++ ostream, while v7 patch works fine in every test case I can
>> think of.
> v7 patch seems to be lost. I resent it.


FWIW, I agree with previous opinions that this approach is way too 
invasive. Maybe you could make it less invasive by limiting its scope to 
__USE_MINGW_ANSI_STDIO or something along those lines.


But honestly, I'm not sure we should try to work around Microsoft's bugs 
like that. It comes with a serious price of complicating the code and it 
will always be a hack one way or another. Proper fix requires modifying 
Microsoft part of CRT, it's already fixed properly by Microsoft in UCRT 
and we support building with UCRT.


Thanks,

Jacek