Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units

[Tamar C. <ta...@zh...>]

Actually..

This may not be the right fix. The regression I am trying to fix is a duplicate symbols error on _wassert when
linking both mscvrt and mingwex. But I now see that:

commit 1035bed24e833ea5eb487c78f4f350ea48f31e8b
Author: Martin Storsjö <ma...@ma...>
Date:   Fri Sep 29 12:42:59 2017 +0300

    crt: More strictly flag functions in the unified msvcrt.def.in

    Now the output from the unified msvcrt.def.in should be almost identical
    to what it was before, except for some new *_dbg and __p_* functions.

    The functions that were included for 32 and 64 bit x86 in the unification
    were originally believed to be harmless, but some of them turned out to
    be function that we have compatibility fallbacks for, that were missed
    when libmsvcrt.a suddenly started exporting them. This broke compatibility
    with XP in some cases.

    Signed-off-by: Martin Storsjö <ma...@ma...>

added the change

-_wassert
+F_ARM_ANY(_wassert)

and I don't know why... it's there on x86 as well.

I'm dubious about this patch as all of these F_ARM_ANY'ed values are also
available on x86, this is causing an annoying linking problem. As I want to link to the
msvcrt functions first and only mingwex for the extensions it provides.


 ---- On Sun, 22 Oct 2017 03:23:19 +0000 Tamar Christina <ta...@zh...> wrote ---- 
 > Ah, weird. Trying again. 
 >  
 > thanks. 
 >  
 >  
 >  ---- On Sat, 21 Oct 2017 23:36:27 +0000 JonY via Mingw-w64-public <min...@li...> wrote ----  
 >  > On 10/21/2017 10:35 PM, Tamar Christina wrote:  
 >  > > Hi All,  
 >  > >   
 >  > > This patch splits wassert and assert off into their own units  
 >  > > so they end up in different object files to give a bit more  
 >  > > freedom during linking.  
 >  > >   
 >  > > OK for master?  
 >  > >   
 >  >   
 >  > Looks like SF ate your patch. Try attaching as a .txt.  
 >  >   
 >  > ------------------------------------------------------------------------------  
 >  > Check out the vibrant tech community on one of the world's most  
 >  > engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________  
 >  > Mingw-w64-public mailing list  
 >  > Min...@li...  
 >  > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public  
 >  >  
 > ------------------------------------------------------------------------------ 
 > Check out the vibrant tech community on one of the world's most 
 > engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________ 
 > Mingw-w64-public mailing list 
 > Min...@li... 
 > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public 
 >