Re: [Mingw-w64-public] [patch] add LIST_MODULES_* values in psapi.h

[Kai T. <kti...@go...>]

2011/9/14 Vincent Torri <vin...@gm...>:
>
>
> On Wed, Sep 14, 2011 at 9:02 AM, Ozkan Sezer <se...@gm...> wrote:
>>
>> On Wed, Sep 14, 2011 at 9:51 AM, Vincent Torri <vin...@gm...>
>> wrote:
>> > Hey
>> >
>> > here is a patch that adds LIST_MODULES_* values in psapi.h. See
>> > http://msdn.microsoft.com/en-us/library/ms682633%28v=VS.85%29.aspx
>> >
>> > Vincent Torri
>>
>> Why are you using ifdefs ??
>
> Kai told me to use them
>
>>
>> As for LIST_MODULES_ALL, defining as
>> (LIST_MODULES_32BIT|LIST_MODULES_64BIT) would be
>> more eye friendly as opposed to 0x3, IMO.
>
> why not. Feel free to modify the patch
>
> Vincent Torri
>
>>
>> --
>> O.S.

The cause for this ifdef's might be that user might have defined those
values h(im/er)self.  To use here an unnamed enumerator looks to me
wrong here, so I prefer defines for those constants

Nevertheless patch looks ok, but Ozkan, if you want to alter it, feel
free to do so.

Regards,
Kai