#890 Can't Scrap Mech Right Arm

[senorpez]

In the attached save file:

1. Open file.
2. In Hangar, GM Edit Damage on Ostsol OTL-4D to destroy Right Shoulder. (Bug #884)
3. Note that the Upper Arm and Lower Arm are destroyed, and the OTL-4D lacks weapons or hand actuators in its Right Arm.
4. In Repair Bay, scrap Right Arm.
5. Boggle at the message that appears, since there isn't any equipment in this location.

[Taharqa]

Ok, I was able to replicate the problem, thanks for the clear instructions. It does scrap fine if you don't destroy the shoulder, so that is clearly the heart of the issue.

[Taharqa]

The problem here was in Unit.damageSystem from MM that is called by the edit damage dialog. It was setting all systems as repairable that were damaged. Thus, the actuators were showing up on the unit as repairable after the damage was edited. I have changed this so that the damageSystem method does not change the repairable status of the component. It would be good at some point to change the edit damage dialog to allow the user to distinguish between damaged and truly destroyed parts.

In any case, it is fixed for the next release.

[scjazz]

Please re-open. In another fix you fixed the disappearing shoulder/hip crits. However, unable to scrap arm with shoulder crit until after save and reload. Nothing appears in the logs at all.

[Taharqa]

Ok, I will take a look at it.

[Taharqa]

Ok, I have replicated the instructions above by editing to create damage on a shoulder and hip and everything is working fine. After removing all the equipment from the shoulder and hip, both locations scrap fine. I am attaching a copy of my test. Just scrap all items on the RA and RL and then you can scrap those locations fine. Could you please clarify what you are seeing? Is there a pop-up message or is the scrap option greyed out or something else? Also did this happen due to damage from scenario resolution or the GM edit damage dialog?

[scjazz]

OK first of all the problem is a run time error. It occurs after a Battle when trying to repair damage. This makes replication tricky. If a unit returns from a Battle with a Hip/Shoulder crit, after salvaging everything, the "You must salvage everything before scrapping" dialogue pops up.

If you save and reload MHQ it works fine.

[Taharqa]

I tried out scenario resolution via MULs where I had damaged shoulders and hips on every limb. The mul is attached. It should be run on the first scenario of Fist and Falcon, Kewran Wolfhounds. I was able to remove all the limbs and replace the one that was destroyed.

Its possible this is only happening with auto-resolve, but I would be surprised.

[Taharqa]

Also, if this bug is happening after repair, then it is a replicate of Bug [#842], which I have left open until I had time to try to replicate, so I am closing this one.