Re: [mantisbt-dev] [mantisbt-cvs] mantisbt/core user_api.php, 1.110, 1.111

[Victor B. <vb...@gm...>]

Hi Gianluca,

I've noticed below that we are not handling the case where the email
is empty.  If the email is blank then we shouldn't calculate an md5 or
contact gravatar.  In other words, we should have no image rather than
the gravatar default image.

On 8/10/07, Gianluca Sforna <gi...@us...> wrote:
> Update of /cvsroot/mantisbt/mantisbt/core
> In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv22016
>
> Modified Files:
>         user_api.php
> Log Message:
> Fix 8252: Gravatars and case sensitivity of email addresses
>
> Index: user_api.php
> ===================================================================
> RCS file: /cvsroot/mantisbt/mantisbt/core/user_api.php,v
> retrieving revision 1.110
> retrieving revision 1.111
> diff -u -d -r1.110 -r1.111
> --- user_api.php        5 Aug 2007 21:09:35 -0000       1.110
> +++ user_api.php        10 Aug 2007 22:17:22 -0000      1.111
> @@ -633,7 +633,7 @@
>         # return value is an array( URL, width, height )
>         # in this first implementation, only gravatar.com avatars are supported
>         function user_get_avatar( $p_user_id ) {
> -               $t_email = user_get_email( $p_user_id );
> +               $t_email = strtolower( user_get_email( $p_user_id ) );
>                 $t_default_image = "/images/gravatar_logo.gif";
>                 $t_size = 80;
>                 $t_avatar_url = "http://www.gravatar.com/avatar.php?gravatar_id=" . md5( $t_email ) .
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >>  http://get.splunk.com/
> _______________________________________________
> mantisbt-cvs mailing list
> man...@li...
> https://lists.sourceforge.net/lists/listinfo/mantisbt-cvs
>