Re: [Mantisbt-dev] Re: [Mantisbt-cvs] mantisbt/core error_api.php,1.6,1.7

[Julian F. <ju...@be...>]

Actually, thinking about it more...

Do you think that's always appropriate or only while debugging?  It 
means we'll end up with two headers, etc. and a partially drawn page in 
some cases.

Most of the errors we're generating are user notifications.  Although 
line numbers, etc are useful for tracking them down while debugging, 
once it's working the user shouldn't need to see that for most (if not 
all) of our errors.

Julian

Julian Fitzell wrote:
> Sure,
> 
> I buy that... feel like coding it?  :)
> 
> Julian
> 
> Victor Boctor wrote:
> 
>> Hi,
>>
>> Whatever the details we are losing, I think we should get the contents of
>> the buffer, and output it into a <div>..</div> after the error message.
>> Assuming that the buffer is not empty.
>>
>> Regards,
>> Victor.
>>
>>
>>> -----Original Message-----
>>> From: man...@li...
>>> [mailto:man...@li...]On Behalf Of Julian
>>> Fitzell
>>> Sent: Monday, 16 September 2002 11:09 AM
>>> To: man...@li...
>>> Cc: pre...@us...
>>> Subject: Re: [Mantisbt-dev] Re: [Mantisbt-cvs] mantisbt/core
>>> error_api.php,1.6,1.7
>>>
>>>
>>> This message seems to have slipped through with no responses... I'd
>>> still like to find out exactly what the problem was so we can come up
>>> with a solution.
>>>
>>> Julian
>>>
>>> Julian Fitzell wrote:
>>>
>>>> pre...@us... wrote:
>>>>
>>>>
>>>>> Update of /cvsroot/mantisbt/mantisbt/core
>>>>> In directory usw-pr-cvs1:/tmp/cvs-serv1194/core
>>>>>
>>>>> Modified Files:
>>>>>    error_api.php Log Message:
>>>>> removed ob_clean call.  Clearing the buffer may make for a nicer error
>>>>> message but it totally destroys any debug output.  Think of a better
>>>>> way if a pretty error must be displayed.
>>>>
>>>>
>>>>
>>>> Hrm...
>>>>
>>>> What debugging data are you losing exactly?  I've occasionaly had
>>>> problems with non-fatal E_CORE_* or E_COMPILE_* type errors getting
>>>> erased, but it hasn't seemed to make debugging any more difficult.  I
>>>> would like to figure out a better-solution but the only way I can find
>>>> to catch *all* errors in PHP is to use some hack that appends code to
>>>> the end of every page - I don't want to go there.
>>>>
>>>> Other options include having a config option to turn the
>>>
>>>
>>> ob_clean() call
>>>
>>>> on or off and only clearing for certain errors.  I do think when
>>>> deployed we want to make the error messages look good and clean, and I
>>>> particularly think that things like "You are not authorized" should not
>>>> be showing up half way down a partially rendered page.
>>>>
>>>> Anyone have any brilliant thoughts?
>>>>
>>>> Julian
>>>
>>>
>>>
>>> -- 
>>> ju...@be...
>>> Beta4 Productions (http://www.beta4.com)
>>
> 


-- 
ju...@be...
Beta4 Productions (http://www.beta4.com)