Re: [mantisbt-dev] Pull Requests

[Damien R. <dr...@ma...>]

> I think we should have a policy that we reject / close off any pull
> requests not against Master.

While I agree that on principle and in most cases the PRs should be 
against master, there are situations (i.e. bug fixes) where it makes 
more sense to patch the issue in 1.2 and forward-port it to master 
afterwards, as it allows the person who submitted the issue to test the 
patch that resolves it.

While we as developers can (and should) have both a 1.2.x and a 1.3.x 
environment to play with, we can't ask that of our users.

Of course these 1.2.x PRs should be strictly limited to fixes for issues 
submitted by end-users.

> I don't have a working web server setup that runs master-1.2.x

Not a good excuse IMO - it would not take more than 10-15 minutes to set 
one up

> Personally, one of the reasons I feel we don't have 1.3.x out the door
> is we've allowed development to happen against 1.2 - providing little
> incentive to work towards getting a release out.

You got it all backwards here - development of new features happened 
against 1.2 because master got completely stuck by overly ambitious 
changes that never got through.

D