[mantisbt-commits] [mantisbt/mantisbt] 380b5d: Fix data type mismatch when filtering by date

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/mantisbt/mantisbt
  Commit: 380b5de1f44c1c56a873992c7c2c05464944485b
      https://github.com/mantisbt/mantisbt/commit/380b5de1f44c1c56a873992c7c2c05464944485b
  Author: Damien Regad <dr...@ma...>
  Date:   2013-10-27 (Sun, 27 Oct 2013)

  Changed paths:
    M core/filter_api.php
    M view_all_set.php

  Log Message:
  -----------
  Fix data type mismatch when filtering by date

Follow-up on commit 1a417b123b1dbea702c3b55ff4e83bc8b8fb5545 which did
not cover all possible cases for the error.

We now consistently store the 'filter by date' property as a boolean,
and rely on gpc_string_to_bool() to ensure any string we get (e.g. 1,
'on', 'true') is properly converted to boolean before comparing. We
therefore no longer need the ternary operator in view_all_set.php. We
use 'on'/'off' when encoding the filter only.

Fixes #16516


  Commit: b02a50e3011ba5e168f54aecd65e2c133ac1942b
      https://github.com/mantisbt/mantisbt/commit/b02a50e3011ba5e168f54aecd65e2c133ac1942b
  Author: Damien Regad <dr...@ma...>
  Date:   2013-10-27 (Sun, 27 Oct 2013)

  Changed paths:
    M view_all_set.php

  Log Message:
  -----------
  Whitespace


  Commit: bdb6e9ae2b8c56aeb968dea54cdcfc0d0471f9d6
      https://github.com/mantisbt/mantisbt/commit/bdb6e9ae2b8c56aeb968dea54cdcfc0d0471f9d6
  Author: Damien Regad <dr...@ma...>
  Date:   2013-10-27 (Sun, 27 Oct 2013)

  Changed paths:
    M core/filter_api.php

  Log Message:
  -----------
  Fix 'Sticky' property reset to 'No' when applying filter

Fixes #16540


Compare: https://github.com/mantisbt/mantisbt/compare/e8cd4bea71e0...bdb6e9ae2b8c