From: Victor B. <vb...@gm...> - 2013-07-31 03:42:39
|
The list looks good. A couple of suggestions: 1. Should the build script require a clean just extracted from git copy? In such case, should it exclude files like config_inc.php or fail when it finds them, because it is a development work area rather than a clean one for publishing. 2. .gitignore has some excludes that are not in the list you propose. e.g. editor files, libraries that we don't distribute, etc. This is not really relevant if we go with #1. On Thu, Jul 25, 2013 at 2:15 PM, Damien Regad <dr...@ma...> wrote: > On 2013-07-25 22:09, Roland Becker wrote: > > There is one more file in nightly builds which should be removed: > > config_defaults_inc.php=bak > > Yes I noticed that one too as I was updating the build script. > > This file actually is a byproduct of executing sed to update the version > suffix (with the commit's sha). > > In the script's work-in-progress new version, this file is not generated > anymore [1] (if you check the file list I attached in my earlier post, > you'll see the file is no longer there). > > [1] > > https://github.com/dregad/mantisbt-tools/compare/9b28018...buildrelease#L0R163 > > > > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > mantisbt-dev mailing list > man...@li... > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev > |