[mantisbt-commits] [mantisbt/mantisbt] 6ecddd: Whitespace fixes

[GitHub <no...@gi...>]

  Branch: refs/heads/master-1.2.x
  Home:   https://github.com/mantisbt/mantisbt
  Commit: 6ecdddeaae696453cc31f0ef9178e6838bad5576
      https://github.com/mantisbt/mantisbt/commit/6ecdddeaae696453cc31f0ef9178e6838bad5576
  Author: Damien Regad <dam...@me...>
  Date:   2012-10-04 (Thu, 04 Oct 2012)

  Changed paths:
    M core/tag_api.php

  Log Message:
  -----------
  Whitespace fixes


  Commit: 32ba11600018efd188b76d5ee83b8a4400ede881
      https://github.com/mantisbt/mantisbt/commit/32ba11600018efd188b76d5ee83b8a4400ede881
  Author: Bill Stidham <bil...@gm...>
  Date:   2012-10-04 (Thu, 04 Oct 2012)

  Changed paths:
    M core/tag_api.php

  Log Message:
  -----------
  Fix issue in tag api with odbc_mssql driver

This branch of code was put into place to handle a deficiency in the
odbc_mssql driver that doesn't allow for bound subqueries. This is not
needed for the other mssql drivers, yet using db_is_mssql() returns true
for all mssql drivers so code is indiscriminately executed for other
drivers.

$t_params[] init was changed because it only needs to be set once. It is
needed for the query in the mssql condition block for the first query
only to grab the list of tags that aren't specific to this bug.
Afterwards in the second query, $t_params needs to be null or it results
in the database returning an error due to no '?' replacements.
Therefore, after running the first query, we need to set this to null.
If the condition fails and the dbtype is not mssql (or 'odbc_mssql')
then $t_params is already set.

Note: the multiple query setup in the "true" condition is a really bad
way to do this. I'm not going to mess with it, however, since the tag
count probably won't get too high in any general scenario.

Fixes #14774

Signed-off-by: Damien Regad <dam...@me...>

Note, this was simply checked for syntax errors and compliance with
coding guidelines as I don't have access to an MSSQL setup.


Compare: https://github.com/mantisbt/mantisbt/compare/791fbd93d09b...32ba11600018