[mantisbt-dev] Attachments column - issue #13276

[Damien R. <dam...@me...>]

Hi,

I was looking at an issue in the tracker [1] where user mentions 
inconsistent behavior of g_show_attachment_indicator.

I believe the problem is caused by a combination of the attachment 
column being renamed to attachment_count back in 2009, and an 
inconsistent/misleading use of g_show_attachment_indicator parameter.

Following a discussion with David on IRC, I uploaded to github 2 
possible fixes to the problem

a) cascading the column name change everywhere it needs to happen
    and removing inconsistent use of the param to avoid column deletion
b) removing the parameter

David thinks that we should do b), and I tend to agree as I don't see 
any added value for this parameter; however as I had already mostly 
implemented the fix for a) prior to that, I pushed 2 branches to github 
for your review.

a) https://github.com/dregad/mantisbt/commits/fix-attach-column-13276
b) 
https://github.com/dregad/mantisbt/commits/remove-show_attachment_indicator

Comments welcome, and please let me know which one you think should be 
pulled into 1.2.x.

Damien


[1] http://www.mantisbt.org/bugs/view.php?id=13276