[mantisbt-commits] mantisbt.git branch, master, updated. release-1.2.0rc1-951-g93b581b

[<gi...@ma...>]

The branch, master has been updated
       via  93b581bfb6804990030d5fbe1954147f2741cd13 (commit)
      from  08c027af59b88a6934377d71d19a86edfd7d12dd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 93b581bfb6804990030d5fbe1954147f2741cd13
Author: Tamás Gulácsi <gt...@gt...>
Date:   Sat Feb 26 21:15:30 2011 +1100

    Fix #12549: Bug change status form always creates private bug notes
    
    Due to invalid handling of boolean types and built in view state
    constants, bug notes added via the bug change status form were ignoring
    the "private" checkbox.
    
    Signed-off-by: David Hicks <hic...@op...>

-----------------------------------------------------------------------

Summary of changes:
 bug_update.php |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

-----------------------------------------------------------------------

commit 93b581bfb6804990030d5fbe1954147f2741cd13
Author: Tamás Gulácsi <gt...@gt...>
Date:   Sat Feb 26 21:15:30 2011 +1100

    Fix #12549: Bug change status form always creates private bug notes
    
    Due to invalid handling of boolean types and built in view state
    constants, bug notes added via the bug change status form were ignoring
    the "private" checkbox.
    
    Signed-off-by: David Hicks <hic...@op...>

diff --git a/bug_update.php b/bug_update.php
index aa567a4..ebf26ce 100644
--- a/bug_update.php
+++ b/bug_update.php
@@ -123,7 +123,7 @@ $t_updated_bug->view_state = gpc_get_int( 'view_state', $t_existing_bug->view_st
 
 $t_bug_note = new BugNoteData();
 $t_bug_note->note = gpc_get_string( 'bugnote_text', '' );
-$t_bug_note->view_state = gpc_get_bool( 'private', config_get( 'default_bugnote_view_status' ) );
+$t_bug_note->view_state = gpc_get_bool( 'private', config_get( 'default_bugnote_view_status' ) == VS_PRIVATE ) ? VS_PRIVATE : VS_PUBLIC;
 $t_bug_note->time_tracking = gpc_get_string( 'time_tracking', '0:00' );
 
 # Determine whether the new status will reopen, resolve or close the issue.
@@ -358,7 +358,7 @@ foreach ( $t_custom_fields_to_set as $t_custom_field_to_set ) {
 
 # Add a bug note if there is one.
 if ( $t_bug_note->note || helper_duration_to_minutes( $t_bug_note->time_tracking ) > 0 ) {
-	bugnote_add( $f_bug_id, $t_bug_note->note, $t_bug_note->time_tracking, $t_bug_note->view_state, 0, '', null, false );
+	bugnote_add( $f_bug_id, $t_bug_note->note, $t_bug_note->time_tracking, $t_bug_note->view_state == VS_PRIVATE, 0, '', null, false );
 }
 
 # Add a duplicate relationship if requested.

-----------------------------------------------------------------------


--
Mantis Bug Tracker