From: <gi...@ma...> - 2009-07-04 06:56:35
|
The branch, master has been updated via 6c8c7bed92a6cd7589378c53fb9208f772a3d0bd (commit) from 2a94e8305070731e90126bcb2344cddf1fecd4d9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6c8c7bed92a6cd7589378c53fb9208f772a3d0bd Author: Victor Boctor <vb...@gm...> Date: Fri Jul 3 23:56:26 2009 -0700 Fixes #10655: Private notes cause the view page to stop rendering. ----------------------------------------------------------------------- Summary of changes: core/bugnote_api.php | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) ----------------------------------------------------------------------- commit 6c8c7bed92a6cd7589378c53fb9208f772a3d0bd Author: Victor Boctor <vb...@gm...> Date: Fri Jul 3 23:56:26 2009 -0700 Fixes #10655: Private notes cause the view page to stop rendering. diff --git a/core/bugnote_api.php b/core/bugnote_api.php index 8f937a6..3f0f0c9 100644 --- a/core/bugnote_api.php +++ b/core/bugnote_api.php @@ -349,9 +349,10 @@ function bugnote_get_all_visible_bugnotes( $p_bug_id, $p_user_bugnote_order, $p_ $t_bugnotes = array(); $t_bugnote_count = count( $t_all_bugnotes ); $t_bugnote_limit = $p_user_bugnote_limit > 0 ? $p_user_bugnote_limit : $t_bugnote_count; + $t_bugnotes_found = 0; # build a list of the latest bugnotes that the user can see - for( $i = 0; $i < $t_bugnote_count && $i < $t_bugnote_limit; ) { + for ( $i = 0; ( $i < $t_bugnote_count ) && ( $t_bugnotes_found < $t_bugnote_limit ); $i++ ) { $t_bugnote = array_pop( $t_all_bugnotes ); if( $t_private_bugnote_visible || $t_bugnote->reporter_id == $t_user_id || ( VS_PUBLIC == $t_bugnote->view_state ) ) { @@ -362,7 +363,7 @@ function bugnote_get_all_visible_bugnotes( $p_bug_id, $p_user_bugnote_order, $p_ $t_bugnote->time_tracking = 0; } - $t_bugnotes[$i++] = $t_bugnote; + $t_bugnotes[$t_bugnotes_found++] = $t_bugnote; } } ----------------------------------------------------------------------- -- Mantis Bug Tracker |