Re: [Linuxwacom-discuss] Inconsistencies between xsetwacom 'get all' and 'get parameter'

[Jason G. <kil...@gm...>]

On Wed, Aug 8, 2018 at 3:11 AM James Pearson <ja...@mo...> wrote:
>
> Jason Gerecke wrote:
> >
> > That's a good list of things that should probably be addressed... The
> > issues you've brought up are either bugs or otherwise unintentional:
> >
> > "No longer in use" -- By default, "get all" uses the "xorg.conf"
> > output format. The driver still requires the use of the old names when
> > giving the options through xorg.conf which is why it doesn't use the
> > new names. One way around this would be to run xsetwacom with the "-s"
> > switch to use the "shell" output format instead. This prints out
> > everything as a series of xsetwacom commands which use the new names.
> > That's not really a full solution though because of the next issue...
> >
> > "TabletID not listed in 'all' output" -- Neither the xorg.conf nor the
> > shell output format will print anything for read-only properties. Both
> > of these output formats assume that you're using them because you want
> > to set the property, and it would be impossible to set a read-only
> > property. If "get all" used the "default" output format instead, the
> > value would be printed out. "Default" doesn't work as-is though since
> > it doesn't bother printing out the name of the property. This could be
> > worked around though.
>
> Thanks for the explanation - although it is rather confusing that 'get
> all' and 'get $parameter' use different output formats by default ...
> and that the man page doesn't make it clear that 'get all' excludes the
> read-only parameters
>

Yeah. Neither of those were conscious decisions. The former is an
implementation detail that wasn't completely thought out, and the
latter one of the unintended consequences of that choice.

I took a few minutes to look at improving the "get all" output. The
most straightforward patch (basically add a printf of the property
name to the default case of the 'print_value()' function and remove
the printformat override in 'get_all()') works but is not ideal.
Because it changes the default output used by all get requests,
there's a good chance that it would break user scripts. It would be
less disruptive if only the "get all" output was changed, but that's a
little trickier.

Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one  /
(That is to say, eight) to the two,     /
But you can’t take seven from three,    /
So you look at the sixty-fours....

> > "Serial is unknown" -- Your patch looks like the right solution for
> > this particular issue. If you send it to the linuxwacom-devel list as
> > a git-formatted patch with description and "Signed-off-by" line, we
> > can integrate it in to the next release.
>
> Done - I hope it is in the required format ...
>
> James Pearson