|
From: Jason G. <kil...@gm...> - 2018-08-07 20:58:55
|
That's a good list of things that should probably be addressed... The
issues you've brought up are either bugs or otherwise unintentional:
"No longer in use" -- By default, "get all" uses the "xorg.conf"
output format. The driver still requires the use of the old names when
giving the options through xorg.conf which is why it doesn't use the
new names. One way around this would be to run xsetwacom with the "-s"
switch to use the "shell" output format instead. This prints out
everything as a series of xsetwacom commands which use the new names.
That's not really a full solution though because of the next issue...
"TabletID not listed in 'all' output" -- Neither the xorg.conf nor the
shell output format will print anything for read-only properties. Both
of these output formats assume that you're using them because you want
to set the property, and it would be impossible to set a read-only
property. If "get all" used the "default" output format instead, the
value would be printed out. "Default" doesn't work as-is though since
it doesn't bother printing out the name of the property. This could be
worked around though.
"Serial is unknown" -- Your patch looks like the right solution for
this particular issue. If you send it to the linuxwacom-devel list as
a git-formatted patch with description and "Signed-off-by" line, we
can integrate it in to the next release.
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....
On Tue, Aug 7, 2018 at 3:55 AM James Pearson <ja...@mo...> wrote:
>
> When I run 'xsetwacom get $id all' - where $id is a valid device name -
> I get (amongst other output):
>
> Option "DebugLevel" "0"
> Option "CommonDBG" "0"
> Option "PressCurve" "0 0 100 100"
> Option "TPCButton" "off"
> Option "Serial" "0"
>
> However, if I then run 'xsetwacom get $id $param' - where $param is one
> of the above Option parameters, I get:
>
> Parameter 'DebugLevel' is no longer in use. It was replaced with
> 'ToolDebugLevel'.
> Parameter 'CommonDBG' is no longer in use. It was replaced with
> 'TabletDebugLevel'.
> Parameter 'PressCurve' is no longer in use. It was replaced with
> 'PressureCurve'.
> Parameter 'TPCButton' is no longer in use. It was replaced with
> 'TabletPCButton'.
> Unknown parameter name 'Serial'.
>
> Why is the 'get all' giving output for parameters that are no longer in
> use - and not their replacements?
>
> To add to this, 'get all' doesn't actually list all the parameters -
> e.g. why is the value of, say, 'TabletID' not listed in the 'all' output ?
>
>
> Also, 'Serial' is 'Unknown' ...
>
> I notice from the source that 'Serial' is not defined in
> deprecated_parameters[] - whereas 'GetTabletID' is defined twice ?
>
> i.e. maybe the following is needed? :
>
> --- xsetwacom.c.dist 2018-01-04 23:21:35.000000000 +0000
> +++ xsetwacom.c 2018-08-07 09:55:32.498424475 +0100
> @@ -513,7 +513,7 @@ static struct deprecated
> {"GetTabletID", "TabletID"},
> {"DebugLevel", "ToolDebugLevel"},
> {"CommonDBG", "TabletDebugLevel"},
> - {"GetTabletID", "TabletID"},
> + {"Serial", "BindToSerial"},
> {"PressCurve", "PressureCurve"},
> {"TPCButton", "TabletPCButton"},
> {"CursorProx", "CursorProximity"},
>
> Thanks
>
> James Pearson
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linuxwacom-discuss mailing list
> Lin...@li...
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-discuss
|