|
From: Ping C. <pin...@gm...> - 2010-05-18 05:09:47
|
Hi Przemo I changed the Subject. wcmLastToolSerial can be moved to wcmUSBData as well since it is USB specific. wcmPktLength is unnecessary for USB. It is always the same (sizeof(struct input_event)). This change can wait when you work on wcmISDV4Data for ISDV4 though. Thank you for the patch. Ping > From b96be496a6ace0b13d60d37b599949a41f3f822a Mon Sep 17 00:00:00 2001 > From: Przemo Firszt <pr...@fi...> > Date: Mon, 17 May 2010 20:54:03 +0100 > Subject: [PATCH] Move USB event queue variables out of WacomCommonRec to wcmUSB.h file > > Event queue and event counter (wcmEventCnt & wcmEvents) in WacomCommonRec > struct are replaced by a void pointer to private data. A new file (wcmUSB.h) > contains struct wcmUSBData used to manage the queue. Initialisation of > the queue is done in usbWcmInit. Freeing memory allocated for the queue is > part of wcmUninit. > > Signed-off-by: Przemo Firszt <pr...@fi...> On Mon, May 17, 2010 at 2:02 PM, Przemo Firszt <pr...@fi...> wrote: > Dnia 2010-05-17, pon o godzinie 21:12 +0100, Przemo Firszt pisze: >> Dnia 2010-05-16, nie o godzinie 23:12 -0700, Ping Cheng pisze: >> > On Sun, May 16, 2010 at 9:43 PM, Peter Hutterer >> [..] >> > > we could just add a void *private; field to the WacomCommon struct and let >> > > that be filled in with backend-specific data (i.e. a wcmUSBData struct). On >> > > those backends where it's not needed simply set it to NULL and don't access >> > > it. >> > >> > This is a good idea. Przemo, are you interested in implementing >> > Peter's suggestion? >> Hi, >> See attached patch. I'd have more later. > Part 2 of cleaning: Move all definitons and declarations from wcmUSB.c > to wcmUSB.h > > I'm open to discuss this path ;-) > regards, > Przemo > > |