Re: [Linuxwacom-devel] FW: [PATCH] xf86-input-wacom

[Ping <pin...@gm...>]

2009/11/22 Przemysław Firszt <pr...@fi...>

> Dnia 2009-11-19, czw o godzinie 12:00 +1000, Peter Hutterer pisze:
> > now, moving these structs and the associated bits over to xf86Wacom.c
> makes
> > sense in principle, though right now the distinction between what goes
> into
> > wcmConfig.c and xf86Wacom.c isn't quite clear to me. hence I don't really
> > see the point of moving it around for now until we've sorted out why
> there's
> > two different files for it :)
> Ping, do we have a guideline what should be where?
>
That's a good question. The short answer would be no. But that answer
doesn't even make myself feel comfortable. There is a history on what we
have now.  Initially, there was only one file which is xf86Wacom.c.  When
John Joganic created this project about 7 years ago, he refactored the code
and made it easier for us to maintain.  I guess, wcmConfig.c was intended
only to deal with configuration related stuff.  Those routines that have a
closer tie to XFree86, such as xf86WcmDevConvert,
xf86WcmDevReverseConvert, xf86WcmDevProc,
etc., stayed.  I have added a few new files while introducing new features.
With so many features and new models to support, halting the development for
a whole code refactoring was something I could not afford.

However, this is an open source project. You can provide a guideline for us
or share your suggestions with us. We are more than happy to accept any
contributions to the project, especially for xf86-input-wacom, which bears
our future. We want, by all means, to make it easier for others to contribue
to linuxwacom project.

Ping