#2438 XML Replace crashes when "Find what" and "Replace what" are empty

[Santiago González]

In XML Replace, leaving both "Find what" and "Replace what" empty causes KeePass to freeze and crash.

Steps to reproduce:

1. Open XML Replace.
2. Use this XPath:
   //Entry/String[starts-with(Key,'AndroidApp')]/Value
3. Leave "Find what" and "Replace what" empty.
4. Execute the replacement.

Expected: Show a validation error.

Actual: KeePass freezes and crashes.

KeePass 2.61.1
Windows 11

[Dominik Reichl]

Many thanks for reporting this issue!

The [OK] button of the XML Replace dialog is now disabled when the node selection XPath expression or the search text (if necessary) is empty. Furthermore, I've added a check in the string replacement method that XML Replace uses (which may also be used by plugins, PowerShell scripts, etc.).

Here's the latest development snapshot for testing:
https://keepass.info/filepool/KeePass_260817.zip

Best regards,
Dominik

[Santiago González]

Thank you so much!

By the way, any update on this?

https://sourceforge.net/p/keepass/feature-requests/2990/

[Dominik Reichl]

Not yet; I'll post in FR 2990 when there are news about it.

Best regards,
Dominik